qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Kiarie <davidkiarie4@gmail.com>
To: qemu-devel@nongnu.org
Cc: marcel@redhat.com, valentine.sinitsyn@gmail.com,
	jan.kiszka@web.de, David Kiarie <davidkiarie4@gmail.com>,
	mst@redhat.com
Subject: [Qemu-devel] [V6 4/4] hw/pci-host: Emulate AMD IOMMU
Date: Sun, 21 Feb 2016 21:11:00 +0300	[thread overview]
Message-ID: <1456078260-6669-5-git-send-email-davidkiarie4@gmail.com> (raw)
In-Reply-To: <1456078260-6669-1-git-send-email-davidkiarie4@gmail.com>

Add AMD IOMMU emulation support to q35 chipset

Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
---
 hw/pci-host/piix.c            |  1 +
 hw/pci-host/q35.c             | 14 ++++++++++++--
 include/hw/i386/intel_iommu.h |  1 +
 3 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 41aa66f..ab2e24a 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -36,6 +36,7 @@
 #include "hw/i386/ioapic.h"
 #include "qapi/visitor.h"
 #include "qemu/error-report.h"
+#include "hw/i386/amd_iommu.h"
 
 /*
  * I440FX chipset data sheet.
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index 115fb8c..355fb32 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -31,6 +31,7 @@
 #include "hw/hw.h"
 #include "hw/pci-host/q35.h"
 #include "qapi/visitor.h"
+#include "hw/i386/amd_iommu.h"
 
 /****************************************************************************
  * Q35 host
@@ -505,9 +506,18 @@ static void mch_realize(PCIDevice *d, Error **errp)
                  mch->pci_address_space, &mch->pam_regions[i+1],
                  PAM_EXPAN_BASE + i * PAM_EXPAN_SIZE, PAM_EXPAN_SIZE);
     }
-    /* Intel IOMMU (VT-d) */
-    if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) {
+
+    if (g_strcmp0(MACHINE(qdev_get_machine())->iommu, INTEL_IOMMU_STR) == 0) {
+        /* Intel IOMMU (VT-d) */
         mch_init_dmar(mch);
+    } else if (g_strcmp0(MACHINE(qdev_get_machine())->iommu, AMD_IOMMU_STR)
+               == 0) {
+        AMDIOMMUState *iommu_state;
+        PCIDevice *iommu;
+        PCIBus *bus = PCI_BUS(qdev_get_parent_bus(DEVICE(mch)));
+        iommu = pci_create_simple(bus, 0x20, TYPE_AMD_IOMMU_DEVICE);
+        iommu_state = AMD_IOMMU_DEVICE(iommu);
+        pci_setup_iommu(bus, bridge_host_amd_iommu, iommu_state);
     }
 }
 
diff --git a/include/hw/i386/intel_iommu.h b/include/hw/i386/intel_iommu.h
index b024ffa..539530c 100644
--- a/include/hw/i386/intel_iommu.h
+++ b/include/hw/i386/intel_iommu.h
@@ -27,6 +27,7 @@
 #define TYPE_INTEL_IOMMU_DEVICE "intel-iommu"
 #define INTEL_IOMMU_DEVICE(obj) \
      OBJECT_CHECK(IntelIOMMUState, (obj), TYPE_INTEL_IOMMU_DEVICE)
+#define INTEL_IOMMU_STR "intel"
 
 /* DMAR Hardware Unit Definition address (IOMMU unit) */
 #define Q35_HOST_BRIDGE_IOMMU_ADDR  0xfed90000ULL
-- 
2.1.4

  parent reply	other threads:[~2016-02-21 18:11 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-21 18:10 [Qemu-devel] [V6 0/4] AMD IOMMU David Kiarie
2016-02-21 18:10 ` [Qemu-devel] [V6 1/4] hw/i386: Introduce " David Kiarie
2016-02-25 15:43   ` Marcel Apfelbaum
2016-02-26  6:23     ` David Kiarie
2016-03-02  4:00       ` David Kiarie
2016-03-02  4:08         ` David Kiarie
2016-03-03  9:40           ` Marcel Apfelbaum
2016-03-03  9:34         ` Marcel Apfelbaum
2016-03-02 19:11     ` David Kiarie
2016-03-03 12:16       ` Marcel Apfelbaum
2016-02-21 18:10 ` [Qemu-devel] [V6 2/4] hw/core: Add AMD IOMMU to machine properties David Kiarie
2016-02-21 20:09   ` Jan Kiszka
2016-03-02 20:51     ` David Kiarie
2016-03-03  9:28       ` Marcel Apfelbaum
2016-03-11 13:20   ` Michael S. Tsirkin
2016-02-21 18:10 ` [Qemu-devel] [V6 3/4] hw/i386: ACPI table for AMD IOMMU David Kiarie
2016-02-21 18:20   ` Jan Kiszka
2016-02-21 19:00     ` David Kiarie
2016-02-21 18:11 ` David Kiarie [this message]
2016-02-22 11:22   ` [Qemu-devel] [V6 4/4] hw/pci-host: Emulate " Marcel Apfelbaum
     [not found]     ` <56D75688.1020500@gmail.com>
2016-03-02 21:17       ` Michael S. Tsirkin
2016-03-02 22:04         ` David Kiarie
2016-03-03  9:49           ` Michael S. Tsirkin
2016-03-03 11:47             ` David Kiarie
2016-03-03 12:02               ` Marcel Apfelbaum
2016-03-03 12:06                 ` Marcel Apfelbaum
2016-03-03 12:18                   ` David Kiarie
2016-03-03 12:58                     ` Michael S. Tsirkin
2016-03-08 17:15             ` David Kiarie
2016-03-11 13:22   ` Michael S. Tsirkin
2016-03-13  0:14     ` David Kiarie
2016-03-13 13:59       ` Michael S. Tsirkin
2016-02-21 20:20 ` [Qemu-devel] [V6 0/4] " Jan Kiszka
2016-02-22  5:57   ` David Kiarie
2016-02-22  7:29     ` Jan Kiszka
2016-02-22 11:05       ` David Kiarie
2016-02-22 11:12         ` Jan Kiszka
2016-03-01 13:07 ` Michael S. Tsirkin
2016-03-01 13:48   ` Jan Kiszka
2016-03-01 13:55     ` Michael S. Tsirkin
2016-03-01 14:12       ` Jan Kiszka
2016-03-01 14:18         ` Jan Kiszka
2016-03-01 14:30           ` Michael S. Tsirkin
2016-03-01 14:35             ` Jan Kiszka
2016-03-01 14:19         ` Michael S. Tsirkin
2016-03-01 14:00     ` Jan Kiszka
2016-03-01 20:11       ` Michael S. Tsirkin
2016-03-01 20:17         ` Jan Kiszka
2016-03-01 20:39           ` Michael S. Tsirkin
2016-03-01 21:23             ` Jan Kiszka
2016-03-01 22:35               ` Michael S. Tsirkin
2016-03-02 21:17     ` David Kiarie
2016-03-02 21:32       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456078260-6669-5-git-send-email-davidkiarie4@gmail.com \
    --to=davidkiarie4@gmail.com \
    --cc=jan.kiszka@web.de \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=valentine.sinitsyn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).