[Qemu-devel] [PULL 0/1] gtk: fix uninitialized temporary VirtualConsole

[Qemu-devel] [PULL 0/1] gtk: fix uninitialized temporary VirtualConsole

[Gerd Hoffmann]

  Hi,

UI patch queue with a single bugfix.

please pull,
  Gerd

The following changes since commit c3bce9d5f986bc22b0692a8fa9d26ce6d304375c:

  etraxfs_dma: Dont forward zero-length payload to clients (2016-02-20 00:17:48 +0100)

are available in the git repository at:

  git://git.kraxel.org/qemu tags/pull-ui-20160222-1

for you to fetch changes up to 327d83ba717c879f5640b41c15af3ce56a7922eb:

  gtk: fix uninitialized temporary VirtualConsole (2016-02-22 08:38:42 +0100)

----------------------------------------------------------------
gtk: fix uninitialized temporary VirtualConsole

----------------------------------------------------------------
Paolo Bonzini (1):
      gtk: fix uninitialized temporary VirtualConsole

 ui/gtk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PULL 1/1] gtk: fix uninitialized temporary VirtualConsole

[Gerd Hoffmann]

From: Paolo Bonzini <pbonzini@redhat.com>

Only the echo field is used in the temporary VirtualConsole, so the
damage was limited.  But still, if echo was incorrectly set to true,
the result would be some puzzling output in VTE monitor and serial
consoles.

Fixes: fba958c692e47a373d15c1fd3d72b255bf76adbd
Cc: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1455015557-15106-2-git-send-email-pbonzini@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/gtk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/gtk.c b/ui/gtk.c
index 2b46965..3773826 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1613,7 +1613,7 @@ static CharDriverState *gd_vc_handler(ChardevVC *vc, Error **errp)
     chr->chr_set_echo = gd_vc_chr_set_echo;
 
     /* Temporary, until gd_vc_vte_init runs.  */
-    chr->opaque = g_new(VirtualConsole, 1);
+    chr->opaque = g_new0(VirtualConsole, 1);
 
     /* defer OPENED events until our vc is fully initialized */
     chr->explicit_be_open = true;
-- 
1.8.3.1

Re: [Qemu-devel] [PULL 0/1] gtk: fix uninitialized temporary VirtualConsole

[Peter Maydell]

On 22 February 2016 at 08:32, Gerd Hoffmann <kraxel@redhat.com> wrote:
>   Hi,
>
> UI patch queue with a single bugfix.
>
> please pull,
>   Gerd
>
> The following changes since commit c3bce9d5f986bc22b0692a8fa9d26ce6d304375c:
>
>   etraxfs_dma: Dont forward zero-length payload to clients (2016-02-20 00:17:48 +0100)
>
> are available in the git repository at:
>
>   git://git.kraxel.org/qemu tags/pull-ui-20160222-1
>
> for you to fetch changes up to 327d83ba717c879f5640b41c15af3ce56a7922eb:
>
>   gtk: fix uninitialized temporary VirtualConsole (2016-02-22 08:38:42 +0100)
>
> ----------------------------------------------------------------
> gtk: fix uninitialized temporary VirtualConsole
>
> ----------------------------------------------------------------
> Paolo Bonzini (1):
>       gtk: fix uninitialized temporary VirtualConsole

Applied, thanks.

-- PMM