* [Qemu-devel] [PATCH] tracetool: Include osdep.h in generated-ust.c
@ 2016-02-23 15:17 Peter Maydell
2016-02-23 15:41 ` Eric Blake
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2016-02-23 15:17 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Stefan Hajnoczi, patches
When generating the trace/generated-ust.c source file, make sure
it includes osdep.h as its first include.
This fixes compilation with --enable-trace-backends=ust
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Picked up by the travis build tests.
scripts/tracetool/format/ust_events_c.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/tracetool/format/ust_events_c.py b/scripts/tracetool/format/ust_events_c.py
index bc97093..52100c0 100644
--- a/scripts/tracetool/format/ust_events_c.py
+++ b/scripts/tracetool/format/ust_events_c.py
@@ -22,6 +22,8 @@ def generate(events, backend):
out('/* This file is autogenerated by tracetool, do not edit. */',
'',
+ '#include "qemu/osdep.h"',
+ '',
'#define TRACEPOINT_DEFINE',
'#define TRACEPOINT_CREATE_PROBES',
'',
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] tracetool: Include osdep.h in generated-ust.c
2016-02-23 15:17 [Qemu-devel] [PATCH] tracetool: Include osdep.h in generated-ust.c Peter Maydell
@ 2016-02-23 15:41 ` Eric Blake
2016-02-23 16:13 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Eric Blake @ 2016-02-23 15:41 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: Alex Bennée, Stefan Hajnoczi, patches
[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]
On 02/23/2016 08:17 AM, Peter Maydell wrote:
> When generating the trace/generated-ust.c source file, make sure
> it includes osdep.h as its first include.
>
> This fixes compilation with --enable-trace-backends=ust
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Picked up by the travis build tests.
>
> scripts/tracetool/format/ust_events_c.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/tracetool/format/ust_events_c.py b/scripts/tracetool/format/ust_events_c.py
> index bc97093..52100c0 100644
> --- a/scripts/tracetool/format/ust_events_c.py
> +++ b/scripts/tracetool/format/ust_events_c.py
> @@ -22,6 +22,8 @@ def generate(events, backend):
>
> out('/* This file is autogenerated by tracetool, do not edit. */',
> '',
> + '#include "qemu/osdep.h"',
> + '',
TAB-damaged. With that fixed,
Reviewed-by: Eric Blake <eblake@redhat.com>
> '#define TRACEPOINT_DEFINE',
> '#define TRACEPOINT_CREATE_PROBES',
> '',
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] tracetool: Include osdep.h in generated-ust.c
2016-02-23 15:41 ` Eric Blake
@ 2016-02-23 16:13 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2016-02-23 16:13 UTC (permalink / raw)
To: Eric Blake
Cc: Alex Bennée, QEMU Developers, Stefan Hajnoczi,
Patch Tracking
On 23 February 2016 at 15:41, Eric Blake <eblake@redhat.com> wrote:
> On 02/23/2016 08:17 AM, Peter Maydell wrote:
>> When generating the trace/generated-ust.c source file, make sure
>> it includes osdep.h as its first include.
>>
>> This fixes compilation with --enable-trace-backends=ust
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> Picked up by the travis build tests.
>>
>> scripts/tracetool/format/ust_events_c.py | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/scripts/tracetool/format/ust_events_c.py b/scripts/tracetool/format/ust_events_c.py
>> index bc97093..52100c0 100644
>> --- a/scripts/tracetool/format/ust_events_c.py
>> +++ b/scripts/tracetool/format/ust_events_c.py
>> @@ -22,6 +22,8 @@ def generate(events, backend):
>>
>> out('/* This file is autogenerated by tracetool, do not edit. */',
>> '',
>> + '#include "qemu/osdep.h"',
>> + '',
>
> TAB-damaged. With that fixed,
> Reviewed-by: Eric Blake <eblake@redhat.com>
Thanks; applied to master as a buildfix (with the tab damage fixed).
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-23 16:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-23 15:17 [Qemu-devel] [PATCH] tracetool: Include osdep.h in generated-ust.c Peter Maydell
2016-02-23 15:41 ` Eric Blake
2016-02-23 16:13 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).