From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYWwK-0007Ka-H4 for qemu-devel@nongnu.org; Wed, 24 Feb 2016 05:45:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYWwE-00029A-1D for qemu-devel@nongnu.org; Wed, 24 Feb 2016 05:45:04 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:24142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYWwD-00027s-RF for qemu-devel@nongnu.org; Wed, 24 Feb 2016 05:44:57 -0500 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O3100H38SITXN90@mailout3.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 24 Feb 2016 10:44:53 +0000 (GMT) From: Ilya Maximets Date: Wed, 24 Feb 2016 13:44:34 +0300 Message-id: <1456310674-3237-1-git-send-email-i.maximets@samsung.com> Subject: [Qemu-devel] [PATCH] vhost-user: verify that number of queues is less than MAX_QUEUE_NUM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Ilya Maximets , Jason Wang , Dyasly Sergey , "Michael S. Tsirkin" Fix QEMU crash when -netdev vhost-user,queues=n is passed with number of queues greater than MAX_QUEUE_NUM. Signed-off-by: Ilya Maximets --- net/vhost-user.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/vhost-user.c b/net/vhost-user.c index 451dbbf..b753b3d 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -317,9 +317,10 @@ int net_init_vhost_user(const NetClientOptions *opts, const char *name, } queues = vhost_user_opts->has_queues ? vhost_user_opts->queues : 1; - if (queues < 1) { + if (queues < 1 || queues > MAX_QUEUE_NUM) { error_setg(errp, - "vhost-user number of queues must be bigger than zero"); + "vhost-user number of queues must be in range [1, %d]", + MAX_QUEUE_NUM); return -1; } -- 2.5.0