From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
Peter Maydell <peter.maydell@linaro.org>,
Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL v3 11/21] virtio: export vring_notify as virtio_should_notify
Date: Thu, 25 Feb 2016 13:20:55 +0200 [thread overview]
Message-ID: <1456399032-6172-12-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1456399032-6172-1-git-send-email-mst@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Virtio dataplane needs to trigger the irq manually through the
guest notifier. Export virtio_should_notify so that it can be
used around event_notifier_set.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
---
include/hw/virtio/virtio.h | 1 +
hw/virtio/virtio.c | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index 3ecdb20..2b5b248 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -163,6 +163,7 @@ void virtqueue_get_avail_bytes(VirtQueue *vq, unsigned int *in_bytes,
unsigned int *out_bytes,
unsigned max_in_bytes, unsigned max_out_bytes);
+bool virtio_should_notify(VirtIODevice *vdev, VirtQueue *vq);
void virtio_notify(VirtIODevice *vdev, VirtQueue *vq);
void virtio_save(VirtIODevice *vdev, QEMUFile *f);
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index f419e7c..08275a9 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -1162,7 +1162,7 @@ void virtio_irq(VirtQueue *vq)
virtio_notify_vector(vq->vdev, vq->vector);
}
-static bool vring_notify(VirtIODevice *vdev, VirtQueue *vq)
+bool virtio_should_notify(VirtIODevice *vdev, VirtQueue *vq)
{
uint16_t old, new;
bool v;
@@ -1187,7 +1187,7 @@ static bool vring_notify(VirtIODevice *vdev, VirtQueue *vq)
void virtio_notify(VirtIODevice *vdev, VirtQueue *vq)
{
- if (!vring_notify(vdev, vq)) {
+ if (!virtio_should_notify(vdev, vq)) {
return;
}
--
MST
next prev parent reply other threads:[~2016-02-25 11:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 11:20 [Qemu-devel] [PULL v3 00/21] vhost, virtio, pci, pc Michael S. Tsirkin
2016-02-25 11:20 ` [Qemu-devel] [PULL v3 01/21] bios-linker-loader: document+validate input Michael S. Tsirkin
2016-02-25 11:20 ` [Qemu-devel] [PULL v3 02/21] vhost-user: don't merge regions with different fds Michael S. Tsirkin
2016-02-25 11:20 ` [Qemu-devel] [PULL v3 03/21] move get_current_ram_size to virtio-balloon.c Michael S. Tsirkin
2016-02-25 11:20 ` [Qemu-devel] [PULL v3 04/21] virtio-balloon: rewrite get_current_ram_size() Michael S. Tsirkin
2016-03-01 16:28 ` Vladimir Sementsov-Ogievskiy
2016-02-25 11:20 ` [Qemu-devel] [PULL v3 05/21] balloon: Use only 'pc-dimm' type dimm for ballooning Michael S. Tsirkin
2016-02-25 11:20 ` [Qemu-devel] [PULL v3 06/21] pci core: function pci_host_bus_register() cleanup Michael S. Tsirkin
2016-02-25 11:20 ` [Qemu-devel] [PULL v3 07/21] pci core: function pci_bus_init() cleanup Michael S. Tsirkin
2016-02-25 11:20 ` [Qemu-devel] [PULL v3 08/21] block-migration: acquire AioContext as necessary Michael S. Tsirkin
2016-02-25 11:20 ` [Qemu-devel] [PULL v3 09/21] vring: make vring_enable_notification return void Michael S. Tsirkin
2016-02-25 11:20 ` [Qemu-devel] [PULL v3 10/21] virtio: add AioContext-specific function for host notifiers Michael S. Tsirkin
2016-02-25 11:20 ` Michael S. Tsirkin [this message]
2016-02-25 11:20 ` [Qemu-devel] [PULL v3 12/21] virtio-blk: fix "disabled data plane" mode Michael S. Tsirkin
2016-02-25 11:21 ` [Qemu-devel] [PULL v3 13/21] virtio-blk: do not use vring in dataplane Michael S. Tsirkin
2016-02-25 11:21 ` [Qemu-devel] [PULL v3 14/21] virtio-scsi: " Michael S. Tsirkin
2016-02-25 11:21 ` [Qemu-devel] [PULL v3 15/21] vring: remove Michael S. Tsirkin
2016-02-25 11:21 ` [Qemu-devel] [PULL v3 16/21] tests/vhost-user-bridge: fix build on 32 bit systems Michael S. Tsirkin
2016-02-25 11:21 ` [Qemu-devel] [PULL v3 17/21] q35: Remove old machine versions Michael S. Tsirkin
2016-02-25 11:21 ` [Qemu-devel] [PULL v3 18/21] machine: Remove no_tco field Michael S. Tsirkin
2016-02-25 11:21 ` [Qemu-devel] [PULL v3 19/21] ich9: Remove enable_tco arguments from init functions Michael S. Tsirkin
2016-02-25 11:21 ` [Qemu-devel] [PULL v3 20/21] q35: Remove unused q35-acpi-dsdt.aml file Michael S. Tsirkin
2016-02-25 11:21 ` [Qemu-devel] [PULL v3 21/21] q35: No need to check gigabyte_align Michael S. Tsirkin
2016-02-25 12:57 ` [Qemu-devel] [PULL v3 00/21] vhost, virtio, pci, pc Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456399032-6172-12-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).