qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 1/6] target-tricore: fix save_context_upper using env->PSW
Date: Thu, 25 Feb 2016 13:06:08 +0100	[thread overview]
Message-ID: <1456401973-29673-2-git-send-email-kbastian@mail.uni-paderborn.de> (raw)
In-Reply-To: <1456401973-29673-1-git-send-email-kbastian@mail.uni-paderborn.de>

If the cached bits for C, V, SV, AV, or SAV were set, they would
not be saved during the context save since env->PSW was stored instead
of properly reading them using psw_read().

Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
 target-tricore/op_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-tricore/op_helper.c b/target-tricore/op_helper.c
index 3aa6326..796fe67 100644
--- a/target-tricore/op_helper.c
+++ b/target-tricore/op_helper.c
@@ -2279,7 +2279,7 @@ static bool cdc_zero(target_ulong *psw)
 static void save_context_upper(CPUTriCoreState *env, int ea)
 {
     cpu_stl_data(env, ea, env->PCXI);
-    cpu_stl_data(env, ea+4, env->PSW);
+    cpu_stl_data(env, ea+4, psw_read(env));
     cpu_stl_data(env, ea+8, env->gpr_a[10]);
     cpu_stl_data(env, ea+12, env->gpr_a[11]);
     cpu_stl_data(env, ea+16, env->gpr_d[8]);
-- 
2.7.1

  reply	other threads:[~2016-02-25 12:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25 12:06 [Qemu-devel] [PULL 0/6] tricore patches Bastian Koppelmann
2016-02-25 12:06 ` Bastian Koppelmann [this message]
2016-02-25 12:06 ` [Qemu-devel] [PULL 2/6] target-tricore: Fix wrong precedences on psw_write Bastian Koppelmann
2016-02-25 12:06 ` [Qemu-devel] [PULL 3/6] target-tricore: Add trap handling & SOVF/OVF traps Bastian Koppelmann
2016-02-25 12:06 ` [Qemu-devel] [PULL 4/6] target-tricore: add context managment trap generation Bastian Koppelmann
2016-02-25 12:06 ` [Qemu-devel] [PULL 5/6] target-tricore: add illegal opcode " Bastian Koppelmann
2016-02-25 12:06 ` [Qemu-devel] [PULL 6/6] target-tricore: add opd " Bastian Koppelmann
2016-02-25 14:56 ` [Qemu-devel] [PULL 0/6] tricore patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456401973-29673-2-git-send-email-kbastian@mail.uni-paderborn.de \
    --to=kbastian@mail.uni-paderborn.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).