From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYwxX-0001EK-Pg for qemu-devel@nongnu.org; Thu, 25 Feb 2016 09:32:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYwxW-00083G-WE for qemu-devel@nongnu.org; Thu, 25 Feb 2016 09:32:03 -0500 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:33369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYwxW-00082l-Q6 for qemu-devel@nongnu.org; Thu, 25 Feb 2016 09:32:02 -0500 Received: by mail-wm0-x22e.google.com with SMTP id g62so34330019wme.0 for ; Thu, 25 Feb 2016 06:32:02 -0800 (PST) From: Jiri Pirko Date: Thu, 25 Feb 2016 15:31:56 +0100 Message-Id: <1456410718-24506-3-git-send-email-jiri@resnulli.us> In-Reply-To: <1456410718-24506-1-git-send-email-jiri@resnulli.us> References: <1456410718-24506-1-git-send-email-jiri@resnulli.us> Subject: [Qemu-devel] [patch qemu v2 2/4] rocker: return -ENOMEM in case of some world alloc fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: prem@barefootnetworks.com, daniel@iogearbox.net, stefanha@gmail.com, jasowang@redhat.com, parag.bhide@barefootnetworks.com, idosch@mellanox.com, sfeldma@gmail.com, eladr@mellanox.com, pbonzini@redhat.com, alexei.starovoitov@gmail.com From: Jiri Pirko Until now, 0 is returned in this error case. Fix it ro return -ENOMEM. Signed-off-by: Jiri Pirko --- v1->v2: - new patch --- hw/net/rocker/rocker.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c index a1d921d..104c097 100644 --- a/hw/net/rocker/rocker.c +++ b/hw/net/rocker/rocker.c @@ -1301,6 +1301,7 @@ static int pci_rocker_init(PCIDevice *dev) for (i = 0; i < ROCKER_WORLD_TYPE_MAX; i++) { if (!r->worlds[i]) { + err = -ENOMEM; goto err_world_alloc; } } -- 2.4.3