qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, jcody@redhat.com,
	qemu-devel@nongnu.org, stefanha@redhat.com,
	John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH v4 0/3] blockjob: correct backup cluster size for backups
Date: Thu, 25 Feb 2016 15:58:28 -0500	[thread overview]
Message-ID: <1456433911-24718-1-git-send-email-jsnow@redhat.com> (raw)

Backups sometimes need a non-64KiB transfer cluster size.
See patch #2 for the detailed justificaton.

===
v4:
===

02: Polished the error message.

===
v3:
===

01: +R-B
02: Added failure mode for bdrv_get_info, including critical failure for when
    we don't have a backing file but couldn't retrieve the cluster_size info.

===
v2:
===

01: Removed "sectors_per_cluster" as a cached property of the Backup Block Job,
    In favor of recomputing it with a small function where needed.
    (I like v1 more. Thoughts?)
02: Expand correction to all backup modes instead of just incremental.
    Added credit: Thanks to Fam Z for noticing this problem!
03: Minor phrasing change in a comment.
    Added r-b.

________________________________________________________________________________

For convenience, this branch is available at:
https://github.com/jnsnow/qemu.git branch incremental-granularity-fix
https://github.com/jnsnow/qemu/tree/incremental-granularity-fix

This version is tagged incremental-granularity-fix-v4:
https://github.com/jnsnow/qemu/releases/tag/incremental-granularity-fix-v4

John Snow (3):
  block/backup: make backup cluster size configurable
  block/backup: avoid copying less than full target clusters
  iotests/124: Add cluster_size mismatch test

 block/backup.c             | 87 ++++++++++++++++++++++++++++++----------------
 tests/qemu-iotests/124     | 58 ++++++++++++++++++++++++++++---
 tests/qemu-iotests/124.out |  4 +--
 3 files changed, 112 insertions(+), 37 deletions(-)

-- 
2.4.3

             reply	other threads:[~2016-02-25 20:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25 20:58 John Snow [this message]
2016-02-25 20:58 ` [Qemu-devel] [PATCH v4 1/3] block/backup: make backup cluster size configurable John Snow
2016-02-25 20:58 ` [Qemu-devel] [PATCH v4 2/3] block/backup: avoid copying less than full target clusters John Snow
2016-02-26  5:50   ` Fam Zheng
2016-02-25 20:58 ` [Qemu-devel] [PATCH v4 3/3] iotests/124: Add cluster_size mismatch test John Snow
2016-02-29 19:59 ` [Qemu-devel] [PATCH v4 0/3] blockjob: correct backup cluster size for backups Jeff Cody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456433911-24718-1-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).