From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZzts-0007c1-Ez for qemu-devel@nongnu.org; Sun, 28 Feb 2016 06:52:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZztp-0000nV-9Q for qemu-devel@nongnu.org; Sun, 28 Feb 2016 06:52:36 -0500 Received: from mail-pf0-x22d.google.com ([2607:f8b0:400e:c00::22d]:35280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZztp-0000nM-1d for qemu-devel@nongnu.org; Sun, 28 Feb 2016 06:52:33 -0500 Received: by mail-pf0-x22d.google.com with SMTP id w128so30429651pfb.2 for ; Sun, 28 Feb 2016 03:52:32 -0800 (PST) From: Rita Sinha Date: Sun, 28 Feb 2016 17:22:26 +0530 Message-Id: <1456660346-29148-1-git-send-email-rita.sinha89@gmail.com> Subject: [Qemu-devel] [PATCH] kvm: x86: q35: Add support for -machine kernel_irqchip=split for q35 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, jan.kiszka@web.de, gingell@google.com, stefanha@gmail.com The split IRQ chip mode via KVM_CAP_SPLIT_IRQCHIP was introduced with commit 15eafc2e602ff8c37c6e132eb8c63fec8fc17175 but was broken for q35. This patch makes kernel_irqchip=split functional for q35. --- hw/i386/pc_q35.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 46522c9..ff6a5af 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -39,6 +39,7 @@ #include "hw/kvm/clock.h" #include "hw/pci-host/q35.h" #include "exec/address-spaces.h" +#include "hw/i386/pc.h" #include "hw/i386/ich9.h" #include "hw/smbios/smbios.h" #include "hw/ide/pci.h" @@ -145,7 +146,7 @@ static void pc_q35_init(MachineState *machine) /* irq lines */ gsi_state = g_malloc0(sizeof(*gsi_state)); - if (kvm_irqchip_in_kernel()) { + if (kvm_ioapic_in_kernel()) { kvm_pc_setup_irq_routing(pcmc->pci_enabled); gsi = qemu_allocate_irqs(kvm_pc_gsi_handler, gsi_state, GSI_NUM_PINS); @@ -192,7 +193,7 @@ static void pc_q35_init(MachineState *machine) /*end early*/ isa_bus_irqs(isa_bus, gsi); - if (kvm_irqchip_in_kernel()) { + if (kvm_pit_in_kernel()) { i8259 = kvm_i8259_init(isa_bus); } else if (xen_enabled()) { i8259 = xen_interrupt_controller_init(); -- 2.7.1