qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, qemu-devel@nongnu.org,
	agraf@suse.de, qemu-ppc@nongnu.org,
	David Gibson <david@gibson.dropbear.id.au>,
	Greg Kurz <gkurz@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PULL 2/8] spapr_pci: kill useless variable in rtas_ibm_change_msi()
Date: Mon, 29 Feb 2016 17:58:25 +1100	[thread overview]
Message-ID: <1456729111-16797-3-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1456729111-16797-1-git-send-email-david@gibson.dropbear.id.au>

From: Greg Kurz <gkurz@linux.vnet.ibm.com>

The num local variable is initialized to zero and has no writer.

Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/ppc/spapr_pci.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index cca9257..19dd6db 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -275,7 +275,7 @@ static void rtas_ibm_change_msi(PowerPCCPU *cpu, sPAPRMachineState *spapr,
     unsigned int req_num = rtas_ld(args, 4); /* 0 == remove all */
     unsigned int seq_num = rtas_ld(args, 5);
     unsigned int ret_intr_type;
-    unsigned int irq, max_irqs = 0, num = 0;
+    unsigned int irq, max_irqs = 0;
     sPAPRPHBState *phb = NULL;
     PCIDevice *pdev = NULL;
     spapr_pci_msi *msi;
@@ -316,10 +316,10 @@ static void rtas_ibm_change_msi(PowerPCCPU *cpu, sPAPRMachineState *spapr,
 
         xics_free(spapr->icp, msi->first_irq, msi->num);
         if (msi_present(pdev)) {
-            spapr_msi_setmsg(pdev, 0, false, 0, num);
+            spapr_msi_setmsg(pdev, 0, false, 0, 0);
         }
         if (msix_present(pdev)) {
-            spapr_msi_setmsg(pdev, 0, true, 0, num);
+            spapr_msi_setmsg(pdev, 0, true, 0, 0);
         }
         g_hash_table_remove(phb->msi, &config_addr);
 
-- 
2.5.0

  parent reply	other threads:[~2016-02-29  6:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29  6:58 [Qemu-devel] [PULL 0/8] ppc-for-2.6 queue 20160229 David Gibson
2016-02-29  6:58 ` [Qemu-devel] [PULL 1/8] spapr_rng: disable hotpluggability David Gibson
2016-02-29  6:58 ` David Gibson [this message]
2016-02-29  6:58 ` [Qemu-devel] [PULL 3/8] spapr_pci: fix irq leak in RTAS ibm, change-msi David Gibson
2016-02-29  6:58 ` [Qemu-devel] [PULL 4/8] spapr: disable vmdesc submission for old machines David Gibson
2016-02-29  6:58 ` [Qemu-devel] [PULL 5/8] dbdma: warn when using unassigned channel David Gibson
2016-02-29  6:58 ` [Qemu-devel] [PULL 6/8] spapr: skip configuration section during migration of older machines David Gibson
2016-02-29  6:58 ` [Qemu-devel] [PULL 7/8] migration: allow machine to enforce configuration section migration David Gibson
2016-02-29  6:58 ` [Qemu-devel] [PULL 8/8] xics: report errors with the QEMU Error API David Gibson
2016-02-29 11:24 ` [Qemu-devel] [PULL 0/8] ppc-for-2.6 queue 20160229 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456729111-16797-3-git-send-email-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=gkurz@linux.vnet.ibm.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).