From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43667)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <abologna@redhat.com>) id 1aalAm-0003iy-KC
	for qemu-devel@nongnu.org; Tue, 01 Mar 2016 09:21:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <abologna@redhat.com>) id 1aalAj-0001ev-Cn
	for qemu-devel@nongnu.org; Tue, 01 Mar 2016 09:21:12 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35999)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <abologna@redhat.com>) id 1aalAj-0001eg-81
	for qemu-devel@nongnu.org; Tue, 01 Mar 2016 09:21:09 -0500
Message-ID: <1456842059.3566.11.camel@redhat.com>
From: Andrea Bolognani <abologna@redhat.com>
Date: Tue, 01 Mar 2016 15:20:59 +0100
In-Reply-To: <1456224728-28163-2-git-send-email-peterx@redhat.com>
References: <1456224728-28163-1-git-send-email-peterx@redhat.com>
	<1456224728-28163-2-git-send-email-peterx@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: wei@redhat.com, peter.maydell@linaro.org, drjones@redhat.com, armbru@redhat.com, mdroth@linux.vnet.ibm.com

On Tue, 2016-02-23 at 18:52 +0800, Peter Xu wrote:
> A new enum type is added to define ARM GIC types.
>=C2=A0
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>=C2=A0=C2=A0qapi-schema.json | 17 +++++++++++++++++
>=C2=A0=C2=A01 file changed, 17 insertions(+)
>=C2=A0
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 8d04897..81654bd 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -4083,3 +4083,20 @@
>=C2=A0=C2=A0##
>=C2=A0=C2=A0{ 'enum': 'ReplayMode',
>=C2=A0=C2=A0=C2=A0=C2=A0'data': [ 'none', 'record', 'play' ] }
> +
> +##
> +# @GICType:
> +#
> +# An enumeration of GIC types
> +#
> +# @gicv2:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0GICv2 support without kernel ir=
qchip
> +#
> +# @gicv3:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0GICv3 support without kernel ir=
qchip
> +#
> +# @gicv2-kvm: GICv3 support with kernel irqchip
> +#
> +# @gicv3-kvm: GICv3 support with kernel irqchip
> +#
> +# Since: 2.6
> +##
> +{ 'enum': 'GICType', 'data': [ 'gicv2', 'gicv3', 'gicv2-kvm', 'gicv3-k=
vm' ] }

Wouldn't this conflate the use of accel=3D and kernel_irqchip=3D options?

IIUC, depending on the hardware, you might find yourself in the
following situation:

=C2=A0 accel=3Dtcg,gic-version=3D3 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 unavailable
=C2=A0 accel=3Dkvm,kernel_irqchip=3Doff,gic-version=3D3=C2=A0=C2=A0unavai=
lable
=C2=A0 accel=3Dkvm,gic-version=3D3=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0available

so I'd expect the output to be something like

=C2=A0 [ "v2": { "tcg": true,
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0"=
kvm-without-kernel-irqchip": true,
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0"=
kvm": true },
=C2=A0=C2=A0=C2=A0=C2=A0"v3": { "tcg": false,
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0"=
kvm-without-kernel-irqchip": false,
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0"=
kvm": true } ]

Since libvirt currently doesn't have support for the
kernel_irqchip=3D option, it would only take the "tcg" and "kvm"
values into account; on the other hand, if at some point
libvirt will grow support for that option it would be able to
retrieve all the required information.

Cheers.

--=C2=A0
Andrea Bolognani
Software Engineer - Virtualization Team