* [Qemu-devel] [PATCH] target-i386: avoid repeated calls to the bnd_jmp helper
@ 2016-03-01 15:12 Paolo Bonzini
2016-03-01 16:28 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2016-03-01 15:12 UTC (permalink / raw)
To: qemu-devel; +Cc: rth
One flag was tested the wrong way.
Cc: rth@twiddle.net
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target-i386/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index b345e2c..ebd8995 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -2420,7 +2420,7 @@ static void gen_bnd_jmp(DisasContext *s)
itself will check BNDPRESERVE at runtime. */
if ((s->prefix & PREFIX_REPNZ) == 0
&& (s->flags & HF_MPX_EN_MASK) == 0
- && (s->flags & HF_MPX_IU_MASK) == 0) {
+ && (s->flags & HF_MPX_IU_MASK) != 0) {
gen_helper_bnd_jmp(cpu_env);
}
}
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] target-i386: avoid repeated calls to the bnd_jmp helper
2016-03-01 15:12 [Qemu-devel] [PATCH] target-i386: avoid repeated calls to the bnd_jmp helper Paolo Bonzini
@ 2016-03-01 16:28 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2016-03-01 16:28 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
On 03/01/2016 07:12 AM, Paolo Bonzini wrote:
> One flag was tested the wrong way.
>
> Cc: rth@twiddle.net
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> target-i386/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/translate.c b/target-i386/translate.c
> index b345e2c..ebd8995 100644
> --- a/target-i386/translate.c
> +++ b/target-i386/translate.c
> @@ -2420,7 +2420,7 @@ static void gen_bnd_jmp(DisasContext *s)
> itself will check BNDPRESERVE at runtime. */
> if ((s->prefix & PREFIX_REPNZ) == 0
> && (s->flags & HF_MPX_EN_MASK) == 0
> - && (s->flags & HF_MPX_IU_MASK) == 0) {
> + && (s->flags & HF_MPX_IU_MASK) != 0) {
Ho hum. Two flags tested the wrong way -- EN_MASK should be on as well.
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-01 16:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-01 15:12 [Qemu-devel] [PATCH] target-i386: avoid repeated calls to the bnd_jmp helper Paolo Bonzini
2016-03-01 16:28 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).