From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aarbr-0000E6-6D for qemu-devel@nongnu.org; Tue, 01 Mar 2016 16:13:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aarbn-0002H4-ST for qemu-devel@nongnu.org; Tue, 01 Mar 2016 16:13:35 -0500 Received: from e17.ny.us.ibm.com ([129.33.205.207]:40137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aarbn-0002GO-Os for qemu-devel@nongnu.org; Tue, 01 Mar 2016 16:13:31 -0500 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 1 Mar 2016 16:13:30 -0500 Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 9C1426E8040 for ; Tue, 1 Mar 2016 16:00:19 -0500 (EST) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u21LDSQ732112734 for ; Tue, 1 Mar 2016 21:13:28 GMT Received: from d01av05.pok.ibm.com (localhost [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u21L9J32002368 for ; Tue, 1 Mar 2016 16:09:19 -0500 From: Matthew Rosato Date: Tue, 1 Mar 2016 16:13:20 -0500 Message-Id: <1456866806-31466-1-git-send-email-mjrosato@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v7 0/6] Allow hotplug of s390 CPUs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: dahi@linux.vnet.ibm.com, agraf@suse.de, borntraeger@de.ibm.com, imammedo@redhat.com, bharata@linux.vnet.ibm.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, afaerber@suse.de, rth@twiddle.net Changes from v6->v7: * Patch 1 - Cannot move cpu_model default setting to machine instance_init, as vl.c can overwrite it again with a NULL during startup. Left check in s390_init_cpus. * Drop cpu_last patch (Andreas) * Patch 4 - merged with patch that adds hotplug handler / set cpu property. * New patch 5 - Add cpu_s390x_create and s390_new_cpu to allow for error handling during cpu creation (Andreas). Re-add mechanism for tracking next cpu ID. Encapsulate IDs as a CPU property & perform checking (David) -- I used x86 apic_id as a template. * Patch 6 - Add error handling to s390_hot_add_cpu via s390_new_cpu. (Andreas) ************** As discussed in the KVM call, we will go ahead with cpu_add for s390x to get cpu hotplug functionality in s390x now, until architectures that require a more robust hotplug interface settle on a design. To configure a guest with 2 CPUs online at boot and 4 maximum: qemu -smp 2,maxcpus=4 Or, when using libvirt: ... 4 ... To subsequently hotplug a CPU: Issue 'cpu-add ' from qemu monitor, or use virsh setvcpus --count , where is the total number of desired guest CPUs. At this point, the guest must bring the CPU online for use -- This can be achieved via "echo 1 > /sys/devices/system/cpu/cpuX/online" or via a management tool like cpuplugd. This patch set is based on work previously done by Jason Herne. Matthew Rosato (6): s390x/cpu: Cleanup init in preparation for hotplug s390x/cpu: Set initial CPU state in common routine s390x/cpu: Move some CPU initialization into realize s390x/cpu: Add CPU property links s390x/cpu: Add error handling to cpu creation s390x/cpu: Allow hotplug of CPUs hw/s390x/s390-virtio-ccw.c | 78 +++++++++++++++++++++++++++++++++++++++++++- hw/s390x/s390-virtio.c | 36 +++++++++++---------- hw/s390x/s390-virtio.h | 3 +- target-s390x/cpu-qom.h | 3 ++ target-s390x/cpu.c | 80 +++++++++++++++++++++++++++++++++++++++++++--- target-s390x/cpu.h | 1 + target-s390x/helper.c | 31 ++++++++++++++++-- 7 files changed, 208 insertions(+), 24 deletions(-) -- 1.9.1