* [Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys
@ 2016-03-01 22:04 Programmingkid
2016-03-01 22:23 ` Gerd Hoffmann
0 siblings, 1 reply; 5+ messages in thread
From: Programmingkid @ 2016-03-01 22:04 UTC (permalink / raw)
To: Peter Maydell, Eric Blake, Gerd Hoffmann; +Cc: qemu-devel qemu-devel
Add kp_equals and power keys support to the QKeyCode enum of keys.
Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
---
qapi-schema.json | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index 8d04897..d63b17a 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3044,7 +3044,7 @@
'left', 'up', 'down', 'right', 'insert', 'delete', 'stop', 'again',
'props', 'undo', 'front', 'copy', 'open', 'paste', 'find', 'cut',
'lf', 'help', 'meta_l', 'meta_r', 'compose', 'pause', 'ro',
- 'kp_comma' ] }
+ 'kp_comma', 'kp_equals', 'power' ] }
##
# @KeyValue
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys
2016-03-01 22:04 [Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys Programmingkid
@ 2016-03-01 22:23 ` Gerd Hoffmann
2016-03-01 22:33 ` Programmingkid
0 siblings, 1 reply; 5+ messages in thread
From: Gerd Hoffmann @ 2016-03-01 22:23 UTC (permalink / raw)
To: Programmingkid; +Cc: Peter Maydell, qemu-devel qemu-devel
On Di, 2016-03-01 at 17:04 -0500, Programmingkid wrote:
> Add kp_equals and power keys support to the QKeyCode enum of keys.
Please update the documentation in the comment too, so we keep track of
which keys where added in which release.
Otherwise it's fine.
thanks,
Gerd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys
2016-03-01 22:23 ` Gerd Hoffmann
@ 2016-03-01 22:33 ` Programmingkid
2016-03-01 23:17 ` Eric Blake
2016-03-02 6:29 ` Gerd Hoffmann
0 siblings, 2 replies; 5+ messages in thread
From: Programmingkid @ 2016-03-01 22:33 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: Peter Maydell, qemu-devel qemu-devel
On Mar 1, 2016, at 5:23 PM, Gerd Hoffmann wrote:
> On Di, 2016-03-01 at 17:04 -0500, Programmingkid wrote:
>> Add kp_equals and power keys support to the QKeyCode enum of keys.
>
> Please update the documentation in the comment too, so we keep track of
> which keys where added in which release.
>
> Otherwise it's fine.
>
> thanks,
> Gerd
>
Is this what you mean:
##
# @QKeyCode:
#
# An enumeration of key name.
#
# This is used by the send-key command.
#
# Since: 1.3.0
#
# 'unmapped' and 'pause' since 2.0
# 'ro' and 'kp_comma' since 2.4
# 'kp_equals' and 'power' since 2.6
##
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys
2016-03-01 22:33 ` Programmingkid
@ 2016-03-01 23:17 ` Eric Blake
2016-03-02 6:29 ` Gerd Hoffmann
1 sibling, 0 replies; 5+ messages in thread
From: Eric Blake @ 2016-03-01 23:17 UTC (permalink / raw)
To: Programmingkid, Gerd Hoffmann; +Cc: Peter Maydell, qemu-devel qemu-devel
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
On 03/01/2016 03:33 PM, Programmingkid wrote:
>
> On Mar 1, 2016, at 5:23 PM, Gerd Hoffmann wrote:
>
>> On Di, 2016-03-01 at 17:04 -0500, Programmingkid wrote:
>>> Add kp_equals and power keys support to the QKeyCode enum of keys.
>>
>> Please update the documentation in the comment too, so we keep track of
>> which keys where added in which release.
>>
>> Otherwise it's fine.
>>
>> thanks,
>> Gerd
>>
>
> Is this what you mean:
>
> ##
> # @QKeyCode:
> #
> # An enumeration of key name.
> #
> # This is used by the send-key command.
> #
> # Since: 1.3.0
> #
> # 'unmapped' and 'pause' since 2.0
> # 'ro' and 'kp_comma' since 2.4
> # 'kp_equals' and 'power' since 2.6
Yes.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys
2016-03-01 22:33 ` Programmingkid
2016-03-01 23:17 ` Eric Blake
@ 2016-03-02 6:29 ` Gerd Hoffmann
1 sibling, 0 replies; 5+ messages in thread
From: Gerd Hoffmann @ 2016-03-02 6:29 UTC (permalink / raw)
To: Programmingkid; +Cc: Peter Maydell, qemu-devel qemu-devel
> > Please update the documentation in the comment too, so we keep track of
> > which keys where added in which release.
> >
> > Otherwise it's fine.
> >
> > thanks,
> > Gerd
> >
>
> Is this what you mean:
>
> # 'unmapped' and 'pause' since 2.0
> # 'ro' and 'kp_comma' since 2.4
> # 'kp_equals' and 'power' since 2.6
> ##
Yes.
thanks,
Gerd
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-02 6:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-01 22:04 [Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys Programmingkid
2016-03-01 22:23 ` Gerd Hoffmann
2016-03-01 22:33 ` Programmingkid
2016-03-01 23:17 ` Eric Blake
2016-03-02 6:29 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).