From: Liang Li <liang.z.li@intel.com>
To: quintela@redhat.com, amit.shah@redhat.com, qemu-devel@nongnu.org,
linux-kernel@vger.kernel.org
Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
Liang Li <liang.z.li@intel.com>,
dgilbert@redhat.com, virtualization@lists.linux-foundation.org,
linux-mm@kvack.org, pbonzini@redhat.com,
akpm@linux-foundation.org, rth@twiddle.net
Subject: [Qemu-devel] [RFC qemu 3/4] migration: not set migration bitmap in setup stage
Date: Thu, 3 Mar 2016 18:44:27 +0800 [thread overview]
Message-ID: <1457001868-15949-4-git-send-email-liang.z.li@intel.com> (raw)
In-Reply-To: <1457001868-15949-1-git-send-email-liang.z.li@intel.com>
Set ram_list.dirty_memory instead of migration bitmap, the migration
bitmap will be update when doing migration_bitmap_sync().
Set migration_dirty_pages to 0 and it will be updated by
migration_dirty_pages() too.
The following patch is based on this change.
Signed-off-by: Liang Li <liang.z.li@intel.com>
---
migration/ram.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 704f6a9..ee2547d 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1931,19 +1931,19 @@ static int ram_save_setup(QEMUFile *f, void *opaque)
ram_bitmap_pages = last_ram_offset() >> TARGET_PAGE_BITS;
migration_bitmap_rcu = g_new0(struct BitmapRcu, 1);
migration_bitmap_rcu->bmap = bitmap_new(ram_bitmap_pages);
- bitmap_set(migration_bitmap_rcu->bmap, 0, ram_bitmap_pages);
if (migrate_postcopy_ram()) {
migration_bitmap_rcu->unsentmap = bitmap_new(ram_bitmap_pages);
bitmap_set(migration_bitmap_rcu->unsentmap, 0, ram_bitmap_pages);
}
- /*
- * Count the total number of pages used by ram blocks not including any
- * gaps due to alignment or unplugs.
- */
- migration_dirty_pages = ram_bytes_total() >> TARGET_PAGE_BITS;
+ migration_dirty_pages = 0;
+ QLIST_FOREACH_RCU(block, &ram_list.blocks, next) {
+ cpu_physical_memory_set_dirty_range(block->offset,
+ block->used_length,
+ DIRTY_MEMORY_MIGRATION);
+ }
memory_global_dirty_log_start();
migration_bitmap_sync();
qemu_mutex_unlock_ramlist();
--
1.8.3.1
next prev parent reply other threads:[~2016-03-03 10:50 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 10:44 [Qemu-devel] [RFC qemu 0/4] A PV solution for live migration optimization Liang Li
2016-03-03 10:44 ` [Qemu-devel] [RFC qemu 1/4] pc: Add code to get the lowmem form PCMachineState Liang Li
2016-03-03 10:44 ` [Qemu-devel] [RFC qemu 2/4] virtio-balloon: Add a new feature to balloon device Liang Li
2016-03-03 12:23 ` Cornelia Huck
2016-03-04 2:38 ` Li, Liang Z
2016-03-03 12:56 ` Michael S. Tsirkin
2016-03-04 2:29 ` Li, Liang Z
2016-03-03 10:44 ` Liang Li [this message]
2016-03-03 10:44 ` [Qemu-devel] [RFC qemu 4/4] migration: filter out guest's free pages in ram bulk stage Liang Li
2016-03-03 12:16 ` Cornelia Huck
2016-03-04 2:32 ` Li, Liang Z
2016-03-03 12:45 ` Daniel P. Berrange
2016-03-04 2:43 ` Li, Liang Z
2016-03-03 13:58 ` [Qemu-devel] [RFC qemu 0/4] A PV solution for live migration optimization Roman Kagan
2016-03-04 1:35 ` Li, Liang Z
2016-03-03 17:46 ` Dr. David Alan Gilbert
2016-03-04 1:52 ` Li, Liang Z
2016-03-04 8:14 ` Roman Kagan
2016-03-04 9:08 ` Li, Liang Z
2016-03-04 10:23 ` Roman Kagan
2016-03-04 14:26 ` Li, Liang Z
2016-03-04 14:45 ` Michael S. Tsirkin
2016-03-04 15:49 ` Li, Liang Z
2016-03-05 19:55 ` Michael S. Tsirkin
2016-03-07 6:49 ` Li, Liang Z
2016-03-07 11:40 ` Michael S. Tsirkin
2016-03-07 15:06 ` Li, Liang Z
2016-03-09 14:28 ` Roman Kagan
2016-03-09 15:27 ` Li, Liang Z
2016-03-09 15:30 ` Michael S. Tsirkin
2016-03-10 1:41 ` Li, Liang Z
2016-03-10 12:29 ` Michael S. Tsirkin
2016-03-09 15:41 ` Michael S. Tsirkin
2016-03-09 17:04 ` Roman Kagan
2016-03-09 17:39 ` Michael S. Tsirkin
2016-03-10 10:21 ` Roman Kagan
2016-03-09 19:38 ` Rik van Riel
2016-03-10 9:30 ` Roman Kagan
2016-03-04 16:24 ` Paolo Bonzini
2016-03-04 18:51 ` Dr. David Alan Gilbert
2016-03-07 5:34 ` Li, Liang Z
2016-03-09 13:22 ` Roman Kagan
2016-03-09 14:19 ` Li, Liang Z
2016-03-09 6:18 ` Li, Liang Z
2016-03-04 7:55 ` Roman Kagan
2016-03-04 8:23 ` Li, Liang Z
2016-03-04 8:35 ` Roman Kagan
2016-03-04 9:08 ` Dr. David Alan Gilbert
2016-03-04 9:12 ` Li, Liang Z
2016-03-04 9:47 ` Michael S. Tsirkin
2016-03-04 10:11 ` Li, Liang Z
2016-03-04 10:36 ` Michael S. Tsirkin
2016-03-04 15:13 ` Li, Liang Z
2016-03-08 14:03 ` Michael S. Tsirkin
2016-03-08 14:17 ` Li, Liang Z
2016-03-04 9:35 ` Roman Kagan
2016-03-08 11:13 ` Amit Shah
2016-03-08 13:11 ` Li, Liang Z
2016-03-10 7:44 ` Li, Liang Z
2016-03-10 7:57 ` Amit Shah
2016-03-10 8:36 ` Li, Liang Z
2016-03-10 11:18 ` Dr. David Alan Gilbert
2016-03-11 2:38 ` Li, Liang Z
2016-03-14 17:03 ` Dr. David Alan Gilbert
2016-03-15 3:31 ` Li, Liang Z
2016-03-15 10:29 ` Michael S. Tsirkin
2016-03-15 11:11 ` Li, Liang Z
2016-03-15 19:55 ` Dr. David Alan Gilbert
2016-03-16 1:20 ` Li, Liang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457001868-15949-4-git-send-email-liang.z.li@intel.com \
--to=liang.z.li@intel.com \
--cc=akpm@linux-foundation.org \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).