From: Andrea Bolognani <abologna@redhat.com>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: wei@redhat.com, peter.maydell@linaro.org, drjones@redhat.com,
armbru@redhat.com, mdroth@linux.vnet.ibm.com,
qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 3/3] arm: implement query-gic-capability
Date: Thu, 03 Mar 2016 13:19:47 +0100 [thread overview]
Message-ID: <1457007587.4468.2.camel@redhat.com> (raw)
In-Reply-To: <1456993272-32292-4-git-send-email-peterx@redhat.com>
On Thu, 2016-03-03 at 16:21 +0800, Peter Xu wrote:
> For emulated ARM VM, only gicv2 is supported. We need to add gicv3
in
> when emulated gicv3 ready. For KVM accelerated ARM VM, we detect the
> capability bits using ioctls.
>
> if we want to
know GIC kernel capabilities, we need to make sure we have
> enabled KVM when querying (like, with "-enable-kvm").
>
>
Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> target-arm/machine.c | 48
+++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 47 insertions(+), 1 deletion(-)
Sorry for not catching this earlier, but I'm afraid this is not
going to work -- libvirt doesn't pass either -enable-kvm or the
machine option accel=kvm when probing for capabilities, which
means that, with the current implementation, it will only get
information about emulated GIC.
Is there a way to make probing work without requiring KVM to
be enabled?
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team
next prev parent reply other threads:[~2016-03-03 12:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 8:21 [Qemu-devel] [PATCH v2 0/3] ARM: add query-gic-capability SMP command Peter Xu
2016-03-03 8:21 ` [Qemu-devel] [PATCH v2 1/3] arm: qmp: add GICCapability struct Peter Xu
2016-03-03 8:21 ` [Qemu-devel] [PATCH v2 2/3] arm: qmp: add query-gic-capability interface Peter Xu
2016-03-03 11:55 ` Andrew Jones
2016-03-04 2:22 ` Peter Xu
2016-03-03 8:21 ` [Qemu-devel] [PATCH v2 3/3] arm: implement query-gic-capability Peter Xu
2016-03-03 12:19 ` Andrea Bolognani [this message]
2016-03-04 2:52 ` Peter Xu
2016-03-04 8:43 ` Andrea Bolognani
2016-03-07 4:27 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457007587.4468.2.camel@redhat.com \
--to=abologna@redhat.com \
--cc=armbru@redhat.com \
--cc=drjones@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).