From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abSEZ-0000v9-Jk for qemu-devel@nongnu.org; Thu, 03 Mar 2016 07:20:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abSEY-00088s-PQ for qemu-devel@nongnu.org; Thu, 03 Mar 2016 07:19:59 -0500 Message-ID: <1457007587.4468.2.camel@redhat.com> From: Andrea Bolognani Date: Thu, 03 Mar 2016 13:19:47 +0100 In-Reply-To: <1456993272-32292-4-git-send-email-peterx@redhat.com> References: <1456993272-32292-1-git-send-email-peterx@redhat.com> <1456993272-32292-4-git-send-email-peterx@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 3/3] arm: implement query-gic-capability List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org Cc: wei@redhat.com, peter.maydell@linaro.org, drjones@redhat.com, armbru@redhat.com, mdroth@linux.vnet.ibm.com, qemu-arm@nongnu.org On Thu, 2016-03-03 at 16:21 +0800, Peter Xu wrote: > For emulated ARM VM, only gicv2 is supported. We need to add gicv3 in > when emulated gicv3 ready. For KVM accelerated ARM VM, we detect the > capability bits using ioctls. >=C2=A0 > if we want to know GIC kernel capabilities, we need to make sure we have > enabled KVM when querying (like, with "-enable-kvm"). >=C2=A0 > Signed-off-by: Peter Xu > --- >=C2=A0=C2=A0target-arm/machine.c | 48 +++++++++++++++++++++++++++++++++++++++++++++++- >=C2=A0=C2=A01 file changed, 47 insertions(+), 1 deletion(-) Sorry for not catching this earlier, but I'm afraid this is not going to work -- libvirt doesn't pass either -enable-kvm or the machine option accel=3Dkvm when probing for capabilities, which means that, with the current implementation, it will only get information about emulated GIC. Is there a way to make probing work without requiring KVM to be enabled? Cheers. --=C2=A0 Andrea Bolognani Software Engineer - Virtualization Team