From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abjdM-0001Yr-R3 for qemu-devel@nongnu.org; Fri, 04 Mar 2016 01:54:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abjdI-0005T9-NY for qemu-devel@nongnu.org; Fri, 04 Mar 2016 01:54:44 -0500 Received: from e28smtp01.in.ibm.com ([125.16.236.1]:42655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abjdI-0005S7-0X for qemu-devel@nongnu.org; Fri, 04 Mar 2016 01:54:40 -0500 Received: from localhost by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 4 Mar 2016 12:24:36 +0530 From: Bharata B Rao Date: Fri, 4 Mar 2016 12:24:13 +0530 Message-Id: <1457074461-14285-3-git-send-email-bharata@linux.vnet.ibm.com> In-Reply-To: <1457074461-14285-1-git-send-email-bharata@linux.vnet.ibm.com> References: <1457074461-14285-1-git-send-email-bharata@linux.vnet.ibm.com> Subject: [Qemu-devel] [RFC PATCH v1 02/10] exec: Do vmstate unregistration from cpu_exec_exit() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mjrosato@linux.vnet.ibm.com, thuth@redhat.com, pkrempa@redhat.com, ehabkost@redhat.com, aik@ozlabs.ru, Bharata B Rao , armbru@redhat.com, agraf@suse.de, borntraeger@de.ibm.com, qemu-ppc@nongnu.org, pbonzini@redhat.com, imammedo@redhat.com, mdroth@linux.vnet.ibm.com, afaerber@suse.de, david@gibson.dropbear.id.au cpu_exec_init() does vmstate_register and register_savevm for the CPU device. These need to be undone from cpu_exec_exit(). These changes are needed to support CPU hot removal. Signed-off-by: Bharata B Rao --- exec.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/exec.c b/exec.c index 7c3f747..b8eeb54 100644 --- a/exec.c +++ b/exec.c @@ -613,6 +613,8 @@ static void cpu_release_index(CPUState *cpu) void cpu_exec_exit(CPUState *cpu) { + CPUClass *cc = CPU_GET_CLASS(cpu); + #if defined(CONFIG_USER_ONLY) cpu_list_lock(); #endif @@ -630,6 +632,16 @@ void cpu_exec_exit(CPUState *cpu) #if defined(CONFIG_USER_ONLY) cpu_list_unlock(); #endif + + if (cc->vmsd != NULL) { + vmstate_unregister(NULL, cc->vmsd, cpu); + } +#if defined(CPU_SAVE_VERSION) && !defined(CONFIG_USER_ONLY) + unregister_savevm(NULL, "cpu", cpu->env_ptr); +#endif + if (qdev_get_vmsd(DEVICE(cpu)) == NULL) { + vmstate_unregister(NULL, &vmstate_cpu_common, cpu); + } } void cpu_exec_init(CPUState *cpu, Error **errp) -- 2.1.0