From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Xiao Guangrong <guangrong.xiao@linux.intel.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PULL 04/16] acpi: add build_append_named_dword, returning an offset in buffer
Date: Fri, 4 Mar 2016 09:49:23 +0200 [thread overview]
Message-ID: <1457077710-17678-5-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1457077710-17678-1-git-send-email-mst@redhat.com>
This is a very limited form of support for runtime patching -
similar in functionality to what we can do with ACPI_EXTRACT
macros in python, but implemented in C.
This is to allow ACPI code direct access to data tables -
which is exactly what DataTableRegion is there for, except
no known windows release so far implements DataTableRegion.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/acpi/aml-build.h | 3 +++
hw/acpi/aml-build.c | 28 ++++++++++++++++++++++++++++
2 files changed, 31 insertions(+)
diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
index b16017e..66f48ec 100644
--- a/include/hw/acpi/aml-build.h
+++ b/include/hw/acpi/aml-build.h
@@ -368,4 +368,7 @@ void
build_rsdt(GArray *table_data, GArray *linker, GArray *table_offsets,
const char *oem_id, const char *oem_table_id);
+int
+build_append_named_dword(GArray *array, const char *name_format, ...);
+
#endif
diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index f26fa26..ab89ca6 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -258,6 +258,34 @@ static void build_append_int(GArray *table, uint64_t value)
}
}
+/*
+ * Build NAME(XXXX, 0x00000000) where 0x00000000 is encoded as a dword,
+ * and return the offset to 0x00000000 for runtime patching.
+ *
+ * Warning: runtime patching is best avoided. Only use this as
+ * a replacement for DataTableRegion (for guests that don't
+ * support it).
+ */
+int
+build_append_named_dword(GArray *array, const char *name_format, ...)
+{
+ int offset;
+ va_list ap;
+
+ build_append_byte(array, 0x08); /* NameOp */
+ va_start(ap, name_format);
+ build_append_namestringv(array, name_format, ap);
+ va_end(ap);
+
+ build_append_byte(array, 0x0C); /* DWordPrefix */
+
+ offset = array->len;
+ build_append_int_noprefix(array, 0x00000000, 4);
+ assert(array->len == offset + 4);
+
+ return offset;
+}
+
static GPtrArray *alloc_list;
static Aml *aml_alloc(void)
--
MST
next prev parent reply other threads:[~2016-03-04 7:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 7:49 [Qemu-devel] [PULL 00/16] vhost, virtio, pci, pc, acpi Michael S. Tsirkin
2016-03-04 7:49 ` [Qemu-devel] [PULL 01/16] acpi: add aml_create_field() Michael S. Tsirkin
2016-03-04 7:49 ` [Qemu-devel] [PULL 02/16] acpi: add aml_concatenate() Michael S. Tsirkin
2016-03-04 7:49 ` [Qemu-devel] [PULL 03/16] acpi: allow using object as offset for OperationRegion Michael S. Tsirkin
2016-03-04 7:49 ` Michael S. Tsirkin [this message]
2016-03-04 7:49 ` [Qemu-devel] [PULL 05/16] balloon: fix segfault and harden the stats queue Michael S. Tsirkin
2016-03-04 7:49 ` [Qemu-devel] [PULL 06/16] hw/virtio: fix double use of a virtio flag Michael S. Tsirkin
2016-03-04 7:49 ` [Qemu-devel] [PULL 07/16] hw/virtio: group virtio flags into an enum Michael S. Tsirkin
2016-03-04 7:49 ` [Qemu-devel] [PULL 08/16] virtio-balloon: export all balloon statistics Michael S. Tsirkin
2016-03-16 10:33 ` Denis V. Lunev
2016-03-16 10:37 ` Michael S. Tsirkin
2016-05-14 10:49 ` Denis V. Lunev
2016-03-04 7:49 ` [Qemu-devel] [PULL 09/16] virtio-balloon: add 'available' counter Michael S. Tsirkin
2016-03-04 7:49 ` [Qemu-devel] [PULL 10/16] vhost-user: verify that number of queues is less than MAX_QUEUE_NUM Michael S. Tsirkin
2016-03-04 7:49 ` [Qemu-devel] [PULL 11/16] pc-dimm: fix error handling in pc_dimm_check_memdev_is_busy() Michael S. Tsirkin
2016-03-04 7:49 ` [Qemu-devel] [PULL 12/16] i386/acpi: make floppy controller object dynamic Michael S. Tsirkin
2016-03-04 7:49 ` [Qemu-devel] [PULL 13/16] i386: expose floppy drive CMOS type Michael S. Tsirkin
2016-03-04 7:49 ` [Qemu-devel] [PULL 14/16] fdc: add function to determine drive chs limits Michael S. Tsirkin
2016-03-04 7:50 ` [Qemu-devel] [PULL 15/16] i386: populate floppy drive information in DSDT Michael S. Tsirkin
2016-03-04 7:50 ` [Qemu-devel] [PULL 16/16] i386: update expected DSDT Michael S. Tsirkin
2016-03-04 8:49 ` [Qemu-devel] [PULL 00/16] vhost, virtio, pci, pc, acpi Fam Zheng
2016-03-04 8:52 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457077710-17678-5-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=guangrong.xiao@linux.intel.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).