qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Sarah Khan <sarahjmi07@gmail.com>
To: qemu-devel@nongnu.org, famz@redhat.org
Cc: Sarah Khan <sarahjmi07@gmail.com>
Subject: [Qemu-devel] [PATCH v2][Outreachy Round 12]
Date: Fri,  4 Mar 2016 22:39:30 +0530	[thread overview]
Message-ID: <1457111370-5455-1-git-send-email-sarahjmi07@gmail.com> (raw)
In-Reply-To: <1457103235-3341-1-git-send-email-sarahjmi07@gmail.com>

Replaced g_malloc() with g_new() as it would detect multiplication overflow if nb_fields ever oversize.

There is no corresponding free(). thunk_register_struct() is called
only at startup from the linux-user code in order to populate the
struct_entries array; this data structure then remains live for
the entire lifetime of the program and is automatically freed when
QEMU exits.

This replacement was suggested as part of the bite-sized tasks.

Signed-off-by: Sarah Khan <sarahjmi07@gmail.com>
---
Changes in v2 :Make commit message clearer
	       Replace g_malloc() with g_new()	
---
 thunk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/thunk.c b/thunk.c
index bddabae..6237702 100644
--- a/thunk.c
+++ b/thunk.c
@@ -88,7 +88,7 @@ void thunk_register_struct(int id, const char *name, const argtype *types)
     for(i = 0;i < 2; i++) {
         offset = 0;
         max_align = 1;
-        se->field_offsets[i] = g_malloc(nb_fields * sizeof(int));
+        se->field_offsets[i] = g_new(int,nb_fields);
         type_ptr = se->field_types;
         for(j = 0;j < nb_fields; j++) {
             size = thunk_type_size(type_ptr, i);
-- 
1.9.1

  parent reply	other threads:[~2016-03-04 17:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-04 14:53 [Qemu-devel] [PATCH][Outreachy] Signed-off-by: Sarah Khan <sarahjmi07@gmail.com> Sarah Khan
2016-03-04 15:44 ` Eric Blake
2016-03-04 15:49   ` Eric Blake
2016-03-04 15:53     ` Eric Blake
2016-03-04 16:06   ` Peter Maydell
2016-03-04 16:29     ` Sarah Khan
2016-03-04 16:35     ` Eric Blake
2016-03-04 16:44       ` Peter Maydell
2016-03-04 17:09 ` Sarah Khan [this message]
2016-03-05 10:42   ` [Qemu-devel] [PATCH v2][Outreachy Round 12] Markus Armbruster
2016-03-07  5:37     ` Sarah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457111370-5455-1-git-send-email-sarahjmi07@gmail.com \
    --to=sarahjmi07@gmail.com \
    --cc=famz@redhat.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).