From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abtFF-0007ND-Cv for qemu-devel@nongnu.org; Fri, 04 Mar 2016 12:10:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abtFC-00040d-3e for qemu-devel@nongnu.org; Fri, 04 Mar 2016 12:10:29 -0500 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:35257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abtFB-00040Z-T5 for qemu-devel@nongnu.org; Fri, 04 Mar 2016 12:10:26 -0500 Received: by mail-pf0-x244.google.com with SMTP id x188so1289336pfb.2 for ; Fri, 04 Mar 2016 09:10:25 -0800 (PST) From: Sarah Khan Date: Fri, 4 Mar 2016 22:39:30 +0530 Message-Id: <1457111370-5455-1-git-send-email-sarahjmi07@gmail.com> In-Reply-To: <1457103235-3341-1-git-send-email-sarahjmi07@gmail.com> References: <1457103235-3341-1-git-send-email-sarahjmi07@gmail.com> Subject: [Qemu-devel] [PATCH v2][Outreachy Round 12] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, famz@redhat.org Cc: Sarah Khan Replaced g_malloc() with g_new() as it would detect multiplication overflow if nb_fields ever oversize. There is no corresponding free(). thunk_register_struct() is called only at startup from the linux-user code in order to populate the struct_entries array; this data structure then remains live for the entire lifetime of the program and is automatically freed when QEMU exits. This replacement was suggested as part of the bite-sized tasks. Signed-off-by: Sarah Khan --- Changes in v2 :Make commit message clearer Replace g_malloc() with g_new() --- thunk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/thunk.c b/thunk.c index bddabae..6237702 100644 --- a/thunk.c +++ b/thunk.c @@ -88,7 +88,7 @@ void thunk_register_struct(int id, const char *name, const argtype *types) for(i = 0;i < 2; i++) { offset = 0; max_align = 1; - se->field_offsets[i] = g_malloc(nb_fields * sizeof(int)); + se->field_offsets[i] = g_new(int,nb_fields); type_ptr = se->field_types; for(j = 0;j < nb_fields; j++) { size = thunk_type_size(type_ptr, i); -- 1.9.1