From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acIzR-00045Y-0U for qemu-devel@nongnu.org; Sat, 05 Mar 2016 15:39:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acIzN-0001RD-PT for qemu-devel@nongnu.org; Sat, 05 Mar 2016 15:39:52 -0500 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:35289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acIzN-0001R9-Iv for qemu-devel@nongnu.org; Sat, 05 Mar 2016 15:39:49 -0500 Received: by mail-wm0-x235.google.com with SMTP id l68so35124023wml.0 for ; Sat, 05 Mar 2016 12:39:49 -0800 (PST) From: Nikos Filippakis Date: Sat, 5 Mar 2016 22:39:41 +0200 Message-Id: <1457210381-23325-1-git-send-email-aesmade@gmail.com> Subject: [Qemu-devel] [PATCH] net.c: Moved large array in nc_sendv_compat from the stack to the heap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Nikos Filippakis , jasowang@redhat.com Hello everyone! I am interested in getting to know the codebase a little better so that I can eventually apply for a GSOC position. This is my first attempt at posting a patch to a mailing list, any feedback is greatly appreciated. Signed-off-by: Nikos Filippakis --- net/net.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/net/net.c b/net/net.c index aebf753..79e9d7c 100644 --- a/net/net.c +++ b/net/net.c @@ -710,23 +710,30 @@ ssize_t qemu_send_packet_raw(NetClientState *nc, const uint8_t *buf, int size) static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov, int iovcnt, unsigned flags) { - uint8_t buf[NET_BUFSIZE]; uint8_t *buffer; size_t offset; + ssize_t ret; if (iovcnt == 1) { buffer = iov[0].iov_base; offset = iov[0].iov_len; } else { - buffer = buf; - offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf)); + buffer = g_malloc(NET_BUFSIZE * sizeof(uint8_t)); + offset = iov_to_buf(iov, iovcnt, 0, buffer, + NET_BUFSIZE * sizeof(uint8_t)); } if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) { - return nc->info->receive_raw(nc, buffer, offset); + ret = nc->info->receive_raw(nc, buffer, offset); } else { - return nc->info->receive(nc, buffer, offset); + ret = nc->info->receive(nc, buffer, offset); } + + if (iovcnt != 1) { + g_free(buffer); + } + + return ret; } ssize_t qemu_deliver_packet_iov(NetClientState *sender, -- 1.9.1