From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acclx-00022K-PD for qemu-devel@nongnu.org; Sun, 06 Mar 2016 12:47:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acclu-0000W7-Hu for qemu-devel@nongnu.org; Sun, 06 Mar 2016 12:47:17 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:34831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acclu-0000W2-AR for qemu-devel@nongnu.org; Sun, 06 Mar 2016 12:47:14 -0500 Received: by mail-wm0-x242.google.com with SMTP id 1so7057143wmg.2 for ; Sun, 06 Mar 2016 09:47:14 -0800 (PST) From: Nikos Filippakis Date: Sun, 6 Mar 2016 19:47:03 +0200 Message-Id: <1457286423-1587-1-git-send-email-aesmade@gmail.com> Subject: [Qemu-devel] [PATCH v2] net.c: Moved large array in nc_sendv_compat from the stack to the heap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Nikos Filippakis , jasowang@redhat.com Allocate large array in nc_sendv_compat on the heap to reduce stack frame size, as stated in the BiteSizedTasks wiki page. Signed-off-by: Nikos Filippakis --- net/net.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/net/net.c b/net/net.c index aebf753..ac78aba 100644 --- a/net/net.c +++ b/net/net.c @@ -710,23 +710,28 @@ ssize_t qemu_send_packet_raw(NetClientState *nc, const uint8_t *buf, int size) static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov, int iovcnt, unsigned flags) { - uint8_t buf[NET_BUFSIZE]; - uint8_t *buffer; + uint8_t *buffer, *dynbuf = NULL; size_t offset; + ssize_t ret; if (iovcnt == 1) { buffer = iov[0].iov_base; offset = iov[0].iov_len; } else { - buffer = buf; - offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf)); + buffer = dynbuf = g_new(uint8_t, NET_BUFSIZE); + offset = iov_to_buf(iov, iovcnt, 0, buffer, + NET_BUFSIZE * sizeof(uint8_t)); } if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) { - return nc->info->receive_raw(nc, buffer, offset); + ret = nc->info->receive_raw(nc, buffer, offset); } else { - return nc->info->receive(nc, buffer, offset); + ret = nc->info->receive(nc, buffer, offset); } + + g_free(dynbuf); + + return ret; } ssize_t qemu_deliver_packet_iov(NetClientState *sender, -- 1.9.1