From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: wei@redhat.com, peter.maydell@linaro.org, drjones@redhat.com,
mdroth@linux.vnet.ibm.com, armbru@redhat.com, peterx@redhat.com,
abologna@redhat.com, qemu-arm@nongnu.org
Subject: [Qemu-devel] [PATCH v3 2/3] arm: qmp: add query-gic-capability interface
Date: Mon, 7 Mar 2016 12:23:27 +0800 [thread overview]
Message-ID: <1457324608-11434-3-git-send-email-peterx@redhat.com> (raw)
In-Reply-To: <1457324608-11434-1-git-send-email-peterx@redhat.com>
This patch adds the command "query-gic-capability" but not implemnet
it. The command is ARM-only. Return of the command is a list of
GICCapability struct that describes all GIC versions that current QEMU
and system support.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
monitor.c | 8 ++++++++
qapi-schema.json | 11 +++++++++++
qmp-commands.hx | 26 ++++++++++++++++++++++++++
scripts/qapi.py | 1 +
target-arm/machine.c | 6 ++++++
5 files changed, 52 insertions(+)
diff --git a/monitor.c b/monitor.c
index 73eac17..3b34feb 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4241,3 +4241,11 @@ void qmp_dump_skeys(const char *filename, Error **errp)
error_setg(errp, QERR_FEATURE_DISABLED, "dump-skeys");
}
#endif
+
+#ifndef TARGET_ARM
+GICCapabilityList *qmp_query_gic_capability(Error **errp)
+{
+ error_setg(errp, QERR_FEATURE_DISABLED, "query-gic-capability");
+ return NULL;
+}
+#endif
diff --git a/qapi-schema.json b/qapi-schema.json
index 0b2de6c..f42c8f7 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -4157,3 +4157,14 @@
'data': { 'version': 'int',
'emulated': 'bool',
'kernel': 'bool' } }
+
+##
+# @query-gic-capability:
+#
+# Return a list of supported GIC version capabilities.
+#
+# Returns: a list of GICCapability.
+#
+# Since: 2.6
+##
+{ 'command': 'query-gic-capability', 'returns': ['GICCapability'] }
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 13f158d..5e843f2 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -4852,3 +4852,29 @@ Example:
{"type": 0, "out-pport": 0, "pport": 0, "vlan-id": 3840,
"pop-vlan": 1, "id": 251658240}
]}
+
+EQMP
+
+#if defined TARGET_ARM
+ {
+ .name = "query-gic-capability",
+ .args_type = "",
+ .mhandler.cmd_new = qmp_marshal_query_gic_capability,
+ },
+#endif
+
+SQMP
+query-gic-capability
+---------------
+
+Return a list of supported ARM GIC versions and their capabilities.
+
+Arguments: None
+
+Example:
+
+-> { "execute": "query-gic-capability" }
+<- { "return": [{ "version": 2, "emulated": true, "kernel": false },
+ { "version": 3, "emulated": false, "kernel": true } ] }
+
+EQMP
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 8497777..9dc8f73 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -46,6 +46,7 @@ returns_whitelist = [
'query-tpm-models',
'query-tpm-types',
'ringbuf-read',
+ 'query-gic-capability',
# From QGA:
'guest-file-open',
diff --git a/target-arm/machine.c b/target-arm/machine.c
index 03a73d9..60bd5c1 100644
--- a/target-arm/machine.c
+++ b/target-arm/machine.c
@@ -5,6 +5,7 @@
#include "sysemu/kvm.h"
#include "kvm_arm.h"
#include "internals.h"
+#include "qmp-commands.h"
static bool vfp_needed(void *opaque)
{
@@ -345,3 +346,8 @@ const char *gicv3_class_name(void)
exit(1);
}
+
+GICCapabilityList *qmp_query_gic_capability(Error **errp)
+{
+ return NULL;
+}
--
2.4.3
next prev parent reply other threads:[~2016-03-07 4:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 4:23 [Qemu-devel] [PATCH v3 0/3] ARM: add query-gic-capability SMP command Peter Xu
2016-03-07 4:23 ` [Qemu-devel] [PATCH v3 1/3] arm: qmp: add GICCapability struct Peter Xu
2016-03-07 4:23 ` Peter Xu [this message]
2016-03-07 4:23 ` [Qemu-devel] [PATCH v3 3/3] arm: implement query-gic-capability Peter Xu
2016-03-07 5:12 ` Andrew Jones
2016-03-07 5:38 ` Peter Xu
2016-03-07 7:38 ` Andrew Jones
2016-03-07 9:55 ` [Qemu-devel] [PATCH v3 0/3] ARM: add query-gic-capability SMP command Andrea Bolognani
2016-03-08 5:20 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457324608-11434-3-git-send-email-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=abologna@redhat.com \
--cc=armbru@redhat.com \
--cc=drjones@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).