From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acrtX-0007r7-Up for qemu-devel@nongnu.org; Mon, 07 Mar 2016 04:56:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acrtX-0000O9-0B for qemu-devel@nongnu.org; Mon, 07 Mar 2016 04:56:07 -0500 Message-ID: <1457344554.4468.12.camel@redhat.com> From: Andrea Bolognani Date: Mon, 07 Mar 2016 10:55:54 +0100 In-Reply-To: <1457324608-11434-1-git-send-email-peterx@redhat.com> References: <1457324608-11434-1-git-send-email-peterx@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 0/3] ARM: add query-gic-capability SMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org Cc: wei@redhat.com, peter.maydell@linaro.org, drjones@redhat.com, armbru@redhat.com, mdroth@linux.vnet.ibm.com, qemu-arm@nongnu.org On Mon, 2016-03-07 at 12:23 +0800, Peter Xu wrote: > v3 changes: > - patch 2: remove func declaration, add qmp header [Drew] > - patch 3: being able to detect KVM GIC capabilities even without >=C2=A0=C2=A0=C2=A0kvm enabled [Andrea]: this is a little bit hacky, need= some more >=C2=A0=C2=A0=C2=A0review on this. >=C2=A0 > v2 changes: > - result layout change: use array and dict for the capability bits >=C2=A0=C2=A0=C2=A0rather than a single array of strings [Andrea/Markus] > - spelling out what GIC is in doc [Eric] >=C2=A0 > This patch is to add ARM-specific command "query-gic-capability". >=C2=A0 > The new command can report which kind of GIC device the host/QEMU > support. The returned result is in the form of array. >=C2=A0 > Sample command and output: >=C2=A0 > {"execute": "query-gic-capability"} > {"return": [{"emulated": false, "version": 3, "kernel": false}, >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0{"emulated": true, "version": 2, "kernel": true}]} >=C2=A0 > Testing: >=C2=A0 > Smoke tests on both x86 (emulated) and another moonshot ARM server. >=C2=A0 > Peter Xu (3): >=C2=A0=C2=A0=C2=A0arm: qmp: add GICCapability struct >=C2=A0=C2=A0=C2=A0arm: qmp: add query-gic-capability interface >=C2=A0=C2=A0=C2=A0arm: implement query-gic-capability >=C2=A0 >=C2=A0=C2=A0monitor.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A0=C2=A08 ++++ >=C2=A0=C2=A0qapi-schema.json=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A03= 3 ++++++++++++++++ >=C2=A0=C2=A0qmp-commands.hx=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2= =A026 ++++++++++++ >=C2=A0=C2=A0scripts/qapi.py=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2= =A0=C2=A01 + >=C2=A0=C2=A0target-arm/machine.c | 109 +++++++++++++++++++++++++++++++++= ++++++++++++++++++ >=C2=A0=C2=A05 files changed, 177 insertions(+) I tested this both on a v2-only machine =C2=A0 {"return": [ =C2=A0=C2=A0=C2=A0=C2=A0{"emulated": false, "version": 3, "kernel": false= }, =C2=A0=C2=A0=C2=A0=C2=A0{"emulated": true, "version": 2, "kernel": true} =C2=A0 ]} and on a v3-only machine =C2=A0 {"return": [ =C2=A0=C2=A0=C2=A0=C2=A0{"emulated": false, "version": 3, "kernel": true}= , =C2=A0=C2=A0=C2=A0=C2=A0{"emulated": true, "version": 2, "kernel": false} =C2=A0 ]} The output looks good to me - I'll leave reviewing the implementation to someone with more QEMU knowledge than me, that is, any QEMU knowledge at all ;) One last, purely cosmetic, bit: should the command name be query-gic-capabilities rather than query-gic-capability? Any native speaker feels like weighing in? Cheers. --=C2=A0 Andrea Bolognani Software Engineer - Virtualization Team