From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PULL 12/15] doc/memory.txt: correct description of MemoryRegionOps fields
Date: Mon, 7 Mar 2016 18:36:58 +0100 [thread overview]
Message-ID: <1457372221-19285-13-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1457372221-19285-1-git-send-email-pbonzini@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Probably what happened was that when the API was being designed it
started off with an 'aligned' field, and then later the field name
and semantics were changed but the docs weren't updated to match.
Similarly, cpu_register_io_memory() does not exist anymore, so
clarify the documentation for .old_mmio.
Reported-by: Cao jin <caoj.fnst@cn.fujitsu.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
docs/memory.txt | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/docs/memory.txt b/docs/memory.txt
index d0aca05..97134e1 100644
--- a/docs/memory.txt
+++ b/docs/memory.txt
@@ -297,8 +297,9 @@ various constraints can be supplied to control how these callbacks are called:
- .valid.min_access_size, .valid.max_access_size define the access sizes
(in bytes) which the device accepts; accesses outside this range will
have device and bus specific behaviour (ignored, or machine check)
- - .valid.aligned specifies that the device only accepts naturally aligned
- accesses. Unaligned accesses invoke device and bus specific behaviour.
+ - .valid.unaligned specifies that the *device being modelled* supports
+ unaligned accesses; if false, unaligned accesses will invoke the
+ appropriate bus or CPU specific behaviour.
- .impl.min_access_size, .impl.max_access_size define the access sizes
(in bytes) supported by the *implementation*; other access sizes will be
emulated using the ones available. For example a 4-byte write will be
@@ -306,5 +307,5 @@ various constraints can be supplied to control how these callbacks are called:
- .impl.unaligned specifies that the *implementation* supports unaligned
accesses; if false, unaligned accesses will be emulated by two aligned
accesses.
- - .old_mmio can be used to ease porting from code using
+ - .old_mmio eases the porting of code that was formerly using
cpu_register_io_memory(). It should not be used in new code.
--
2.5.0
next prev parent reply other threads:[~2016-03-07 17:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 17:36 [Qemu-devel] [PULL 00/15] Memory changes and misc bug fixes for 2016-03-07 Paolo Bonzini
2016-03-07 17:36 ` [Qemu-devel] [PULL 01/15] log: do not log if QEMU is daemonized but without -D Paolo Bonzini
2016-03-07 17:36 ` [Qemu-devel] [PULL 02/15] i8257: fix Terminal Count status Paolo Bonzini
2016-03-07 17:36 ` [Qemu-devel] [PULL 03/15] exec: Return RAMBlock pointer from allocating functions Paolo Bonzini
2016-03-07 17:36 ` [Qemu-devel] [PULL 04/15] memory: Move assignment to ram_block to memory_region_init_* Paolo Bonzini
2016-03-07 17:36 ` [Qemu-devel] [PULL 05/15] memory: Implement memory_region_get_ram_addr with mr->ram_block Paolo Bonzini
2016-03-07 17:36 ` [Qemu-devel] [PULL 06/15] memory: Drop MemoryRegion.ram_addr Paolo Bonzini
2016-03-07 17:36 ` [Qemu-devel] [PULL 07/15] exec: Pass RAMBlock pointer to qemu_ram_free Paolo Bonzini
2016-03-07 17:36 ` [Qemu-devel] [PULL 08/15] exec: Factor out section_covers_addr Paolo Bonzini
2016-03-07 17:36 ` [Qemu-devel] [PULL 09/15] exec: Introduce AddressSpaceDispatch.mru_section Paolo Bonzini
2016-03-07 17:36 ` [Qemu-devel] [PULL 10/15] icount: possible options for sleep are on or off Paolo Bonzini
2016-03-07 17:36 ` [Qemu-devel] [PULL 11/15] doc/memory.txt: correct a logic error Paolo Bonzini
2016-03-07 17:36 ` Paolo Bonzini [this message]
2016-03-07 17:36 ` [Qemu-devel] [PULL 13/15] MAINTAINERS: Add entry for include/sysemu/kvm*.h Paolo Bonzini
2016-03-07 17:37 ` [Qemu-devel] [PULL 14/15] kvm/irqchip: use bitmap utility for gsi tracking Paolo Bonzini
2016-03-07 17:37 ` [Qemu-devel] [PULL 15/15] scsi-bus: Remove tape command from scsi_req_xfer Paolo Bonzini
2016-03-08 5:48 ` [Qemu-devel] [PULL 00/15] Memory changes and misc bug fixes for 2016-03-07 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457372221-19285-13-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).