From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acz5g-0003at-AS for qemu-devel@nongnu.org; Mon, 07 Mar 2016 12:37:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acz5e-0003GV-SN for qemu-devel@nongnu.org; Mon, 07 Mar 2016 12:37:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acz5e-0003GK-N6 for qemu-devel@nongnu.org; Mon, 07 Mar 2016 12:37:06 -0500 From: Paolo Bonzini Date: Mon, 7 Mar 2016 18:36:48 +0100 Message-Id: <1457372221-19285-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1457372221-19285-1-git-send-email-pbonzini@redhat.com> References: <1457372221-19285-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 02/15] i8257: fix Terminal Count status List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= From: Herv=C3=A9 Poussineau When a DMA transfer is done (ie all bytes have been transfered), the corr= esponding Terminal Count bit must be set in the status register. This bit is already cleared in i8257_read_cont and i8257_write_cont when = required. This fixes (at least) floppy transfer in IBM 40p firmware, which checks i= n DMA controller if everything went fine. Signed-off-by: Herv=C3=A9 Poussineau Message-Id: <1456404332-31556-1-git-send-email-hpoussin@reactos.org> Reviewed-by: John Snow Signed-off-by: Paolo Bonzini --- hw/dma/i8257.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c index 5a52707..6078893 100644 --- a/hw/dma/i8257.c +++ b/hw/dma/i8257.c @@ -342,6 +342,10 @@ static void i8257_channel_run(I8257State *d, int ich= an) r->now[COUNT], (r->base[COUNT] + 1) << ncon= t); r->now[COUNT] =3D n; ldebug ("dma_pos %d size %d\n", n, (r->base[COUNT] + 1) << ncont); + if (n =3D=3D (r->base[COUNT] + 1) << ncont) { + ldebug("transfer done\n"); + d->status |=3D (1 << ichan); + } } =20 static void i8257_dma_run(void *opaque) --=20 2.5.0