From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad0n6-00043B-Pz for qemu-devel@nongnu.org; Mon, 07 Mar 2016 14:26:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ad0n2-0003sp-Bc for qemu-devel@nongnu.org; Mon, 07 Mar 2016 14:26:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad0n2-0003sV-6i for qemu-devel@nongnu.org; Mon, 07 Mar 2016 14:26:00 -0500 From: Markus Armbruster Date: Mon, 7 Mar 2016 20:25:21 +0100 Message-Id: <1457378754-21649-10-git-send-email-armbru@redhat.com> In-Reply-To: <1457378754-21649-1-git-send-email-armbru@redhat.com> References: <1457378754-21649-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 09/42] ivshmem-test: Improve test case /ivshmem/single List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: claudio.fontana@huawei.com, cam@cs.ualberta.ca, mlureau@redhat.com, david.marchand@6wind.com, pbonzini@redhat.com Test state of registers after reset. Test reading Interrupt Status clears it. Test (invalid) read of Doorbell. Add more comments. Signed-off-by: Markus Armbruster Reviewed-by: Marc-Andr=C3=A9 Lureau --- tests/ivshmem-test.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c index da6ca0d..a48dc49 100644 --- a/tests/ivshmem-test.c +++ b/tests/ivshmem-test.c @@ -143,32 +143,41 @@ static void test_ivshmem_single(void) setup_vm(&state); s =3D &state; =20 - /* valid io */ - out_reg(s, INTRMASK, 0); - in_reg(s, INTRSTATUS); - in_reg(s, IVPOSITION); + /* initial state of readable registers */ + g_assert_cmpuint(in_reg(s, INTRMASK), =3D=3D, 0); + g_assert_cmpuint(in_reg(s, INTRSTATUS), =3D=3D, 0); + g_assert_cmpuint(in_reg(s, IVPOSITION), =3D=3D, 0); =20 + /* trigger interrupt via registers */ out_reg(s, INTRMASK, 0xffffffff); g_assert_cmpuint(in_reg(s, INTRMASK), =3D=3D, 0xffffffff); out_reg(s, INTRSTATUS, 1); - /* XXX: intercept IRQ, not seen in resp */ + /* check interrupt status */ g_assert_cmpuint(in_reg(s, INTRSTATUS), =3D=3D, 1); + /* reading clears */ + g_assert_cmpuint(in_reg(s, INTRSTATUS), =3D=3D, 0); + /* TODO intercept actual interrupt (needs qtest work) */ =20 - /* invalid io */ + /* invalid register access */ out_reg(s, IVPOSITION, 1); + in_reg(s, DOORBELL); + + /* ring the (non-functional) doorbell */ out_reg(s, DOORBELL, 8 << 16); =20 + /* write shared memory */ for (i =3D 0; i < G_N_ELEMENTS(data); i++) { data[i] =3D i; } qtest_memwrite(s->qtest, (uintptr_t)s->mem_base, data, sizeof(data))= ; =20 + /* verify write */ for (i =3D 0; i < G_N_ELEMENTS(data); i++) { g_assert_cmpuint(((uint32_t *)tmpshmem)[i], =3D=3D, i); } =20 + /* read it back and verify read */ memset(data, 0, sizeof(data)); - qtest_memread(s->qtest, (uintptr_t)s->mem_base, data, sizeof(data)); for (i =3D 0; i < G_N_ELEMENTS(data); i++) { g_assert_cmpuint(data[i], =3D=3D, i); --=20 2.4.3