* [Qemu-devel] [PATCH v2 01/42] exec: Fix memory allocation when memory path names new file
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 02/42] exec: Fix memory allocation when memory path isn't on hugetlbfs Markus Armbruster
` (42 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Commit 8d31d6b extended file_ram_alloc() to accept file names in
addition to directory names. Even though it passes O_CREAT to open(),
it actually works only for existing files. Reproducer adapted from
the commit's qemu-doc.texi update:
$ qemu-system-x86_64 -object memory-backend-file,size=2M,mem-path=/dev/hugepages/my-shmem-file,id=mb1
qemu-system-x86_64: -object memory-backend-file,size=2M,mem-path=/dev/hugepages/my-shmem-file,id=mb1: failed to get page size of file /dev/hugepages/my-shmem-file: No such file or directory
This is because we first get the page size for @path, then open the
actual file. Unwise even before the flawed commit, because the
directory could change in between, invalidating the page size.
Unlikely to bite in practice.
Rearrange the code to create the file (if necessary) before getting
its page size. Carefully avoid TOCTTOU conditions with a method
suggested by Paolo Bonzini.
While there, replace "hugepages" by "guest RAM" in error messages,
because host memory backends can be used for purposes other than huge
pages, e.g. /dev/shm/ shared memory. Help text of -mem-path agrees.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
exec.c | 115 ++++++++++++++++++++++++++++++++++++++---------------------------
1 file changed, 68 insertions(+), 47 deletions(-)
diff --git a/exec.c b/exec.c
index c62c439..5275ff4 100644
--- a/exec.c
+++ b/exec.c
@@ -1212,19 +1212,17 @@ void qemu_mutex_unlock_ramlist(void)
#define HUGETLBFS_MAGIC 0x958458f6
-static long gethugepagesize(const char *path, Error **errp)
+static long gethugepagesize(int fd)
{
struct statfs fs;
int ret;
do {
- ret = statfs(path, &fs);
+ ret = fstatfs(fd, &fs);
} while (ret != 0 && errno == EINTR);
if (ret != 0) {
- error_setg_errno(errp, errno, "failed to get page size of file %s",
- path);
- return 0;
+ return -1;
}
return fs.f_bsize;
@@ -1235,63 +1233,82 @@ static void *file_ram_alloc(RAMBlock *block,
const char *path,
Error **errp)
{
- struct stat st;
+ bool unlink_on_error = false;
char *filename;
char *sanitized_name;
char *c;
void *area;
int fd;
- uint64_t hpagesize;
- Error *local_err = NULL;
+ int64_t hpagesize;
- hpagesize = gethugepagesize(path, &local_err);
- if (local_err) {
- error_propagate(errp, local_err);
+ if (kvm_enabled() && !kvm_has_sync_mmu()) {
+ error_setg(errp,
+ "host lacks kvm mmu notifiers, -mem-path unsupported");
+ return NULL;
+ }
+
+ for (;;) {
+ fd = open(path, O_RDWR);
+ if (fd >= 0) {
+ /* @path names an existing file, use it */
+ break;
+ }
+ if (errno == ENOENT) {
+ /* @path names a file that doesn't exist, create it */
+ fd = open(path, O_RDWR | O_CREAT | O_EXCL, 0644);
+ if (fd >= 0) {
+ unlink_on_error = true;
+ break;
+ }
+ } else if (errno == EISDIR) {
+ /* @path names a directory, create a file there */
+ /* Make name safe to use with mkstemp by replacing '/' with '_'. */
+ sanitized_name = g_strdup(memory_region_name(block->mr));
+ for (c = sanitized_name; *c != '\0'; c++) {
+ if (*c == '/') {
+ *c = '_';
+ }
+ }
+
+ filename = g_strdup_printf("%s/qemu_back_mem.%s.XXXXXX", path,
+ sanitized_name);
+ g_free(sanitized_name);
+
+ fd = mkstemp(filename);
+ if (fd >= 0) {
+ unlink(filename);
+ g_free(filename);
+ break;
+ }
+ g_free(filename);
+ }
+ if (errno != EEXIST && errno != EINTR) {
+ error_setg_errno(errp, errno,
+ "can't open backing store %s for guest RAM",
+ path);
+ goto error;
+ }
+ /*
+ * Try again on EINTR and EEXIST. The latter happens when
+ * something else creates the file between our two open().
+ */
+ }
+
+ hpagesize = gethugepagesize(fd);
+ if (hpagesize < 0) {
+ error_setg_errno(errp, errno, "can't get page size for %s",
+ path);
goto error;
}
block->mr->align = hpagesize;
if (memory < hpagesize) {
error_setg(errp, "memory size 0x" RAM_ADDR_FMT " must be equal to "
- "or larger than huge page size 0x%" PRIx64,
+ "or larger than page size 0x%" PRIx64,
memory, hpagesize);
goto error;
}
- if (kvm_enabled() && !kvm_has_sync_mmu()) {
- error_setg(errp,
- "host lacks kvm mmu notifiers, -mem-path unsupported");
- goto error;
- }
-
- if (!stat(path, &st) && S_ISDIR(st.st_mode)) {
- /* Make name safe to use with mkstemp by replacing '/' with '_'. */
- sanitized_name = g_strdup(memory_region_name(block->mr));
- for (c = sanitized_name; *c != '\0'; c++) {
- if (*c == '/') {
- *c = '_';
- }
- }
-
- filename = g_strdup_printf("%s/qemu_back_mem.%s.XXXXXX", path,
- sanitized_name);
- g_free(sanitized_name);
-
- fd = mkstemp(filename);
- if (fd >= 0) {
- unlink(filename);
- }
- g_free(filename);
- } else {
- fd = open(path, O_RDWR | O_CREAT, 0644);
- }
-
- if (fd < 0) {
- error_setg_errno(errp, errno,
- "unable to create backing store for hugepages");
- goto error;
- }
-
memory = ROUND_UP(memory, hpagesize);
/*
@@ -1307,7 +1324,7 @@ static void *file_ram_alloc(RAMBlock *block,
area = qemu_ram_mmap(fd, memory, hpagesize, block->flags & RAM_SHARED);
if (area == MAP_FAILED) {
error_setg_errno(errp, errno,
- "unable to map backing store for hugepages");
+ "unable to map backing store for guest RAM");
close(fd);
goto error;
}
@@ -1320,6 +1337,10 @@ static void *file_ram_alloc(RAMBlock *block,
return area;
error:
+ if (unlink_on_error) {
+ unlink(path);
+ }
+ close(fd);
return NULL;
}
#endif
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 02/42] exec: Fix memory allocation when memory path isn't on hugetlbfs
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 01/42] exec: Fix memory allocation when memory path names new file Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-08 14:17 ` Paolo Bonzini
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 03/42] target-ppc: Document TOCTTOU in hugepage support Markus Armbruster
` (41 subsequent siblings)
43 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
gethugepagesize() works reliably only when its argument is on
hugetlbfs. When it's not, it returns the filesystem's "optimal
transfer block size", which may or may not be the actual page size
you'll get when you mmap().
If the value is too small or not a power of two, we fail
qemu_ram_mmap()'s assertions. These were added in commit 794e8f3
(v2.5.0). The bug's impact before that is currently unknown. Seems
fairly unlikely at least when the normal page size is 4KiB.
Else, if the value is too large, we align more strictly than
necessary.
gethugepagesize() goes back to commit c902760 (v0.13). That commit
clearly intended gethugepagesize() to be used on hugetlbfs only. Not
only was it named accordingly, it also printed a warning when used on
anything else. However, the commit neglected to spell out the
restriction in user documentation of -mem-path.
Commit bfc2a1a (v2.5.0) dropped the warning as bogus "because QEMU
functions perfectly well with the path on a regular tmpfs filesystem".
It sure does when you're sufficiently lucky. In my testing, I was
lucky, too.
Fix by switching to qemu_fd_getpagesize(). Rename the variable
holding its result from hpagesize to page_size.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
exec.c | 40 +++++++---------------------------------
1 file changed, 7 insertions(+), 33 deletions(-)
diff --git a/exec.c b/exec.c
index 5275ff4..d41194e 100644
--- a/exec.c
+++ b/exec.c
@@ -1207,27 +1207,6 @@ void qemu_mutex_unlock_ramlist(void)
}
#ifdef __linux__
-
-#include <sys/vfs.h>
-
-#define HUGETLBFS_MAGIC 0x958458f6
-
-static long gethugepagesize(int fd)
-{
- struct statfs fs;
- int ret;
-
- do {
- ret = fstatfs(fd, &fs);
- } while (ret != 0 && errno == EINTR);
-
- if (ret != 0) {
- return -1;
- }
-
- return fs.f_bsize;
-}
-
static void *file_ram_alloc(RAMBlock *block,
ram_addr_t memory,
const char *path,
@@ -1239,7 +1218,7 @@ static void *file_ram_alloc(RAMBlock *block,
char *c;
void *area;
int fd;
- int64_t hpagesize;
+ int64_t page_size;
if (kvm_enabled() && !kvm_has_sync_mmu()) {
error_setg(errp,
@@ -1294,22 +1273,17 @@ static void *file_ram_alloc(RAMBlock *block,
*/
}
- hpagesize = gethugepagesize(fd);
- if (hpagesize < 0) {
- error_setg_errno(errp, errno, "can't get page size for %s",
- path);
- goto error;
- }
- block->mr->align = hpagesize;
+ page_size = qemu_fd_getpagesize(fd);
+ block->mr->align = page_size;
- if (memory < hpagesize) {
+ if (memory < page_size) {
error_setg(errp, "memory size 0x" RAM_ADDR_FMT " must be equal to "
"or larger than page size 0x%" PRIx64,
- memory, hpagesize);
+ memory, page_size);
goto error;
}
- memory = ROUND_UP(memory, hpagesize);
+ memory = ROUND_UP(memory, page_size);
/*
* ftruncate is not supported by hugetlbfs in older
@@ -1321,7 +1295,7 @@ static void *file_ram_alloc(RAMBlock *block,
perror("ftruncate");
}
- area = qemu_ram_mmap(fd, memory, hpagesize, block->flags & RAM_SHARED);
+ area = qemu_ram_mmap(fd, memory, page_size, block->flags & RAM_SHARED);
if (area == MAP_FAILED) {
error_setg_errno(errp, errno,
"unable to map backing store for guest RAM");
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 02/42] exec: Fix memory allocation when memory path isn't on hugetlbfs
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 02/42] exec: Fix memory allocation when memory path isn't on hugetlbfs Markus Armbruster
@ 2016-03-08 14:17 ` Paolo Bonzini
2016-03-15 16:41 ` Markus Armbruster
0 siblings, 1 reply; 74+ messages in thread
From: Paolo Bonzini @ 2016-03-08 14:17 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel
Cc: claudio.fontana, cam, mlureau, david.marchand
On 07/03/2016 20:25, Markus Armbruster wrote:
> gethugepagesize() works reliably only when its argument is on
> hugetlbfs. When it's not, it returns the filesystem's "optimal
> transfer block size", which may or may not be the actual page size
> you'll get when you mmap().
>
> If the value is too small or not a power of two, we fail
> qemu_ram_mmap()'s assertions. These were added in commit 794e8f3
> (v2.5.0). The bug's impact before that is currently unknown. Seems
> fairly unlikely at least when the normal page size is 4KiB.
>
> Else, if the value is too large, we align more strictly than
> necessary.
>
> gethugepagesize() goes back to commit c902760 (v0.13). That commit
> clearly intended gethugepagesize() to be used on hugetlbfs only. Not
> only was it named accordingly, it also printed a warning when used on
> anything else. However, the commit neglected to spell out the
> restriction in user documentation of -mem-path.
>
> Commit bfc2a1a (v2.5.0) dropped the warning as bogus "because QEMU
> functions perfectly well with the path on a regular tmpfs filesystem".
> It sure does when you're sufficiently lucky. In my testing, I was
> lucky, too.
>
> Fix by switching to qemu_fd_getpagesize(). Rename the variable
> holding its result from hpagesize to page_size.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> exec.c | 40 +++++++---------------------------------
> 1 file changed, 7 insertions(+), 33 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 5275ff4..d41194e 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1207,27 +1207,6 @@ void qemu_mutex_unlock_ramlist(void)
> }
>
> #ifdef __linux__
> -
> -#include <sys/vfs.h>
> -
> -#define HUGETLBFS_MAGIC 0x958458f6
> -
> -static long gethugepagesize(int fd)
> -{
> - struct statfs fs;
> - int ret;
> -
> - do {
> - ret = fstatfs(fd, &fs);
> - } while (ret != 0 && errno == EINTR);
> -
> - if (ret != 0) {
> - return -1;
> - }
> -
> - return fs.f_bsize;
> -}
> -
> static void *file_ram_alloc(RAMBlock *block,
> ram_addr_t memory,
> const char *path,
> @@ -1239,7 +1218,7 @@ static void *file_ram_alloc(RAMBlock *block,
> char *c;
> void *area;
> int fd;
> - int64_t hpagesize;
> + int64_t page_size;
>
> if (kvm_enabled() && !kvm_has_sync_mmu()) {
> error_setg(errp,
> @@ -1294,22 +1273,17 @@ static void *file_ram_alloc(RAMBlock *block,
> */
> }
>
> - hpagesize = gethugepagesize(fd);
> - if (hpagesize < 0) {
> - error_setg_errno(errp, errno, "can't get page size for %s",
> - path);
> - goto error;
> - }
> - block->mr->align = hpagesize;
> + page_size = qemu_fd_getpagesize(fd);
> + block->mr->align = page_size;
>
> - if (memory < hpagesize) {
> + if (memory < page_size) {
> error_setg(errp, "memory size 0x" RAM_ADDR_FMT " must be equal to "
> "or larger than page size 0x%" PRIx64,
> - memory, hpagesize);
> + memory, page_size);
> goto error;
> }
>
> - memory = ROUND_UP(memory, hpagesize);
> + memory = ROUND_UP(memory, page_size);
>
> /*
> * ftruncate is not supported by hugetlbfs in older
> @@ -1321,7 +1295,7 @@ static void *file_ram_alloc(RAMBlock *block,
> perror("ftruncate");
> }
>
> - area = qemu_ram_mmap(fd, memory, hpagesize, block->flags & RAM_SHARED);
> + area = qemu_ram_mmap(fd, memory, page_size, block->flags & RAM_SHARED);
> if (area == MAP_FAILED) {
> error_setg_errno(errp, errno,
> "unable to map backing store for guest RAM");
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 02/42] exec: Fix memory allocation when memory path isn't on hugetlbfs
2016-03-08 14:17 ` Paolo Bonzini
@ 2016-03-15 16:41 ` Markus Armbruster
2016-03-15 16:56 ` Paolo Bonzini
0 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-15 16:41 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: mlureau, cam, claudio.fontana, qemu-devel, david.marchand
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 07/03/2016 20:25, Markus Armbruster wrote:
>> gethugepagesize() works reliably only when its argument is on
>> hugetlbfs. When it's not, it returns the filesystem's "optimal
>> transfer block size", which may or may not be the actual page size
>> you'll get when you mmap().
>>
>> If the value is too small or not a power of two, we fail
>> qemu_ram_mmap()'s assertions. These were added in commit 794e8f3
>> (v2.5.0). The bug's impact before that is currently unknown. Seems
>> fairly unlikely at least when the normal page size is 4KiB.
>>
>> Else, if the value is too large, we align more strictly than
>> necessary.
>>
>> gethugepagesize() goes back to commit c902760 (v0.13). That commit
>> clearly intended gethugepagesize() to be used on hugetlbfs only. Not
>> only was it named accordingly, it also printed a warning when used on
>> anything else. However, the commit neglected to spell out the
>> restriction in user documentation of -mem-path.
>>
>> Commit bfc2a1a (v2.5.0) dropped the warning as bogus "because QEMU
>> functions perfectly well with the path on a regular tmpfs filesystem".
>> It sure does when you're sufficiently lucky. In my testing, I was
>> lucky, too.
>>
>> Fix by switching to qemu_fd_getpagesize(). Rename the variable
>> holding its result from hpagesize to page_size.
>>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
[...]
>
> Queued, thanks.
Not in master, yet. What repo+branch should I use as base for v3?
^ permalink raw reply [flat|nested] 74+ messages in thread
* Re: [Qemu-devel] [PATCH v2 02/42] exec: Fix memory allocation when memory path isn't on hugetlbfs
2016-03-15 16:41 ` Markus Armbruster
@ 2016-03-15 16:56 ` Paolo Bonzini
0 siblings, 0 replies; 74+ messages in thread
From: Paolo Bonzini @ 2016-03-15 16:56 UTC (permalink / raw)
To: Markus Armbruster
Cc: mlureau, cam, claudio.fontana, qemu-devel, david.marchand
On 15/03/2016 17:41, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> On 07/03/2016 20:25, Markus Armbruster wrote:
>>> gethugepagesize() works reliably only when its argument is on
>>> hugetlbfs. When it's not, it returns the filesystem's "optimal
>>> transfer block size", which may or may not be the actual page size
>>> you'll get when you mmap().
>>>
>>> If the value is too small or not a power of two, we fail
>>> qemu_ram_mmap()'s assertions. These were added in commit 794e8f3
>>> (v2.5.0). The bug's impact before that is currently unknown. Seems
>>> fairly unlikely at least when the normal page size is 4KiB.
>>>
>>> Else, if the value is too large, we align more strictly than
>>> necessary.
>>>
>>> gethugepagesize() goes back to commit c902760 (v0.13). That commit
>>> clearly intended gethugepagesize() to be used on hugetlbfs only. Not
>>> only was it named accordingly, it also printed a warning when used on
>>> anything else. However, the commit neglected to spell out the
>>> restriction in user documentation of -mem-path.
>>>
>>> Commit bfc2a1a (v2.5.0) dropped the warning as bogus "because QEMU
>>> functions perfectly well with the path on a regular tmpfs filesystem".
>>> It sure does when you're sufficiently lucky. In my testing, I was
>>> lucky, too.
>>>
>>> Fix by switching to qemu_fd_getpagesize(). Rename the variable
>>> holding its result from hpagesize to page_size.
>>>
>>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> [...]
>>
>> Queued, thanks.
>
> Not in master, yet. What repo+branch should I use as base for v3?
I'll send a pull request later today, keep an eye on it.
Paolo
^ permalink raw reply [flat|nested] 74+ messages in thread
* [Qemu-devel] [PATCH v2 03/42] target-ppc: Document TOCTTOU in hugepage support
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 01/42] exec: Fix memory allocation when memory path names new file Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 02/42] exec: Fix memory allocation when memory path isn't on hugetlbfs Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-09 12:44 ` Marc-André Lureau
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 04/42] ivshmem-server: Fix and clean up command line help Markus Armbruster
` (40 subsequent siblings)
43 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel
Cc: claudio.fontana, Michael Roth, david.marchand, mlureau, pbonzini,
cam
The code to find the minimum page size is is vulnerable to TOCTTOU.
Added in commit 2d103aa "target-ppc: fix hugepage support when using
memory-backend-file" (v2.4.0). Since I can't fix it myself right now,
add a FIXME comment.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
target-ppc/kvm.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index d67c169..0ef6ecd 100644
--- a/target-ppc/kvm.c
+++ b/target-ppc/kvm.c
@@ -333,6 +333,12 @@ static long gethugepagesize(const char *mem_path)
return fs.f_bsize;
}
+/*
+ * FIXME TOCTTOU: this iterates over memory backends' mem-path, which
+ * may or may not name the same files / on the same filesystem now as
+ * when we actually open and map them. Iterate over the file
+ * descriptors instead, and use qemu_fd_getpagesize().
+ */
static int find_max_supported_pagesize(Object *obj, void *opaque)
{
char *mem_path;
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 03/42] target-ppc: Document TOCTTOU in hugepage support
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 03/42] target-ppc: Document TOCTTOU in hugepage support Markus Armbruster
@ 2016-03-09 12:44 ` Marc-André Lureau
2016-03-09 20:05 ` Markus Armbruster
0 siblings, 1 reply; 74+ messages in thread
From: Marc-André Lureau @ 2016-03-09 12:44 UTC (permalink / raw)
To: Markus Armbruster
Cc: Michael Roth, Claudio Fontana, QEMU, David Marchand,
Paolo Bonzini, cam
Hi
On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
> +/*
nitpick, extra space here
> + * FIXME TOCTTOU: this iterates over memory backends' mem-path, which
> + * may or may not name the same files / on the same filesystem now as
> + * when we actually open and map them. Iterate over the file
> + * descriptors instead, and use qemu_fd_getpagesize().
> + */
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 74+ messages in thread
* Re: [Qemu-devel] [PATCH v2 03/42] target-ppc: Document TOCTTOU in hugepage support
2016-03-09 12:44 ` Marc-André Lureau
@ 2016-03-09 20:05 ` Markus Armbruster
0 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-09 20:05 UTC (permalink / raw)
To: Marc-André Lureau
Cc: QEMU, Claudio Fontana, Michael Roth, David Marchand,
Paolo Bonzini, cam
Marc-André Lureau <marcandre.lureau@gmail.com> writes:
> Hi
>
> On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
>> +/*
>
> nitpick, extra space here
Will fix, thanks!
>> + * FIXME TOCTTOU: this iterates over memory backends' mem-path, which
>> + * may or may not name the same files / on the same filesystem now as
>> + * when we actually open and map them. Iterate over the file
>> + * descriptors instead, and use qemu_fd_getpagesize().
>> + */
^ permalink raw reply [flat|nested] 74+ messages in thread
* [Qemu-devel] [PATCH v2 04/42] ivshmem-server: Fix and clean up command line help
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (2 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 03/42] target-ppc: Document TOCTTOU in hugepage support Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-09 12:44 ` Marc-André Lureau
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 05/42] ivshmem-server: Don't overload POSIX shmem and file name Markus Armbruster
` (39 subsequent siblings)
43 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Burying error messages in ~20 lines of usage help is bad form. Print
a single line pointing to -h instead.
Print -h help to stdout rather than stderr. Fix default of -p. Clean
up the help text a bit.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
contrib/ivshmem-server/main.c | 63 ++++++++++++++++++++++++-------------------
1 file changed, 35 insertions(+), 28 deletions(-)
diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c
index cca1061..e9b4388 100644
--- a/contrib/ivshmem-server/main.c
+++ b/contrib/ivshmem-server/main.c
@@ -33,31 +33,32 @@ typedef struct IvshmemServerArgs {
unsigned n_vectors;
} IvshmemServerArgs;
-/* show ivshmem_server_usage and exit with given error code */
static void
-ivshmem_server_usage(const char *name, int code)
+ivshmem_server_usage(const char *progname)
{
- fprintf(stderr, "%s [opts]\n", name);
- fprintf(stderr, " -h: show this help\n");
- fprintf(stderr, " -v: verbose mode\n");
- fprintf(stderr, " -F: foreground mode (default is to daemonize)\n");
- fprintf(stderr, " -p <pid_file>: path to the PID file (used in daemon\n"
- " mode only).\n"
- " Default=%s\n", IVSHMEM_SERVER_DEFAULT_SHM_PATH);
- fprintf(stderr, " -S <unix_socket_path>: path to the unix socket\n"
- " to listen to.\n"
- " Default=%s\n", IVSHMEM_SERVER_DEFAULT_UNIX_SOCK_PATH);
- fprintf(stderr, " -m <shm_path>: path to the shared memory.\n"
- " The path corresponds to a POSIX shm name or a\n"
- " hugetlbfs mount point.\n"
- " default=%s\n", IVSHMEM_SERVER_DEFAULT_SHM_PATH);
- fprintf(stderr, " -l <size>: size of shared memory in bytes. The suffix\n"
- " K, M and G can be used (ex: 1K means 1024).\n"
- " default=%u\n", IVSHMEM_SERVER_DEFAULT_SHM_SIZE);
- fprintf(stderr, " -n <n_vects>: number of vectors.\n"
- " default=%u\n", IVSHMEM_SERVER_DEFAULT_N_VECTORS);
+ printf("Usage: %s [OPTION]...\n"
+ " -h: show this help\n"
+ " -v: verbose mode\n"
+ " -F: foreground mode (default is to daemonize)\n"
+ " -p <pid_file>: path to the PID file (used in daemon mode only)\n"
+ " default " IVSHMEM_SERVER_DEFAULT_PID_FILE "\n"
+ " -S <unix_socket_path>: path to the unix socket to listen to\n"
+ " default " IVSHMEM_SERVER_DEFAULT_UNIX_SOCK_PATH "\n"
+ " -m <shm_path>: POSIX shared memory object name or a hugetlbfs mount point\n"
+ " default " IVSHMEM_SERVER_DEFAULT_SHM_PATH "\n"
+ " -l <size>: size of shared memory in bytes\n"
+ " suffixes K, M and G can be used, e.g. 1K means 1024\n"
+ " default %u\n"
+ " -n <n_vectors>: number of vectors\n"
+ " default %u\n",
+ progname, IVSHMEM_SERVER_DEFAULT_SHM_SIZE,
+ IVSHMEM_SERVER_DEFAULT_N_VECTORS);
+}
- exit(code);
+static void
+ivshmem_server_help(const char *progname)
+{
+ fprintf(stderr, "Try '%s -h' for more information.\n", progname);
}
/* parse the program arguments, exit on error */
@@ -81,7 +82,8 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
switch (c) {
case 'h': /* help */
- ivshmem_server_usage(argv[0], 0);
+ ivshmem_server_usage(argv[0]);
+ exit(0);
break;
case 'v': /* verbose */
@@ -108,20 +110,23 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
parse_option_size("shm_size", optarg, &args->shm_size, &err);
if (err) {
error_report_err(err);
- ivshmem_server_usage(argv[0], 1);
+ ivshmem_server_help(argv[0]);
+ exit(1);
}
break;
case 'n': /* n_vectors */
if (parse_uint_full(optarg, &v, 0) < 0) {
fprintf(stderr, "cannot parse n_vectors\n");
- ivshmem_server_usage(argv[0], 1);
+ ivshmem_server_help(argv[0]);
+ exit(1);
}
args->n_vectors = v;
break;
default:
- ivshmem_server_usage(argv[0], 1);
+ ivshmem_server_usage(argv[0]);
+ exit(1);
break;
}
}
@@ -129,12 +134,14 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
if (args->n_vectors > IVSHMEM_SERVER_MAX_VECTORS) {
fprintf(stderr, "too many requested vectors (max is %d)\n",
IVSHMEM_SERVER_MAX_VECTORS);
- ivshmem_server_usage(argv[0], 1);
+ ivshmem_server_help(argv[0]);
+ exit(1);
}
if (args->verbose == 1 && args->foreground == 0) {
fprintf(stderr, "cannot use verbose in daemon mode\n");
- ivshmem_server_usage(argv[0], 1);
+ ivshmem_server_help(argv[0]);
+ exit(1);
}
}
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 04/42] ivshmem-server: Fix and clean up command line help
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 04/42] ivshmem-server: Fix and clean up command line help Markus Armbruster
@ 2016-03-09 12:44 ` Marc-André Lureau
0 siblings, 0 replies; 74+ messages in thread
From: Marc-André Lureau @ 2016-03-09 12:44 UTC (permalink / raw)
To: Markus Armbruster
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
> Burying error messages in ~20 lines of usage help is bad form. Print
> a single line pointing to -h instead.
>
> Print -h help to stdout rather than stderr. Fix default of -p. Clean
> up the help text a bit.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> contrib/ivshmem-server/main.c | 63 ++++++++++++++++++++++++-------------------
> 1 file changed, 35 insertions(+), 28 deletions(-)
>
> diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c
> index cca1061..e9b4388 100644
> --- a/contrib/ivshmem-server/main.c
> +++ b/contrib/ivshmem-server/main.c
> @@ -33,31 +33,32 @@ typedef struct IvshmemServerArgs {
> unsigned n_vectors;
> } IvshmemServerArgs;
>
> -/* show ivshmem_server_usage and exit with given error code */
> static void
> -ivshmem_server_usage(const char *name, int code)
> +ivshmem_server_usage(const char *progname)
> {
> - fprintf(stderr, "%s [opts]\n", name);
> - fprintf(stderr, " -h: show this help\n");
> - fprintf(stderr, " -v: verbose mode\n");
> - fprintf(stderr, " -F: foreground mode (default is to daemonize)\n");
> - fprintf(stderr, " -p <pid_file>: path to the PID file (used in daemon\n"
> - " mode only).\n"
> - " Default=%s\n", IVSHMEM_SERVER_DEFAULT_SHM_PATH);
> - fprintf(stderr, " -S <unix_socket_path>: path to the unix socket\n"
> - " to listen to.\n"
> - " Default=%s\n", IVSHMEM_SERVER_DEFAULT_UNIX_SOCK_PATH);
> - fprintf(stderr, " -m <shm_path>: path to the shared memory.\n"
> - " The path corresponds to a POSIX shm name or a\n"
> - " hugetlbfs mount point.\n"
> - " default=%s\n", IVSHMEM_SERVER_DEFAULT_SHM_PATH);
> - fprintf(stderr, " -l <size>: size of shared memory in bytes. The suffix\n"
> - " K, M and G can be used (ex: 1K means 1024).\n"
> - " default=%u\n", IVSHMEM_SERVER_DEFAULT_SHM_SIZE);
> - fprintf(stderr, " -n <n_vects>: number of vectors.\n"
> - " default=%u\n", IVSHMEM_SERVER_DEFAULT_N_VECTORS);
> + printf("Usage: %s [OPTION]...\n"
> + " -h: show this help\n"
> + " -v: verbose mode\n"
> + " -F: foreground mode (default is to daemonize)\n"
> + " -p <pid_file>: path to the PID file (used in daemon mode only)\n"
> + " default " IVSHMEM_SERVER_DEFAULT_PID_FILE "\n"
> + " -S <unix_socket_path>: path to the unix socket to listen to\n"
> + " default " IVSHMEM_SERVER_DEFAULT_UNIX_SOCK_PATH "\n"
> + " -m <shm_path>: POSIX shared memory object name or a hugetlbfs mount point\n"
> + " default " IVSHMEM_SERVER_DEFAULT_SHM_PATH "\n"
> + " -l <size>: size of shared memory in bytes\n"
> + " suffixes K, M and G can be used, e.g. 1K means 1024\n"
> + " default %u\n"
> + " -n <n_vectors>: number of vectors\n"
> + " default %u\n",
> + progname, IVSHMEM_SERVER_DEFAULT_SHM_SIZE,
> + IVSHMEM_SERVER_DEFAULT_N_VECTORS);
> +}
>
> - exit(code);
> +static void
> +ivshmem_server_help(const char *progname)
> +{
> + fprintf(stderr, "Try '%s -h' for more information.\n", progname);
> }
>
> /* parse the program arguments, exit on error */
> @@ -81,7 +82,8 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
>
> switch (c) {
> case 'h': /* help */
> - ivshmem_server_usage(argv[0], 0);
> + ivshmem_server_usage(argv[0]);
> + exit(0);
> break;
>
> case 'v': /* verbose */
> @@ -108,20 +110,23 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
> parse_option_size("shm_size", optarg, &args->shm_size, &err);
> if (err) {
> error_report_err(err);
> - ivshmem_server_usage(argv[0], 1);
> + ivshmem_server_help(argv[0]);
> + exit(1);
> }
> break;
>
> case 'n': /* n_vectors */
> if (parse_uint_full(optarg, &v, 0) < 0) {
> fprintf(stderr, "cannot parse n_vectors\n");
> - ivshmem_server_usage(argv[0], 1);
> + ivshmem_server_help(argv[0]);
> + exit(1);
> }
> args->n_vectors = v;
> break;
>
> default:
> - ivshmem_server_usage(argv[0], 1);
> + ivshmem_server_usage(argv[0]);
> + exit(1);
> break;
> }
> }
> @@ -129,12 +134,14 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
> if (args->n_vectors > IVSHMEM_SERVER_MAX_VECTORS) {
> fprintf(stderr, "too many requested vectors (max is %d)\n",
> IVSHMEM_SERVER_MAX_VECTORS);
> - ivshmem_server_usage(argv[0], 1);
> + ivshmem_server_help(argv[0]);
> + exit(1);
> }
>
> if (args->verbose == 1 && args->foreground == 0) {
> fprintf(stderr, "cannot use verbose in daemon mode\n");
> - ivshmem_server_usage(argv[0], 1);
> + ivshmem_server_help(argv[0]);
> + exit(1);
> }
> }
>
> --
> 2.4.3
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 74+ messages in thread
* [Qemu-devel] [PATCH v2 05/42] ivshmem-server: Don't overload POSIX shmem and file name
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (3 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 04/42] ivshmem-server: Fix and clean up command line help Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-09 12:44 ` Marc-André Lureau
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 06/42] qemu-doc: Fix ivshmem huge page example Markus Armbruster
` (38 subsequent siblings)
43 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Option -m NAME is interpreted as directory name if we can statfs() it
and its on hugetlbfs. Else it's interpreted as POSIX shared memory
object name. This is nuts.
Always interpret -m as directory. Create new -M for POSIX shared
memory. Last of -m or -M wins.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
contrib/ivshmem-server/ivshmem-server.c | 56 ++++++---------------------------
contrib/ivshmem-server/ivshmem-server.h | 4 ++-
contrib/ivshmem-server/main.c | 15 +++++++--
tests/ivshmem-test.c | 2 +-
4 files changed, 27 insertions(+), 50 deletions(-)
diff --git a/contrib/ivshmem-server/ivshmem-server.c b/contrib/ivshmem-server/ivshmem-server.c
index bfd0fad..41aee35 100644
--- a/contrib/ivshmem-server/ivshmem-server.c
+++ b/contrib/ivshmem-server/ivshmem-server.c
@@ -12,9 +12,6 @@
#include <sys/mman.h>
#include <sys/socket.h>
#include <sys/un.h>
-#ifdef CONFIG_LINUX
-#include <sys/vfs.h>
-#endif
#include "ivshmem-server.h"
@@ -257,7 +254,8 @@ ivshmem_server_ftruncate(int fd, unsigned shmsize)
/* Init a new ivshmem server */
int
ivshmem_server_init(IvshmemServer *server, const char *unix_sock_path,
- const char *shm_path, size_t shm_size, unsigned n_vectors,
+ const char *shm_path, bool use_shm_open,
+ size_t shm_size, unsigned n_vectors,
bool verbose)
{
int ret;
@@ -278,6 +276,7 @@ ivshmem_server_init(IvshmemServer *server, const char *unix_sock_path,
return -1;
}
+ server->use_shm_open = use_shm_open;
server->shm_size = shm_size;
server->n_vectors = n_vectors;
@@ -286,31 +285,6 @@ ivshmem_server_init(IvshmemServer *server, const char *unix_sock_path,
return 0;
}
-#ifdef CONFIG_LINUX
-
-#define HUGETLBFS_MAGIC 0x958458f6
-
-static long gethugepagesize(const char *path)
-{
- struct statfs fs;
- int ret;
-
- do {
- ret = statfs(path, &fs);
- } while (ret != 0 && errno == EINTR);
-
- if (ret != 0) {
- return -1;
- }
-
- if (fs.f_type != HUGETLBFS_MAGIC) {
- return -1;
- }
-
- return fs.f_bsize;
-}
-#endif
-
/* open shm, create and bind to the unix socket */
int
ivshmem_server_start(IvshmemServer *server)
@@ -319,27 +293,17 @@ ivshmem_server_start(IvshmemServer *server)
int shm_fd, sock_fd, ret;
/* open shm file */
-#ifdef CONFIG_LINUX
- long hpagesize;
-
- hpagesize = gethugepagesize(server->shm_path);
- if (hpagesize < 0 && errno != ENOENT) {
- IVSHMEM_SERVER_DEBUG(server, "cannot stat shm file %s: %s\n",
- server->shm_path, strerror(errno));
- }
-
- if (hpagesize > 0) {
+ if (server->use_shm_open) {
+ IVSHMEM_SERVER_DEBUG(server, "Using POSIX shared memory: %s\n",
+ server->shm_path);
+ shm_fd = shm_open(server->shm_path, O_CREAT|O_RDWR, S_IRWXU);
+ } else {
gchar *filename = g_strdup_printf("%s/ivshmem.XXXXXX", server->shm_path);
- IVSHMEM_SERVER_DEBUG(server, "Using hugepages: %s\n", server->shm_path);
+ IVSHMEM_SERVER_DEBUG(server, "Using file-backed shared memory: %s\n",
+ server->shm_path);
shm_fd = mkstemp(filename);
unlink(filename);
g_free(filename);
- } else
-#endif
- {
- IVSHMEM_SERVER_DEBUG(server, "Using POSIX shared memory: %s\n",
- server->shm_path);
- shm_fd = shm_open(server->shm_path, O_CREAT|O_RDWR, S_IRWXU);
}
if (shm_fd < 0) {
diff --git a/contrib/ivshmem-server/ivshmem-server.h b/contrib/ivshmem-server/ivshmem-server.h
index e9de8a3..3851639 100644
--- a/contrib/ivshmem-server/ivshmem-server.h
+++ b/contrib/ivshmem-server/ivshmem-server.h
@@ -66,6 +66,7 @@ typedef struct IvshmemServer {
char unix_sock_path[PATH_MAX]; /**< path to unix socket */
int sock_fd; /**< unix sock file descriptor */
char shm_path[PATH_MAX]; /**< path to shm */
+ bool use_shm_open;
size_t shm_size; /**< size of shm */
int shm_fd; /**< shm file descriptor */
unsigned n_vectors; /**< number of vectors */
@@ -89,7 +90,8 @@ typedef struct IvshmemServer {
*/
int
ivshmem_server_init(IvshmemServer *server, const char *unix_sock_path,
- const char *shm_path, size_t shm_size, unsigned n_vectors,
+ const char *shm_path, bool use_shm_open,
+ size_t shm_size, unsigned n_vectors,
bool verbose);
/**
diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c
index e9b4388..2795db5 100644
--- a/contrib/ivshmem-server/main.c
+++ b/contrib/ivshmem-server/main.c
@@ -29,6 +29,7 @@ typedef struct IvshmemServerArgs {
const char *pid_file;
const char *unix_socket_path;
const char *shm_path;
+ bool use_shm_open;
uint64_t shm_size;
unsigned n_vectors;
} IvshmemServerArgs;
@@ -44,8 +45,9 @@ ivshmem_server_usage(const char *progname)
" default " IVSHMEM_SERVER_DEFAULT_PID_FILE "\n"
" -S <unix_socket_path>: path to the unix socket to listen to\n"
" default " IVSHMEM_SERVER_DEFAULT_UNIX_SOCK_PATH "\n"
- " -m <shm_path>: POSIX shared memory object name or a hugetlbfs mount point\n"
+ " -M <name>: POSIX shared memory object to use\n"
" default " IVSHMEM_SERVER_DEFAULT_SHM_PATH "\n"
+ " -m <dirname>: where to create shared memory\n"
" -l <size>: size of shared memory in bytes\n"
" suffixes K, M and G can be used, e.g. 1K means 1024\n"
" default %u\n"
@@ -76,6 +78,7 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
"p:" /* pid_file */
"S:" /* unix_socket_path */
"m:" /* shm_path */
+ "M:" /* shm_path */
"l:" /* shm_size */
"n:" /* n_vectors */
)) != -1) {
@@ -102,8 +105,14 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
args->unix_socket_path = optarg;
break;
+ case 'M': /* shm_path */
+ args->shm_path = optarg;
+ args->use_shm_open = true;
+ break;
+
case 'm': /* shm_path */
args->shm_path = optarg;
+ args->use_shm_open = false;
break;
case 'l': /* shm_size */
@@ -199,6 +208,7 @@ main(int argc, char *argv[])
.pid_file = IVSHMEM_SERVER_DEFAULT_PID_FILE,
.unix_socket_path = IVSHMEM_SERVER_DEFAULT_UNIX_SOCK_PATH,
.shm_path = IVSHMEM_SERVER_DEFAULT_SHM_PATH,
+ .use_shm_open = true,
.shm_size = IVSHMEM_SERVER_DEFAULT_SHM_SIZE,
.n_vectors = IVSHMEM_SERVER_DEFAULT_N_VECTORS,
};
@@ -226,7 +236,8 @@ main(int argc, char *argv[])
}
/* init the ivshms structure */
- if (ivshmem_server_init(&server, args.unix_socket_path, args.shm_path,
+ if (ivshmem_server_init(&server, args.unix_socket_path,
+ args.shm_path, args.use_shm_open,
args.shm_size, args.n_vectors, args.verbose) < 0) {
fprintf(stderr, "cannot init server\n");
goto err;
diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c
index e184c67..4efa433 100644
--- a/tests/ivshmem-test.c
+++ b/tests/ivshmem-test.c
@@ -294,7 +294,7 @@ static void test_ivshmem_server(bool msi)
guint64 end_time = g_get_monotonic_time() + 5 * G_TIME_SPAN_SECOND;
memset(tmpshmem, 0x42, TMPSHMSIZE);
- ret = ivshmem_server_init(&server, tmpserver, tmpshm,
+ ret = ivshmem_server_init(&server, tmpserver, tmpshm, true,
TMPSHMSIZE, nvectors,
g_test_verbose());
g_assert_cmpint(ret, ==, 0);
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 05/42] ivshmem-server: Don't overload POSIX shmem and file name
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 05/42] ivshmem-server: Don't overload POSIX shmem and file name Markus Armbruster
@ 2016-03-09 12:44 ` Marc-André Lureau
2016-03-09 20:14 ` Markus Armbruster
0 siblings, 1 reply; 74+ messages in thread
From: Marc-André Lureau @ 2016-03-09 12:44 UTC (permalink / raw)
To: Markus Armbruster
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
[-- Attachment #1: Type: text/plain, Size: 9063 bytes --]
Hi
On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
> Option -m NAME is interpreted as directory name if we can statfs() it
> and its on hugetlbfs. Else it's interpreted as POSIX shared memory
> object name. This is nuts.
>
> Always interpret -m as directory. Create new -M for POSIX shared
> memory. Last of -m or -M wins.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
I don't see why the last should win is a good idea, see attached patch
for a possible solution, also changing a few comments. Feel free to
squash it in this patch or include it in your series.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> contrib/ivshmem-server/ivshmem-server.c | 56 ++++++---------------------------
> contrib/ivshmem-server/ivshmem-server.h | 4 ++-
> contrib/ivshmem-server/main.c | 15 +++++++--
> tests/ivshmem-test.c | 2 +-
> 4 files changed, 27 insertions(+), 50 deletions(-)
>
> diff --git a/contrib/ivshmem-server/ivshmem-server.c b/contrib/ivshmem-server/ivshmem-server.c
> index bfd0fad..41aee35 100644
> --- a/contrib/ivshmem-server/ivshmem-server.c
> +++ b/contrib/ivshmem-server/ivshmem-server.c
> @@ -12,9 +12,6 @@
> #include <sys/mman.h>
> #include <sys/socket.h>
> #include <sys/un.h>
> -#ifdef CONFIG_LINUX
> -#include <sys/vfs.h>
> -#endif
>
> #include "ivshmem-server.h"
>
> @@ -257,7 +254,8 @@ ivshmem_server_ftruncate(int fd, unsigned shmsize)
> /* Init a new ivshmem server */
> int
> ivshmem_server_init(IvshmemServer *server, const char *unix_sock_path,
> - const char *shm_path, size_t shm_size, unsigned n_vectors,
> + const char *shm_path, bool use_shm_open,
> + size_t shm_size, unsigned n_vectors,
> bool verbose)
> {
> int ret;
> @@ -278,6 +276,7 @@ ivshmem_server_init(IvshmemServer *server, const char *unix_sock_path,
> return -1;
> }
>
> + server->use_shm_open = use_shm_open;
> server->shm_size = shm_size;
> server->n_vectors = n_vectors;
>
> @@ -286,31 +285,6 @@ ivshmem_server_init(IvshmemServer *server, const char *unix_sock_path,
> return 0;
> }
>
> -#ifdef CONFIG_LINUX
> -
> -#define HUGETLBFS_MAGIC 0x958458f6
> -
> -static long gethugepagesize(const char *path)
> -{
> - struct statfs fs;
> - int ret;
> -
> - do {
> - ret = statfs(path, &fs);
> - } while (ret != 0 && errno == EINTR);
> -
> - if (ret != 0) {
> - return -1;
> - }
> -
> - if (fs.f_type != HUGETLBFS_MAGIC) {
> - return -1;
> - }
> -
> - return fs.f_bsize;
> -}
> -#endif
> -
> /* open shm, create and bind to the unix socket */
> int
> ivshmem_server_start(IvshmemServer *server)
> @@ -319,27 +293,17 @@ ivshmem_server_start(IvshmemServer *server)
> int shm_fd, sock_fd, ret;
>
> /* open shm file */
> -#ifdef CONFIG_LINUX
> - long hpagesize;
> -
> - hpagesize = gethugepagesize(server->shm_path);
> - if (hpagesize < 0 && errno != ENOENT) {
> - IVSHMEM_SERVER_DEBUG(server, "cannot stat shm file %s: %s\n",
> - server->shm_path, strerror(errno));
> - }
> -
> - if (hpagesize > 0) {
> + if (server->use_shm_open) {
> + IVSHMEM_SERVER_DEBUG(server, "Using POSIX shared memory: %s\n",
> + server->shm_path);
> + shm_fd = shm_open(server->shm_path, O_CREAT|O_RDWR, S_IRWXU);
> + } else {
> gchar *filename = g_strdup_printf("%s/ivshmem.XXXXXX", server->shm_path);
> - IVSHMEM_SERVER_DEBUG(server, "Using hugepages: %s\n", server->shm_path);
> + IVSHMEM_SERVER_DEBUG(server, "Using file-backed shared memory: %s\n",
> + server->shm_path);
> shm_fd = mkstemp(filename);
> unlink(filename);
> g_free(filename);
> - } else
> -#endif
> - {
> - IVSHMEM_SERVER_DEBUG(server, "Using POSIX shared memory: %s\n",
> - server->shm_path);
> - shm_fd = shm_open(server->shm_path, O_CREAT|O_RDWR, S_IRWXU);
> }
>
> if (shm_fd < 0) {
> diff --git a/contrib/ivshmem-server/ivshmem-server.h b/contrib/ivshmem-server/ivshmem-server.h
> index e9de8a3..3851639 100644
> --- a/contrib/ivshmem-server/ivshmem-server.h
> +++ b/contrib/ivshmem-server/ivshmem-server.h
> @@ -66,6 +66,7 @@ typedef struct IvshmemServer {
> char unix_sock_path[PATH_MAX]; /**< path to unix socket */
> int sock_fd; /**< unix sock file descriptor */
> char shm_path[PATH_MAX]; /**< path to shm */
> + bool use_shm_open;
> size_t shm_size; /**< size of shm */
> int shm_fd; /**< shm file descriptor */
> unsigned n_vectors; /**< number of vectors */
> @@ -89,7 +90,8 @@ typedef struct IvshmemServer {
> */
> int
> ivshmem_server_init(IvshmemServer *server, const char *unix_sock_path,
> - const char *shm_path, size_t shm_size, unsigned n_vectors,
> + const char *shm_path, bool use_shm_open,
> + size_t shm_size, unsigned n_vectors,
> bool verbose);
>
> /**
> diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c
> index e9b4388..2795db5 100644
> --- a/contrib/ivshmem-server/main.c
> +++ b/contrib/ivshmem-server/main.c
> @@ -29,6 +29,7 @@ typedef struct IvshmemServerArgs {
> const char *pid_file;
> const char *unix_socket_path;
> const char *shm_path;
> + bool use_shm_open;
> uint64_t shm_size;
> unsigned n_vectors;
> } IvshmemServerArgs;
> @@ -44,8 +45,9 @@ ivshmem_server_usage(const char *progname)
> " default " IVSHMEM_SERVER_DEFAULT_PID_FILE "\n"
> " -S <unix_socket_path>: path to the unix socket to listen to\n"
> " default " IVSHMEM_SERVER_DEFAULT_UNIX_SOCK_PATH "\n"
> - " -m <shm_path>: POSIX shared memory object name or a hugetlbfs mount point\n"
> + " -M <name>: POSIX shared memory object to use\n"
> " default " IVSHMEM_SERVER_DEFAULT_SHM_PATH "\n"
> + " -m <dirname>: where to create shared memory\n"
> " -l <size>: size of shared memory in bytes\n"
> " suffixes K, M and G can be used, e.g. 1K means 1024\n"
> " default %u\n"
> @@ -76,6 +78,7 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
> "p:" /* pid_file */
> "S:" /* unix_socket_path */
> "m:" /* shm_path */
> + "M:" /* shm_path */
> "l:" /* shm_size */
> "n:" /* n_vectors */
> )) != -1) {
> @@ -102,8 +105,14 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
> args->unix_socket_path = optarg;
> break;
>
> + case 'M': /* shm_path */
> + args->shm_path = optarg;
> + args->use_shm_open = true;
> + break;
> +
> case 'm': /* shm_path */
> args->shm_path = optarg;
> + args->use_shm_open = false;
> break;
>
> case 'l': /* shm_size */
> @@ -199,6 +208,7 @@ main(int argc, char *argv[])
> .pid_file = IVSHMEM_SERVER_DEFAULT_PID_FILE,
> .unix_socket_path = IVSHMEM_SERVER_DEFAULT_UNIX_SOCK_PATH,
> .shm_path = IVSHMEM_SERVER_DEFAULT_SHM_PATH,
> + .use_shm_open = true,
> .shm_size = IVSHMEM_SERVER_DEFAULT_SHM_SIZE,
> .n_vectors = IVSHMEM_SERVER_DEFAULT_N_VECTORS,
> };
> @@ -226,7 +236,8 @@ main(int argc, char *argv[])
> }
>
> /* init the ivshms structure */
> - if (ivshmem_server_init(&server, args.unix_socket_path, args.shm_path,
> + if (ivshmem_server_init(&server, args.unix_socket_path,
> + args.shm_path, args.use_shm_open,
> args.shm_size, args.n_vectors, args.verbose) < 0) {
> fprintf(stderr, "cannot init server\n");
> goto err;
> diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c
> index e184c67..4efa433 100644
> --- a/tests/ivshmem-test.c
> +++ b/tests/ivshmem-test.c
> @@ -294,7 +294,7 @@ static void test_ivshmem_server(bool msi)
> guint64 end_time = g_get_monotonic_time() + 5 * G_TIME_SPAN_SECOND;
>
> memset(tmpshmem, 0x42, TMPSHMSIZE);
> - ret = ivshmem_server_init(&server, tmpserver, tmpshm,
> + ret = ivshmem_server_init(&server, tmpserver, tmpshm, true,
> TMPSHMSIZE, nvectors,
> g_test_verbose());
> g_assert_cmpint(ret, ==, 0);
> --
> 2.4.3
>
>
--
Marc-André Lureau
[-- Attachment #2: 0001-ivshmem-server-expect-either-m-or-M.patch --]
[-- Type: text/x-patch, Size: 2869 bytes --]
From e8112678496fd873ceaa34b3169e516130075ed4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>
Date: Tue, 8 Mar 2016 20:31:09 +0100
Subject: [PATCH] ivshmem-server: expect either -m or -M
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
contrib/ivshmem-server/main.c | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c
index 2795db5..368fc67 100644
--- a/contrib/ivshmem-server/main.c
+++ b/contrib/ivshmem-server/main.c
@@ -77,7 +77,7 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
"F" /* foreground */
"p:" /* pid_file */
"S:" /* unix_socket_path */
- "m:" /* shm_path */
+ "m:" /* dirname */
"M:" /* shm_path */
"l:" /* shm_size */
"n:" /* n_vectors */
@@ -106,13 +106,15 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
break;
case 'M': /* shm_path */
- args->shm_path = optarg;
- args->use_shm_open = true;
- break;
+ case 'm': /* dirname */
+ if (args->shm_path) {
+ fprintf(stderr, "Please specify either -m or -M.\n");
+ ivshmem_server_help(argv[0]);
+ exit(1);
+ }
- case 'm': /* shm_path */
args->shm_path = optarg;
- args->use_shm_open = false;
+ args->use_shm_open = c == 'M';
break;
case 'l': /* shm_size */
@@ -207,7 +209,7 @@ main(int argc, char *argv[])
.foreground = IVSHMEM_SERVER_DEFAULT_FOREGROUND,
.pid_file = IVSHMEM_SERVER_DEFAULT_PID_FILE,
.unix_socket_path = IVSHMEM_SERVER_DEFAULT_UNIX_SOCK_PATH,
- .shm_path = IVSHMEM_SERVER_DEFAULT_SHM_PATH,
+ .shm_path = NULL,
.use_shm_open = true,
.shm_size = IVSHMEM_SERVER_DEFAULT_SHM_SIZE,
.n_vectors = IVSHMEM_SERVER_DEFAULT_N_VECTORS,
@@ -237,8 +239,9 @@ main(int argc, char *argv[])
/* init the ivshms structure */
if (ivshmem_server_init(&server, args.unix_socket_path,
- args.shm_path, args.use_shm_open,
- args.shm_size, args.n_vectors, args.verbose) < 0) {
+ args.shm_path ?: IVSHMEM_SERVER_DEFAULT_SHM_PATH,
+ args.use_shm_open, args.shm_size, args.n_vectors,
+ args.verbose) < 0) {
fprintf(stderr, "cannot init server\n");
goto err;
}
--
2.5.0
^ permalink raw reply related [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 05/42] ivshmem-server: Don't overload POSIX shmem and file name
2016-03-09 12:44 ` Marc-André Lureau
@ 2016-03-09 20:14 ` Markus Armbruster
2016-03-10 0:44 ` Marc-André Lureau
0 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-09 20:14 UTC (permalink / raw)
To: Marc-André Lureau
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
Marc-André Lureau <marcandre.lureau@gmail.com> writes:
> Hi
>
> On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
>> Option -m NAME is interpreted as directory name if we can statfs() it
>> and its on hugetlbfs. Else it's interpreted as POSIX shared memory
>> object name. This is nuts.
>>
>> Always interpret -m as directory. Create new -M for POSIX shared
>> memory. Last of -m or -M wins.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>
> I don't see why the last should win is a good idea, see attached patch
Last one wins is pretty common behavior. In fact, it's what this
program does for every single option with an argument. I didn't feel
like making -m and -M special.
> for a possible solution, also changing a few comments. Feel free to
> squash it in this patch or include it in your series.
I got a few comments inline.
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Thanks!
[...]
> From e8112678496fd873ceaa34b3169e516130075ed4 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>
> Date: Tue, 8 Mar 2016 20:31:09 +0100
> Subject: [PATCH] ivshmem-server: expect either -m or -M
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> contrib/ivshmem-server/main.c | 21 ++++++++++++---------
> 1 file changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c
> index 2795db5..368fc67 100644
> --- a/contrib/ivshmem-server/main.c
> +++ b/contrib/ivshmem-server/main.c
> @@ -77,7 +77,7 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
> "F" /* foreground */
> "p:" /* pid_file */
> "S:" /* unix_socket_path */
> - "m:" /* shm_path */
> + "m:" /* dirname */
The existing comments all name the member of args set by the option.
There is no member dirname.
> "M:" /* shm_path */
> "l:" /* shm_size */
> "n:" /* n_vectors */
> @@ -106,13 +106,15 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
> break;
>
> case 'M': /* shm_path */
> - args->shm_path = optarg;
> - args->use_shm_open = true;
> - break;
> + case 'm': /* dirname */
> + if (args->shm_path) {
> + fprintf(stderr, "Please specify either -m or -M.\n");
> + ivshmem_server_help(argv[0]);
> + exit(1);
> + }
>
> - case 'm': /* shm_path */
> args->shm_path = optarg;
> - args->use_shm_open = false;
> + args->use_shm_open = c == 'M';
I think I'll steal this idea :)
> break;
>
> case 'l': /* shm_size */
> @@ -207,7 +209,7 @@ main(int argc, char *argv[])
> .foreground = IVSHMEM_SERVER_DEFAULT_FOREGROUND,
> .pid_file = IVSHMEM_SERVER_DEFAULT_PID_FILE,
> .unix_socket_path = IVSHMEM_SERVER_DEFAULT_UNIX_SOCK_PATH,
> - .shm_path = IVSHMEM_SERVER_DEFAULT_SHM_PATH,
> + .shm_path = NULL,
> .use_shm_open = true,
> .shm_size = IVSHMEM_SERVER_DEFAULT_SHM_SIZE,
> .n_vectors = IVSHMEM_SERVER_DEFAULT_N_VECTORS,
> @@ -237,8 +239,9 @@ main(int argc, char *argv[])
>
> /* init the ivshms structure */
> if (ivshmem_server_init(&server, args.unix_socket_path,
> - args.shm_path, args.use_shm_open,
> - args.shm_size, args.n_vectors, args.verbose) < 0) {
> + args.shm_path ?: IVSHMEM_SERVER_DEFAULT_SHM_PATH,
> + args.use_shm_open, args.shm_size, args.n_vectors,
> + args.verbose) < 0) {
> fprintf(stderr, "cannot init server\n");
> goto err;
> }
^ permalink raw reply [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 05/42] ivshmem-server: Don't overload POSIX shmem and file name
2016-03-09 20:14 ` Markus Armbruster
@ 2016-03-10 0:44 ` Marc-André Lureau
2016-03-10 6:57 ` Markus Armbruster
0 siblings, 1 reply; 74+ messages in thread
From: Marc-André Lureau @ 2016-03-10 0:44 UTC (permalink / raw)
To: Markus Armbruster
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
Hi
On Wed, Mar 9, 2016 at 9:14 PM, Markus Armbruster <armbru@redhat.com> wrote:
>> @@ -77,7 +77,7 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
>> "F" /* foreground */
>> "p:" /* pid_file */
>> "S:" /* unix_socket_path */
>> - "m:" /* shm_path */
>> + "m:" /* dirname */
>
> The existing comments all name the member of args set by the option.
> There is no member dirname.
I read from help: "-m <dirname>: where to create shared memory"
>
>> "M:" /* shm_path */
>> "l:" /* shm_size */
>> "n:" /* n_vectors */
>> @@ -106,13 +106,15 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
>> break;
>>
>> case 'M': /* shm_path */
>> - args->shm_path = optarg;
>> - args->use_shm_open = true;
>> - break;
>> + case 'm': /* dirname */
>> + if (args->shm_path) {
>> + fprintf(stderr, "Please specify either -m or -M.\n");
>> + ivshmem_server_help(argv[0]);
>> + exit(1);
>> + }
>>
>> - case 'm': /* shm_path */
>> args->shm_path = optarg;
>> - args->use_shm_open = false;
>> + args->use_shm_open = c == 'M';
>
> I think I'll steal this idea :)
feel free
>
>> break;
>>
>> case 'l': /* shm_size */
>> @@ -207,7 +209,7 @@ main(int argc, char *argv[])
>> .foreground = IVSHMEM_SERVER_DEFAULT_FOREGROUND,
>> .pid_file = IVSHMEM_SERVER_DEFAULT_PID_FILE,
>> .unix_socket_path = IVSHMEM_SERVER_DEFAULT_UNIX_SOCK_PATH,
>> - .shm_path = IVSHMEM_SERVER_DEFAULT_SHM_PATH,
>> + .shm_path = NULL,
>> .use_shm_open = true,
>> .shm_size = IVSHMEM_SERVER_DEFAULT_SHM_SIZE,
>> .n_vectors = IVSHMEM_SERVER_DEFAULT_N_VECTORS,
>> @@ -237,8 +239,9 @@ main(int argc, char *argv[])
>>
>> /* init the ivshms structure */
>> if (ivshmem_server_init(&server, args.unix_socket_path,
>> - args.shm_path, args.use_shm_open,
>> - args.shm_size, args.n_vectors, args.verbose) < 0) {
>> + args.shm_path ?: IVSHMEM_SERVER_DEFAULT_SHM_PATH,
>> + args.use_shm_open, args.shm_size, args.n_vectors,
>> + args.verbose) < 0) {
>> fprintf(stderr, "cannot init server\n");
>> goto err;
>> }
thanks
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 05/42] ivshmem-server: Don't overload POSIX shmem and file name
2016-03-10 0:44 ` Marc-André Lureau
@ 2016-03-10 6:57 ` Markus Armbruster
0 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-10 6:57 UTC (permalink / raw)
To: Marc-André Lureau
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
Marc-André Lureau <marcandre.lureau@gmail.com> writes:
> Hi
>
> On Wed, Mar 9, 2016 at 9:14 PM, Markus Armbruster <armbru@redhat.com> wrote:
>>> @@ -77,7 +77,7 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
>>> "F" /* foreground */
>>> "p:" /* pid_file */
>>> "S:" /* unix_socket_path */
>>> - "m:" /* shm_path */
>>> + "m:" /* dirname */
>>
>> The existing comments all name the member of args set by the option.
>> There is no member dirname.
>
> I read from help: "-m <dirname>: where to create shared memory"
Differently logical. In your interpretation, the comments are of very
little value. In mine, even less. That makes yours "superior".
>>> "M:" /* shm_path */
>>> "l:" /* shm_size */
>>> "n:" /* n_vectors */
[...]
^ permalink raw reply [flat|nested] 74+ messages in thread
* [Qemu-devel] [PATCH v2 06/42] qemu-doc: Fix ivshmem huge page example
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (4 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 05/42] ivshmem-server: Don't overload POSIX shmem and file name Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 07/42] event_notifier: Make event_notifier_init_fd() #ifdef CONFIG_EVENTFD Markus Armbruster
` (37 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Option parameter "share" is missing. Without it, you get a *private*
mmap(), which defeats ivshmem's purpose pretty thoroughly ;)
While there, switch to the conventional mountpoint of hugetlbfs
/dev/hugepages.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---
qemu-doc.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-doc.texi b/qemu-doc.texi
index bc9dd13..65f3b29 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -1311,7 +1311,7 @@ Instead of specifying the <shm size> using POSIX shm, you may specify
a memory backend that has hugepage support:
@example
-qemu-system-i386 -object memory-backend-file,size=1G,mem-path=/mnt/hugepages/my-shmem-file,id=mb1
+qemu-system-i386 -object memory-backend-file,size=1G,mem-path=/dev/hugepages/my-shmem-file,share,id=mb1
-device ivshmem,x-memdev=mb1
@end example
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 07/42] event_notifier: Make event_notifier_init_fd() #ifdef CONFIG_EVENTFD
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (5 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 06/42] qemu-doc: Fix ivshmem huge page example Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 08/42] tests/libqos/pci-pc: Fix qpci_pc_iomap() to map BARs aligned Markus Armbruster
` (36 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Event notifiers are designed for eventfd(2). They can fall back to
pipes, but according to Paolo, event_notifier_init_fd() really
requires the real thing, and should therefore be under #ifdef
CONFIG_EVENTFD. Do that.
Its only user is ivshmem, which is currently CONFIG_POSIX. Narrow it
to CONFIG_EVENTFD.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---
default-configs/pci.mak | 2 +-
util/event_notifier-posix.c | 6 ++++++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/default-configs/pci.mak b/default-configs/pci.mak
index 4fa9a28..9c8bc68 100644
--- a/default-configs/pci.mak
+++ b/default-configs/pci.mak
@@ -36,5 +36,5 @@ CONFIG_SDHCI=y
CONFIG_EDU=y
CONFIG_VGA=y
CONFIG_VGA_PCI=y
-CONFIG_IVSHMEM=$(CONFIG_POSIX)
+CONFIG_IVSHMEM=$(CONFIG_EVENTFD)
CONFIG_ROCKER=y
diff --git a/util/event_notifier-posix.c b/util/event_notifier-posix.c
index 2e30e74..c9657a6 100644
--- a/util/event_notifier-posix.c
+++ b/util/event_notifier-posix.c
@@ -20,11 +20,17 @@
#include <sys/eventfd.h>
#endif
+#ifdef CONFIG_EVENTFD
+/*
+ * Initialize @e with existing file descriptor @fd.
+ * @fd must be a genuine eventfd object, emulation with pipe won't do.
+ */
void event_notifier_init_fd(EventNotifier *e, int fd)
{
e->rfd = fd;
e->wfd = fd;
}
+#endif
int event_notifier_init(EventNotifier *e, int active)
{
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 08/42] tests/libqos/pci-pc: Fix qpci_pc_iomap() to map BARs aligned
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (6 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 07/42] event_notifier: Make event_notifier_init_fd() #ifdef CONFIG_EVENTFD Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 09/42] ivshmem-test: Improve test case /ivshmem/single Markus Armbruster
` (35 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
qpci_pc_iomap() maps BARs one after the other, without padding. This
is wrong. PCI Local Bus Specification Revision 3.0, 6.2.5.1. Address
Maps: "all address spaces used are a power of two in size and are
naturally aligned". That's because the size of a BAR is given by the
number of address bits the device decodes, and the BAR needs to be
mapped at a multiple of that size to ensure the address decoding
works.
Fix qpci_pc_iomap() accordingly. This takes care of a FIXME in
ivshmem-test.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
tests/ivshmem-test.c | 17 ++++++++---------
tests/libqos/pci-pc.c | 8 ++++++--
2 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c
index 4efa433..da6ca0d 100644
--- a/tests/ivshmem-test.c
+++ b/tests/ivshmem-test.c
@@ -110,19 +110,18 @@ static void setup_vm_cmd(IVState *s, const char *cmd, bool msix)
s->pcibus = qpci_init_pc();
s->dev = get_device(s->pcibus);
- /* FIXME: other bar order fails, mappings changes */
- s->mem_base = qpci_iomap(s->dev, 2, &barsize);
- g_assert_nonnull(s->mem_base);
- g_assert_cmpuint(barsize, ==, TMPSHMSIZE);
-
- if (msix) {
- qpci_msix_enable(s->dev);
- }
-
s->reg_base = qpci_iomap(s->dev, 0, &barsize);
g_assert_nonnull(s->reg_base);
g_assert_cmpuint(barsize, ==, 256);
+ if (msix) {
+ qpci_msix_enable(s->dev);
+ }
+
+ s->mem_base = qpci_iomap(s->dev, 2, &barsize);
+ g_assert_nonnull(s->mem_base);
+ g_assert_cmpuint(barsize, ==, TMPSHMSIZE);
+
qpci_device_enable(s->dev);
}
diff --git a/tests/libqos/pci-pc.c b/tests/libqos/pci-pc.c
index 08167c0..77f15e5 100644
--- a/tests/libqos/pci-pc.c
+++ b/tests/libqos/pci-pc.c
@@ -184,7 +184,9 @@ static void *qpci_pc_iomap(QPCIBus *bus, QPCIDevice *dev, int barno, uint64_t *s
if (io_type == PCI_BASE_ADDRESS_SPACE_IO) {
uint16_t loc;
- g_assert((s->pci_iohole_alloc + size) <= s->pci_iohole_size);
+ g_assert(QEMU_ALIGN_UP(s->pci_iohole_alloc, size) + size
+ <= s->pci_iohole_size);
+ s->pci_iohole_alloc = QEMU_ALIGN_UP(s->pci_iohole_alloc, size);
loc = s->pci_iohole_start + s->pci_iohole_alloc;
s->pci_iohole_alloc += size;
@@ -194,7 +196,9 @@ static void *qpci_pc_iomap(QPCIBus *bus, QPCIDevice *dev, int barno, uint64_t *s
} else {
uint64_t loc;
- g_assert((s->pci_hole_alloc + size) <= s->pci_hole_size);
+ g_assert(QEMU_ALIGN_UP(s->pci_hole_alloc, size) + size
+ <= s->pci_hole_size);
+ s->pci_hole_alloc = QEMU_ALIGN_UP(s->pci_hole_alloc, size);
loc = s->pci_hole_start + s->pci_hole_alloc;
s->pci_hole_alloc += size;
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 09/42] ivshmem-test: Improve test case /ivshmem/single
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (7 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 08/42] tests/libqos/pci-pc: Fix qpci_pc_iomap() to map BARs aligned Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 10/42] ivshmem-test: Clean up wait for devices to become operational Markus Armbruster
` (34 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Test state of registers after reset.
Test reading Interrupt Status clears it.
Test (invalid) read of Doorbell.
Add more comments.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
tests/ivshmem-test.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c
index da6ca0d..a48dc49 100644
--- a/tests/ivshmem-test.c
+++ b/tests/ivshmem-test.c
@@ -143,32 +143,41 @@ static void test_ivshmem_single(void)
setup_vm(&state);
s = &state;
- /* valid io */
- out_reg(s, INTRMASK, 0);
- in_reg(s, INTRSTATUS);
- in_reg(s, IVPOSITION);
+ /* initial state of readable registers */
+ g_assert_cmpuint(in_reg(s, INTRMASK), ==, 0);
+ g_assert_cmpuint(in_reg(s, INTRSTATUS), ==, 0);
+ g_assert_cmpuint(in_reg(s, IVPOSITION), ==, 0);
+ /* trigger interrupt via registers */
out_reg(s, INTRMASK, 0xffffffff);
g_assert_cmpuint(in_reg(s, INTRMASK), ==, 0xffffffff);
out_reg(s, INTRSTATUS, 1);
- /* XXX: intercept IRQ, not seen in resp */
+ /* check interrupt status */
g_assert_cmpuint(in_reg(s, INTRSTATUS), ==, 1);
+ /* reading clears */
+ g_assert_cmpuint(in_reg(s, INTRSTATUS), ==, 0);
+ /* TODO intercept actual interrupt (needs qtest work) */
- /* invalid io */
+ /* invalid register access */
out_reg(s, IVPOSITION, 1);
+ in_reg(s, DOORBELL);
+
+ /* ring the (non-functional) doorbell */
out_reg(s, DOORBELL, 8 << 16);
+ /* write shared memory */
for (i = 0; i < G_N_ELEMENTS(data); i++) {
data[i] = i;
}
qtest_memwrite(s->qtest, (uintptr_t)s->mem_base, data, sizeof(data));
+ /* verify write */
for (i = 0; i < G_N_ELEMENTS(data); i++) {
g_assert_cmpuint(((uint32_t *)tmpshmem)[i], ==, i);
}
+ /* read it back and verify read */
memset(data, 0, sizeof(data));
-
qtest_memread(s->qtest, (uintptr_t)s->mem_base, data, sizeof(data));
for (i = 0; i < G_N_ELEMENTS(data); i++) {
g_assert_cmpuint(data[i], ==, i);
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 10/42] ivshmem-test: Clean up wait for devices to become operational
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (8 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 09/42] ivshmem-test: Improve test case /ivshmem/single Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 11/42] ivshmem-test: Improve test cases /ivshmem/server-* Markus Armbruster
` (33 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
test_ivshmem_server() waits until the first byte in BAR 2 contains the
0x42 we put into shared memory. Works because the byte reads zero
until the device maps the shared memory gotten from the server.
Check the IVPosition register instead: it's initially -1, and becomes
non-negative right when the device maps the share memory, so no
change, just cleaner, because it's what guest software is supposed to
do.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
tests/ivshmem-test.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c
index a48dc49..bbea8cd 100644
--- a/tests/ivshmem-test.c
+++ b/tests/ivshmem-test.c
@@ -301,7 +301,6 @@ static void test_ivshmem_server(bool msi)
int nvectors = 2;
guint64 end_time = g_get_monotonic_time() + 5 * G_TIME_SPAN_SECOND;
- memset(tmpshmem, 0x42, TMPSHMSIZE);
ret = ivshmem_server_init(&server, tmpserver, tmpshm, true,
TMPSHMSIZE, nvectors,
g_test_verbose());
@@ -315,9 +314,9 @@ static void test_ivshmem_server(bool msi)
setup_vm_with_server(&state2, nvectors, msi);
s2 = &state2;
+ /* check state before server sends stuff */
g_assert_cmpuint(in_reg(s1, IVPOSITION), ==, 0xffffffff);
g_assert_cmpuint(in_reg(s2, IVPOSITION), ==, 0xffffffff);
-
g_assert_cmpuint(qtest_readb(s1->qtest, (uintptr_t)s1->mem_base), ==, 0x00);
thread.server = &server;
@@ -326,12 +325,11 @@ static void test_ivshmem_server(bool msi)
thread.thread = g_thread_new("ivshmem-server", server_thread, &thread);
g_assert(thread.thread != NULL);
- /* waiting until mapping is done */
+ /* waiting for devices to become operational */
while (g_get_monotonic_time() < end_time) {
g_usleep(1000);
-
- if (qtest_readb(s1->qtest, (uintptr_t)s1->mem_base) == 0x42 &&
- qtest_readb(s2->qtest, (uintptr_t)s2->mem_base) == 0x42) {
+ if ((int)in_reg(s1, IVPOSITION) >= 0 &&
+ (int)in_reg(s2, IVPOSITION) >= 0) {
break;
}
}
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 11/42] ivshmem-test: Improve test cases /ivshmem/server-*
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (9 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 10/42] ivshmem-test: Clean up wait for devices to become operational Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 12/42] ivshmem: Rewrite specification document Markus Armbruster
` (32 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Document missing test: behavior with MSI-X present but not enabled.
For MSI-X, we test and clear the interrupt pending bit before testing
the interrupt. For INTx, we only clear. Change to test and clear for
consistency.
Test MSI-X vector 1 in addition to vector 0.
Improve comments.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
tests/ivshmem-test.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c
index bbea8cd..7b6b957 100644
--- a/tests/ivshmem-test.c
+++ b/tests/ivshmem-test.c
@@ -339,18 +339,21 @@ static void test_ivshmem_server(bool msi)
vm2 = in_reg(s2, IVPOSITION);
g_assert_cmpuint(vm1, !=, vm2);
+ /* check number of MSI-X vectors */
global_qtest = s1->qtest;
if (msi) {
ret = qpci_msix_table_size(s1->dev);
g_assert_cmpuint(ret, ==, nvectors);
}
- /* ping vm2 -> vm1 */
+ /* TODO test behavior before MSI-X is enabled */
+
+ /* ping vm2 -> vm1 on vector 0 */
if (msi) {
ret = qpci_msix_pending(s1->dev, 0);
g_assert_cmpuint(ret, ==, 0);
} else {
- out_reg(s1, INTRSTATUS, 0);
+ g_assert_cmpuint(in_reg(s1, INTRSTATUS), ==, 0);
}
out_reg(s2, DOORBELL, vm1 << 16);
do {
@@ -359,18 +362,18 @@ static void test_ivshmem_server(bool msi)
} while (ret == 0 && g_get_monotonic_time() < end_time);
g_assert_cmpuint(ret, !=, 0);
- /* ping vm1 -> vm2 */
+ /* ping vm1 -> vm2 on vector 1 */
global_qtest = s2->qtest;
if (msi) {
- ret = qpci_msix_pending(s2->dev, 0);
+ ret = qpci_msix_pending(s2->dev, 1);
g_assert_cmpuint(ret, ==, 0);
} else {
- out_reg(s2, INTRSTATUS, 0);
+ g_assert_cmpuint(in_reg(s2, INTRSTATUS), ==, 0);
}
- out_reg(s1, DOORBELL, vm2 << 16);
+ out_reg(s1, DOORBELL, vm2 << 16 | 1);
do {
g_usleep(10000);
- ret = msi ? qpci_msix_pending(s2->dev, 0) : in_reg(s2, INTRSTATUS);
+ ret = msi ? qpci_msix_pending(s2->dev, 1) : in_reg(s2, INTRSTATUS);
} while (ret == 0 && g_get_monotonic_time() < end_time);
g_assert_cmpuint(ret, !=, 0);
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 12/42] ivshmem: Rewrite specification document
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (10 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 11/42] ivshmem-test: Improve test cases /ivshmem/server-* Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 13/42] ivshmem: Add missing newlines to debug printfs Markus Armbruster
` (31 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
This started as an attempt to update ivshmem_device_spec.txt for
clarity, accuracy and completeness while working on its code, and
quickly became a full rewrite. Since the diff would be useless
anyway, I'm using the opportunity to rename the file to
ivshmem-spec.txt.
I tried hard to ensure the new text contradicts neither the old text
nor the code. If the new text contradicts the old text but not the
code, it's probably a bug in the old text. If the new text
contradicts both, its probably a bug in the new text.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
docs/specs/ivshmem-spec.txt | 243 +++++++++++++++++++++++++++++++++++++
docs/specs/ivshmem_device_spec.txt | 161 ------------------------
2 files changed, 243 insertions(+), 161 deletions(-)
create mode 100644 docs/specs/ivshmem-spec.txt
delete mode 100644 docs/specs/ivshmem_device_spec.txt
diff --git a/docs/specs/ivshmem-spec.txt b/docs/specs/ivshmem-spec.txt
new file mode 100644
index 0000000..0e9185a
--- /dev/null
+++ b/docs/specs/ivshmem-spec.txt
@@ -0,0 +1,243 @@
+= Device Specification for Inter-VM shared memory device =
+
+The Inter-VM shared memory device (ivshmem) is designed to share a
+memory region between multiple QEMU processes running different guests
+and the host. In order for all guests to be able to pick up the
+shared memory area, it is modeled by QEMU as a PCI device exposing
+said memory to the guest as a PCI BAR.
+
+The device can use a shared memory object on the host directly, or it
+can obtain one from an ivshmem server.
+
+In the latter case, the device can additionally interrupt its peers, and
+get interrupted by its peers.
+
+
+== Configuring the ivshmem PCI device ==
+
+There are two basic configurations:
+
+- Just shared memory: -device ivshmem,shm=NAME,...
+
+ This uses shared memory object NAME.
+
+- Shared memory plus interrupts: -device ivshmem,chardev=CHR,vectors=N,...
+
+ An ivshmem server must already be running on the host. The device
+ connects to the server's UNIX domain socket via character device
+ CHR.
+
+ Each peer gets assigned a unique ID by the server. IDs must be
+ between 0 and 65535.
+
+ Interrupts are message-signaled by default (MSI-X). With msi=off
+ the device has no MSI-X capability, and uses legacy INTx instead.
+ vectors=N configures the number of vectors to use.
+
+For more details on ivshmem device properties, see The QEMU Emulator
+User Documentation (qemu-doc.*).
+
+
+== The ivshmem PCI device's guest interface ==
+
+The device has vendor ID 1af4, device ID 1110, revision 0.
+
+=== PCI BARs ===
+
+The ivshmem PCI device has two or three BARs:
+
+- BAR0 holds device registers (256 Byte MMIO)
+- BAR1 holds MSI-X table and PBA (only when using MSI-X)
+- BAR2 maps the shared memory object
+
+There are two ways to use this device:
+
+- If you only need the shared memory part, BAR2 suffices. This way,
+ you have access to the shared memory in the guest and can use it as
+ you see fit. Memnic, for example, uses ivshmem this way from guest
+ user space (see http://dpdk.org/browse/memnic).
+
+- If you additionally need the capability for peers to interrupt each
+ other, you need BAR0 and, if using MSI-X, BAR1. You will most
+ likely want to write a kernel driver to handle interrupts. Requires
+ the device to be configured for interrupts, obviously.
+
+If the device is configured for interrupts, BAR2 is initially invalid.
+It becomes safely accessible only after the ivshmem server provided
+the shared memory. Guest software should wait for the IVPosition
+register (described below) to become non-negative before accessing
+BAR2.
+
+The device is not capable to tell guest software whether it is
+configured for interrupts.
+
+=== PCI device registers ===
+
+BAR 0 contains the following registers:
+
+ Offset Size Access On reset Function
+ 0 4 read/write 0 Interrupt Mask
+ bit 0: peer interrupt
+ bit 1..31: reserved
+ 4 4 read/write 0 Interrupt Status
+ bit 0: peer interrupt
+ bit 1..31: reserved
+ 8 4 read-only 0 or -1 IVPosition
+ 12 4 write-only N/A Doorbell
+ bit 0..15: vector
+ bit 16..31: peer ID
+ 16 240 none N/A reserved
+
+Software should only access the registers as specified in column
+"Access". Reserved bits should be ignored on read, and preserved on
+write.
+
+Interrupt Status and Mask Register together control the legacy INTx
+interrupt when the device has no MSI-X capability: INTx is asserted
+when the bit-wise AND of Status and Mask is non-zero and the device
+has no MSI-X capability. Interrupt Status Register bit 0 becomes 1
+when an interrupt request from a peer is received. Reading the
+register clears it.
+
+IVPosition Register: if the device is not configured for interrupts,
+this is zero. Else, it's -1 for a short while after reset, then
+changes to the device's ID (between 0 and 65535).
+
+There is no good way for software to find out whether the device is
+configured for interrupts. A positive IVPosition means interrupts,
+but zero could be either. The initial -1 cannot be reliably observed.
+
+Doorbell Register: writing this register requests to interrupt a peer.
+The written value's high 16 bits are the ID of the peer to interrupt,
+and its low 16 bits select an interrupt vector.
+
+If the device is not configured for interrupts, the write is ignored.
+
+If the interrupt hasn't completed setup, the write is ignored. The
+device is not capable to tell guest software whether setup is
+complete. Interrupts can regress to this state on migration.
+
+If the peer with the requested ID isn't connected, or it has fewer
+interrupt vectors connected, the write is ignored. The device is not
+capable to tell guest software what peers are connected, or how many
+interrupt vectors are connected.
+
+If the peer doesn't use MSI-X, its Interrupt Status register is set to
+1. This asserts INTx unless masked by the Interrupt Mask register.
+The device is not capable to communicate the interrupt vector to guest
+software then.
+
+If the peer uses MSI-X, the interrupt for this vector becomes pending.
+There is no way for software to clear the pending bit, and a polling
+mode of operation is therefore impossible with MSI-X.
+
+With multiple MSI-X vectors, different vectors can be used to indicate
+different events have occurred. The semantics of interrupt vectors
+are left to the application.
+
+
+== Interrupt infrastructure ==
+
+When configured for interrupts, the peers share eventfd objects in
+addition to shared memory. The shared resources are managed by an
+ivshmem server.
+
+=== The ivshmem server ===
+
+The server listens on a UNIX domain socket.
+
+For each new client that connects to the server, the server
+- picks an ID,
+- creates eventfd file descriptors for the interrupt vectors,
+- sends the ID and the file descriptor for the shared memory to the
+ new client,
+- sends connect notifications for the new client to the other clients
+ (these contain file descriptors for sending interrupts),
+- sends connect notifications for the other clients to the new client,
+ and
+- sends interrupt setup messages to the new client (these contain file
+ descriptors for receiving interrupts).
+
+When a client disconnects from the server, the server sends disconnect
+notifications to the other clients.
+
+The next section describes the protocol in detail.
+
+If the server terminates without sending disconnect notifications for
+its connected clients, the clients can elect to continue. They can
+communicate with each other normally, but won't receive disconnect
+notification on disconnect, and no new clients can connect. There is
+no way for the clients to connect to a restarted server. The device
+is not capable to tell guest software whether the server is still up.
+
+Example server code is in contrib/ivshmem-server/. Not to be used in
+production. It assumes all clients use the same number of interrupt
+vectors.
+
+A standalone client is in contrib/ivshmem-client/. It can be useful
+for debugging.
+
+=== The ivshmem Client-Server Protocol ===
+
+An ivshmem device configured for interrupts connects to an ivshmem
+server. This section details the protocol between the two.
+
+The connection is one-way: the server sends messages to the client.
+Each message consists of a single 8 byte little-endian signed number,
+and may be accompanied by a file descriptor via SCM_RIGHTS. Both
+client and server close the connection on error.
+
+On connect, the server sends the following messages in order:
+
+1. The protocol version number, currently zero. The client should
+ close the connection on receipt of versions it can't handle.
+
+2. The client's ID. This is unique among all clients of this server.
+ IDs must be between 0 and 65535, because the Doorbell register
+ provides only 16 bits for them.
+
+3. The number -1, accompanied by the file descriptor for the shared
+ memory.
+
+4. Connect notifications for existing other clients, if any. This is
+ a peer ID (number between 0 and 65535 other than the client's ID),
+ repeated N times. Each repetition is accompanied by one file
+ descriptor. These are for interrupting the peer with that ID using
+ vector 0,..,N-1, in order. If the client is configured for fewer
+ vectors, it closes the extra file descriptors. If it is configured
+ for more, the extra vectors remain unconnected.
+
+5. Interrupt setup. This is the client's own ID, repeated N times.
+ Each repetition is accompanied by one file descriptor. These are
+ for receiving interrupts from peers using vector 0,..,N-1, in
+ order. If the client is configured for fewer vectors, it closes
+ the extra file descriptors. If it is configured for more, the
+ extra vectors remain unconnected.
+
+From then on, the server sends these kinds of messages:
+
+6. Connection / disconnection notification. This is a peer ID.
+
+ - If the number comes with a file descriptor, it's a connection
+ notification, exactly like in step 4.
+
+ - Else, it's a disconnection notification for the peer with that ID.
+
+Known bugs:
+
+* The protocol changed incompatibly in QEMU 2.5. Before, messages
+ were native endian long, and there was no version number.
+
+* The protocol is poorly designed.
+
+=== The ivshmem Client-Client Protocol ===
+
+An ivshmem device configured for interrupts receives eventfd file
+descriptors for interrupting peers and getting interrupted by peers
+from the server, as explained in the previous section.
+
+To interrupt a peer, the device writes the 8-byte integer 1 in native
+byte order to the respective file descriptor.
+
+To receive an interrupt, the device reads and discards as many 8-byte
+integers as it can.
diff --git a/docs/specs/ivshmem_device_spec.txt b/docs/specs/ivshmem_device_spec.txt
deleted file mode 100644
index d318d65..0000000
--- a/docs/specs/ivshmem_device_spec.txt
+++ /dev/null
@@ -1,161 +0,0 @@
-
-Device Specification for Inter-VM shared memory device
-------------------------------------------------------
-
-The Inter-VM shared memory device is designed to share a memory region (created
-on the host via the POSIX shared memory API) between multiple QEMU processes
-running different guests. In order for all guests to be able to pick up the
-shared memory area, it is modeled by QEMU as a PCI device exposing said memory
-to the guest as a PCI BAR.
-The memory region does not belong to any guest, but is a POSIX memory object on
-the host. The host can access this shared memory if needed.
-
-The device also provides an optional communication mechanism between guests
-sharing the same memory object. More details about that in the section 'Guest to
-guest communication' section.
-
-
-The Inter-VM PCI device
------------------------
-
-From the VM point of view, the ivshmem PCI device supports three BARs.
-
-- BAR0 is a 1 Kbyte MMIO region to support registers and interrupts when MSI is
- not used.
-- BAR1 is used for MSI-X when it is enabled in the device.
-- BAR2 is used to access the shared memory object.
-
-It is your choice how to use the device but you must choose between two
-behaviors :
-
-- basically, if you only need the shared memory part, you will map BAR2.
- This way, you have access to the shared memory in guest and can use it as you
- see fit (memnic, for example, uses it in userland
- http://dpdk.org/browse/memnic).
-
-- BAR0 and BAR1 are used to implement an optional communication mechanism
- through interrupts in the guests. If you need an event mechanism between the
- guests accessing the shared memory, you will most likely want to write a
- kernel driver that will handle interrupts. See details in the section 'Guest
- to guest communication' section.
-
-The behavior is chosen when starting your QEMU processes:
-- no communication mechanism needed, the first QEMU to start creates the shared
- memory on the host, subsequent QEMU processes will use it.
-
-- communication mechanism needed, an ivshmem server must be started before any
- QEMU processes, then each QEMU process connects to the server unix socket.
-
-For more details on the QEMU ivshmem parameters, see qemu-doc documentation.
-
-
-Guest to guest communication
-----------------------------
-
-This section details the communication mechanism between the guests accessing
-the ivhsmem shared memory.
-
-*ivshmem server*
-
-This server code is available in qemu.git/contrib/ivshmem-server.
-
-The server must be started on the host before any guest.
-It creates a shared memory object then waits for clients to connect on a unix
-socket. All the messages are little-endian int64_t integer.
-
-For each client (QEMU process) that connects to the server:
-- the server sends a protocol version, if client does not support it, the client
- closes the communication,
-- the server assigns an ID for this client and sends this ID to him as the first
- message,
-- the server sends a fd to the shared memory object to this client,
-- the server creates a new set of host eventfds associated to the new client and
- sends this set to all already connected clients,
-- finally, the server sends all the eventfds sets for all clients to the new
- client.
-
-The server signals all clients when one of them disconnects.
-
-The client IDs are limited to 16 bits because of the current implementation (see
-Doorbell register in 'PCI device registers' subsection). Hence only 65536
-clients are supported.
-
-All the file descriptors (fd to the shared memory, eventfds for each client)
-are passed to clients using SCM_RIGHTS over the server unix socket.
-
-Apart from the current ivshmem implementation in QEMU, an ivshmem client has
-been provided in qemu.git/contrib/ivshmem-client for debug.
-
-*QEMU as an ivshmem client*
-
-At initialisation, when creating the ivshmem device, QEMU first receives a
-protocol version and closes communication with server if it does not match.
-Then, QEMU gets its ID from the server then makes it available through BAR0
-IVPosition register for the VM to use (see 'PCI device registers' subsection).
-QEMU then uses the fd to the shared memory to map it to BAR2.
-eventfds for all other clients received from the server are stored to implement
-BAR0 Doorbell register (see 'PCI device registers' subsection).
-Finally, eventfds assigned to this QEMU process are used to send interrupts in
-this VM.
-
-*PCI device registers*
-
-From the VM point of view, the ivshmem PCI device supports 4 registers of
-32-bits each.
-
-enum ivshmem_registers {
- IntrMask = 0,
- IntrStatus = 4,
- IVPosition = 8,
- Doorbell = 12
-};
-
-The first two registers are the interrupt mask and status registers. Mask and
-status are only used with pin-based interrupts. They are unused with MSI
-interrupts.
-
-Status Register: The status register is set to 1 when an interrupt occurs.
-
-Mask Register: The mask register is bitwise ANDed with the interrupt status
-and the result will raise an interrupt if it is non-zero. However, since 1 is
-the only value the status will be set to, it is only the first bit of the mask
-that has any effect. Therefore interrupts can be masked by setting the first
-bit to 0 and unmasked by setting the first bit to 1.
-
-IVPosition Register: The IVPosition register is read-only and reports the
-guest's ID number. The guest IDs are non-negative integers. When using the
-server, since the server is a separate process, the VM ID will only be set when
-the device is ready (shared memory is received from the server and accessible
-via the device). If the device is not ready, the IVPosition will return -1.
-Applications should ensure that they have a valid VM ID before accessing the
-shared memory.
-
-Doorbell Register: To interrupt another guest, a guest must write to the
-Doorbell register. The doorbell register is 32-bits, logically divided into
-two 16-bit fields. The high 16-bits are the guest ID to interrupt and the low
-16-bits are the interrupt vector to trigger. The semantics of the value
-written to the doorbell depends on whether the device is using MSI or a regular
-pin-based interrupt. In short, MSI uses vectors while regular interrupts set
-the status register.
-
-Regular Interrupts
-
-If regular interrupts are used (due to either a guest not supporting MSI or the
-user specifying not to use them on startup) then the value written to the lower
-16-bits of the Doorbell register results is arbitrary and will trigger an
-interrupt in the destination guest.
-
-Message Signalled Interrupts
-
-An ivshmem device may support multiple MSI vectors. If so, the lower 16-bits
-written to the Doorbell register must be between 0 and the maximum number of
-vectors the guest supports. The lower 16 bits written to the doorbell is the
-MSI vector that will be raised in the destination guest. The number of MSI
-vectors is configurable but it is set when the VM is started.
-
-The important thing to remember with MSI is that it is only a signal, no status
-is set (since MSI interrupts are not shared). All information other than the
-interrupt itself should be communicated via the shared memory region. Devices
-supporting multiple MSI vectors can use different vectors to indicate different
-events have occurred. The semantics of interrupt vectors are left to the
-user's discretion.
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 13/42] ivshmem: Add missing newlines to debug printfs
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (11 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 12/42] ivshmem: Rewrite specification document Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 14/42] ivshmem: Compile debug prints unconditionally to prevent bit-rot Markus Armbruster
` (30 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/misc/ivshmem.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 48b7a34..b74b02c 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -568,10 +568,10 @@ static void setup_interrupt(IVShmemState *s, int vector)
IVSHMEM_DPRINTF("setting up interrupt for vector: %d\n", vector);
if (!with_irqfd) {
- IVSHMEM_DPRINTF("with eventfd");
+ IVSHMEM_DPRINTF("with eventfd\n");
watch_vector_notifier(s, n, vector);
} else if (msix_enabled(pdev)) {
- IVSHMEM_DPRINTF("with irqfd");
+ IVSHMEM_DPRINTF("with irqfd\n");
if (ivshmem_add_kvm_msi_virq(s, vector) < 0) {
return;
}
@@ -582,7 +582,7 @@ static void setup_interrupt(IVShmemState *s, int vector)
}
} else {
/* it will be delayed until msix is enabled, in write_config */
- IVSHMEM_DPRINTF("with irqfd, delayed until msix enabled");
+ IVSHMEM_DPRINTF("with irqfd, delayed until msix enabled\n");
}
}
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 14/42] ivshmem: Compile debug prints unconditionally to prevent bit-rot
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (12 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 13/42] ivshmem: Add missing newlines to debug printfs Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 15/42] ivshmem: Clean up after commit 9940c32 Markus Armbruster
` (29 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/misc/ivshmem.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index b74b02c..395f357 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -48,13 +48,13 @@
#define IVSHMEM_REG_BAR_SIZE 0x100
-//#define DEBUG_IVSHMEM
-#ifdef DEBUG_IVSHMEM
-#define IVSHMEM_DPRINTF(fmt, ...) \
- do {printf("IVSHMEM: " fmt, ## __VA_ARGS__); } while (0)
-#else
-#define IVSHMEM_DPRINTF(fmt, ...)
-#endif
+#define IVSHMEM_DEBUG 0
+#define IVSHMEM_DPRINTF(fmt, ...) \
+ do { \
+ if (IVSHMEM_DEBUG) { \
+ printf("IVSHMEM: " fmt, ## __VA_ARGS__); \
+ } \
+ } while (0)
#define TYPE_IVSHMEM "ivshmem"
#define IVSHMEM(obj) \
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 15/42] ivshmem: Clean up after commit 9940c32
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (13 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 14/42] ivshmem: Compile debug prints unconditionally to prevent bit-rot Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 16/42] ivshmem: Drop ivshmem_event() stub Markus Armbruster
` (28 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
IVShmemState member eventfd_chr is useless since commit 9940c32. Drop
it.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/misc/ivshmem.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 395f357..b087dc3 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -79,7 +79,6 @@ typedef struct IVShmemState {
uint32_t intrmask;
uint32_t intrstatus;
- CharDriverState **eventfd_chr;
CharDriverState *server_chr;
Fifo8 incoming_fifo;
MemoryRegion ivshmem_mmio;
@@ -941,8 +940,6 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
pci_register_bar(dev, 2, attr, &s->bar);
- s->eventfd_chr = g_malloc0(s->vectors * sizeof(CharDriverState *));
-
qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive,
ivshmem_check_version, ivshmem_event, s);
} else {
@@ -1004,15 +1001,6 @@ static void pci_ivshmem_exit(PCIDevice *dev)
memory_region_del_subregion(&s->bar, &s->ivshmem);
}
- if (s->eventfd_chr) {
- for (i = 0; i < s->vectors; i++) {
- if (s->eventfd_chr[i]) {
- qemu_chr_free(s->eventfd_chr[i]);
- }
- }
- g_free(s->eventfd_chr);
- }
-
if (s->peers) {
for (i = 0; i < s->nb_peers; i++) {
close_peer_eventfds(s, i);
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 16/42] ivshmem: Drop ivshmem_event() stub
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (14 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 15/42] ivshmem: Clean up after commit 9940c32 Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 17/42] ivshmem: Don't destroy the chardev on version mismatch Markus Armbruster
` (27 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/misc/ivshmem.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index b087dc3..7119a07 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -267,11 +267,6 @@ static int ivshmem_can_receive(void * opaque)
return sizeof(int64_t);
}
-static void ivshmem_event(void *opaque, int event)
-{
- IVSHMEM_DPRINTF("ivshmem_event %d\n", event);
-}
-
static void ivshmem_vector_notify(void *opaque)
{
MSIVector *entry = opaque;
@@ -719,7 +714,7 @@ static void ivshmem_check_version(void *opaque, const uint8_t * buf, int size)
IVSHMEM_DPRINTF("version check ok, switch to real chardev handler\n");
qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive, ivshmem_read,
- ivshmem_event, s);
+ NULL, s);
}
/* Select the MSI-X vectors used by device.
@@ -941,7 +936,7 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
pci_register_bar(dev, 2, attr, &s->bar);
qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive,
- ivshmem_check_version, ivshmem_event, s);
+ ivshmem_check_version, NULL, s);
} else {
/* just map the file immediately, we're not using a server */
int fd;
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 17/42] ivshmem: Don't destroy the chardev on version mismatch
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (15 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 16/42] ivshmem: Drop ivshmem_event() stub Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 18/42] ivshmem: Fix harmless misuse of Error Markus Armbruster
` (26 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Yes, the chardev is commonly useless after we read a bad version from
it, but destroying it is inappropriate anyway: the user created it, so
the user should be able to hold on to it as long as he likes. We
don't destroy it on other errors. Screwed up in commit 5105b1d.
Stop reading instead.
Also note QEMU's behavior in ivshmem-spec.txt.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
docs/specs/ivshmem-spec.txt | 3 +++
hw/misc/ivshmem.c | 3 +--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/docs/specs/ivshmem-spec.txt b/docs/specs/ivshmem-spec.txt
index 0e9185a..0cd63ad 100644
--- a/docs/specs/ivshmem-spec.txt
+++ b/docs/specs/ivshmem-spec.txt
@@ -187,6 +187,9 @@ Each message consists of a single 8 byte little-endian signed number,
and may be accompanied by a file descriptor via SCM_RIGHTS. Both
client and server close the connection on error.
+Note: QEMU currently doesn't close the connection right on error, but
+only when the character device is destroyed.
+
On connect, the server sends the following messages in order:
1. The protocol version number, currently zero. The client should
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 7119a07..2850e8a 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -707,8 +707,7 @@ static void ivshmem_check_version(void *opaque, const uint8_t * buf, int size)
if (tmp != -1 || version != IVSHMEM_PROTOCOL_VERSION) {
fprintf(stderr, "incompatible version, you are connecting to a ivshmem-"
"server using a different protocol please check your setup\n");
- qemu_chr_delete(s->server_chr);
- s->server_chr = NULL;
+ qemu_chr_add_handlers(s->server_chr, NULL, NULL, NULL, s);
return;
}
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 18/42] ivshmem: Fix harmless misuse of Error
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (16 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 17/42] ivshmem: Don't destroy the chardev on version mismatch Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 19/42] ivshmem: Failed realize() can leave migration blocker behind Markus Armbruster
` (25 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
We reuse errp after passing it host_memory_backend_get_memory(). If
both host_memory_backend_get_memory() and the reuse set an error, the
reuse will fail the assertion in error_setv(). Fortunately,
host_memory_backend_get_memory() can't fail.
Pass it &error_abort to make our assumption explicit, and to get the
assertion failure in the right place should it become invalid.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/misc/ivshmem.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 2850e8a..eb53d9a 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -841,7 +841,7 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
g_warning("size argument ignored with hostmem");
}
- mr = host_memory_backend_get_memory(s->hostmem, errp);
+ mr = host_memory_backend_get_memory(s->hostmem, &error_abort);
s->ivshmem_size = memory_region_size(mr);
} else if (s->sizearg == NULL) {
s->ivshmem_size = 4 << 20; /* 4 MB default */
@@ -906,7 +906,8 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
IVSHMEM_DPRINTF("using hostmem\n");
- mr = host_memory_backend_get_memory(MEMORY_BACKEND(s->hostmem), errp);
+ mr = host_memory_backend_get_memory(MEMORY_BACKEND(s->hostmem),
+ &error_abort);
vmstate_register_ram(mr, DEVICE(s));
memory_region_add_subregion(&s->bar, 0, mr);
pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar);
@@ -1131,7 +1132,7 @@ static void ivshmem_check_memdev_is_busy(Object *obj, const char *name,
{
MemoryRegion *mr;
- mr = host_memory_backend_get_memory(MEMORY_BACKEND(val), errp);
+ mr = host_memory_backend_get_memory(MEMORY_BACKEND(val), &error_abort);
if (memory_region_is_mapped(mr)) {
char *path = object_get_canonical_path_component(val);
error_setg(errp, "can't use already busy memdev: %s", path);
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 19/42] ivshmem: Failed realize() can leave migration blocker behind
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (17 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 18/42] ivshmem: Fix harmless misuse of Error Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 20/42] ivshmem: Clean up register callbacks Markus Armbruster
` (24 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
If pci_ivshmem_realize() fails after it created its migration blocker,
the blocker is left in place. Fix that by creating it last.
Likewise, if it fails after it called fifo8_create(), it leaks fifo
memory. Fix that the same way.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/misc/ivshmem.c | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index eb53d9a..1392426 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -824,6 +824,7 @@ static void ivshmem_write_config(PCIDevice *pdev, uint32_t address,
static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
{
IVShmemState *s = IVSHMEM(dev);
+ Error *err = NULL;
uint8_t *pci_conf;
uint8_t attr = PCI_BASE_ADDRESS_SPACE_MEMORY |
PCI_BASE_ADDRESS_MEM_PREFETCH;
@@ -855,8 +856,6 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
s->ivshmem_size = size;
}
- fifo8_create(&s->incoming_fifo, sizeof(int64_t));
-
/* IRQFD requires MSI */
if (ivshmem_has_feature(s, IVSHMEM_IOEVENTFD) &&
!ivshmem_has_feature(s, IVSHMEM_MSI)) {
@@ -878,12 +877,6 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
s->role_val = IVSHMEM_MASTER; /* default */
}
- if (s->role_val == IVSHMEM_PEER) {
- error_setg(&s->migration_blocker,
- "Migration is disabled when using feature 'peer mode' in device 'ivshmem'");
- migrate_add_blocker(s->migration_blocker);
- }
-
pci_conf = dev->config;
pci_conf[PCI_COMMAND] = PCI_COMMAND_IO | PCI_COMMAND_MEMORY;
@@ -962,7 +955,19 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
return;
}
- create_shared_memory_BAR(s, fd, attr, errp);
+ create_shared_memory_BAR(s, fd, attr, &err);
+ if (err) {
+ error_propagate(errp, err);
+ return;
+ }
+ }
+
+ fifo8_create(&s->incoming_fifo, sizeof(int64_t));
+
+ if (s->role_val == IVSHMEM_PEER) {
+ error_setg(&s->migration_blocker,
+ "Migration is disabled when using feature 'peer mode' in device 'ivshmem'");
+ migrate_add_blocker(s->migration_blocker);
}
}
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 20/42] ivshmem: Clean up register callbacks
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (18 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 19/42] ivshmem: Failed realize() can leave migration blocker behind Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 21/42] ivshmem: Clean up MSI-X conditions Markus Armbruster
` (23 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/misc/ivshmem.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 1392426..7191914 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -121,12 +121,10 @@ static inline uint32_t ivshmem_has_feature(IVShmemState *ivs,
return (ivs->features & (1 << feature));
}
-/* accessing registers - based on rtl8139 */
static void ivshmem_update_irq(IVShmemState *s)
{
PCIDevice *d = PCI_DEVICE(s);
- int isr;
- isr = (s->intrstatus & s->intrmask) & 0xffffffff;
+ uint32_t isr = s->intrstatus & s->intrmask;
/* don't print ISR resets */
if (isr) {
@@ -134,7 +132,7 @@ static void ivshmem_update_irq(IVShmemState *s)
isr ? 1 : 0, s->intrstatus, s->intrmask);
}
- pci_set_irq(d, (isr != 0));
+ pci_set_irq(d, isr != 0);
}
static void ivshmem_IntrMask_write(IVShmemState *s, uint32_t val)
@@ -142,7 +140,6 @@ static void ivshmem_IntrMask_write(IVShmemState *s, uint32_t val)
IVSHMEM_DPRINTF("IntrMask write(w) val = 0x%04x\n", val);
s->intrmask = val;
-
ivshmem_update_irq(s);
}
@@ -151,7 +148,6 @@ static uint32_t ivshmem_IntrMask_read(IVShmemState *s)
uint32_t ret = s->intrmask;
IVSHMEM_DPRINTF("intrmask read(w) val = 0x%04x\n", ret);
-
return ret;
}
@@ -160,7 +156,6 @@ static void ivshmem_IntrStatus_write(IVShmemState *s, uint32_t val)
IVSHMEM_DPRINTF("IntrStatus write(w) val = 0x%04x\n", val);
s->intrstatus = val;
-
ivshmem_update_irq(s);
}
@@ -170,9 +165,7 @@ static uint32_t ivshmem_IntrStatus_read(IVShmemState *s)
/* reading ISR clears all interrupts */
s->intrstatus = 0;
-
ivshmem_update_irq(s);
-
return ret;
}
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 21/42] ivshmem: Clean up MSI-X conditions
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (19 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 20/42] ivshmem: Clean up register callbacks Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-09 12:45 ` Marc-André Lureau
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 22/42] ivshmem: Leave INTx alone when using MSI-X Markus Armbruster
` (22 subsequent siblings)
43 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
There are three predicates related to MSI-X:
* ivshmem_has_feature(s, IVSHMEM_MSI) is true unless the non-MSI-X
variant of the device is selected with msi=off.
* msix_present() is true when the device has the PCI capability MSI-X.
It's initially false, and becomes true during successful realize of
the MSI-X variant of the device. Thus, it's the same as
ivshmem_has_feature(s, IVSHMEM_MSI) for realized devices.
* msix_enabled() is true when msix_present() is true and guest software
has enabled MSI-X.
Code that differs between the non-MSI-X and the MSI-X variant of the
device needs to be guarded by ivshmem_has_feature(s, IVSHMEM_MSI) or
by msix_present(), except the latter works only for realized devices.
Code that depends on whether MSI-X is in use needs to be guarded with
msix_enabled().
Code review led me to two minor messes:
* ivshmem_vector_notify() calls msix_notify() even when
!msix_enabled(), unlike most other MSI-X-capable devices. As far as
I can tell, msix_notify() does nothing when !msix_enabled(). Add
the guard anyway.
* Most callers of ivshmem_use_msix() guard it with
ivshmem_has_feature(s, IVSHMEM_MSI). Not necessary, because
ivshmem_use_msix() does nothing when !msix_present(). That's
ivshmem's only use of msix_present(), though. Rename
ivshmem_use_msix() to ivshmem_vector_use(), replace msix_present()
by ivshmem_has_feature() there, and drop the redundant guards.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/misc/ivshmem.c | 22 +++++++++-------------
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 7191914..cfea151 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -274,7 +274,9 @@ static void ivshmem_vector_notify(void *opaque)
IVSHMEM_DPRINTF("interrupt on vector %p %d\n", pdev, vector);
if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
- msix_notify(pdev, vector);
+ if (msix_enabled(pdev)) {
+ msix_notify(pdev, vector);
+ }
} else {
ivshmem_IntrStatus_write(s, 1);
}
@@ -712,13 +714,12 @@ static void ivshmem_check_version(void *opaque, const uint8_t * buf, int size)
/* Select the MSI-X vectors used by device.
* ivshmem maps events to vectors statically, so
* we just enable all vectors on init and after reset. */
-static void ivshmem_use_msix(IVShmemState * s)
+static void ivshmem_vector_use(IVShmemState *s)
{
PCIDevice *d = PCI_DEVICE(s);
int i;
- IVSHMEM_DPRINTF("%s, msix present: %d\n", __func__, msix_present(d));
- if (!msix_present(d)) {
+ if (!ivshmem_has_feature(s, IVSHMEM_MSI)) {
return;
}
@@ -733,7 +734,7 @@ static void ivshmem_reset(DeviceState *d)
s->intrstatus = 0;
s->intrmask = 0;
- ivshmem_use_msix(s);
+ ivshmem_vector_use(s);
}
static int ivshmem_setup_interrupts(IVShmemState *s)
@@ -747,9 +748,9 @@ static int ivshmem_setup_interrupts(IVShmemState *s)
}
IVSHMEM_DPRINTF("msix initialized (%d vectors)\n", s->vectors);
- ivshmem_use_msix(s);
}
+ ivshmem_vector_use(s);
return 0;
}
@@ -1034,12 +1035,7 @@ static int ivshmem_pre_load(void *opaque)
static int ivshmem_post_load(void *opaque, int version_id)
{
- IVShmemState *s = opaque;
-
- if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
- ivshmem_use_msix(s);
- }
-
+ ivshmem_vector_use(opaque);
return 0;
}
@@ -1067,11 +1063,11 @@ static int ivshmem_load_old(QEMUFile *f, void *opaque, int version_id)
if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
msix_load(pdev, f);
- ivshmem_use_msix(s);
} else {
s->intrstatus = qemu_get_be32(f);
s->intrmask = qemu_get_be32(f);
}
+ ivshmem_vector_use(s);
return 0;
}
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 21/42] ivshmem: Clean up MSI-X conditions
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 21/42] ivshmem: Clean up MSI-X conditions Markus Armbruster
@ 2016-03-09 12:45 ` Marc-André Lureau
2016-03-09 20:15 ` Markus Armbruster
0 siblings, 1 reply; 74+ messages in thread
From: Marc-André Lureau @ 2016-03-09 12:45 UTC (permalink / raw)
To: Markus Armbruster
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
Hi
On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
> There are three predicates related to MSI-X:
>
> * ivshmem_has_feature(s, IVSHMEM_MSI) is true unless the non-MSI-X
> variant of the device is selected with msi=off.
>
> * msix_present() is true when the device has the PCI capability MSI-X.
> It's initially false, and becomes true during successful realize of
> the MSI-X variant of the device. Thus, it's the same as
> ivshmem_has_feature(s, IVSHMEM_MSI) for realized devices.
>
> * msix_enabled() is true when msix_present() is true and guest software
> has enabled MSI-X.
>
> Code that differs between the non-MSI-X and the MSI-X variant of the
> device needs to be guarded by ivshmem_has_feature(s, IVSHMEM_MSI) or
> by msix_present(), except the latter works only for realized devices.
>
> Code that depends on whether MSI-X is in use needs to be guarded with
> msix_enabled().
>
> Code review led me to two minor messes:
>
> * ivshmem_vector_notify() calls msix_notify() even when
> !msix_enabled(), unlike most other MSI-X-capable devices. As far as
> I can tell, msix_notify() does nothing when !msix_enabled(). Add
> the guard anyway.
>
> * Most callers of ivshmem_use_msix() guard it with
> ivshmem_has_feature(s, IVSHMEM_MSI). Not necessary, because
> ivshmem_use_msix() does nothing when !msix_present(). That's
> ivshmem's only use of msix_present(), though. Rename
> ivshmem_use_msix() to ivshmem_vector_use(), replace msix_present()
> by ivshmem_has_feature() there, and drop the redundant guards.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/misc/ivshmem.c | 22 +++++++++-------------
> 1 file changed, 9 insertions(+), 13 deletions(-)
>
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index 7191914..cfea151 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -274,7 +274,9 @@ static void ivshmem_vector_notify(void *opaque)
>
> IVSHMEM_DPRINTF("interrupt on vector %p %d\n", pdev, vector);
> if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
> - msix_notify(pdev, vector);
> + if (msix_enabled(pdev)) {
> + msix_notify(pdev, vector);
> + }
> } else {
> ivshmem_IntrStatus_write(s, 1);
> }
> @@ -712,13 +714,12 @@ static void ivshmem_check_version(void *opaque, const uint8_t * buf, int size)
> /* Select the MSI-X vectors used by device.
> * ivshmem maps events to vectors statically, so
> * we just enable all vectors on init and after reset. */
> -static void ivshmem_use_msix(IVShmemState * s)
> +static void ivshmem_vector_use(IVShmemState *s)
> {
> PCIDevice *d = PCI_DEVICE(s);
> int i;
>
> - IVSHMEM_DPRINTF("%s, msix present: %d\n", __func__, msix_present(d));
> - if (!msix_present(d)) {
> + if (!ivshmem_has_feature(s, IVSHMEM_MSI)) {
> return;
> }
>
> @@ -733,7 +734,7 @@ static void ivshmem_reset(DeviceState *d)
>
> s->intrstatus = 0;
> s->intrmask = 0;
> - ivshmem_use_msix(s);
> + ivshmem_vector_use(s);
> }
>
> static int ivshmem_setup_interrupts(IVShmemState *s)
> @@ -747,9 +748,9 @@ static int ivshmem_setup_interrupts(IVShmemState *s)
> }
>
> IVSHMEM_DPRINTF("msix initialized (%d vectors)\n", s->vectors);
> - ivshmem_use_msix(s);
> }
>
> + ivshmem_vector_use(s);
> return 0;
> }
>
> @@ -1034,12 +1035,7 @@ static int ivshmem_pre_load(void *opaque)
>
> static int ivshmem_post_load(void *opaque, int version_id)
> {
> - IVShmemState *s = opaque;
> -
> - if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
> - ivshmem_use_msix(s);
> - }
> -
> + ivshmem_vector_use(opaque);
> return 0;
> }
>
> @@ -1067,11 +1063,11 @@ static int ivshmem_load_old(QEMUFile *f, void *opaque, int version_id)
>
> if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
> msix_load(pdev, f);
> - ivshmem_use_msix(s);
> } else {
> s->intrstatus = qemu_get_be32(f);
> s->intrmask = qemu_get_be32(f);
> }
> + ivshmem_vector_use(s);
>
Sorry I didn't reply to your previous mail (which was slightly
confusing due to wrong naming), yes I think calling it
ivshmem_msix_vectors_use() inside the msix block is better (#2 from
your reply).
Other than that
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 21/42] ivshmem: Clean up MSI-X conditions
2016-03-09 12:45 ` Marc-André Lureau
@ 2016-03-09 20:15 ` Markus Armbruster
0 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-09 20:15 UTC (permalink / raw)
To: Marc-André Lureau
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
Marc-André Lureau <marcandre.lureau@gmail.com> writes:
> Hi
>
> On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
>> There are three predicates related to MSI-X:
>>
>> * ivshmem_has_feature(s, IVSHMEM_MSI) is true unless the non-MSI-X
>> variant of the device is selected with msi=off.
>>
>> * msix_present() is true when the device has the PCI capability MSI-X.
>> It's initially false, and becomes true during successful realize of
>> the MSI-X variant of the device. Thus, it's the same as
>> ivshmem_has_feature(s, IVSHMEM_MSI) for realized devices.
>>
>> * msix_enabled() is true when msix_present() is true and guest software
>> has enabled MSI-X.
>>
>> Code that differs between the non-MSI-X and the MSI-X variant of the
>> device needs to be guarded by ivshmem_has_feature(s, IVSHMEM_MSI) or
>> by msix_present(), except the latter works only for realized devices.
>>
>> Code that depends on whether MSI-X is in use needs to be guarded with
>> msix_enabled().
>>
>> Code review led me to two minor messes:
>>
>> * ivshmem_vector_notify() calls msix_notify() even when
>> !msix_enabled(), unlike most other MSI-X-capable devices. As far as
>> I can tell, msix_notify() does nothing when !msix_enabled(). Add
>> the guard anyway.
>>
>> * Most callers of ivshmem_use_msix() guard it with
>> ivshmem_has_feature(s, IVSHMEM_MSI). Not necessary, because
>> ivshmem_use_msix() does nothing when !msix_present(). That's
>> ivshmem's only use of msix_present(), though. Rename
>> ivshmem_use_msix() to ivshmem_vector_use(), replace msix_present()
>> by ivshmem_has_feature() there, and drop the redundant guards.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> hw/misc/ivshmem.c | 22 +++++++++-------------
>> 1 file changed, 9 insertions(+), 13 deletions(-)
>>
>> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
>> index 7191914..cfea151 100644
>> --- a/hw/misc/ivshmem.c
>> +++ b/hw/misc/ivshmem.c
>> @@ -274,7 +274,9 @@ static void ivshmem_vector_notify(void *opaque)
>>
>> IVSHMEM_DPRINTF("interrupt on vector %p %d\n", pdev, vector);
>> if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
>> - msix_notify(pdev, vector);
>> + if (msix_enabled(pdev)) {
>> + msix_notify(pdev, vector);
>> + }
>> } else {
>> ivshmem_IntrStatus_write(s, 1);
>> }
>> @@ -712,13 +714,12 @@ static void ivshmem_check_version(void *opaque, const uint8_t * buf, int size)
>> /* Select the MSI-X vectors used by device.
>> * ivshmem maps events to vectors statically, so
>> * we just enable all vectors on init and after reset. */
>> -static void ivshmem_use_msix(IVShmemState * s)
>> +static void ivshmem_vector_use(IVShmemState *s)
>> {
>> PCIDevice *d = PCI_DEVICE(s);
>> int i;
>>
>> - IVSHMEM_DPRINTF("%s, msix present: %d\n", __func__, msix_present(d));
>> - if (!msix_present(d)) {
>> + if (!ivshmem_has_feature(s, IVSHMEM_MSI)) {
>> return;
>> }
>>
>> @@ -733,7 +734,7 @@ static void ivshmem_reset(DeviceState *d)
>>
>> s->intrstatus = 0;
>> s->intrmask = 0;
>> - ivshmem_use_msix(s);
>> + ivshmem_vector_use(s);
>> }
>>
>> static int ivshmem_setup_interrupts(IVShmemState *s)
>> @@ -747,9 +748,9 @@ static int ivshmem_setup_interrupts(IVShmemState *s)
>> }
>>
>> IVSHMEM_DPRINTF("msix initialized (%d vectors)\n", s->vectors);
>> - ivshmem_use_msix(s);
>> }
>>
>> + ivshmem_vector_use(s);
>> return 0;
>> }
>>
>> @@ -1034,12 +1035,7 @@ static int ivshmem_pre_load(void *opaque)
>>
>> static int ivshmem_post_load(void *opaque, int version_id)
>> {
>> - IVShmemState *s = opaque;
>> -
>> - if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
>> - ivshmem_use_msix(s);
>> - }
>> -
>> + ivshmem_vector_use(opaque);
>> return 0;
>> }
>>
>> @@ -1067,11 +1063,11 @@ static int ivshmem_load_old(QEMUFile *f, void *opaque, int version_id)
>>
>> if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
>> msix_load(pdev, f);
>> - ivshmem_use_msix(s);
>> } else {
>> s->intrstatus = qemu_get_be32(f);
>> s->intrmask = qemu_get_be32(f);
>> }
>> + ivshmem_vector_use(s);
>>
>
> Sorry I didn't reply to your previous mail (which was slightly
> confusing due to wrong naming), yes I think calling it
> ivshmem_msix_vectors_use() inside the msix block is better (#2 from
> your reply).
I'll give it a try and see how it comes out.
> Other than that
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Thanks!
^ permalink raw reply [flat|nested] 74+ messages in thread
* [Qemu-devel] [PATCH v2 22/42] ivshmem: Leave INTx alone when using MSI-X
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (20 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 21/42] ivshmem: Clean up MSI-X conditions Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-09 12:45 ` Marc-André Lureau
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 23/42] ivshmem: Assert interrupts are set up once Markus Armbruster
` (21 subsequent siblings)
43 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
The ivshmem device can either use MSI-X or legacy INTx for interrupts.
With MSI-X enabled, peer interrupt events trigger an MSI as they
should. But software can still raise INTx via interrupt status and
mask register in BAR 0. This is explicitly prohibited by PCI Local
Bus Specification Revision 3.0, section 6.8.3.3:
While enabled for MSI or MSI-X operation, a function is prohibited
from using its INTx# pin (if implemented) to request service (MSI,
MSI-X, and INTx# are mutually exclusive).
Fix the device model to leave INTx alone when using MSI-X.
Document that we claim to use INTx in config space even when we don't.
Unlike other devices, ivshmem does *not* use INTx when configured for
MSI-X and MSI-X isn't enabled by software.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/misc/ivshmem.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index cfea151..fc37feb 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -126,6 +126,11 @@ static void ivshmem_update_irq(IVShmemState *s)
PCIDevice *d = PCI_DEVICE(s);
uint32_t isr = s->intrstatus & s->intrmask;
+ /* No INTx with msi=off, whether the guest enabled MSI-X or not */
+ if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
+ return;
+ }
+
/* don't print ISR resets */
if (isr) {
IVSHMEM_DPRINTF("Set IRQ to %d (%04x %04x)\n",
@@ -874,6 +879,10 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
pci_conf = dev->config;
pci_conf[PCI_COMMAND] = PCI_COMMAND_IO | PCI_COMMAND_MEMORY;
+ /*
+ * Note: we don't use INTx with IVSHMEM_MSI at all, so this is a
+ * bald-faced lie then. But it's a backwards compatible lie.
+ */
pci_config_set_interrupt_pin(pci_conf, 1);
memory_region_init_io(&s->ivshmem_mmio, OBJECT(s), &ivshmem_mmio_ops, s,
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 22/42] ivshmem: Leave INTx alone when using MSI-X
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 22/42] ivshmem: Leave INTx alone when using MSI-X Markus Armbruster
@ 2016-03-09 12:45 ` Marc-André Lureau
2016-03-09 20:16 ` Markus Armbruster
0 siblings, 1 reply; 74+ messages in thread
From: Marc-André Lureau @ 2016-03-09 12:45 UTC (permalink / raw)
To: Markus Armbruster
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
Hi
On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
> The ivshmem device can either use MSI-X or legacy INTx for interrupts.
>
> With MSI-X enabled, peer interrupt events trigger an MSI as they
> should. But software can still raise INTx via interrupt status and
> mask register in BAR 0. This is explicitly prohibited by PCI Local
> Bus Specification Revision 3.0, section 6.8.3.3:
>
> While enabled for MSI or MSI-X operation, a function is prohibited
> from using its INTx# pin (if implemented) to request service (MSI,
> MSI-X, and INTx# are mutually exclusive).
>
> Fix the device model to leave INTx alone when using MSI-X.
>
> Document that we claim to use INTx in config space even when we don't.
> Unlike other devices, ivshmem does *not* use INTx when configured for
> MSI-X and MSI-X isn't enabled by software.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/misc/ivshmem.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index cfea151..fc37feb 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -126,6 +126,11 @@ static void ivshmem_update_irq(IVShmemState *s)
> PCIDevice *d = PCI_DEVICE(s);
> uint32_t isr = s->intrstatus & s->intrmask;
>
> + /* No INTx with msi=off, whether the guest enabled MSI-X or not */
> + if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
> + return;
So you probably mean msi=on
with that
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> + }
> +
> /* don't print ISR resets */
> if (isr) {
> IVSHMEM_DPRINTF("Set IRQ to %d (%04x %04x)\n",
> @@ -874,6 +879,10 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
> pci_conf = dev->config;
> pci_conf[PCI_COMMAND] = PCI_COMMAND_IO | PCI_COMMAND_MEMORY;
>
> + /*
> + * Note: we don't use INTx with IVSHMEM_MSI at all, so this is a
> + * bald-faced lie then. But it's a backwards compatible lie.
> + */
> pci_config_set_interrupt_pin(pci_conf, 1);
>
> memory_region_init_io(&s->ivshmem_mmio, OBJECT(s), &ivshmem_mmio_ops, s,
> --
> 2.4.3
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 22/42] ivshmem: Leave INTx alone when using MSI-X
2016-03-09 12:45 ` Marc-André Lureau
@ 2016-03-09 20:16 ` Markus Armbruster
0 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-09 20:16 UTC (permalink / raw)
To: Marc-André Lureau
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
Marc-André Lureau <marcandre.lureau@gmail.com> writes:
> Hi
>
> On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
>> The ivshmem device can either use MSI-X or legacy INTx for interrupts.
>>
>> With MSI-X enabled, peer interrupt events trigger an MSI as they
>> should. But software can still raise INTx via interrupt status and
>> mask register in BAR 0. This is explicitly prohibited by PCI Local
>> Bus Specification Revision 3.0, section 6.8.3.3:
>>
>> While enabled for MSI or MSI-X operation, a function is prohibited
>> from using its INTx# pin (if implemented) to request service (MSI,
>> MSI-X, and INTx# are mutually exclusive).
>>
>> Fix the device model to leave INTx alone when using MSI-X.
>>
>> Document that we claim to use INTx in config space even when we don't.
>> Unlike other devices, ivshmem does *not* use INTx when configured for
>> MSI-X and MSI-X isn't enabled by software.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> hw/misc/ivshmem.c | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
>> index cfea151..fc37feb 100644
>> --- a/hw/misc/ivshmem.c
>> +++ b/hw/misc/ivshmem.c
>> @@ -126,6 +126,11 @@ static void ivshmem_update_irq(IVShmemState *s)
>> PCIDevice *d = PCI_DEVICE(s);
>> uint32_t isr = s->intrstatus & s->intrmask;
>>
>> + /* No INTx with msi=off, whether the guest enabled MSI-X or not */
>> + if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
>> + return;
>
> So you probably mean msi=on
You're right.
> with that
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Thanks!
[...]
^ permalink raw reply [flat|nested] 74+ messages in thread
* [Qemu-devel] [PATCH v2 23/42] ivshmem: Assert interrupts are set up once
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (21 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 22/42] ivshmem: Leave INTx alone when using MSI-X Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 24/42] ivshmem: Simplify rejection of invalid peer ID from server Markus Armbruster
` (20 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
An interrupt is set up when the interrupt's file descriptor is
received. Each message applies to the next interrupt vector.
Therefore, each vector cannot be set up more than once.
ivshmem_add_kvm_msi_virq() half-heartedly tries not to rely on this by
doing nothing then, but that's not going to recover from this error
should it become possible in the future. watch_vector_notifier()
doesn't even try.
Simply assert what is the case, so we get alerted if we ever screw it
up.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/misc/ivshmem.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index fc37feb..9d2209d 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -349,7 +349,7 @@ static void watch_vector_notifier(IVShmemState *s, EventNotifier *n,
{
int eventfd = event_notifier_get_fd(n);
- /* if MSI is supported we need multiple interrupts */
+ assert(!s->msi_vectors[vector].pdev);
s->msi_vectors[vector].pdev = PCI_DEVICE(s);
qemu_set_fd_handler(eventfd, ivshmem_vector_notify,
@@ -535,10 +535,7 @@ static int ivshmem_add_kvm_msi_virq(IVShmemState *s, int vector)
int ret;
IVSHMEM_DPRINTF("ivshmem_add_kvm_msi_virq vector:%d\n", vector);
-
- if (s->msi_vectors[vector].pdev != NULL) {
- return 0;
- }
+ assert(!s->msi_vectors[vector].pdev);
ret = kvm_irqchip_add_msi_route(kvm_state, msg, pdev);
if (ret < 0) {
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 24/42] ivshmem: Simplify rejection of invalid peer ID from server
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (22 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 23/42] ivshmem: Assert interrupts are set up once Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 25/42] ivshmem: Disentangle ivshmem_read() Markus Armbruster
` (19 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
ivshmem_read() processes server messages. These are 64 bit signed
integers. -1 is shared memory setup, 16 bit unsigned is a peer ID,
anything else is invalid.
ivshmem_read() rejects invalid negative messages right away, silently.
Invalid positive messages get rejected only in resize_peers(), and
ivshmem_read() then prints the rather cryptic message "failed to
resize peers array".
Extend the first check to cover all invalid messages, make it report
"server sent invalid message", and drop the second check.
Now resize_peers() can't fail anymore; simplify.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/misc/ivshmem.c | 61 ++++++++++++++++++++-----------------------------------
1 file changed, 22 insertions(+), 39 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 9d2209d..5d33be4 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -39,7 +39,7 @@
#define PCI_VENDOR_ID_IVSHMEM PCI_VENDOR_ID_REDHAT_QUMRANET
#define PCI_DEVICE_ID_IVSHMEM 0x1110
-#define IVSHMEM_MAX_PEERS G_MAXUINT16
+#define IVSHMEM_MAX_PEERS UINT16_MAX
#define IVSHMEM_IOEVENTFD 0
#define IVSHMEM_MSI 1
@@ -93,7 +93,7 @@ typedef struct IVShmemState {
uint32_t ivshmem_64bit;
Peer *peers;
- int nb_peers; /* how many peers we have space for */
+ int nb_peers; /* space in @peers[] */
int vm_id;
uint32_t vectors;
@@ -451,34 +451,21 @@ static void close_peer_eventfds(IVShmemState *s, int posn)
s->peers[posn].nb_eventfds = 0;
}
-/* this function increase the dynamic storage need to store data about other
- * peers */
-static int resize_peers(IVShmemState *s, int new_min_size)
+static void resize_peers(IVShmemState *s, int nb_peers)
{
+ int old_nb_peers = s->nb_peers;
+ int i;
- int j, old_size;
+ assert(nb_peers > old_nb_peers);
+ IVSHMEM_DPRINTF("bumping storage to %d peers\n", nb_peers);
- /* limit number of max peers */
- if (new_min_size <= 0 || new_min_size > IVSHMEM_MAX_PEERS) {
- return -1;
- }
- if (new_min_size <= s->nb_peers) {
- return 0;
- }
-
- old_size = s->nb_peers;
- s->nb_peers = new_min_size;
+ s->peers = g_realloc(s->peers, nb_peers * sizeof(Peer));
+ s->nb_peers = nb_peers;
- IVSHMEM_DPRINTF("bumping storage to %d peers\n", s->nb_peers);
-
- s->peers = g_realloc(s->peers, s->nb_peers * sizeof(Peer));
-
- for (j = old_size; j < s->nb_peers; j++) {
- s->peers[j].eventfds = g_new0(EventNotifier, s->vectors);
- s->peers[j].nb_eventfds = 0;
+ for (i = old_nb_peers; i < nb_peers; i++) {
+ s->peers[i].eventfds = g_new0(EventNotifier, s->vectors);
+ s->peers[i].nb_eventfds = 0;
}
-
- return 0;
}
static bool fifo_update_and_get(IVShmemState *s, const uint8_t *buf, int size,
@@ -590,25 +577,21 @@ static void ivshmem_read(void *opaque, const uint8_t *buf, int size)
return;
}
- if (incoming_posn < -1) {
- IVSHMEM_DPRINTF("invalid incoming_posn %" PRId64 "\n", incoming_posn);
- return;
- }
-
- /* pick off s->server_chr->msgfd and store it, posn should accompany msg */
incoming_fd = qemu_chr_fe_get_msgfd(s->server_chr);
IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n",
incoming_posn, incoming_fd);
- /* make sure we have enough space for this peer */
+ if (incoming_posn < -1 || incoming_posn > IVSHMEM_MAX_PEERS) {
+ error_report("server sent invalid message %" PRId64,
+ incoming_posn);
+ if (incoming_fd != -1) {
+ close(incoming_fd);
+ }
+ return;
+ }
+
if (incoming_posn >= s->nb_peers) {
- if (resize_peers(s, incoming_posn + 1) < 0) {
- error_report("failed to resize peers array");
- if (incoming_fd != -1) {
- close(incoming_fd);
- }
- return;
- }
+ resize_peers(s, incoming_posn + 1);
}
peer = &s->peers[incoming_posn];
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 25/42] ivshmem: Disentangle ivshmem_read()
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (23 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 24/42] ivshmem: Simplify rejection of invalid peer ID from server Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-09 12:45 ` Marc-André Lureau
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 26/42] ivshmem: Plug leaks on unplug, fix peer disconnect Markus Armbruster
` (18 subsequent siblings)
43 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/misc/ivshmem.c | 172 +++++++++++++++++++++++++++---------------------------
1 file changed, 87 insertions(+), 85 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 5d33be4..e568263 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -564,115 +564,117 @@ static void setup_interrupt(IVShmemState *s, int vector)
}
}
-static void ivshmem_read(void *opaque, const uint8_t *buf, int size)
+static void process_msg_shmem(IVShmemState *s, int fd)
{
- IVShmemState *s = opaque;
- int incoming_fd;
- int new_eventfd;
- int64_t incoming_posn;
Error *err = NULL;
- Peer *peer;
+ void *ptr;
- if (!fifo_update_and_get_i64(s, buf, size, &incoming_posn)) {
+ if (memory_region_is_mapped(&s->ivshmem)) {
+ error_report("shm already initialized");
+ close(fd);
return;
}
- incoming_fd = qemu_chr_fe_get_msgfd(s->server_chr);
- IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n",
- incoming_posn, incoming_fd);
-
- if (incoming_posn < -1 || incoming_posn > IVSHMEM_MAX_PEERS) {
- error_report("server sent invalid message %" PRId64,
- incoming_posn);
- if (incoming_fd != -1) {
- close(incoming_fd);
- }
- return;
- }
-
- if (incoming_posn >= s->nb_peers) {
- resize_peers(s, incoming_posn + 1);
- }
-
- peer = &s->peers[incoming_posn];
-
- if (incoming_fd == -1) {
- /* if posn is positive and unseen before then this is our posn*/
- if (incoming_posn >= 0 && s->vm_id == -1) {
- /* receive our posn */
- s->vm_id = incoming_posn;
- } else {
- /* otherwise an fd == -1 means an existing peer has gone away */
- IVSHMEM_DPRINTF("posn %" PRId64 " has gone away\n", incoming_posn);
- close_peer_eventfds(s, incoming_posn);
- }
+ if (check_shm_size(s, fd, &err) == -1) {
+ error_report_err(err);
+ close(fd);
return;
}
- /* if the position is -1, then it's shared memory region fd */
- if (incoming_posn == -1) {
- void * map_ptr;
-
- if (memory_region_is_mapped(&s->ivshmem)) {
- error_report("shm already initialized");
- close(incoming_fd);
- return;
- }
-
- if (check_shm_size(s, incoming_fd, &err) == -1) {
- error_report_err(err);
- close(incoming_fd);
- return;
- }
-
- /* mmap the region and map into the BAR2 */
- map_ptr = mmap(0, s->ivshmem_size, PROT_READ|PROT_WRITE, MAP_SHARED,
- incoming_fd, 0);
- if (map_ptr == MAP_FAILED) {
- error_report("Failed to mmap shared memory %s", strerror(errno));
- close(incoming_fd);
- return;
- }
- memory_region_init_ram_ptr(&s->ivshmem, OBJECT(s),
- "ivshmem.bar2", s->ivshmem_size, map_ptr);
- qemu_set_ram_fd(s->ivshmem.ram_addr, incoming_fd);
- vmstate_register_ram(&s->ivshmem, DEVICE(s));
-
- IVSHMEM_DPRINTF("guest h/w addr = %p, size = %" PRIu64 "\n",
- map_ptr, s->ivshmem_size);
-
- memory_region_add_subregion(&s->bar, 0, &s->ivshmem);
-
+ /* mmap the region and map into the BAR2 */
+ ptr = mmap(0, s->ivshmem_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
+ if (ptr == MAP_FAILED) {
+ error_report("Failed to mmap shared memory %s", strerror(errno));
+ close(fd);
return;
}
-
- /* each peer has an associated array of eventfds, and we keep
- * track of how many eventfds received so far */
- /* get a new eventfd: */
+ memory_region_init_ram_ptr(&s->ivshmem, OBJECT(s),
+ "ivshmem.bar2", s->ivshmem_size, ptr);
+ qemu_set_ram_fd(s->ivshmem.ram_addr, fd);
+ vmstate_register_ram(&s->ivshmem, DEVICE(s));
+ memory_region_add_subregion(&s->bar, 0, &s->ivshmem);
+}
+
+static void process_msg_disconnect(IVShmemState *s, uint16_t posn)
+{
+ IVSHMEM_DPRINTF("posn %d has gone away\n", posn);
+ close_peer_eventfds(s, posn);
+}
+
+static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd)
+{
+ Peer *peer = &s->peers[posn];
+ int vector;
+
+ /*
+ * The N-th connect message for this peer comes with the file
+ * descriptor for vector N-1. Count messages to find the vector.
+ */
if (peer->nb_eventfds >= s->vectors) {
error_report("Too many eventfd received, device has %d vectors",
s->vectors);
- close(incoming_fd);
+ close(fd);
return;
}
+ vector = peer->nb_eventfds++;
- new_eventfd = peer->nb_eventfds++;
+ IVSHMEM_DPRINTF("eventfds[%d][%d] = %d\n", posn, vector, fd);
+ event_notifier_init_fd(&peer->eventfds[vector], fd);
+ fcntl_setfl(fd, O_NONBLOCK); /* msix/irqfd poll non block */
- /* this is an eventfd for a particular peer VM */
- IVSHMEM_DPRINTF("eventfds[%" PRId64 "][%d] = %d\n", incoming_posn,
- new_eventfd, incoming_fd);
- event_notifier_init_fd(&peer->eventfds[new_eventfd], incoming_fd);
- fcntl_setfl(incoming_fd, O_NONBLOCK); /* msix/irqfd poll non block */
-
- if (incoming_posn == s->vm_id) {
- setup_interrupt(s, new_eventfd);
+ if (posn == s->vm_id) {
+ setup_interrupt(s, vector);
}
if (ivshmem_has_feature(s, IVSHMEM_IOEVENTFD)) {
- ivshmem_add_eventfd(s, incoming_posn, new_eventfd);
+ ivshmem_add_eventfd(s, posn, vector);
}
}
+static void process_msg(IVShmemState *s, int64_t msg, int fd)
+{
+ IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n", msg, fd);
+
+ if (msg < -1 || msg > IVSHMEM_MAX_PEERS) {
+ error_report("server sent invalid message %" PRId64, msg);
+ close(fd);
+ return;
+ }
+
+ if (msg == -1) {
+ process_msg_shmem(s, fd);
+ return;
+ }
+
+ if (msg >= s->nb_peers) {
+ resize_peers(s, msg + 1);
+ }
+
+ if (fd >= 0) {
+ process_msg_connect(s, msg, fd);
+ } else if (s->vm_id == -1) {
+ s->vm_id = msg;
+ } else {
+ process_msg_disconnect(s, msg);
+ }
+}
+
+static void ivshmem_read(void *opaque, const uint8_t *buf, int size)
+{
+ IVShmemState *s = opaque;
+ int fd;
+ int64_t msg;
+
+ if (!fifo_update_and_get_i64(s, buf, size, &msg)) {
+ return;
+ }
+
+ fd = qemu_chr_fe_get_msgfd(s->server_chr);
+ IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n", msg, fd);
+
+ process_msg(s, msg, fd);
+}
+
static void ivshmem_check_version(void *opaque, const uint8_t * buf, int size)
{
IVShmemState *s = opaque;
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 25/42] ivshmem: Disentangle ivshmem_read()
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 25/42] ivshmem: Disentangle ivshmem_read() Markus Armbruster
@ 2016-03-09 12:45 ` Marc-André Lureau
0 siblings, 0 replies; 74+ messages in thread
From: Marc-André Lureau @ 2016-03-09 12:45 UTC (permalink / raw)
To: Markus Armbruster
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> hw/misc/ivshmem.c | 172 +++++++++++++++++++++++++++---------------------------
> 1 file changed, 87 insertions(+), 85 deletions(-)
>
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index 5d33be4..e568263 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -564,115 +564,117 @@ static void setup_interrupt(IVShmemState *s, int vector)
> }
> }
>
> -static void ivshmem_read(void *opaque, const uint8_t *buf, int size)
> +static void process_msg_shmem(IVShmemState *s, int fd)
> {
> - IVShmemState *s = opaque;
> - int incoming_fd;
> - int new_eventfd;
> - int64_t incoming_posn;
> Error *err = NULL;
> - Peer *peer;
> + void *ptr;
>
> - if (!fifo_update_and_get_i64(s, buf, size, &incoming_posn)) {
> + if (memory_region_is_mapped(&s->ivshmem)) {
> + error_report("shm already initialized");
> + close(fd);
> return;
> }
>
> - incoming_fd = qemu_chr_fe_get_msgfd(s->server_chr);
> - IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n",
> - incoming_posn, incoming_fd);
> -
> - if (incoming_posn < -1 || incoming_posn > IVSHMEM_MAX_PEERS) {
> - error_report("server sent invalid message %" PRId64,
> - incoming_posn);
> - if (incoming_fd != -1) {
> - close(incoming_fd);
> - }
> - return;
> - }
> -
> - if (incoming_posn >= s->nb_peers) {
> - resize_peers(s, incoming_posn + 1);
> - }
> -
> - peer = &s->peers[incoming_posn];
> -
> - if (incoming_fd == -1) {
> - /* if posn is positive and unseen before then this is our posn*/
> - if (incoming_posn >= 0 && s->vm_id == -1) {
> - /* receive our posn */
> - s->vm_id = incoming_posn;
> - } else {
> - /* otherwise an fd == -1 means an existing peer has gone away */
> - IVSHMEM_DPRINTF("posn %" PRId64 " has gone away\n", incoming_posn);
> - close_peer_eventfds(s, incoming_posn);
> - }
> + if (check_shm_size(s, fd, &err) == -1) {
> + error_report_err(err);
> + close(fd);
> return;
> }
>
> - /* if the position is -1, then it's shared memory region fd */
> - if (incoming_posn == -1) {
> - void * map_ptr;
> -
> - if (memory_region_is_mapped(&s->ivshmem)) {
> - error_report("shm already initialized");
> - close(incoming_fd);
> - return;
> - }
> -
> - if (check_shm_size(s, incoming_fd, &err) == -1) {
> - error_report_err(err);
> - close(incoming_fd);
> - return;
> - }
> -
> - /* mmap the region and map into the BAR2 */
> - map_ptr = mmap(0, s->ivshmem_size, PROT_READ|PROT_WRITE, MAP_SHARED,
> - incoming_fd, 0);
> - if (map_ptr == MAP_FAILED) {
> - error_report("Failed to mmap shared memory %s", strerror(errno));
> - close(incoming_fd);
> - return;
> - }
> - memory_region_init_ram_ptr(&s->ivshmem, OBJECT(s),
> - "ivshmem.bar2", s->ivshmem_size, map_ptr);
> - qemu_set_ram_fd(s->ivshmem.ram_addr, incoming_fd);
> - vmstate_register_ram(&s->ivshmem, DEVICE(s));
> -
> - IVSHMEM_DPRINTF("guest h/w addr = %p, size = %" PRIu64 "\n",
> - map_ptr, s->ivshmem_size);
> -
> - memory_region_add_subregion(&s->bar, 0, &s->ivshmem);
> -
> + /* mmap the region and map into the BAR2 */
> + ptr = mmap(0, s->ivshmem_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
> + if (ptr == MAP_FAILED) {
> + error_report("Failed to mmap shared memory %s", strerror(errno));
> + close(fd);
> return;
> }
> -
> - /* each peer has an associated array of eventfds, and we keep
> - * track of how many eventfds received so far */
> - /* get a new eventfd: */
> + memory_region_init_ram_ptr(&s->ivshmem, OBJECT(s),
> + "ivshmem.bar2", s->ivshmem_size, ptr);
> + qemu_set_ram_fd(s->ivshmem.ram_addr, fd);
> + vmstate_register_ram(&s->ivshmem, DEVICE(s));
> + memory_region_add_subregion(&s->bar, 0, &s->ivshmem);
> +}
> +
> +static void process_msg_disconnect(IVShmemState *s, uint16_t posn)
> +{
> + IVSHMEM_DPRINTF("posn %d has gone away\n", posn);
> + close_peer_eventfds(s, posn);
> +}
> +
> +static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd)
> +{
> + Peer *peer = &s->peers[posn];
> + int vector;
> +
> + /*
> + * The N-th connect message for this peer comes with the file
> + * descriptor for vector N-1. Count messages to find the vector.
> + */
> if (peer->nb_eventfds >= s->vectors) {
> error_report("Too many eventfd received, device has %d vectors",
> s->vectors);
> - close(incoming_fd);
> + close(fd);
> return;
> }
> + vector = peer->nb_eventfds++;
>
> - new_eventfd = peer->nb_eventfds++;
> + IVSHMEM_DPRINTF("eventfds[%d][%d] = %d\n", posn, vector, fd);
> + event_notifier_init_fd(&peer->eventfds[vector], fd);
> + fcntl_setfl(fd, O_NONBLOCK); /* msix/irqfd poll non block */
>
> - /* this is an eventfd for a particular peer VM */
> - IVSHMEM_DPRINTF("eventfds[%" PRId64 "][%d] = %d\n", incoming_posn,
> - new_eventfd, incoming_fd);
> - event_notifier_init_fd(&peer->eventfds[new_eventfd], incoming_fd);
> - fcntl_setfl(incoming_fd, O_NONBLOCK); /* msix/irqfd poll non block */
> -
> - if (incoming_posn == s->vm_id) {
> - setup_interrupt(s, new_eventfd);
> + if (posn == s->vm_id) {
> + setup_interrupt(s, vector);
> }
>
> if (ivshmem_has_feature(s, IVSHMEM_IOEVENTFD)) {
> - ivshmem_add_eventfd(s, incoming_posn, new_eventfd);
> + ivshmem_add_eventfd(s, posn, vector);
> }
> }
>
> +static void process_msg(IVShmemState *s, int64_t msg, int fd)
> +{
> + IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n", msg, fd);
> +
> + if (msg < -1 || msg > IVSHMEM_MAX_PEERS) {
> + error_report("server sent invalid message %" PRId64, msg);
> + close(fd);
> + return;
> + }
> +
> + if (msg == -1) {
> + process_msg_shmem(s, fd);
> + return;
> + }
> +
> + if (msg >= s->nb_peers) {
> + resize_peers(s, msg + 1);
> + }
> +
> + if (fd >= 0) {
> + process_msg_connect(s, msg, fd);
> + } else if (s->vm_id == -1) {
> + s->vm_id = msg;
> + } else {
> + process_msg_disconnect(s, msg);
> + }
> +}
> +
> +static void ivshmem_read(void *opaque, const uint8_t *buf, int size)
> +{
> + IVShmemState *s = opaque;
> + int fd;
> + int64_t msg;
> +
> + if (!fifo_update_and_get_i64(s, buf, size, &msg)) {
> + return;
> + }
> +
> + fd = qemu_chr_fe_get_msgfd(s->server_chr);
> + IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n", msg, fd);
> +
> + process_msg(s, msg, fd);
> +}
> +
> static void ivshmem_check_version(void *opaque, const uint8_t * buf, int size)
> {
> IVShmemState *s = opaque;
> --
> 2.4.3
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 74+ messages in thread
* [Qemu-devel] [PATCH v2 26/42] ivshmem: Plug leaks on unplug, fix peer disconnect
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (24 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 25/42] ivshmem: Disentangle ivshmem_read() Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-09 12:45 ` Marc-André Lureau
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 27/42] ivshmem: Receive shared memory synchronously in realize() Markus Armbruster
` (17 subsequent siblings)
43 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
close_peer_eventfds() cleans up three things: ioeventfd triggers if
they exist, eventfds, and the array to store them.
Commit 98609cd (v1.2.0) fixed it not to clean up ioeventfd triggers
when they don't exist (property ioeventfd=off, which is the default).
Unfortunately, the fix also made it skip cleanup of the eventfds and
the array then. This is a memory and file descriptor leak on unplug.
Additionally, the reset of nb_eventfds is skipped. Doesn't matter on
unplug. On peer disconnect, however, this permanently wedges the
interrupt vectors used for that peer's ID. The eventfds stay behind,
but aren't connected to a peer anymore. When the ID gets recycled for
a new peer, the new peer's eventfds get assigned to vectors after the
old ones. Commonly, the device's number of vectors matches the
server's, so the new ones get dropped with a "Too many eventfd
received" message. Interrupts either don't work (common case) or go
to the wrong vector.
Fix by narrowing the conditional to just the ioeventfd trigger
cleanup.
While there, move the "invalid" peer check to the only caller where it
can actually happen, and tighten it to reject own ID.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/misc/ivshmem.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index e568263..2f2f43f 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -428,21 +428,17 @@ static void close_peer_eventfds(IVShmemState *s, int posn)
{
int i, n;
- if (!ivshmem_has_feature(s, IVSHMEM_IOEVENTFD)) {
- return;
- }
- if (posn < 0 || posn >= s->nb_peers) {
- error_report("invalid peer %d", posn);
- return;
- }
-
+ assert(posn >= 0 && posn < s->nb_peers);
n = s->peers[posn].nb_eventfds;
- memory_region_transaction_begin();
- for (i = 0; i < n; i++) {
- ivshmem_del_eventfd(s, posn, i);
+ if (ivshmem_has_feature(s, IVSHMEM_IOEVENTFD)) {
+ memory_region_transaction_begin();
+ for (i = 0; i < n; i++) {
+ ivshmem_del_eventfd(s, posn, i);
+ }
+ memory_region_transaction_commit();
}
- memory_region_transaction_commit();
+
for (i = 0; i < n; i++) {
event_notifier_cleanup(&s->peers[posn].eventfds[i]);
}
@@ -598,6 +594,10 @@ static void process_msg_shmem(IVShmemState *s, int fd)
static void process_msg_disconnect(IVShmemState *s, uint16_t posn)
{
IVSHMEM_DPRINTF("posn %d has gone away\n", posn);
+ if (posn >= s->nb_peers || posn == s->vm_id) {
+ error_report("invalid peer %d", posn);
+ return;
+ }
close_peer_eventfds(s, posn);
}
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 26/42] ivshmem: Plug leaks on unplug, fix peer disconnect
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 26/42] ivshmem: Plug leaks on unplug, fix peer disconnect Markus Armbruster
@ 2016-03-09 12:45 ` Marc-André Lureau
0 siblings, 0 replies; 74+ messages in thread
From: Marc-André Lureau @ 2016-03-09 12:45 UTC (permalink / raw)
To: Markus Armbruster
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
> close_peer_eventfds() cleans up three things: ioeventfd triggers if
> they exist, eventfds, and the array to store them.
>
> Commit 98609cd (v1.2.0) fixed it not to clean up ioeventfd triggers
> when they don't exist (property ioeventfd=off, which is the default).
> Unfortunately, the fix also made it skip cleanup of the eventfds and
> the array then. This is a memory and file descriptor leak on unplug.
>
> Additionally, the reset of nb_eventfds is skipped. Doesn't matter on
> unplug. On peer disconnect, however, this permanently wedges the
> interrupt vectors used for that peer's ID. The eventfds stay behind,
> but aren't connected to a peer anymore. When the ID gets recycled for
> a new peer, the new peer's eventfds get assigned to vectors after the
> old ones. Commonly, the device's number of vectors matches the
> server's, so the new ones get dropped with a "Too many eventfd
> received" message. Interrupts either don't work (common case) or go
> to the wrong vector.
>
> Fix by narrowing the conditional to just the ioeventfd trigger
> cleanup.
>
> While there, move the "invalid" peer check to the only caller where it
> can actually happen, and tighten it to reject own ID.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> hw/misc/ivshmem.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index e568263..2f2f43f 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -428,21 +428,17 @@ static void close_peer_eventfds(IVShmemState *s, int posn)
> {
> int i, n;
>
> - if (!ivshmem_has_feature(s, IVSHMEM_IOEVENTFD)) {
> - return;
> - }
> - if (posn < 0 || posn >= s->nb_peers) {
> - error_report("invalid peer %d", posn);
> - return;
> - }
> -
> + assert(posn >= 0 && posn < s->nb_peers);
> n = s->peers[posn].nb_eventfds;
>
> - memory_region_transaction_begin();
> - for (i = 0; i < n; i++) {
> - ivshmem_del_eventfd(s, posn, i);
> + if (ivshmem_has_feature(s, IVSHMEM_IOEVENTFD)) {
> + memory_region_transaction_begin();
> + for (i = 0; i < n; i++) {
> + ivshmem_del_eventfd(s, posn, i);
> + }
> + memory_region_transaction_commit();
> }
> - memory_region_transaction_commit();
> +
> for (i = 0; i < n; i++) {
> event_notifier_cleanup(&s->peers[posn].eventfds[i]);
> }
> @@ -598,6 +594,10 @@ static void process_msg_shmem(IVShmemState *s, int fd)
> static void process_msg_disconnect(IVShmemState *s, uint16_t posn)
> {
> IVSHMEM_DPRINTF("posn %d has gone away\n", posn);
> + if (posn >= s->nb_peers || posn == s->vm_id) {
> + error_report("invalid peer %d", posn);
> + return;
> + }
> close_peer_eventfds(s, posn);
> }
>
> --
> 2.4.3
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 74+ messages in thread
* [Qemu-devel] [PATCH v2 27/42] ivshmem: Receive shared memory synchronously in realize()
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (25 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 26/42] ivshmem: Plug leaks on unplug, fix peer disconnect Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-09 12:45 ` Marc-André Lureau
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 28/42] ivshmem: Propagate errors through ivshmem_recv_setup() Markus Armbruster
` (16 subsequent siblings)
43 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
When configured for interrupts (property "chardev" given), we receive
the shared memory from an ivshmem server. We do so asynchronously
after realize() completes, by setting up callbacks with
qemu_chr_add_handlers().
Keeping server I/O out of realize() that way avoids delays due to a
slow server. This is probably relevant only for hot plug.
However, this funny "no shared memory, yet" state of the device also
causes a raft of issues that are hard or impossible to work around:
* The guest is exposed to this state: when we enter and leave it its
shared memory contents is apruptly replaced, and device register
IVPosition changes.
This is a known issue. We document that guests should not access
the shared memory after device initialization until the IVPosition
register becomes non-negative.
For cold plug, the funny state is unlikely to be visible in
practice, because we normally receive the shared memory long before
the guest gets around to mess with the device.
For hot plug, the timing is tighter, but the relative slowness of
PCI device configuration has a good chance to hide the funny state.
In either case, guests complying with the documented procedure are
safe.
* Migration becomes racy.
If migration completes before the shared memory setup completes on
the source, shared memory contents is silently lost. Fortunately,
migration is rather unlikely to win this race.
If the shared memory's ramblock arrives at the destination before
shared memory setup completes, migration fails.
There is no known way for a management application to wait for
shared memory setup to complete.
All you can do is retry failed migration. You can improve your
chances by leaving more time between running the destination QEMU
and the migrate command.
To mitigate silent memory loss, you need to ensure the server
initializes shared memory exactly the same on source and
destination.
These issues are entirely undocumented so far.
I'd expect the server to be almost always fast enough to hide these
issues. But then rare catastrophic races are in a way the worst kind.
This is way more trouble than I'm willing to take from any device.
Kill the funny state by receiving shared memory synchronously in
realize(). If your hot plug hangs, go kill your ivshmem server.
For easier review, this commit only makes the receive synchronous, it
doesn't add the necessary error propagation. Without that, the funny
state persists. The next commit will do that, and kill it off for
real.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/misc/ivshmem.c | 68 ++++++++++++++++++++++++++++++++++++----------------
tests/ivshmem-test.c | 26 ++++++--------------
2 files changed, 55 insertions(+), 39 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 2f2f43f..24da19e 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -675,27 +675,45 @@ static void ivshmem_read(void *opaque, const uint8_t *buf, int size)
process_msg(s, msg, fd);
}
-static void ivshmem_check_version(void *opaque, const uint8_t * buf, int size)
+static int64_t ivshmem_recv_msg(IVShmemState *s, int *pfd)
{
- IVShmemState *s = opaque;
- int tmp;
- int64_t version;
+ int64_t msg;
+ int n, ret;
- if (!fifo_update_and_get_i64(s, buf, size, &version)) {
- return;
- }
+ n = 0;
+ do {
+ ret = qemu_chr_fe_read_all(s->server_chr, (uint8_t *)&msg + n,
+ sizeof(msg) - n);
+ if (ret < 0 && ret != -EINTR) {
+ /* TODO error handling */
+ return INT64_MIN;
+ }
+ n += ret;
+ } while (n < sizeof(msg));
- tmp = qemu_chr_fe_get_msgfd(s->server_chr);
- if (tmp != -1 || version != IVSHMEM_PROTOCOL_VERSION) {
+ *pfd = qemu_chr_fe_get_msgfd(s->server_chr);
+ return msg;
+}
+
+static void ivshmem_recv_setup(IVShmemState *s)
+{
+ int64_t msg;
+ int fd;
+
+ msg = ivshmem_recv_msg(s, &fd);
+ if (fd != -1 || msg != IVSHMEM_PROTOCOL_VERSION) {
fprintf(stderr, "incompatible version, you are connecting to a ivshmem-"
"server using a different protocol please check your setup\n");
- qemu_chr_add_handlers(s->server_chr, NULL, NULL, NULL, s);
return;
}
- IVSHMEM_DPRINTF("version check ok, switch to real chardev handler\n");
- qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive, ivshmem_read,
- NULL, s);
+ /*
+ * Receive more messages until we got shared memory.
+ */
+ do {
+ msg = ivshmem_recv_msg(s, &fd);
+ process_msg(s, msg, fd);
+ } while (msg != -1);
}
/* Select the MSI-X vectors used by device.
@@ -902,19 +920,29 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
IVSHMEM_DPRINTF("using shared memory server (socket = %s)\n",
s->server_chr->filename);
- if (ivshmem_setup_interrupts(s) < 0) {
- error_setg(errp, "failed to initialize interrupts");
- return;
- }
-
/* we allocate enough space for 16 peers and grow as needed */
resize_peers(s, 16);
s->vm_id = -1;
pci_register_bar(dev, 2, attr, &s->bar);
- qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive,
- ivshmem_check_version, NULL, s);
+ /*
+ * Receive setup messages from server synchronously.
+ * Older versions did it asynchronously, but that creates a
+ * number of entertaining race conditions.
+ * TODO Propagate errors! Without that, we still have races
+ * on errors.
+ */
+ ivshmem_recv_setup(s);
+ if (memory_region_is_mapped(&s->ivshmem)) {
+ qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive,
+ ivshmem_read, NULL, s);
+ }
+
+ if (ivshmem_setup_interrupts(s) < 0) {
+ error_setg(errp, "failed to initialize interrupts");
+ return;
+ }
} else {
/* just map the file immediately, we're not using a server */
int fd;
diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c
index 7b6b957..c7f3758 100644
--- a/tests/ivshmem-test.c
+++ b/tests/ivshmem-test.c
@@ -309,35 +309,23 @@ static void test_ivshmem_server(bool msi)
ret = ivshmem_server_start(&server);
g_assert_cmpint(ret, ==, 0);
- setup_vm_with_server(&state1, nvectors, msi);
- s1 = &state1;
- setup_vm_with_server(&state2, nvectors, msi);
- s2 = &state2;
-
- /* check state before server sends stuff */
- g_assert_cmpuint(in_reg(s1, IVPOSITION), ==, 0xffffffff);
- g_assert_cmpuint(in_reg(s2, IVPOSITION), ==, 0xffffffff);
- g_assert_cmpuint(qtest_readb(s1->qtest, (uintptr_t)s1->mem_base), ==, 0x00);
-
thread.server = &server;
ret = pipe(thread.pipe);
g_assert_cmpint(ret, ==, 0);
thread.thread = g_thread_new("ivshmem-server", server_thread, &thread);
g_assert(thread.thread != NULL);
- /* waiting for devices to become operational */
- while (g_get_monotonic_time() < end_time) {
- g_usleep(1000);
- if ((int)in_reg(s1, IVPOSITION) >= 0 &&
- (int)in_reg(s2, IVPOSITION) >= 0) {
- break;
- }
- }
+ setup_vm_with_server(&state1, nvectors, msi);
+ s1 = &state1;
+ setup_vm_with_server(&state2, nvectors, msi);
+ s2 = &state2;
/* check got different VM ids */
vm1 = in_reg(s1, IVPOSITION);
vm2 = in_reg(s2, IVPOSITION);
- g_assert_cmpuint(vm1, !=, vm2);
+ g_assert_cmpint(vm1, >=, 0);
+ g_assert_cmpint(vm2, >=, 0);
+ g_assert_cmpint(vm1, !=, vm2);
/* check number of MSI-X vectors */
global_qtest = s1->qtest;
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 27/42] ivshmem: Receive shared memory synchronously in realize()
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 27/42] ivshmem: Receive shared memory synchronously in realize() Markus Armbruster
@ 2016-03-09 12:45 ` Marc-André Lureau
0 siblings, 0 replies; 74+ messages in thread
From: Marc-André Lureau @ 2016-03-09 12:45 UTC (permalink / raw)
To: Markus Armbruster
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
> When configured for interrupts (property "chardev" given), we receive
> the shared memory from an ivshmem server. We do so asynchronously
> after realize() completes, by setting up callbacks with
> qemu_chr_add_handlers().
>
> Keeping server I/O out of realize() that way avoids delays due to a
> slow server. This is probably relevant only for hot plug.
>
> However, this funny "no shared memory, yet" state of the device also
> causes a raft of issues that are hard or impossible to work around:
>
> * The guest is exposed to this state: when we enter and leave it its
> shared memory contents is apruptly replaced, and device register
> IVPosition changes.
>
> This is a known issue. We document that guests should not access
> the shared memory after device initialization until the IVPosition
> register becomes non-negative.
>
> For cold plug, the funny state is unlikely to be visible in
> practice, because we normally receive the shared memory long before
> the guest gets around to mess with the device.
>
> For hot plug, the timing is tighter, but the relative slowness of
> PCI device configuration has a good chance to hide the funny state.
>
> In either case, guests complying with the documented procedure are
> safe.
>
> * Migration becomes racy.
>
> If migration completes before the shared memory setup completes on
> the source, shared memory contents is silently lost. Fortunately,
> migration is rather unlikely to win this race.
>
> If the shared memory's ramblock arrives at the destination before
> shared memory setup completes, migration fails.
>
> There is no known way for a management application to wait for
> shared memory setup to complete.
>
> All you can do is retry failed migration. You can improve your
> chances by leaving more time between running the destination QEMU
> and the migrate command.
>
> To mitigate silent memory loss, you need to ensure the server
> initializes shared memory exactly the same on source and
> destination.
>
> These issues are entirely undocumented so far.
>
> I'd expect the server to be almost always fast enough to hide these
> issues. But then rare catastrophic races are in a way the worst kind.
>
> This is way more trouble than I'm willing to take from any device.
> Kill the funny state by receiving shared memory synchronously in
> realize(). If your hot plug hangs, go kill your ivshmem server.
>
> For easier review, this commit only makes the receive synchronous, it
> doesn't add the necessary error propagation. Without that, the funny
> state persists. The next commit will do that, and kill it off for
> real.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 74+ messages in thread
* [Qemu-devel] [PATCH v2 28/42] ivshmem: Propagate errors through ivshmem_recv_setup()
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (26 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 27/42] ivshmem: Receive shared memory synchronously in realize() Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-09 12:46 ` Marc-André Lureau
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 29/42] ivshmem: Rely on server sending the ID right after the version Markus Armbruster
` (15 subsequent siblings)
43 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
This kills off the funny state described in the previous commit.
Simplify ivshmem_io_read() accordingly, and update documentation.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
docs/specs/ivshmem-spec.txt | 20 +++----
hw/misc/ivshmem.c | 123 +++++++++++++++++++++++++++-----------------
qemu-doc.texi | 9 +---
3 files changed, 89 insertions(+), 63 deletions(-)
diff --git a/docs/specs/ivshmem-spec.txt b/docs/specs/ivshmem-spec.txt
index 0cd63ad..4c33973 100644
--- a/docs/specs/ivshmem-spec.txt
+++ b/docs/specs/ivshmem-spec.txt
@@ -62,11 +62,11 @@ There are two ways to use this device:
likely want to write a kernel driver to handle interrupts. Requires
the device to be configured for interrupts, obviously.
-If the device is configured for interrupts, BAR2 is initially invalid.
-It becomes safely accessible only after the ivshmem server provided
-the shared memory. Guest software should wait for the IVPosition
-register (described below) to become non-negative before accessing
-BAR2.
+Before QEMU 2.6.0, BAR2 can initially be invalid if the device is
+configured for interrupts. It becomes safely accessible only after
+the ivshmem server provided the shared memory. Guest software should
+wait for the IVPosition register (described below) to become
+non-negative before accessing BAR2.
The device is not capable to tell guest software whether it is
configured for interrupts.
@@ -82,7 +82,7 @@ BAR 0 contains the following registers:
4 4 read/write 0 Interrupt Status
bit 0: peer interrupt
bit 1..31: reserved
- 8 4 read-only 0 or -1 IVPosition
+ 8 4 read-only 0 or ID IVPosition
12 4 write-only N/A Doorbell
bit 0..15: vector
bit 16..31: peer ID
@@ -100,12 +100,14 @@ when an interrupt request from a peer is received. Reading the
register clears it.
IVPosition Register: if the device is not configured for interrupts,
-this is zero. Else, it's -1 for a short while after reset, then
-changes to the device's ID (between 0 and 65535).
+this is zero. Else, it is the device's ID (between 0 and 65535).
+
+Before QEMU 2.6.0, the register may read -1 for a short while after
+reset.
There is no good way for software to find out whether the device is
configured for interrupts. A positive IVPosition means interrupts,
-but zero could be either. The initial -1 cannot be reliably observed.
+but zero could be either.
Doorbell Register: writing this register requests to interrupt a peer.
The written value's high 16 bits are the ID of the peer to interrupt,
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 24da19e..c3327dc 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -234,12 +234,7 @@ static uint64_t ivshmem_io_read(void *opaque, hwaddr addr,
break;
case IVPOSITION:
- /* return my VM ID if the memory is mapped */
- if (memory_region_is_mapped(&s->ivshmem)) {
- ret = s->vm_id;
- } else {
- ret = -1;
- }
+ ret = s->vm_id;
break;
default:
@@ -511,7 +506,8 @@ static bool fifo_update_and_get_i64(IVShmemState *s,
return false;
}
-static int ivshmem_add_kvm_msi_virq(IVShmemState *s, int vector)
+static void ivshmem_add_kvm_msi_virq(IVShmemState *s, int vector,
+ Error **errp)
{
PCIDevice *pdev = PCI_DEVICE(s);
MSIMessage msg = msix_get_message(pdev, vector);
@@ -522,22 +518,21 @@ static int ivshmem_add_kvm_msi_virq(IVShmemState *s, int vector)
ret = kvm_irqchip_add_msi_route(kvm_state, msg, pdev);
if (ret < 0) {
- error_report("ivshmem: kvm_irqchip_add_msi_route failed");
- return -1;
+ error_setg(errp, "kvm_irqchip_add_msi_route failed");
+ return;
}
s->msi_vectors[vector].virq = ret;
s->msi_vectors[vector].pdev = pdev;
-
- return 0;
}
-static void setup_interrupt(IVShmemState *s, int vector)
+static void setup_interrupt(IVShmemState *s, int vector, Error **errp)
{
EventNotifier *n = &s->peers[s->vm_id].eventfds[vector];
bool with_irqfd = kvm_msi_via_irqfd_enabled() &&
ivshmem_has_feature(s, IVSHMEM_MSI);
PCIDevice *pdev = PCI_DEVICE(s);
+ Error *err = NULL;
IVSHMEM_DPRINTF("setting up interrupt for vector: %d\n", vector);
@@ -546,13 +541,16 @@ static void setup_interrupt(IVShmemState *s, int vector)
watch_vector_notifier(s, n, vector);
} else if (msix_enabled(pdev)) {
IVSHMEM_DPRINTF("with irqfd\n");
- if (ivshmem_add_kvm_msi_virq(s, vector) < 0) {
+ ivshmem_add_kvm_msi_virq(s, vector, &err);
+ if (err) {
+ error_propagate(errp, err);
return;
}
if (!msix_is_masked(pdev, vector)) {
kvm_irqchip_add_irqfd_notifier_gsi(kvm_state, n, NULL,
s->msi_vectors[vector].virq);
+ /* TODO handle error */
}
} else {
/* it will be delayed until msix is enabled, in write_config */
@@ -560,19 +558,19 @@ static void setup_interrupt(IVShmemState *s, int vector)
}
}
-static void process_msg_shmem(IVShmemState *s, int fd)
+static void process_msg_shmem(IVShmemState *s, int fd, Error **errp)
{
Error *err = NULL;
void *ptr;
if (memory_region_is_mapped(&s->ivshmem)) {
- error_report("shm already initialized");
+ error_setg(errp, "server sent unexpected shared memory message");
close(fd);
return;
}
if (check_shm_size(s, fd, &err) == -1) {
- error_report_err(err);
+ error_propagate(errp, err);
close(fd);
return;
}
@@ -580,7 +578,7 @@ static void process_msg_shmem(IVShmemState *s, int fd)
/* mmap the region and map into the BAR2 */
ptr = mmap(0, s->ivshmem_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
if (ptr == MAP_FAILED) {
- error_report("Failed to mmap shared memory %s", strerror(errno));
+ error_setg_errno(errp, errno, "Failed to mmap shared memory");
close(fd);
return;
}
@@ -591,17 +589,19 @@ static void process_msg_shmem(IVShmemState *s, int fd)
memory_region_add_subregion(&s->bar, 0, &s->ivshmem);
}
-static void process_msg_disconnect(IVShmemState *s, uint16_t posn)
+static void process_msg_disconnect(IVShmemState *s, uint16_t posn,
+ Error **errp)
{
IVSHMEM_DPRINTF("posn %d has gone away\n", posn);
if (posn >= s->nb_peers || posn == s->vm_id) {
- error_report("invalid peer %d", posn);
+ error_setg(errp, "invalid peer %d", posn);
return;
}
close_peer_eventfds(s, posn);
}
-static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd)
+static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd,
+ Error **errp)
{
Peer *peer = &s->peers[posn];
int vector;
@@ -611,8 +611,8 @@ static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd)
* descriptor for vector N-1. Count messages to find the vector.
*/
if (peer->nb_eventfds >= s->vectors) {
- error_report("Too many eventfd received, device has %d vectors",
- s->vectors);
+ error_setg(errp, "Too many eventfd received, device has %d vectors",
+ s->vectors);
close(fd);
return;
}
@@ -623,7 +623,8 @@ static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd)
fcntl_setfl(fd, O_NONBLOCK); /* msix/irqfd poll non block */
if (posn == s->vm_id) {
- setup_interrupt(s, vector);
+ setup_interrupt(s, vector, errp);
+ /* TODO do we need to handle the error? */
}
if (ivshmem_has_feature(s, IVSHMEM_IOEVENTFD)) {
@@ -631,18 +632,18 @@ static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd)
}
}
-static void process_msg(IVShmemState *s, int64_t msg, int fd)
+static void process_msg(IVShmemState *s, int64_t msg, int fd, Error **errp)
{
IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n", msg, fd);
if (msg < -1 || msg > IVSHMEM_MAX_PEERS) {
- error_report("server sent invalid message %" PRId64, msg);
+ error_setg(errp, "server sent invalid message %" PRId64, msg);
close(fd);
return;
}
if (msg == -1) {
- process_msg_shmem(s, fd);
+ process_msg_shmem(s, fd, errp);
return;
}
@@ -651,17 +652,18 @@ static void process_msg(IVShmemState *s, int64_t msg, int fd)
}
if (fd >= 0) {
- process_msg_connect(s, msg, fd);
+ process_msg_connect(s, msg, fd, errp);
} else if (s->vm_id == -1) {
s->vm_id = msg;
} else {
- process_msg_disconnect(s, msg);
+ process_msg_disconnect(s, msg, errp);
}
}
static void ivshmem_read(void *opaque, const uint8_t *buf, int size)
{
IVShmemState *s = opaque;
+ Error *err = NULL;
int fd;
int64_t msg;
@@ -672,10 +674,13 @@ static void ivshmem_read(void *opaque, const uint8_t *buf, int size)
fd = qemu_chr_fe_get_msgfd(s->server_chr);
IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n", msg, fd);
- process_msg(s, msg, fd);
+ process_msg(s, msg, fd, &err);
+ if (err) {
+ error_report_err(err);
+ }
}
-static int64_t ivshmem_recv_msg(IVShmemState *s, int *pfd)
+static int64_t ivshmem_recv_msg(IVShmemState *s, int *pfd, Error **errp)
{
int64_t msg;
int n, ret;
@@ -685,7 +690,7 @@ static int64_t ivshmem_recv_msg(IVShmemState *s, int *pfd)
ret = qemu_chr_fe_read_all(s->server_chr, (uint8_t *)&msg + n,
sizeof(msg) - n);
if (ret < 0 && ret != -EINTR) {
- /* TODO error handling */
+ error_setg_errno(errp, -ret, "read from server failed");
return INT64_MIN;
}
n += ret;
@@ -695,15 +700,24 @@ static int64_t ivshmem_recv_msg(IVShmemState *s, int *pfd)
return msg;
}
-static void ivshmem_recv_setup(IVShmemState *s)
+static void ivshmem_recv_setup(IVShmemState *s, Error **errp)
{
+ Error *err = NULL;
int64_t msg;
int fd;
- msg = ivshmem_recv_msg(s, &fd);
- if (fd != -1 || msg != IVSHMEM_PROTOCOL_VERSION) {
- fprintf(stderr, "incompatible version, you are connecting to a ivshmem-"
- "server using a different protocol please check your setup\n");
+ msg = ivshmem_recv_msg(s, &fd, &err);
+ if (err) {
+ error_propagate(errp, err);
+ return;
+ }
+ if (msg != IVSHMEM_PROTOCOL_VERSION) {
+ error_setg(errp, "server sent version %" PRId64 ", expecting %d",
+ msg, IVSHMEM_PROTOCOL_VERSION);
+ return;
+ }
+ if (fd != -1) {
+ error_setg(errp, "server sent invalid version message");
return;
}
@@ -711,9 +725,19 @@ static void ivshmem_recv_setup(IVShmemState *s)
* Receive more messages until we got shared memory.
*/
do {
- msg = ivshmem_recv_msg(s, &fd);
- process_msg(s, msg, fd);
+ msg = ivshmem_recv_msg(s, &fd, &err);
+ if (err) {
+ error_propagate(errp, err);
+ return;
+ }
+ process_msg(s, msg, fd, &err);
+ if (err) {
+ error_propagate(errp, err);
+ return;
+ }
} while (msg != -1);
+
+ assert(memory_region_is_mapped(&s->ivshmem));
}
/* Select the MSI-X vectors used by device.
@@ -765,7 +789,13 @@ static void ivshmem_enable_irqfd(IVShmemState *s)
int i;
for (i = 0; i < s->peers[s->vm_id].nb_eventfds; i++) {
- ivshmem_add_kvm_msi_virq(s, i);
+ Error *err = NULL;
+
+ ivshmem_add_kvm_msi_virq(s, i, &err);
+ if (err) {
+ error_report_err(err);
+ /* TODO do we need to handle the error? */
+ }
}
if (msix_set_vector_notifiers(pdev,
@@ -811,7 +841,7 @@ static void ivshmem_write_config(PCIDevice *pdev, uint32_t address,
pci_default_write_config(pdev, address, val, len);
is_enabled = msix_enabled(pdev);
- if (kvm_msi_via_irqfd_enabled() && s->vm_id != -1) {
+ if (kvm_msi_via_irqfd_enabled()) {
if (!was_enabled && is_enabled) {
ivshmem_enable_irqfd(s);
} else if (was_enabled && !is_enabled) {
@@ -930,15 +960,16 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
* Receive setup messages from server synchronously.
* Older versions did it asynchronously, but that creates a
* number of entertaining race conditions.
- * TODO Propagate errors! Without that, we still have races
- * on errors.
*/
- ivshmem_recv_setup(s);
- if (memory_region_is_mapped(&s->ivshmem)) {
- qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive,
- ivshmem_read, NULL, s);
+ ivshmem_recv_setup(s, &err);
+ if (err) {
+ error_propagate(errp, err);
+ return;
}
+ qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive,
+ ivshmem_read, NULL, s);
+
if (ivshmem_setup_interrupts(s) < 0) {
error_setg(errp, "failed to initialize interrupts");
return;
diff --git a/qemu-doc.texi b/qemu-doc.texi
index 65f3b29..8afbbcd 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -1289,14 +1289,7 @@ qemu-system-i386 -device ivshmem,size=@var{shm-size},vectors=@var{vectors},chard
When using the server, the guest will be assigned a VM ID (>=0) that allows guests
using the same server to communicate via interrupts. Guests can read their
-VM ID from a device register (see example code). Since receiving the shared
-memory region from the server is asynchronous, there is a (small) chance the
-guest may boot before the shared memory is attached. To allow an application
-to ensure shared memory is attached, the VM ID register will return -1 (an
-invalid VM ID) until the memory is attached. Once the shared memory is
-attached, the VM ID will return the guest's valid VM ID. With these semantics,
-the guest application can check to ensure the shared memory is attached to the
-guest before proceeding.
+VM ID from a device register (see ivshmem-spec.txt).
The @option{role} argument can be set to either master or peer and will affect
how the shared memory is migrated. With @option{role=master}, the guest will
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 28/42] ivshmem: Propagate errors through ivshmem_recv_setup()
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 28/42] ivshmem: Propagate errors through ivshmem_recv_setup() Markus Armbruster
@ 2016-03-09 12:46 ` Marc-André Lureau
2016-03-09 20:25 ` Markus Armbruster
0 siblings, 1 reply; 74+ messages in thread
From: Marc-André Lureau @ 2016-03-09 12:46 UTC (permalink / raw)
To: Markus Armbruster
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
Hi
On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
> This kills off the funny state described in the previous commit.
>
> Simplify ivshmem_io_read() accordingly, and update documentation.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> docs/specs/ivshmem-spec.txt | 20 +++----
> hw/misc/ivshmem.c | 123 +++++++++++++++++++++++++++-----------------
> qemu-doc.texi | 9 +---
> 3 files changed, 89 insertions(+), 63 deletions(-)
>
> diff --git a/docs/specs/ivshmem-spec.txt b/docs/specs/ivshmem-spec.txt
> index 0cd63ad..4c33973 100644
> --- a/docs/specs/ivshmem-spec.txt
> +++ b/docs/specs/ivshmem-spec.txt
> @@ -62,11 +62,11 @@ There are two ways to use this device:
> likely want to write a kernel driver to handle interrupts. Requires
> the device to be configured for interrupts, obviously.
>
> -If the device is configured for interrupts, BAR2 is initially invalid.
> -It becomes safely accessible only after the ivshmem server provided
> -the shared memory. Guest software should wait for the IVPosition
> -register (described below) to become non-negative before accessing
> -BAR2.
> +Before QEMU 2.6.0, BAR2 can initially be invalid if the device is
> +configured for interrupts. It becomes safely accessible only after
> +the ivshmem server provided the shared memory. Guest software should
> +wait for the IVPosition register (described below) to become
> +non-negative before accessing BAR2.
>
> The device is not capable to tell guest software whether it is
> configured for interrupts.
> @@ -82,7 +82,7 @@ BAR 0 contains the following registers:
> 4 4 read/write 0 Interrupt Status
> bit 0: peer interrupt
> bit 1..31: reserved
> - 8 4 read-only 0 or -1 IVPosition
> + 8 4 read-only 0 or ID IVPosition
> 12 4 write-only N/A Doorbell
> bit 0..15: vector
> bit 16..31: peer ID
> @@ -100,12 +100,14 @@ when an interrupt request from a peer is received. Reading the
> register clears it.
>
> IVPosition Register: if the device is not configured for interrupts,
> -this is zero. Else, it's -1 for a short while after reset, then
> -changes to the device's ID (between 0 and 65535).
> +this is zero. Else, it is the device's ID (between 0 and 65535).
> +
> +Before QEMU 2.6.0, the register may read -1 for a short while after
> +reset.
>
> There is no good way for software to find out whether the device is
> configured for interrupts. A positive IVPosition means interrupts,
> -but zero could be either. The initial -1 cannot be reliably observed.
> +but zero could be either.
>
> Doorbell Register: writing this register requests to interrupt a peer.
> The written value's high 16 bits are the ID of the peer to interrupt,
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index 24da19e..c3327dc 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -234,12 +234,7 @@ static uint64_t ivshmem_io_read(void *opaque, hwaddr addr,
> break;
>
> case IVPOSITION:
> - /* return my VM ID if the memory is mapped */
> - if (memory_region_is_mapped(&s->ivshmem)) {
> - ret = s->vm_id;
> - } else {
> - ret = -1;
> - }
> + ret = s->vm_id;
> break;
>
> default:
> @@ -511,7 +506,8 @@ static bool fifo_update_and_get_i64(IVShmemState *s,
> return false;
> }
>
> -static int ivshmem_add_kvm_msi_virq(IVShmemState *s, int vector)
> +static void ivshmem_add_kvm_msi_virq(IVShmemState *s, int vector,
> + Error **errp)
> {
> PCIDevice *pdev = PCI_DEVICE(s);
> MSIMessage msg = msix_get_message(pdev, vector);
> @@ -522,22 +518,21 @@ static int ivshmem_add_kvm_msi_virq(IVShmemState *s, int vector)
>
> ret = kvm_irqchip_add_msi_route(kvm_state, msg, pdev);
> if (ret < 0) {
> - error_report("ivshmem: kvm_irqchip_add_msi_route failed");
> - return -1;
> + error_setg(errp, "kvm_irqchip_add_msi_route failed");
> + return;
> }
>
> s->msi_vectors[vector].virq = ret;
> s->msi_vectors[vector].pdev = pdev;
> -
> - return 0;
> }
>
> -static void setup_interrupt(IVShmemState *s, int vector)
> +static void setup_interrupt(IVShmemState *s, int vector, Error **errp)
> {
> EventNotifier *n = &s->peers[s->vm_id].eventfds[vector];
> bool with_irqfd = kvm_msi_via_irqfd_enabled() &&
> ivshmem_has_feature(s, IVSHMEM_MSI);
> PCIDevice *pdev = PCI_DEVICE(s);
> + Error *err = NULL;
>
> IVSHMEM_DPRINTF("setting up interrupt for vector: %d\n", vector);
>
> @@ -546,13 +541,16 @@ static void setup_interrupt(IVShmemState *s, int vector)
> watch_vector_notifier(s, n, vector);
> } else if (msix_enabled(pdev)) {
> IVSHMEM_DPRINTF("with irqfd\n");
> - if (ivshmem_add_kvm_msi_virq(s, vector) < 0) {
> + ivshmem_add_kvm_msi_virq(s, vector, &err);
> + if (err) {
> + error_propagate(errp, err);
> return;
> }
>
> if (!msix_is_masked(pdev, vector)) {
> kvm_irqchip_add_irqfd_notifier_gsi(kvm_state, n, NULL,
> s->msi_vectors[vector].virq);
> + /* TODO handle error */
> }
> } else {
> /* it will be delayed until msix is enabled, in write_config */
> @@ -560,19 +558,19 @@ static void setup_interrupt(IVShmemState *s, int vector)
> }
> }
>
> -static void process_msg_shmem(IVShmemState *s, int fd)
> +static void process_msg_shmem(IVShmemState *s, int fd, Error **errp)
> {
> Error *err = NULL;
> void *ptr;
>
> if (memory_region_is_mapped(&s->ivshmem)) {
> - error_report("shm already initialized");
> + error_setg(errp, "server sent unexpected shared memory message");
> close(fd);
> return;
> }
>
> if (check_shm_size(s, fd, &err) == -1) {
> - error_report_err(err);
> + error_propagate(errp, err);
> close(fd);
> return;
> }
> @@ -580,7 +578,7 @@ static void process_msg_shmem(IVShmemState *s, int fd)
> /* mmap the region and map into the BAR2 */
> ptr = mmap(0, s->ivshmem_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
> if (ptr == MAP_FAILED) {
> - error_report("Failed to mmap shared memory %s", strerror(errno));
> + error_setg_errno(errp, errno, "Failed to mmap shared memory");
> close(fd);
> return;
> }
> @@ -591,17 +589,19 @@ static void process_msg_shmem(IVShmemState *s, int fd)
> memory_region_add_subregion(&s->bar, 0, &s->ivshmem);
> }
>
> -static void process_msg_disconnect(IVShmemState *s, uint16_t posn)
> +static void process_msg_disconnect(IVShmemState *s, uint16_t posn,
> + Error **errp)
> {
> IVSHMEM_DPRINTF("posn %d has gone away\n", posn);
> if (posn >= s->nb_peers || posn == s->vm_id) {
> - error_report("invalid peer %d", posn);
> + error_setg(errp, "invalid peer %d", posn);
> return;
> }
> close_peer_eventfds(s, posn);
> }
>
> -static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd)
> +static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd,
> + Error **errp)
> {
> Peer *peer = &s->peers[posn];
> int vector;
> @@ -611,8 +611,8 @@ static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd)
> * descriptor for vector N-1. Count messages to find the vector.
> */
> if (peer->nb_eventfds >= s->vectors) {
> - error_report("Too many eventfd received, device has %d vectors",
> - s->vectors);
> + error_setg(errp, "Too many eventfd received, device has %d vectors",
> + s->vectors);
> close(fd);
> return;
> }
> @@ -623,7 +623,8 @@ static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd)
> fcntl_setfl(fd, O_NONBLOCK); /* msix/irqfd poll non block */
>
> if (posn == s->vm_id) {
> - setup_interrupt(s, vector);
> + setup_interrupt(s, vector, errp);
> + /* TODO do we need to handle the error? */
> }
>
> if (ivshmem_has_feature(s, IVSHMEM_IOEVENTFD)) {
> @@ -631,18 +632,18 @@ static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd)
> }
> }
>
> -static void process_msg(IVShmemState *s, int64_t msg, int fd)
> +static void process_msg(IVShmemState *s, int64_t msg, int fd, Error **errp)
> {
> IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n", msg, fd);
>
> if (msg < -1 || msg > IVSHMEM_MAX_PEERS) {
> - error_report("server sent invalid message %" PRId64, msg);
> + error_setg(errp, "server sent invalid message %" PRId64, msg);
> close(fd);
> return;
> }
>
> if (msg == -1) {
> - process_msg_shmem(s, fd);
> + process_msg_shmem(s, fd, errp);
> return;
> }
>
> @@ -651,17 +652,18 @@ static void process_msg(IVShmemState *s, int64_t msg, int fd)
> }
>
> if (fd >= 0) {
> - process_msg_connect(s, msg, fd);
> + process_msg_connect(s, msg, fd, errp);
> } else if (s->vm_id == -1) {
> s->vm_id = msg;
> } else {
> - process_msg_disconnect(s, msg);
> + process_msg_disconnect(s, msg, errp);
> }
> }
>
> static void ivshmem_read(void *opaque, const uint8_t *buf, int size)
> {
> IVShmemState *s = opaque;
> + Error *err = NULL;
> int fd;
> int64_t msg;
>
> @@ -672,10 +674,13 @@ static void ivshmem_read(void *opaque, const uint8_t *buf, int size)
> fd = qemu_chr_fe_get_msgfd(s->server_chr);
> IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n", msg, fd);
>
> - process_msg(s, msg, fd);
> + process_msg(s, msg, fd, &err);
> + if (err) {
> + error_report_err(err);
> + }
> }
>
> -static int64_t ivshmem_recv_msg(IVShmemState *s, int *pfd)
> +static int64_t ivshmem_recv_msg(IVShmemState *s, int *pfd, Error **errp)
> {
> int64_t msg;
> int n, ret;
> @@ -685,7 +690,7 @@ static int64_t ivshmem_recv_msg(IVShmemState *s, int *pfd)
> ret = qemu_chr_fe_read_all(s->server_chr, (uint8_t *)&msg + n,
> sizeof(msg) - n);
> if (ret < 0 && ret != -EINTR) {
> - /* TODO error handling */
> + error_setg_errno(errp, -ret, "read from server failed");
> return INT64_MIN;
> }
> n += ret;
> @@ -695,15 +700,24 @@ static int64_t ivshmem_recv_msg(IVShmemState *s, int *pfd)
> return msg;
> }
>
> -static void ivshmem_recv_setup(IVShmemState *s)
> +static void ivshmem_recv_setup(IVShmemState *s, Error **errp)
> {
> + Error *err = NULL;
> int64_t msg;
> int fd;
>
> - msg = ivshmem_recv_msg(s, &fd);
> - if (fd != -1 || msg != IVSHMEM_PROTOCOL_VERSION) {
> - fprintf(stderr, "incompatible version, you are connecting to a ivshmem-"
> - "server using a different protocol please check your setup\n");
> + msg = ivshmem_recv_msg(s, &fd, &err);
> + if (err) {
> + error_propagate(errp, err);
> + return;
> + }
> + if (msg != IVSHMEM_PROTOCOL_VERSION) {
> + error_setg(errp, "server sent version %" PRId64 ", expecting %d",
> + msg, IVSHMEM_PROTOCOL_VERSION);
> + return;
> + }
> + if (fd != -1) {
> + error_setg(errp, "server sent invalid version message");
> return;
> }
>
> @@ -711,9 +725,19 @@ static void ivshmem_recv_setup(IVShmemState *s)
> * Receive more messages until we got shared memory.
> */
> do {
> - msg = ivshmem_recv_msg(s, &fd);
> - process_msg(s, msg, fd);
> + msg = ivshmem_recv_msg(s, &fd, &err);
> + if (err) {
> + error_propagate(errp, err);
> + return;
> + }
> + process_msg(s, msg, fd, &err);
> + if (err) {
> + error_propagate(errp, err);
> + return;
> + }
> } while (msg != -1);
> +
> + assert(memory_region_is_mapped(&s->ivshmem));
This is still easy to trigger at run time, for example during hotplug
with a broken or uncooperative server. Why not report an error?
>
> /* Select the MSI-X vectors used by device.
> @@ -765,7 +789,13 @@ static void ivshmem_enable_irqfd(IVShmemState *s)
> int i;
>
> for (i = 0; i < s->peers[s->vm_id].nb_eventfds; i++) {
> - ivshmem_add_kvm_msi_virq(s, i);
> + Error *err = NULL;
> +
> + ivshmem_add_kvm_msi_virq(s, i, &err);
> + if (err) {
> + error_report_err(err);
> + /* TODO do we need to handle the error? */
> + }
> }
>
> if (msix_set_vector_notifiers(pdev,
> @@ -811,7 +841,7 @@ static void ivshmem_write_config(PCIDevice *pdev, uint32_t address,
> pci_default_write_config(pdev, address, val, len);
> is_enabled = msix_enabled(pdev);
>
> - if (kvm_msi_via_irqfd_enabled() && s->vm_id != -1) {
> + if (kvm_msi_via_irqfd_enabled()) {
> if (!was_enabled && is_enabled) {
> ivshmem_enable_irqfd(s);
> } else if (was_enabled && !is_enabled) {
> @@ -930,15 +960,16 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
> * Receive setup messages from server synchronously.
> * Older versions did it asynchronously, but that creates a
> * number of entertaining race conditions.
> - * TODO Propagate errors! Without that, we still have races
> - * on errors.
> */
> - ivshmem_recv_setup(s);
> - if (memory_region_is_mapped(&s->ivshmem)) {
> - qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive,
> - ivshmem_read, NULL, s);
> + ivshmem_recv_setup(s, &err);
> + if (err) {
> + error_propagate(errp, err);
> + return;
> }
>
> + qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive,
> + ivshmem_read, NULL, s);
> +
> if (ivshmem_setup_interrupts(s) < 0) {
> error_setg(errp, "failed to initialize interrupts");
> return;
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index 65f3b29..8afbbcd 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -1289,14 +1289,7 @@ qemu-system-i386 -device ivshmem,size=@var{shm-size},vectors=@var{vectors},chard
>
> When using the server, the guest will be assigned a VM ID (>=0) that allows guests
> using the same server to communicate via interrupts. Guests can read their
> -VM ID from a device register (see example code). Since receiving the shared
> -memory region from the server is asynchronous, there is a (small) chance the
> -guest may boot before the shared memory is attached. To allow an application
> -to ensure shared memory is attached, the VM ID register will return -1 (an
> -invalid VM ID) until the memory is attached. Once the shared memory is
> -attached, the VM ID will return the guest's valid VM ID. With these semantics,
> -the guest application can check to ensure the shared memory is attached to the
> -guest before proceeding.
> +VM ID from a device register (see ivshmem-spec.txt).
>
> The @option{role} argument can be set to either master or peer and will affect
> how the shared memory is migrated. With @option{role=master}, the guest will
> --
> 2.4.3
>
>
The rest of the patch looks good.
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 28/42] ivshmem: Propagate errors through ivshmem_recv_setup()
2016-03-09 12:46 ` Marc-André Lureau
@ 2016-03-09 20:25 ` Markus Armbruster
2016-03-10 0:44 ` Marc-André Lureau
0 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-09 20:25 UTC (permalink / raw)
To: Marc-André Lureau
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
Marc-André Lureau <marcandre.lureau@gmail.com> writes:
> Hi
>
> On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
>> This kills off the funny state described in the previous commit.
>>
>> Simplify ivshmem_io_read() accordingly, and update documentation.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> docs/specs/ivshmem-spec.txt | 20 +++----
>> hw/misc/ivshmem.c | 123 +++++++++++++++++++++++++++-----------------
>> qemu-doc.texi | 9 +---
>> 3 files changed, 89 insertions(+), 63 deletions(-)
>>
>> diff --git a/docs/specs/ivshmem-spec.txt b/docs/specs/ivshmem-spec.txt
>> index 0cd63ad..4c33973 100644
>> --- a/docs/specs/ivshmem-spec.txt
>> +++ b/docs/specs/ivshmem-spec.txt
>> @@ -62,11 +62,11 @@ There are two ways to use this device:
>> likely want to write a kernel driver to handle interrupts. Requires
>> the device to be configured for interrupts, obviously.
>>
>> -If the device is configured for interrupts, BAR2 is initially invalid.
>> -It becomes safely accessible only after the ivshmem server provided
>> -the shared memory. Guest software should wait for the IVPosition
>> -register (described below) to become non-negative before accessing
>> -BAR2.
>> +Before QEMU 2.6.0, BAR2 can initially be invalid if the device is
>> +configured for interrupts. It becomes safely accessible only after
>> +the ivshmem server provided the shared memory. Guest software should
>> +wait for the IVPosition register (described below) to become
>> +non-negative before accessing BAR2.
>>
>> The device is not capable to tell guest software whether it is
>> configured for interrupts.
>> @@ -82,7 +82,7 @@ BAR 0 contains the following registers:
>> 4 4 read/write 0 Interrupt Status
>> bit 0: peer interrupt
>> bit 1..31: reserved
>> - 8 4 read-only 0 or -1 IVPosition
>> + 8 4 read-only 0 or ID IVPosition
>> 12 4 write-only N/A Doorbell
>> bit 0..15: vector
>> bit 16..31: peer ID
>> @@ -100,12 +100,14 @@ when an interrupt request from a peer is received. Reading the
>> register clears it.
>>
>> IVPosition Register: if the device is not configured for interrupts,
>> -this is zero. Else, it's -1 for a short while after reset, then
>> -changes to the device's ID (between 0 and 65535).
>> +this is zero. Else, it is the device's ID (between 0 and 65535).
>> +
>> +Before QEMU 2.6.0, the register may read -1 for a short while after
>> +reset.
>>
>> There is no good way for software to find out whether the device is
>> configured for interrupts. A positive IVPosition means interrupts,
>> -but zero could be either. The initial -1 cannot be reliably observed.
>> +but zero could be either.
>>
>> Doorbell Register: writing this register requests to interrupt a peer.
>> The written value's high 16 bits are the ID of the peer to interrupt,
>> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
>> index 24da19e..c3327dc 100644
>> --- a/hw/misc/ivshmem.c
>> +++ b/hw/misc/ivshmem.c
>> @@ -234,12 +234,7 @@ static uint64_t ivshmem_io_read(void *opaque, hwaddr addr,
>> break;
>>
>> case IVPOSITION:
>> - /* return my VM ID if the memory is mapped */
>> - if (memory_region_is_mapped(&s->ivshmem)) {
>> - ret = s->vm_id;
>> - } else {
>> - ret = -1;
>> - }
>> + ret = s->vm_id;
>> break;
>>
>> default:
>> @@ -511,7 +506,8 @@ static bool fifo_update_and_get_i64(IVShmemState *s,
>> return false;
>> }
>>
>> -static int ivshmem_add_kvm_msi_virq(IVShmemState *s, int vector)
>> +static void ivshmem_add_kvm_msi_virq(IVShmemState *s, int vector,
>> + Error **errp)
>> {
>> PCIDevice *pdev = PCI_DEVICE(s);
>> MSIMessage msg = msix_get_message(pdev, vector);
>> @@ -522,22 +518,21 @@ static int ivshmem_add_kvm_msi_virq(IVShmemState *s, int vector)
>>
>> ret = kvm_irqchip_add_msi_route(kvm_state, msg, pdev);
>> if (ret < 0) {
>> - error_report("ivshmem: kvm_irqchip_add_msi_route failed");
>> - return -1;
>> + error_setg(errp, "kvm_irqchip_add_msi_route failed");
>> + return;
>> }
>>
>> s->msi_vectors[vector].virq = ret;
>> s->msi_vectors[vector].pdev = pdev;
>> -
>> - return 0;
>> }
>>
>> -static void setup_interrupt(IVShmemState *s, int vector)
>> +static void setup_interrupt(IVShmemState *s, int vector, Error **errp)
>> {
>> EventNotifier *n = &s->peers[s->vm_id].eventfds[vector];
>> bool with_irqfd = kvm_msi_via_irqfd_enabled() &&
>> ivshmem_has_feature(s, IVSHMEM_MSI);
>> PCIDevice *pdev = PCI_DEVICE(s);
>> + Error *err = NULL;
>>
>> IVSHMEM_DPRINTF("setting up interrupt for vector: %d\n", vector);
>>
>> @@ -546,13 +541,16 @@ static void setup_interrupt(IVShmemState *s, int vector)
>> watch_vector_notifier(s, n, vector);
>> } else if (msix_enabled(pdev)) {
>> IVSHMEM_DPRINTF("with irqfd\n");
>> - if (ivshmem_add_kvm_msi_virq(s, vector) < 0) {
>> + ivshmem_add_kvm_msi_virq(s, vector, &err);
>> + if (err) {
>> + error_propagate(errp, err);
>> return;
>> }
>>
>> if (!msix_is_masked(pdev, vector)) {
>> kvm_irqchip_add_irqfd_notifier_gsi(kvm_state, n, NULL,
>> s->msi_vectors[vector].virq);
>> + /* TODO handle error */
>> }
>> } else {
>> /* it will be delayed until msix is enabled, in write_config */
>> @@ -560,19 +558,19 @@ static void setup_interrupt(IVShmemState *s, int vector)
>> }
>> }
>>
>> -static void process_msg_shmem(IVShmemState *s, int fd)
>> +static void process_msg_shmem(IVShmemState *s, int fd, Error **errp)
>> {
>> Error *err = NULL;
>> void *ptr;
>>
>> if (memory_region_is_mapped(&s->ivshmem)) {
>> - error_report("shm already initialized");
>> + error_setg(errp, "server sent unexpected shared memory message");
>> close(fd);
>> return;
>> }
>>
>> if (check_shm_size(s, fd, &err) == -1) {
>> - error_report_err(err);
>> + error_propagate(errp, err);
>> close(fd);
>> return;
>> }
>> @@ -580,7 +578,7 @@ static void process_msg_shmem(IVShmemState *s, int fd)
>> /* mmap the region and map into the BAR2 */
>> ptr = mmap(0, s->ivshmem_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
>> if (ptr == MAP_FAILED) {
>> - error_report("Failed to mmap shared memory %s", strerror(errno));
>> + error_setg_errno(errp, errno, "Failed to mmap shared memory");
>> close(fd);
>> return;
>> }
>> @@ -591,17 +589,19 @@ static void process_msg_shmem(IVShmemState *s, int fd)
>> memory_region_add_subregion(&s->bar, 0, &s->ivshmem);
>> }
>>
>> -static void process_msg_disconnect(IVShmemState *s, uint16_t posn)
>> +static void process_msg_disconnect(IVShmemState *s, uint16_t posn,
>> + Error **errp)
>> {
>> IVSHMEM_DPRINTF("posn %d has gone away\n", posn);
>> if (posn >= s->nb_peers || posn == s->vm_id) {
>> - error_report("invalid peer %d", posn);
>> + error_setg(errp, "invalid peer %d", posn);
>> return;
>> }
>> close_peer_eventfds(s, posn);
>> }
>>
>> -static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd)
>> +static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd,
>> + Error **errp)
>> {
>> Peer *peer = &s->peers[posn];
>> int vector;
>> @@ -611,8 +611,8 @@ static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd)
>> * descriptor for vector N-1. Count messages to find the vector.
>> */
>> if (peer->nb_eventfds >= s->vectors) {
>> - error_report("Too many eventfd received, device has %d vectors",
>> - s->vectors);
>> + error_setg(errp, "Too many eventfd received, device has %d vectors",
>> + s->vectors);
>> close(fd);
>> return;
>> }
>> @@ -623,7 +623,8 @@ static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd)
>> fcntl_setfl(fd, O_NONBLOCK); /* msix/irqfd poll non block */
>>
>> if (posn == s->vm_id) {
>> - setup_interrupt(s, vector);
>> + setup_interrupt(s, vector, errp);
>> + /* TODO do we need to handle the error? */
>> }
>>
>> if (ivshmem_has_feature(s, IVSHMEM_IOEVENTFD)) {
>> @@ -631,18 +632,18 @@ static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd)
>> }
>> }
>>
>> -static void process_msg(IVShmemState *s, int64_t msg, int fd)
>> +static void process_msg(IVShmemState *s, int64_t msg, int fd, Error **errp)
>> {
>> IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n", msg, fd);
>>
>> if (msg < -1 || msg > IVSHMEM_MAX_PEERS) {
>> - error_report("server sent invalid message %" PRId64, msg);
>> + error_setg(errp, "server sent invalid message %" PRId64, msg);
>> close(fd);
>> return;
>> }
>>
>> if (msg == -1) {
>> - process_msg_shmem(s, fd);
>> + process_msg_shmem(s, fd, errp);
>> return;
>> }
>>
>> @@ -651,17 +652,18 @@ static void process_msg(IVShmemState *s, int64_t msg, int fd)
>> }
>>
>> if (fd >= 0) {
>> - process_msg_connect(s, msg, fd);
>> + process_msg_connect(s, msg, fd, errp);
>> } else if (s->vm_id == -1) {
>> s->vm_id = msg;
>> } else {
>> - process_msg_disconnect(s, msg);
>> + process_msg_disconnect(s, msg, errp);
>> }
>> }
>>
>> static void ivshmem_read(void *opaque, const uint8_t *buf, int size)
>> {
>> IVShmemState *s = opaque;
>> + Error *err = NULL;
>> int fd;
>> int64_t msg;
>>
>> @@ -672,10 +674,13 @@ static void ivshmem_read(void *opaque, const uint8_t *buf, int size)
>> fd = qemu_chr_fe_get_msgfd(s->server_chr);
>> IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n", msg, fd);
>>
>> - process_msg(s, msg, fd);
>> + process_msg(s, msg, fd, &err);
>> + if (err) {
>> + error_report_err(err);
>> + }
>> }
>>
>> -static int64_t ivshmem_recv_msg(IVShmemState *s, int *pfd)
>> +static int64_t ivshmem_recv_msg(IVShmemState *s, int *pfd, Error **errp)
>> {
>> int64_t msg;
>> int n, ret;
>> @@ -685,7 +690,7 @@ static int64_t ivshmem_recv_msg(IVShmemState *s, int *pfd)
>> ret = qemu_chr_fe_read_all(s->server_chr, (uint8_t *)&msg + n,
>> sizeof(msg) - n);
>> if (ret < 0 && ret != -EINTR) {
>> - /* TODO error handling */
>> + error_setg_errno(errp, -ret, "read from server failed");
>> return INT64_MIN;
>> }
>> n += ret;
>> @@ -695,15 +700,24 @@ static int64_t ivshmem_recv_msg(IVShmemState *s, int *pfd)
>> return msg;
>> }
>>
>> -static void ivshmem_recv_setup(IVShmemState *s)
>> +static void ivshmem_recv_setup(IVShmemState *s, Error **errp)
>> {
>> + Error *err = NULL;
>> int64_t msg;
>> int fd;
>>
>> - msg = ivshmem_recv_msg(s, &fd);
>> - if (fd != -1 || msg != IVSHMEM_PROTOCOL_VERSION) {
>> - fprintf(stderr, "incompatible version, you are connecting to a ivshmem-"
>> - "server using a different protocol please check your setup\n");
>> + msg = ivshmem_recv_msg(s, &fd, &err);
>> + if (err) {
>> + error_propagate(errp, err);
>> + return;
>> + }
>> + if (msg != IVSHMEM_PROTOCOL_VERSION) {
>> + error_setg(errp, "server sent version %" PRId64 ", expecting %d",
>> + msg, IVSHMEM_PROTOCOL_VERSION);
>> + return;
>> + }
>> + if (fd != -1) {
>> + error_setg(errp, "server sent invalid version message");
>> return;
>> }
>>
>> @@ -711,9 +725,19 @@ static void ivshmem_recv_setup(IVShmemState *s)
>> * Receive more messages until we got shared memory.
>> */
>> do {
>> - msg = ivshmem_recv_msg(s, &fd);
>> - process_msg(s, msg, fd);
>> + msg = ivshmem_recv_msg(s, &fd, &err);
>> + if (err) {
>> + error_propagate(errp, err);
>> + return;
>> + }
>> + process_msg(s, msg, fd, &err);
>> + if (err) {
>> + error_propagate(errp, err);
>> + return;
>> + }
>> } while (msg != -1);
>> +
>> + assert(memory_region_is_mapped(&s->ivshmem));
>
> This is still easy to trigger at run time, for example during hotplug
> with a broken or uncooperative server. Why not report an error?
We get there only after we received and *successfully* processed a -1
message with process_msg().
process_msg() delegates this message to process_msg_shmem(), which
either maps the memory or fails. If it fails, we propagate the error
and return, bypassing the assertion. The error will then be propagated
further up until it can be reported.
Therefore, the memory must be mapped here.
All clear now?
Now let me explain *why* I want the assertion. The purpose of the
previous patch and this one is to ensure that the realized device always
has the shared memory mapped. The loop does that, but it's not 100%
obvious, so I want the assertion to document my intent, and to prevent
screwups.
>>
>> /* Select the MSI-X vectors used by device.
>> @@ -765,7 +789,13 @@ static void ivshmem_enable_irqfd(IVShmemState *s)
>> int i;
>>
>> for (i = 0; i < s->peers[s->vm_id].nb_eventfds; i++) {
>> - ivshmem_add_kvm_msi_virq(s, i);
>> + Error *err = NULL;
>> +
>> + ivshmem_add_kvm_msi_virq(s, i, &err);
>> + if (err) {
>> + error_report_err(err);
>> + /* TODO do we need to handle the error? */
>> + }
>> }
>>
>> if (msix_set_vector_notifiers(pdev,
>> @@ -811,7 +841,7 @@ static void ivshmem_write_config(PCIDevice *pdev, uint32_t address,
>> pci_default_write_config(pdev, address, val, len);
>> is_enabled = msix_enabled(pdev);
>>
>> - if (kvm_msi_via_irqfd_enabled() && s->vm_id != -1) {
>> + if (kvm_msi_via_irqfd_enabled()) {
>> if (!was_enabled && is_enabled) {
>> ivshmem_enable_irqfd(s);
>> } else if (was_enabled && !is_enabled) {
>> @@ -930,15 +960,16 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
>> * Receive setup messages from server synchronously.
>> * Older versions did it asynchronously, but that creates a
>> * number of entertaining race conditions.
>> - * TODO Propagate errors! Without that, we still have races
>> - * on errors.
>> */
>> - ivshmem_recv_setup(s);
>> - if (memory_region_is_mapped(&s->ivshmem)) {
>> - qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive,
>> - ivshmem_read, NULL, s);
>> + ivshmem_recv_setup(s, &err);
>> + if (err) {
>> + error_propagate(errp, err);
>> + return;
>> }
>>
>> + qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive,
>> + ivshmem_read, NULL, s);
>> +
>> if (ivshmem_setup_interrupts(s) < 0) {
>> error_setg(errp, "failed to initialize interrupts");
>> return;
>> diff --git a/qemu-doc.texi b/qemu-doc.texi
>> index 65f3b29..8afbbcd 100644
>> --- a/qemu-doc.texi
>> +++ b/qemu-doc.texi
>> @@ -1289,14 +1289,7 @@ qemu-system-i386 -device ivshmem,size=@var{shm-size},vectors=@var{vectors},chard
>>
>> When using the server, the guest will be assigned a VM ID (>=0) that allows guests
>> using the same server to communicate via interrupts. Guests can read their
>> -VM ID from a device register (see example code). Since receiving the shared
>> -memory region from the server is asynchronous, there is a (small) chance the
>> -guest may boot before the shared memory is attached. To allow an application
>> -to ensure shared memory is attached, the VM ID register will return -1 (an
>> -invalid VM ID) until the memory is attached. Once the shared memory is
>> -attached, the VM ID will return the guest's valid VM ID. With these semantics,
>> -the guest application can check to ensure the shared memory is attached to the
>> -guest before proceeding.
>> +VM ID from a device register (see ivshmem-spec.txt).
>>
>> The @option{role} argument can be set to either master or peer and will affect
>> how the shared memory is migrated. With @option{role=master}, the guest will
>> --
>> 2.4.3
>>
>>
>
> The rest of the patch looks good.
Okay :)
^ permalink raw reply [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 28/42] ivshmem: Propagate errors through ivshmem_recv_setup()
2016-03-09 20:25 ` Markus Armbruster
@ 2016-03-10 0:44 ` Marc-André Lureau
2016-03-10 6:38 ` Markus Armbruster
0 siblings, 1 reply; 74+ messages in thread
From: Marc-André Lureau @ 2016-03-10 0:44 UTC (permalink / raw)
To: Markus Armbruster
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
On Wed, Mar 9, 2016 at 9:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
> Now let me explain *why* I want the assertion. The purpose of the
> previous patch and this one is to ensure that the realized device always
> has the shared memory mapped. The loop does that, but it's not 100%
> obvious, so I want the assertion to document my intent, and to prevent
> screwups.
alright then, a short comment would have helped! thanks
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 74+ messages in thread
* Re: [Qemu-devel] [PATCH v2 28/42] ivshmem: Propagate errors through ivshmem_recv_setup()
2016-03-10 0:44 ` Marc-André Lureau
@ 2016-03-10 6:38 ` Markus Armbruster
0 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-10 6:38 UTC (permalink / raw)
To: Marc-André Lureau
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
Marc-André Lureau <marcandre.lureau@gmail.com> writes:
> On Wed, Mar 9, 2016 at 9:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
>> Now let me explain *why* I want the assertion. The purpose of the
>> previous patch and this one is to ensure that the realized device always
>> has the shared memory mapped. The loop does that, but it's not 100%
>> obvious, so I want the assertion to document my intent, and to prevent
>> screwups.
>
>
> alright then, a short comment would have helped! thanks
I can add one.
^ permalink raw reply [flat|nested] 74+ messages in thread
* [Qemu-devel] [PATCH v2 29/42] ivshmem: Rely on server sending the ID right after the version
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (27 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 28/42] ivshmem: Propagate errors through ivshmem_recv_setup() Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 30/42] ivshmem: Drop the hackish test for UNIX domain chardev Markus Armbruster
` (14 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
The protocol specification (ivshmem-spec.txt, formerly
ivshmem_device_spec.txt) has always required the ID message to be sent
right at the beginning, and ivshmem-server has always complied. The
device, however, accepts it out of order. If an interrupt setup
arrived before it, though, it would be misinterpreted as connect
notification. Fix the latent bug by relying on the spec and
ivshmem-server's actual behavior.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/misc/ivshmem.c | 27 ++++++++++++++++++++++++---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index c3327dc..ca64654 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -653,8 +653,6 @@ static void process_msg(IVShmemState *s, int64_t msg, int fd, Error **errp)
if (fd >= 0) {
process_msg_connect(s, msg, fd, errp);
- } else if (s->vm_id == -1) {
- s->vm_id = msg;
} else {
process_msg_disconnect(s, msg, errp);
}
@@ -722,6 +720,30 @@ static void ivshmem_recv_setup(IVShmemState *s, Error **errp)
}
/*
+ * ivshmem-server sends the remaining initial messages in a fixed
+ * order, but the device has always accepted them in any order.
+ * Stay as compatible as practical, just in case people use
+ * servers that behave differently.
+ */
+
+ /*
+ * ivshmem_device_spec.txt has always required the ID message
+ * right here, and ivshmem-server has always complied. However,
+ * older versions of the device accepted it out of order, but
+ * broke when an interrupt setup message arrived before it.
+ */
+ msg = ivshmem_recv_msg(s, &fd, &err);
+ if (err) {
+ error_propagate(errp, err);
+ return;
+ }
+ if (fd != -1 || msg < 0 || msg > IVSHMEM_MAX_PEERS) {
+ error_setg(errp, "server sent invalid ID message");
+ return;
+ }
+ s->vm_id = msg;
+
+ /*
* Receive more messages until we got shared memory.
*/
do {
@@ -952,7 +974,6 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
/* we allocate enough space for 16 peers and grow as needed */
resize_peers(s, 16);
- s->vm_id = -1;
pci_register_bar(dev, 2, attr, &s->bar);
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 30/42] ivshmem: Drop the hackish test for UNIX domain chardev
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (28 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 29/42] ivshmem: Rely on server sending the ID right after the version Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 31/42] ivshmem: Simplify how we cope with short reads from server Markus Armbruster
` (13 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
The chardev must be capable of transmitting SCM_RIGHTS ancillary
messages. We check it by comparing CharDriverState member filename to
"unix:". That's almost as brittle as it is disgusting.
When the actual transmission all happened asynchronously, this check
was all we could do in realize(), and thus better than nothing. But
now we receive at least one SCM_RIGHTS synchronously in realize(),
it's not worth its keep anymore. Drop it.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/misc/ivshmem.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index ca64654..2b14daa 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -960,15 +960,6 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
memory_region_add_subregion(&s->bar, 0, mr);
pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar);
} else if (s->server_chr != NULL) {
- /* FIXME do not rely on what chr drivers put into filename */
- if (strncmp(s->server_chr->filename, "unix:", 5)) {
- error_setg(errp, "chardev is not a unix client socket");
- return;
- }
-
- /* if we get a UNIX socket as the parameter we will talk
- * to the ivshmem server to receive the memory region */
-
IVSHMEM_DPRINTF("using shared memory server (socket = %s)\n",
s->server_chr->filename);
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 31/42] ivshmem: Simplify how we cope with short reads from server
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (29 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 30/42] ivshmem: Drop the hackish test for UNIX domain chardev Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-09 12:46 ` Marc-André Lureau
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 32/42] ivshmem: Tighten check of property "size" Markus Armbruster
` (12 subsequent siblings)
43 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Short reads from a UNIX domain sockets are exceedingly unlikely when
the other side always sends eight bytes and we always read eight
bytes. We cope with them anyway. However, the code doing that is
rather convoluted. Dumb it down radically.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/misc/ivshmem.c | 75 ++++++++++++-------------------------------------------
1 file changed, 16 insertions(+), 59 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 2b14daa..ef4249b 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -26,7 +26,6 @@
#include "migration/migration.h"
#include "qemu/error-report.h"
#include "qemu/event_notifier.h"
-#include "qemu/fifo8.h"
#include "sysemu/char.h"
#include "sysemu/hostmem.h"
#include "qapi/visitor.h"
@@ -80,7 +79,6 @@ typedef struct IVShmemState {
uint32_t intrstatus;
CharDriverState *server_chr;
- Fifo8 incoming_fifo;
MemoryRegion ivshmem_mmio;
/* We might need to register the BAR before we actually have the memory.
@@ -99,6 +97,8 @@ typedef struct IVShmemState {
uint32_t vectors;
uint32_t features;
MSIVector *msi_vectors;
+ uint64_t msg_buf; /* buffer for receiving server messages */
+ int msg_buffered_bytes; /* #bytes in @msg_buf */
Error *migration_blocker;
@@ -255,11 +255,6 @@ static const MemoryRegionOps ivshmem_mmio_ops = {
},
};
-static int ivshmem_can_receive(void * opaque)
-{
- return sizeof(int64_t);
-}
-
static void ivshmem_vector_notify(void *opaque)
{
MSIVector *entry = opaque;
@@ -459,53 +454,6 @@ static void resize_peers(IVShmemState *s, int nb_peers)
}
}
-static bool fifo_update_and_get(IVShmemState *s, const uint8_t *buf, int size,
- void *data, size_t len)
-{
- const uint8_t *p;
- uint32_t num;
-
- assert(len <= sizeof(int64_t)); /* limitation of the fifo */
- if (fifo8_is_empty(&s->incoming_fifo) && size == len) {
- memcpy(data, buf, size);
- return true;
- }
-
- IVSHMEM_DPRINTF("short read of %d bytes\n", size);
-
- num = MIN(size, sizeof(int64_t) - fifo8_num_used(&s->incoming_fifo));
- fifo8_push_all(&s->incoming_fifo, buf, num);
-
- if (fifo8_num_used(&s->incoming_fifo) < len) {
- assert(num == 0);
- return false;
- }
-
- size -= num;
- buf += num;
- p = fifo8_pop_buf(&s->incoming_fifo, len, &num);
- assert(num == len);
-
- memcpy(data, p, len);
-
- if (size > 0) {
- fifo8_push_all(&s->incoming_fifo, buf, size);
- }
-
- return true;
-}
-
-static bool fifo_update_and_get_i64(IVShmemState *s,
- const uint8_t *buf, int size, int64_t *i64)
-{
- if (fifo_update_and_get(s, buf, size, i64, sizeof(*i64))) {
- *i64 = GINT64_FROM_LE(*i64);
- return true;
- }
-
- return false;
-}
-
static void ivshmem_add_kvm_msi_virq(IVShmemState *s, int vector,
Error **errp)
{
@@ -658,6 +606,14 @@ static void process_msg(IVShmemState *s, int64_t msg, int fd, Error **errp)
}
}
+static int ivshmem_can_receive(void *opaque)
+{
+ IVShmemState *s = opaque;
+
+ assert(s->msg_buffered_bytes < sizeof(s->msg_buf));
+ return sizeof(s->msg_buf) - s->msg_buffered_bytes;
+}
+
static void ivshmem_read(void *opaque, const uint8_t *buf, int size)
{
IVShmemState *s = opaque;
@@ -665,9 +621,14 @@ static void ivshmem_read(void *opaque, const uint8_t *buf, int size)
int fd;
int64_t msg;
- if (!fifo_update_and_get_i64(s, buf, size, &msg)) {
+ assert(size >= 0 && s->msg_buffered_bytes + size <= sizeof(s->msg_buf));
+ memcpy((unsigned char *)&s->msg_buf + s->msg_buffered_bytes, buf, size);
+ s->msg_buffered_bytes += size;
+ if (s->msg_buffered_bytes < sizeof(s->msg_buf)) {
return;
}
+ msg = le64_to_cpu(s->msg_buf);
+ s->msg_buffered_bytes = 0;
fd = qemu_chr_fe_get_msgfd(s->server_chr);
IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n", msg, fd);
@@ -1018,8 +979,6 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
}
}
- fifo8_create(&s->incoming_fifo, sizeof(int64_t));
-
if (s->role_val == IVSHMEM_PEER) {
error_setg(&s->migration_blocker,
"Migration is disabled when using feature 'peer mode' in device 'ivshmem'");
@@ -1032,8 +991,6 @@ static void pci_ivshmem_exit(PCIDevice *dev)
IVShmemState *s = IVSHMEM(dev);
int i;
- fifo8_destroy(&s->incoming_fifo);
-
if (s->migration_blocker) {
migrate_del_blocker(s->migration_blocker);
error_free(s->migration_blocker);
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 32/42] ivshmem: Tighten check of property "size"
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (30 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 31/42] ivshmem: Simplify how we cope with short reads from server Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 33/42] ivshmem: Implement shm=... with a memory backend Markus Armbruster
` (11 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
If size_t is narrower than 64 bits, passing uint64_t ivshmem_size to
mmap() truncates. Reject such sizes.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/misc/ivshmem.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index ef4249b..1c25621 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -87,7 +87,7 @@ typedef struct IVShmemState {
*/
MemoryRegion bar;
MemoryRegion ivshmem;
- uint64_t ivshmem_size; /* size of shared memory region */
+ size_t ivshmem_size; /* size of shared memory region */
uint32_t ivshmem_64bit;
Peer *peers;
@@ -361,7 +361,7 @@ static int check_shm_size(IVShmemState *s, int fd, Error **errp)
if (s->ivshmem_size > buf.st_size) {
error_setg(errp, "Requested memory size greater"
- " than shared object size (%" PRIu64 " > %" PRIu64")",
+ " than shared object size (%zu > %" PRIu64")",
s->ivshmem_size, (uint64_t)buf.st_size);
return -1;
} else {
@@ -861,7 +861,8 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
} else {
char *end;
int64_t size = qemu_strtosz(s->sizearg, &end);
- if (size < 0 || *end != '\0' || !is_power_of_2(size)) {
+ if (size < 0 || (size_t)size != size || *end != '\0'
+ || !is_power_of_2(size)) {
error_setg(errp, "Invalid size %s", s->sizearg);
return;
}
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 33/42] ivshmem: Implement shm=... with a memory backend
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (31 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 32/42] ivshmem: Tighten check of property "size" Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-09 11:31 ` Marc-André Lureau
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 34/42] ivshmem: Simplify memory regions for BAR 2 (shared memory) Markus Armbruster
` (10 subsequent siblings)
43 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
ivshmem has its very own code to create and map shared memory.
Replace that with an implicitly created memory backend. Reduces the
number of ways we create BAR 2 from three to two.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/misc/ivshmem.c | 79 ++++++++++++++++---------------------------------------
1 file changed, 23 insertions(+), 56 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 1c25621..747f9c3 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -26,6 +26,7 @@
#include "migration/migration.h"
#include "qemu/error-report.h"
#include "qemu/event_notifier.h"
+#include "qom/object_interfaces.h"
#include "sysemu/char.h"
#include "sysemu/hostmem.h"
#include "qapi/visitor.h"
@@ -369,31 +370,6 @@ static int check_shm_size(IVShmemState *s, int fd, Error **errp)
}
}
-/* create the shared memory BAR when we are not using the server, so we can
- * create the BAR and map the memory immediately */
-static int create_shared_memory_BAR(IVShmemState *s, int fd, uint8_t attr,
- Error **errp)
-{
- void * ptr;
-
- ptr = mmap(0, s->ivshmem_size, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);
- if (ptr == MAP_FAILED) {
- error_setg_errno(errp, errno, "Failed to mmap shared memory");
- return -1;
- }
-
- memory_region_init_ram_ptr(&s->ivshmem, OBJECT(s), "ivshmem.bar2",
- s->ivshmem_size, ptr);
- qemu_set_ram_fd(s->ivshmem.ram_addr, fd);
- vmstate_register_ram(&s->ivshmem, DEVICE(s));
- memory_region_add_subregion(&s->bar, 0, &s->ivshmem);
-
- /* region for shared memory */
- pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar);
-
- return 0;
-}
-
static void ivshmem_add_eventfd(IVShmemState *s, int posn, int i)
{
memory_region_add_eventfd(&s->ivshmem_mmio,
@@ -833,6 +809,23 @@ static void ivshmem_write_config(PCIDevice *pdev, uint32_t address,
}
}
+static void desugar_shm(IVShmemState *s)
+{
+ Object *obj;
+ char *path;
+
+ obj = object_new("memory-backend-file");
+ path = g_strdup_printf("/dev/shm/%s", s->shmobj);
+ object_property_set_str(obj, path, "mem-path", &error_abort);
+ g_free(path);
+ object_property_set_int(obj, s->ivshmem_size, "size", &error_abort);
+ object_property_set_bool(obj, true, "share", &error_abort);
+ object_property_add_child(OBJECT(s), "internal-shm-backend", obj,
+ &error_abort);
+ user_creatable_complete(obj, &error_abort);
+ s->hostmem = MEMORY_BACKEND(obj);
+}
+
static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
{
IVShmemState *s = IVSHMEM(dev);
@@ -911,6 +904,10 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
attr |= PCI_BASE_ADDRESS_MEM_TYPE_64;
}
+ if (s->shmobj) {
+ desugar_shm(s);
+ }
+
if (s->hostmem != NULL) {
MemoryRegion *mr;
@@ -921,7 +918,7 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
vmstate_register_ram(mr, DEVICE(s));
memory_region_add_subregion(&s->bar, 0, mr);
pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar);
- } else if (s->server_chr != NULL) {
+ } else {
IVSHMEM_DPRINTF("using shared memory server (socket = %s)\n",
s->server_chr->filename);
@@ -948,36 +945,6 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
error_setg(errp, "failed to initialize interrupts");
return;
}
- } else {
- /* just map the file immediately, we're not using a server */
- int fd;
-
- IVSHMEM_DPRINTF("using shm_open (shm object = %s)\n", s->shmobj);
-
- /* try opening with O_EXCL and if it succeeds zero the memory
- * by truncating to 0 */
- if ((fd = shm_open(s->shmobj, O_CREAT|O_RDWR|O_EXCL,
- S_IRWXU|S_IRWXG|S_IRWXO)) > 0) {
- /* truncate file to length PCI device's memory */
- if (ftruncate(fd, s->ivshmem_size) != 0) {
- error_report("could not truncate shared file");
- }
-
- } else if ((fd = shm_open(s->shmobj, O_CREAT|O_RDWR,
- S_IRWXU|S_IRWXG|S_IRWXO)) < 0) {
- error_setg(errp, "could not open shared file");
- return;
- }
-
- if (check_shm_size(s, fd, errp) == -1) {
- return;
- }
-
- create_shared_memory_BAR(s, fd, attr, &err);
- if (err) {
- error_propagate(errp, err);
- return;
- }
}
if (s->role_val == IVSHMEM_PEER) {
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 33/42] ivshmem: Implement shm=... with a memory backend
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 33/42] ivshmem: Implement shm=... with a memory backend Markus Armbruster
@ 2016-03-09 11:31 ` Marc-André Lureau
2016-03-09 20:59 ` Markus Armbruster
0 siblings, 1 reply; 74+ messages in thread
From: Marc-André Lureau @ 2016-03-09 11:31 UTC (permalink / raw)
To: Markus Armbruster
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
Hi
On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
> ivshmem has its very own code to create and map shared memory.
> Replace that with an implicitly created memory backend. Reduces the
> number of ways we create BAR 2 from three to two.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/misc/ivshmem.c | 79 ++++++++++++++++---------------------------------------
> 1 file changed, 23 insertions(+), 56 deletions(-)
>
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index 1c25621..747f9c3 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -26,6 +26,7 @@
> #include "migration/migration.h"
> #include "qemu/error-report.h"
> #include "qemu/event_notifier.h"
> +#include "qom/object_interfaces.h"
> #include "sysemu/char.h"
> #include "sysemu/hostmem.h"
> #include "qapi/visitor.h"
> @@ -369,31 +370,6 @@ static int check_shm_size(IVShmemState *s, int fd, Error **errp)
> }
> }
>
> -/* create the shared memory BAR when we are not using the server, so we can
> - * create the BAR and map the memory immediately */
> -static int create_shared_memory_BAR(IVShmemState *s, int fd, uint8_t attr,
> - Error **errp)
> -{
> - void * ptr;
> -
> - ptr = mmap(0, s->ivshmem_size, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);
> - if (ptr == MAP_FAILED) {
> - error_setg_errno(errp, errno, "Failed to mmap shared memory");
> - return -1;
> - }
> -
> - memory_region_init_ram_ptr(&s->ivshmem, OBJECT(s), "ivshmem.bar2",
> - s->ivshmem_size, ptr);
> - qemu_set_ram_fd(s->ivshmem.ram_addr, fd);
> - vmstate_register_ram(&s->ivshmem, DEVICE(s));
> - memory_region_add_subregion(&s->bar, 0, &s->ivshmem);
> -
> - /* region for shared memory */
> - pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar);
> -
> - return 0;
> -}
> -
> static void ivshmem_add_eventfd(IVShmemState *s, int posn, int i)
> {
> memory_region_add_eventfd(&s->ivshmem_mmio,
> @@ -833,6 +809,23 @@ static void ivshmem_write_config(PCIDevice *pdev, uint32_t address,
> }
> }
>
> +static void desugar_shm(IVShmemState *s)
> +{
> + Object *obj;
> + char *path;
> +
> + obj = object_new("memory-backend-file");
> + path = g_strdup_printf("/dev/shm/%s", s->shmobj);
> + object_property_set_str(obj, path, "mem-path", &error_abort);
> + g_free(path);
> + object_property_set_int(obj, s->ivshmem_size, "size", &error_abort);
> + object_property_set_bool(obj, true, "share", &error_abort);
> + object_property_add_child(OBJECT(s), "internal-shm-backend", obj,
> + &error_abort);
> + user_creatable_complete(obj, &error_abort);
> + s->hostmem = MEMORY_BACKEND(obj);
> +}
> +
> static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
> {
> IVShmemState *s = IVSHMEM(dev);
> @@ -911,6 +904,10 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
> attr |= PCI_BASE_ADDRESS_MEM_TYPE_64;
> }
>
> + if (s->shmobj) {
> + desugar_shm(s);
> + }
> +
> if (s->hostmem != NULL) {
> MemoryRegion *mr;
>
> @@ -921,7 +918,7 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
> vmstate_register_ram(mr, DEVICE(s));
> memory_region_add_subregion(&s->bar, 0, mr);
> pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar);
> - } else if (s->server_chr != NULL) {
> + } else {
> IVSHMEM_DPRINTF("using shared memory server (socket = %s)\n",
> s->server_chr->filename);
>
> @@ -948,36 +945,6 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
> error_setg(errp, "failed to initialize interrupts");
> return;
> }
> - } else {
> - /* just map the file immediately, we're not using a server */
> - int fd;
> -
> - IVSHMEM_DPRINTF("using shm_open (shm object = %s)\n", s->shmobj);
> -
> - /* try opening with O_EXCL and if it succeeds zero the memory
> - * by truncating to 0 */
> - if ((fd = shm_open(s->shmobj, O_CREAT|O_RDWR|O_EXCL,
> - S_IRWXU|S_IRWXG|S_IRWXO)) > 0) {
Nice patch, but it's worth pointing out that qemu file_ram_alloc()
creates file with open O_CREAT. Here you rely on the fact that
/dev/shm is present and file inside maps to POSIX shared memory object
names. That's a lot more restrictive than using shm_open().
Furthermore, the permissions are not the same. The current code uses
777 for some reasons, while qemu file_ram_alloc() is 644. I am not
convinced the cleanup is worth these braking changes, especially the
restriction to Linux only.
> - /* truncate file to length PCI device's memory */
> - if (ftruncate(fd, s->ivshmem_size) != 0) {
> - error_report("could not truncate shared file");
> - }
> -
> - } else if ((fd = shm_open(s->shmobj, O_CREAT|O_RDWR,
> - S_IRWXU|S_IRWXG|S_IRWXO)) < 0) {
> - error_setg(errp, "could not open shared file");
> - return;
> - }
> -
> - if (check_shm_size(s, fd, errp) == -1) {
> - return;
> - }
> -
> - create_shared_memory_BAR(s, fd, attr, &err);
> - if (err) {
> - error_propagate(errp, err);
> - return;
> - }
> }
>
> if (s->role_val == IVSHMEM_PEER) {
> --
> 2.4.3
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 33/42] ivshmem: Implement shm=... with a memory backend
2016-03-09 11:31 ` Marc-André Lureau
@ 2016-03-09 20:59 ` Markus Armbruster
2016-03-10 0:44 ` Marc-André Lureau
0 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-09 20:59 UTC (permalink / raw)
To: Marc-André Lureau
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
Marc-André Lureau <marcandre.lureau@gmail.com> writes:
> Hi
>
> On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
>> ivshmem has its very own code to create and map shared memory.
>> Replace that with an implicitly created memory backend. Reduces the
>> number of ways we create BAR 2 from three to two.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> hw/misc/ivshmem.c | 79 ++++++++++++++++---------------------------------------
>> 1 file changed, 23 insertions(+), 56 deletions(-)
>>
>> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
>> index 1c25621..747f9c3 100644
>> --- a/hw/misc/ivshmem.c
>> +++ b/hw/misc/ivshmem.c
>> @@ -26,6 +26,7 @@
>> #include "migration/migration.h"
>> #include "qemu/error-report.h"
>> #include "qemu/event_notifier.h"
>> +#include "qom/object_interfaces.h"
>> #include "sysemu/char.h"
>> #include "sysemu/hostmem.h"
>> #include "qapi/visitor.h"
>> @@ -369,31 +370,6 @@ static int check_shm_size(IVShmemState *s, int fd, Error **errp)
>> }
>> }
>>
>> -/* create the shared memory BAR when we are not using the server, so we can
>> - * create the BAR and map the memory immediately */
>> -static int create_shared_memory_BAR(IVShmemState *s, int fd, uint8_t attr,
>> - Error **errp)
>> -{
>> - void * ptr;
>> -
>> - ptr = mmap(0, s->ivshmem_size, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);
>> - if (ptr == MAP_FAILED) {
>> - error_setg_errno(errp, errno, "Failed to mmap shared memory");
>> - return -1;
>> - }
>> -
>> - memory_region_init_ram_ptr(&s->ivshmem, OBJECT(s), "ivshmem.bar2",
>> - s->ivshmem_size, ptr);
>> - qemu_set_ram_fd(s->ivshmem.ram_addr, fd);
>> - vmstate_register_ram(&s->ivshmem, DEVICE(s));
>> - memory_region_add_subregion(&s->bar, 0, &s->ivshmem);
>> -
>> - /* region for shared memory */
>> - pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar);
>> -
>> - return 0;
>> -}
>> -
>> static void ivshmem_add_eventfd(IVShmemState *s, int posn, int i)
>> {
>> memory_region_add_eventfd(&s->ivshmem_mmio,
>> @@ -833,6 +809,23 @@ static void ivshmem_write_config(PCIDevice *pdev, uint32_t address,
>> }
>> }
>>
>> +static void desugar_shm(IVShmemState *s)
>> +{
>> + Object *obj;
>> + char *path;
>> +
>> + obj = object_new("memory-backend-file");
>> + path = g_strdup_printf("/dev/shm/%s", s->shmobj);
>> + object_property_set_str(obj, path, "mem-path", &error_abort);
>> + g_free(path);
>> + object_property_set_int(obj, s->ivshmem_size, "size", &error_abort);
>> + object_property_set_bool(obj, true, "share", &error_abort);
>> + object_property_add_child(OBJECT(s), "internal-shm-backend", obj,
>> + &error_abort);
>> + user_creatable_complete(obj, &error_abort);
>> + s->hostmem = MEMORY_BACKEND(obj);
>> +}
>> +
>> static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
>> {
>> IVShmemState *s = IVSHMEM(dev);
>> @@ -911,6 +904,10 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
>> attr |= PCI_BASE_ADDRESS_MEM_TYPE_64;
>> }
>>
>> + if (s->shmobj) {
>> + desugar_shm(s);
>> + }
>> +
>> if (s->hostmem != NULL) {
>> MemoryRegion *mr;
>>
>> @@ -921,7 +918,7 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
>> vmstate_register_ram(mr, DEVICE(s));
>> memory_region_add_subregion(&s->bar, 0, mr);
>> pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar);
>> - } else if (s->server_chr != NULL) {
>> + } else {
>> IVSHMEM_DPRINTF("using shared memory server (socket = %s)\n",
>> s->server_chr->filename);
>>
>> @@ -948,36 +945,6 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
>> error_setg(errp, "failed to initialize interrupts");
>> return;
>> }
>> - } else {
>> - /* just map the file immediately, we're not using a server */
>> - int fd;
>> -
>> - IVSHMEM_DPRINTF("using shm_open (shm object = %s)\n", s->shmobj);
>> -
>> - /* try opening with O_EXCL and if it succeeds zero the memory
>> - * by truncating to 0 */
>> - if ((fd = shm_open(s->shmobj, O_CREAT|O_RDWR|O_EXCL,
>> - S_IRWXU|S_IRWXG|S_IRWXO)) > 0) {
>
> Nice patch, but it's worth pointing out that qemu file_ram_alloc()
> creates file with open O_CREAT. Here you rely on the fact that
> /dev/shm is present and file inside maps to POSIX shared memory object
> names. That's a lot more restrictive than using shm_open().
> Furthermore, the permissions are not the same. The current code uses
> 777 for some reasons, while qemu file_ram_alloc() is 644. I am not
> convinced the cleanup is worth these braking changes, especially the
> restriction to Linux only.
The integrated memory backend has to go.
Yes, my desugaring to memory-backend-file assumes Linux and the
conventional mount point /dev/shm.
For what it's worth, glibc implements shm_open() as a thin wrapper
around open() on all targets. On Linux, it looks for other mountpoints
when /dev/shm/ isn't there or unsuitable. On other targets, it always
uses /dev/shm/. I didn't bother to duplicate glibc's mountpoint search,
because distros converged to /dev/shm/ long ago.
The proper way to support POSIX shared memory objects on systems where
they're not files (and therefore can't be mapped with
memory-backend-file) is to create memory-backend-shm. If such systems
exist.
I didn't do this now, because one, I'm not aware of a system that needs
it, and two, ivshmem is Linux-specific anyway. ivshmem-plain could be
made more portable, and once that's done, memory-backend-shm might
become useful.
That leaves permissions. You're right, the patch changes them from 0777
to 0644. I'm inclined to call it a bug fix. I failed to mention it in
my commit message, and I'll fix that. We may want to mention it in
release notes, too.
>> - /* truncate file to length PCI device's memory */
>> - if (ftruncate(fd, s->ivshmem_size) != 0) {
>> - error_report("could not truncate shared file");
>> - }
>> -
>> - } else if ((fd = shm_open(s->shmobj, O_CREAT|O_RDWR,
>> - S_IRWXU|S_IRWXG|S_IRWXO)) < 0) {
>> - error_setg(errp, "could not open shared file");
>> - return;
>> - }
>> -
>> - if (check_shm_size(s, fd, errp) == -1) {
>> - return;
>> - }
>> -
>> - create_shared_memory_BAR(s, fd, attr, &err);
>> - if (err) {
>> - error_propagate(errp, err);
>> - return;
>> - }
>> }
>>
>> if (s->role_val == IVSHMEM_PEER) {
>> --
>> 2.4.3
>>
>>
^ permalink raw reply [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 33/42] ivshmem: Implement shm=... with a memory backend
2016-03-09 20:59 ` Markus Armbruster
@ 2016-03-10 0:44 ` Marc-André Lureau
2016-03-10 6:48 ` Markus Armbruster
0 siblings, 1 reply; 74+ messages in thread
From: Marc-André Lureau @ 2016-03-10 0:44 UTC (permalink / raw)
To: Markus Armbruster
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
Hi
On Wed, Mar 9, 2016 at 9:59 PM, Markus Armbruster <armbru@redhat.com> wrote:
> I didn't do this now, because one, I'm not aware of a system that needs
> it, and two, ivshmem is Linux-specific anyway. ivshmem-plain could be
> made more portable, and once that's done, memory-backend-shm might
> become useful.
How is ivshmem (the "plain" part) Linux-specific? Afaik it works on bsd too.
> That leaves permissions. You're right, the patch changes them from 0777
> to 0644. I'm inclined to call it a bug fix. I failed to mention it in
> my commit message, and I'll fix that. We may want to mention it in
> release notes, too.
That's good enough for me.
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 74+ messages in thread
* Re: [Qemu-devel] [PATCH v2 33/42] ivshmem: Implement shm=... with a memory backend
2016-03-10 0:44 ` Marc-André Lureau
@ 2016-03-10 6:48 ` Markus Armbruster
0 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-10 6:48 UTC (permalink / raw)
To: Marc-André Lureau
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
Marc-André Lureau <marcandre.lureau@gmail.com> writes:
> Hi
>
> On Wed, Mar 9, 2016 at 9:59 PM, Markus Armbruster <armbru@redhat.com> wrote:
>> The integrated memory backend has to go.
>>
>> Yes, my desugaring to memory-backend-file assumes Linux and the
>> conventional mount point /dev/shm.
>>
>> For what it's worth, glibc implements shm_open() as a thin wrapper
>> around open() on all targets. On Linux, it looks for other mountpoints
>> when /dev/shm/ isn't there or unsuitable. On other targets, it always
>> uses /dev/shm/. I didn't bother to duplicate glibc's mountpoint search,
>> because distros converged to /dev/shm/ long ago.
>>
>> The proper way to support POSIX shared memory objects on systems where
>> they're not files (and therefore can't be mapped with
>> memory-backend-file) is to create memory-backend-shm. If such systems
>> exist.
>>
>> I didn't do this now, because one, I'm not aware of a system that needs
>> it, and two, ivshmem is Linux-specific anyway. ivshmem-plain could be
>> made more portable, and once that's done, memory-backend-shm might
>> become useful.
>
> How is ivshmem (the "plain" part) Linux-specific? Afaik it works on bsd too.
To make ivshmem-plain more portable, either add suitable #ifdefs to
ivshmem.c or split ivshmem-plain off into its own file. As is, we only
compile ivshmem.c with CONFIG_EVENTFD.
If someone does that work, *and* any of the systems opened up by that
can't do use memory-backend-file, then those systems would profit from
memory-backend-shm.
>> That leaves permissions. You're right, the patch changes them from 0777
>> to 0644. I'm inclined to call it a bug fix. I failed to mention it in
>> my commit message, and I'll fix that. We may want to mention it in
>> release notes, too.
>
> That's good enough for me.
Okay :)
^ permalink raw reply [flat|nested] 74+ messages in thread
* [Qemu-devel] [PATCH v2 34/42] ivshmem: Simplify memory regions for BAR 2 (shared memory)
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (32 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 33/42] ivshmem: Implement shm=... with a memory backend Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-09 12:46 ` Marc-André Lureau
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 35/42] ivshmem: Inline check_shm_size() into its only caller Markus Armbruster
` (9 subsequent siblings)
43 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
ivshmem_realize() puts the shared memory region in a container region.
Used to be necessary to permit delayed mapping of the shared memory.
However, we recently moved to synchronous mapping, in "ivshmem:
Receive shared memory synchronously in realize()" and the commit
following it. The container is redundant since then. Drop it.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/misc/ivshmem.c | 45 ++++++++++++++++-----------------------------
1 file changed, 16 insertions(+), 29 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 747f9c3..6a52a62 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -82,12 +82,8 @@ typedef struct IVShmemState {
CharDriverState *server_chr;
MemoryRegion ivshmem_mmio;
- /* We might need to register the BAR before we actually have the memory.
- * So prepare a container MemoryRegion for the BAR immediately and
- * add a subregion when we have the memory.
- */
- MemoryRegion bar;
- MemoryRegion ivshmem;
+ MemoryRegion *ivshmem_bar2; /* BAR 2 (shared memory) */
+ MemoryRegion server_bar2; /* used with server_chr */
size_t ivshmem_size; /* size of shared memory region */
uint32_t ivshmem_64bit;
@@ -487,7 +483,7 @@ static void process_msg_shmem(IVShmemState *s, int fd, Error **errp)
Error *err = NULL;
void *ptr;
- if (memory_region_is_mapped(&s->ivshmem)) {
+ if (s->ivshmem_bar2) {
error_setg(errp, "server sent unexpected shared memory message");
close(fd);
return;
@@ -506,11 +502,10 @@ static void process_msg_shmem(IVShmemState *s, int fd, Error **errp)
close(fd);
return;
}
- memory_region_init_ram_ptr(&s->ivshmem, OBJECT(s),
+ memory_region_init_ram_ptr(&s->server_bar2, OBJECT(s),
"ivshmem.bar2", s->ivshmem_size, ptr);
- qemu_set_ram_fd(s->ivshmem.ram_addr, fd);
- vmstate_register_ram(&s->ivshmem, DEVICE(s));
- memory_region_add_subregion(&s->bar, 0, &s->ivshmem);
+ qemu_set_ram_fd(s->server_bar2.ram_addr, fd);
+ s->ivshmem_bar2 = &s->server_bar2;
}
static void process_msg_disconnect(IVShmemState *s, uint16_t posn,
@@ -696,7 +691,7 @@ static void ivshmem_recv_setup(IVShmemState *s, Error **errp)
}
} while (msg != -1);
- assert(memory_region_is_mapped(&s->ivshmem));
+ assert(s->ivshmem_bar2);
}
/* Select the MSI-X vectors used by device.
@@ -899,7 +894,6 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_MEMORY,
&s->ivshmem_mmio);
- memory_region_init(&s->bar, OBJECT(s), "ivshmem-bar2-container", s->ivshmem_size);
if (s->ivshmem_64bit) {
attr |= PCI_BASE_ADDRESS_MEM_TYPE_64;
}
@@ -909,15 +903,10 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
}
if (s->hostmem != NULL) {
- MemoryRegion *mr;
-
IVSHMEM_DPRINTF("using hostmem\n");
- mr = host_memory_backend_get_memory(MEMORY_BACKEND(s->hostmem),
- &error_abort);
- vmstate_register_ram(mr, DEVICE(s));
- memory_region_add_subregion(&s->bar, 0, mr);
- pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar);
+ s->ivshmem_bar2 = host_memory_backend_get_memory(s->hostmem,
+ &error_abort);
} else {
IVSHMEM_DPRINTF("using shared memory server (socket = %s)\n",
s->server_chr->filename);
@@ -925,8 +914,6 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
/* we allocate enough space for 16 peers and grow as needed */
resize_peers(s, 16);
- pci_register_bar(dev, 2, attr, &s->bar);
-
/*
* Receive setup messages from server synchronously.
* Older versions did it asynchronously, but that creates a
@@ -947,6 +934,9 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
}
}
+ vmstate_register_ram(s->ivshmem_bar2, DEVICE(s));
+ pci_register_bar(PCI_DEVICE(s), 2, attr, s->ivshmem_bar2);
+
if (s->role_val == IVSHMEM_PEER) {
error_setg(&s->migration_blocker,
"Migration is disabled when using feature 'peer mode' in device 'ivshmem'");
@@ -964,22 +954,19 @@ static void pci_ivshmem_exit(PCIDevice *dev)
error_free(s->migration_blocker);
}
- if (memory_region_is_mapped(&s->ivshmem)) {
+ if (memory_region_is_mapped(s->ivshmem_bar2)) {
if (!s->hostmem) {
- void *addr = memory_region_get_ram_ptr(&s->ivshmem);
- int fd;
+ void *addr = memory_region_get_ram_ptr(s->ivshmem_bar2);
if (munmap(addr, s->ivshmem_size) == -1) {
error_report("Failed to munmap shared memory %s",
strerror(errno));
}
- if ((fd = qemu_get_ram_fd(s->ivshmem.ram_addr)) != -1)
- close(fd);
+ close(qemu_get_ram_fd(s->ivshmem_bar2->ram_addr));
}
- vmstate_unregister_ram(&s->ivshmem, DEVICE(dev));
- memory_region_del_subregion(&s->bar, &s->ivshmem);
+ vmstate_unregister_ram(s->ivshmem_bar2, DEVICE(dev));
}
if (s->peers) {
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 34/42] ivshmem: Simplify memory regions for BAR 2 (shared memory)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 34/42] ivshmem: Simplify memory regions for BAR 2 (shared memory) Markus Armbruster
@ 2016-03-09 12:46 ` Marc-André Lureau
0 siblings, 0 replies; 74+ messages in thread
From: Marc-André Lureau @ 2016-03-09 12:46 UTC (permalink / raw)
To: Markus Armbruster
Cc: Paolo Bonzini, cam, Claudio Fontana, QEMU, David Marchand
On Mon, Mar 7, 2016 at 8:25 PM, Markus Armbruster <armbru@redhat.com> wrote:
> ivshmem_realize() puts the shared memory region in a container region.
> Used to be necessary to permit delayed mapping of the shared memory.
> However, we recently moved to synchronous mapping, in "ivshmem:
> Receive shared memory synchronously in realize()" and the commit
> following it. The container is redundant since then. Drop it.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 74+ messages in thread
* [Qemu-devel] [PATCH v2 35/42] ivshmem: Inline check_shm_size() into its only caller
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (33 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 34/42] ivshmem: Simplify memory regions for BAR 2 (shared memory) Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 36/42] qdev: New DEFINE_PROP_ON_OFF_AUTO Markus Armbruster
` (8 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Improve the error messages while there.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/misc/ivshmem.c | 37 +++++++++++--------------------------
1 file changed, 11 insertions(+), 26 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 6a52a62..da80c8e 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -343,29 +343,6 @@ static void watch_vector_notifier(IVShmemState *s, EventNotifier *n,
NULL, &s->msi_vectors[vector]);
}
-static int check_shm_size(IVShmemState *s, int fd, Error **errp)
-{
- /* check that the guest isn't going to try and map more memory than the
- * the object has allocated return -1 to indicate error */
-
- struct stat buf;
-
- if (fstat(fd, &buf) < 0) {
- error_setg(errp, "exiting: fstat on fd %d failed: %s",
- fd, strerror(errno));
- return -1;
- }
-
- if (s->ivshmem_size > buf.st_size) {
- error_setg(errp, "Requested memory size greater"
- " than shared object size (%zu > %" PRIu64")",
- s->ivshmem_size, (uint64_t)buf.st_size);
- return -1;
- } else {
- return 0;
- }
-}
-
static void ivshmem_add_eventfd(IVShmemState *s, int posn, int i)
{
memory_region_add_eventfd(&s->ivshmem_mmio,
@@ -480,7 +457,7 @@ static void setup_interrupt(IVShmemState *s, int vector, Error **errp)
static void process_msg_shmem(IVShmemState *s, int fd, Error **errp)
{
- Error *err = NULL;
+ struct stat buf;
void *ptr;
if (s->ivshmem_bar2) {
@@ -489,8 +466,16 @@ static void process_msg_shmem(IVShmemState *s, int fd, Error **errp)
return;
}
- if (check_shm_size(s, fd, &err) == -1) {
- error_propagate(errp, err);
+ if (fstat(fd, &buf) < 0) {
+ error_setg_errno(errp, errno,
+ "can't determine size of shared memory sent by server");
+ close(fd);
+ return;
+ }
+
+ if (s->ivshmem_size > buf.st_size) {
+ error_setg(errp, "server sent only %zd bytes of shared memory",
+ (size_t)buf.st_size);
close(fd);
return;
}
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 36/42] qdev: New DEFINE_PROP_ON_OFF_AUTO
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (34 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 35/42] ivshmem: Inline check_shm_size() into its only caller Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 37/42] ivshmem: Replace int role_val by OnOffAuto master Markus Armbruster
` (7 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/core/qdev-properties.c | 10 ++++++++++
include/hw/qdev-properties.h | 3 +++
2 files changed, 13 insertions(+)
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index bc89800..d2f5a08 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -516,6 +516,16 @@ PropertyInfo qdev_prop_macaddr = {
.set = set_mac,
};
+/* --- on/off/auto --- */
+
+PropertyInfo qdev_prop_on_off_auto = {
+ .name = "OnOffAuto",
+ .description = "on/off/auto",
+ .enum_table = OnOffAuto_lookup,
+ .get = get_enum,
+ .set = set_enum,
+};
+
/* --- lost tick policy --- */
QEMU_BUILD_BUG_ON(sizeof(LostTickPolicy) != sizeof(int));
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index 03a1b91..0586cac 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -18,6 +18,7 @@ extern PropertyInfo qdev_prop_string;
extern PropertyInfo qdev_prop_chr;
extern PropertyInfo qdev_prop_ptr;
extern PropertyInfo qdev_prop_macaddr;
+extern PropertyInfo qdev_prop_on_off_auto;
extern PropertyInfo qdev_prop_losttickpolicy;
extern PropertyInfo qdev_prop_bios_chs_trans;
extern PropertyInfo qdev_prop_fdc_drive_type;
@@ -155,6 +156,8 @@ extern PropertyInfo qdev_prop_arraylen;
DEFINE_PROP(_n, _s, _f, qdev_prop_drive, BlockBackend *)
#define DEFINE_PROP_MACADDR(_n, _s, _f) \
DEFINE_PROP(_n, _s, _f, qdev_prop_macaddr, MACAddr)
+#define DEFINE_PROP_ON_OFF_AUTO(_n, _s, _f, _d) \
+ DEFINE_PROP_DEFAULT(_n, _s, _f, _d, qdev_prop_on_off_auto, OnOffAuto)
#define DEFINE_PROP_LOSTTICKPOLICY(_n, _s, _f, _d) \
DEFINE_PROP_DEFAULT(_n, _s, _f, _d, qdev_prop_losttickpolicy, \
LostTickPolicy)
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 37/42] ivshmem: Replace int role_val by OnOffAuto master
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (35 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 36/42] qdev: New DEFINE_PROP_ON_OFF_AUTO Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-09 12:46 ` Marc-André Lureau
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 38/42] ivshmem: Split ivshmem-plain, ivshmem-doorbell off ivshmem Markus Armbruster
` (6 subsequent siblings)
43 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
In preparation of making it a qdev property.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/misc/ivshmem.c | 31 +++++++++++++++++++------------
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index da80c8e..a8b6851 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -43,9 +43,6 @@
#define IVSHMEM_IOEVENTFD 0
#define IVSHMEM_MSI 1
-#define IVSHMEM_PEER 0
-#define IVSHMEM_MASTER 1
-
#define IVSHMEM_REG_BAR_SIZE 0x100
#define IVSHMEM_DEBUG 0
@@ -97,12 +94,12 @@ typedef struct IVShmemState {
uint64_t msg_buf; /* buffer for receiving server messages */
int msg_buffered_bytes; /* #bytes in @msg_buf */
+ OnOffAuto master;
Error *migration_blocker;
char * shmobj;
char * sizearg;
char * role;
- int role_val; /* scalar to avoid multiple string comparisons */
} IVShmemState;
/* registers for the Inter-VM shared memory device */
@@ -118,6 +115,12 @@ static inline uint32_t ivshmem_has_feature(IVShmemState *ivs,
return (ivs->features & (1 << feature));
}
+static inline bool ivshmem_is_master(IVShmemState *s)
+{
+ assert(s->master != ON_OFF_AUTO_AUTO);
+ return s->master == ON_OFF_AUTO_ON;
+}
+
static void ivshmem_update_irq(IVShmemState *s)
{
PCIDevice *d = PCI_DEVICE(s);
@@ -852,15 +855,15 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
/* check that role is reasonable */
if (s->role) {
if (strncmp(s->role, "peer", 5) == 0) {
- s->role_val = IVSHMEM_PEER;
+ s->master = ON_OFF_AUTO_OFF;
} else if (strncmp(s->role, "master", 7) == 0) {
- s->role_val = IVSHMEM_MASTER;
+ s->master = ON_OFF_AUTO_ON;
} else {
error_setg(errp, "'role' must be 'peer' or 'master'");
return;
}
} else {
- s->role_val = IVSHMEM_MASTER; /* default */
+ s->master = ON_OFF_AUTO_AUTO;
}
pci_conf = dev->config;
@@ -922,7 +925,11 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
vmstate_register_ram(s->ivshmem_bar2, DEVICE(s));
pci_register_bar(PCI_DEVICE(s), 2, attr, s->ivshmem_bar2);
- if (s->role_val == IVSHMEM_PEER) {
+ if (s->master == ON_OFF_AUTO_AUTO) {
+ s->master = s->vm_id == 0 ? ON_OFF_AUTO_ON : ON_OFF_AUTO_OFF;
+ }
+
+ if (!ivshmem_is_master(s)) {
error_setg(&s->migration_blocker,
"Migration is disabled when using feature 'peer mode' in device 'ivshmem'");
migrate_add_blocker(s->migration_blocker);
@@ -984,7 +991,7 @@ static int ivshmem_pre_load(void *opaque)
{
IVShmemState *s = opaque;
- if (s->role_val == IVSHMEM_PEER) {
+ if (!ivshmem_is_master(s)) {
error_report("'peer' devices are not migratable");
return -EINVAL;
}
@@ -1010,9 +1017,9 @@ static int ivshmem_load_old(QEMUFile *f, void *opaque, int version_id)
return -EINVAL;
}
- if (s->role_val == IVSHMEM_PEER) {
- error_report("'peer' devices are not migratable");
- return -EINVAL;
+ ret = ivshmem_pre_load(s);
+ if (ret) {
+ return ret;
}
ret = pci_device_load(pdev, f);
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 38/42] ivshmem: Split ivshmem-plain, ivshmem-doorbell off ivshmem
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (36 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 37/42] ivshmem: Replace int role_val by OnOffAuto master Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 39/42] ivshmem: Clean up after the previous commit Markus Armbruster
` (5 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
ivshmem can be configured with and without interrupt capability
(a.k.a. "doorbell"). The two configurations have largely disjoint
options, which makes for a confusing (and badly checked) user
interface. Moreover, the device can't tell the guest whether its
doorbell is enabled.
Create two new device models ivshmem-plain and ivshmem-doorbell, and
deprecate the old one.
Changes from ivshmem:
* PCI revision is 1 instead of 0. The new revision is fully backwards
compatible for guests. Guests may elect to require at least
revision 1 to make sure they're not exposed to the funny "no shared
memory, yet" state.
* Property "role" replaced by "master". role=master becomes
master=on, role=peer becomes master=off. Default is off instead of
auto.
* Property "use64" is gone. The new devices always have 64 bit BARs.
Changes from ivshmem to ivshmem-plain:
* The Interrupt Pin register in PCI config space is zero (does not use
an interrupt pin) instead of one (uses INTA).
* Property "x-memdev" is renamed to "memdev".
* Properties "shm" and "size" are gone. Use property "memdev"
instead.
* Property "msi" is gone. The new device can't have MSI-X capability.
It can't interrupt anyway.
* Properties "ioeventfd" and "vectors" are gone. They're meaningless
without interrupts anyway.
Changes from ivshmem to ivshmem-doorbell:
* Property "msi" is gone. The new device always has MSI-X capability.
* Property "ioeventfd" defaults to on instead of off.
* Property "size" is gone. The new device can only map all the shared
memory received from the server.
Guests can easily find out whether the device is configured for
interrupts by checking for MSI-X capability.
Note: some code added in sub-optimal places to make the diff easier to
review. The next commit will move it to more sensible places.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
docs/specs/ivshmem-spec.txt | 66 +++++-----
hw/misc/ivshmem.c | 312 ++++++++++++++++++++++++++++++++------------
qemu-doc.texi | 33 ++---
tests/ivshmem-test.c | 12 +-
4 files changed, 289 insertions(+), 134 deletions(-)
diff --git a/docs/specs/ivshmem-spec.txt b/docs/specs/ivshmem-spec.txt
index 4c33973..f3912c0 100644
--- a/docs/specs/ivshmem-spec.txt
+++ b/docs/specs/ivshmem-spec.txt
@@ -17,9 +17,10 @@ get interrupted by its peers.
There are two basic configurations:
-- Just shared memory: -device ivshmem,shm=NAME,...
+- Just shared memory: -device ivshmem-plain,memdev=HMB,...
- This uses shared memory object NAME.
+ This uses host memory backend HMB. It should have option "share"
+ set.
- Shared memory plus interrupts: -device ivshmem,chardev=CHR,vectors=N,...
@@ -30,9 +31,8 @@ There are two basic configurations:
Each peer gets assigned a unique ID by the server. IDs must be
between 0 and 65535.
- Interrupts are message-signaled by default (MSI-X). With msi=off
- the device has no MSI-X capability, and uses legacy INTx instead.
- vectors=N configures the number of vectors to use.
+ Interrupts are message-signaled (MSI-X). vectors=N configures the
+ number of vectors to use.
For more details on ivshmem device properties, see The QEMU Emulator
User Documentation (qemu-doc.*).
@@ -40,14 +40,15 @@ User Documentation (qemu-doc.*).
== The ivshmem PCI device's guest interface ==
-The device has vendor ID 1af4, device ID 1110, revision 0.
+The device has vendor ID 1af4, device ID 1110, revision 1. Before
+QEMU 2.6.0, it had revision 0.
=== PCI BARs ===
The ivshmem PCI device has two or three BARs:
- BAR0 holds device registers (256 Byte MMIO)
-- BAR1 holds MSI-X table and PBA (only when using MSI-X)
+- BAR1 holds MSI-X table and PBA (only ivshmem-doorbell)
- BAR2 maps the shared memory object
There are two ways to use this device:
@@ -58,18 +59,19 @@ There are two ways to use this device:
user space (see http://dpdk.org/browse/memnic).
- If you additionally need the capability for peers to interrupt each
- other, you need BAR0 and, if using MSI-X, BAR1. You will most
- likely want to write a kernel driver to handle interrupts. Requires
- the device to be configured for interrupts, obviously.
+ other, you need BAR0 and BAR1. You will most likely want to write a
+ kernel driver to handle interrupts. Requires the device to be
+ configured for interrupts, obviously.
Before QEMU 2.6.0, BAR2 can initially be invalid if the device is
configured for interrupts. It becomes safely accessible only after
-the ivshmem server provided the shared memory. Guest software should
-wait for the IVPosition register (described below) to become
-non-negative before accessing BAR2.
+the ivshmem server provided the shared memory. These devices have PCI
+revision 0 rather than 1. Guest software should wait for the
+IVPosition register (described below) to become non-negative before
+accessing BAR2.
-The device is not capable to tell guest software whether it is
-configured for interrupts.
+Revision 0 of the device is not capable to tell guest software whether
+it is configured for interrupts.
=== PCI device registers ===
@@ -77,10 +79,12 @@ BAR 0 contains the following registers:
Offset Size Access On reset Function
0 4 read/write 0 Interrupt Mask
- bit 0: peer interrupt
+ bit 0: peer interrupt (rev 0)
+ reserved (rev 1)
bit 1..31: reserved
4 4 read/write 0 Interrupt Status
- bit 0: peer interrupt
+ bit 0: peer interrupt (rev 0)
+ reserved (rev 1)
bit 1..31: reserved
8 4 read-only 0 or ID IVPosition
12 4 write-only N/A Doorbell
@@ -92,18 +96,18 @@ Software should only access the registers as specified in column
"Access". Reserved bits should be ignored on read, and preserved on
write.
-Interrupt Status and Mask Register together control the legacy INTx
-interrupt when the device has no MSI-X capability: INTx is asserted
-when the bit-wise AND of Status and Mask is non-zero and the device
-has no MSI-X capability. Interrupt Status Register bit 0 becomes 1
-when an interrupt request from a peer is received. Reading the
-register clears it.
+In revision 0 of the device, Interrupt Status and Mask Register
+together control the legacy INTx interrupt when the device has no
+MSI-X capability: INTx is asserted when the bit-wise AND of Status and
+Mask is non-zero and the device has no MSI-X capability. Interrupt
+Status Register bit 0 becomes 1 when an interrupt request from a peer
+is received. Reading the register clears it.
IVPosition Register: if the device is not configured for interrupts,
this is zero. Else, it is the device's ID (between 0 and 65535).
Before QEMU 2.6.0, the register may read -1 for a short while after
-reset.
+reset. These devices have PCI revision 0 rather than 1.
There is no good way for software to find out whether the device is
configured for interrupts. A positive IVPosition means interrupts,
@@ -124,14 +128,14 @@ interrupt vectors connected, the write is ignored. The device is not
capable to tell guest software what peers are connected, or how many
interrupt vectors are connected.
-If the peer doesn't use MSI-X, its Interrupt Status register is set to
-1. This asserts INTx unless masked by the Interrupt Mask register.
-The device is not capable to communicate the interrupt vector to guest
-software then.
+The peer's interrupt for this vector then becomes pending. There is
+no way for software to clear the pending bit, and a polling mode of
+operation is therefore impossible.
-If the peer uses MSI-X, the interrupt for this vector becomes pending.
-There is no way for software to clear the pending bit, and a polling
-mode of operation is therefore impossible with MSI-X.
+If the peer is a revision 0 device without MSI-X capability, its
+Interrupt Status register is set to 1. This asserts INTx unless
+masked by the Interrupt Mask register. The device is not capable to
+communicate the interrupt vector to guest software then.
With multiple MSI-X vectors, different vectors can be used to indicate
different events have occurred. The semantics of interrupt vectors
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index a8b6851..1fd2ef6 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -29,6 +29,7 @@
#include "qom/object_interfaces.h"
#include "sysemu/char.h"
#include "sysemu/hostmem.h"
+#include "sysemu/qtest.h"
#include "qapi/visitor.h"
#include "exec/ram_addr.h"
@@ -53,6 +54,18 @@
} \
} while (0)
+#define TYPE_IVSHMEM_COMMON "ivshmem-common"
+#define IVSHMEM_COMMON(obj) \
+ OBJECT_CHECK(IVShmemState, (obj), TYPE_IVSHMEM_COMMON)
+
+#define TYPE_IVSHMEM_PLAIN "ivshmem-plain"
+#define IVSHMEM_PLAIN(obj) \
+ OBJECT_CHECK(IVShmemState, (obj), TYPE_IVSHMEM_PLAIN)
+
+#define TYPE_IVSHMEM_DOORBELL "ivshmem-doorbell"
+#define IVSHMEM_DOORBELL(obj) \
+ OBJECT_CHECK(IVShmemState, (obj), TYPE_IVSHMEM_DOORBELL)
+
#define TYPE_IVSHMEM "ivshmem"
#define IVSHMEM(obj) \
OBJECT_CHECK(IVShmemState, (obj), TYPE_IVSHMEM)
@@ -81,8 +94,6 @@ typedef struct IVShmemState {
MemoryRegion *ivshmem_bar2; /* BAR 2 (shared memory) */
MemoryRegion server_bar2; /* used with server_chr */
- size_t ivshmem_size; /* size of shared memory region */
- uint32_t ivshmem_64bit;
Peer *peers;
int nb_peers; /* space in @peers[] */
@@ -97,9 +108,12 @@ typedef struct IVShmemState {
OnOffAuto master;
Error *migration_blocker;
- char * shmobj;
- char * sizearg;
- char * role;
+ /* legacy cruft */
+ char *role;
+ char *shmobj;
+ char *sizearg;
+ size_t legacy_size;
+ uint32_t not_legacy_32bit;
} IVShmemState;
/* registers for the Inter-VM shared memory device */
@@ -259,7 +273,7 @@ static void ivshmem_vector_notify(void *opaque)
{
MSIVector *entry = opaque;
PCIDevice *pdev = entry->pdev;
- IVShmemState *s = IVSHMEM(pdev);
+ IVShmemState *s = IVSHMEM_COMMON(pdev);
int vector = entry - s->msi_vectors;
EventNotifier *n = &s->peers[s->vm_id].eventfds[vector];
@@ -280,7 +294,7 @@ static void ivshmem_vector_notify(void *opaque)
static int ivshmem_vector_unmask(PCIDevice *dev, unsigned vector,
MSIMessage msg)
{
- IVShmemState *s = IVSHMEM(dev);
+ IVShmemState *s = IVSHMEM_COMMON(dev);
EventNotifier *n = &s->peers[s->vm_id].eventfds[vector];
MSIVector *v = &s->msi_vectors[vector];
int ret;
@@ -297,7 +311,7 @@ static int ivshmem_vector_unmask(PCIDevice *dev, unsigned vector,
static void ivshmem_vector_mask(PCIDevice *dev, unsigned vector)
{
- IVShmemState *s = IVSHMEM(dev);
+ IVShmemState *s = IVSHMEM_COMMON(dev);
EventNotifier *n = &s->peers[s->vm_id].eventfds[vector];
int ret;
@@ -314,7 +328,7 @@ static void ivshmem_vector_poll(PCIDevice *dev,
unsigned int vector_start,
unsigned int vector_end)
{
- IVShmemState *s = IVSHMEM(dev);
+ IVShmemState *s = IVSHMEM_COMMON(dev);
unsigned int vector;
IVSHMEM_DPRINTF("vector poll %p %d-%d\n", dev, vector_start, vector_end);
@@ -461,6 +475,7 @@ static void setup_interrupt(IVShmemState *s, int vector, Error **errp)
static void process_msg_shmem(IVShmemState *s, int fd, Error **errp)
{
struct stat buf;
+ size_t size;
void *ptr;
if (s->ivshmem_bar2) {
@@ -476,22 +491,28 @@ static void process_msg_shmem(IVShmemState *s, int fd, Error **errp)
return;
}
- if (s->ivshmem_size > buf.st_size) {
- error_setg(errp, "server sent only %zd bytes of shared memory",
- (size_t)buf.st_size);
- close(fd);
- return;
+ size = buf.st_size;
+
+ /* Legacy cruft */
+ if (s->legacy_size != SIZE_MAX) {
+ if (size < s->legacy_size) {
+ error_setg(errp, "server sent only %zd bytes of shared memory",
+ (size_t)buf.st_size);
+ close(fd);
+ return;
+ }
+ size = s->legacy_size;
}
/* mmap the region and map into the BAR2 */
- ptr = mmap(0, s->ivshmem_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
+ ptr = mmap(0, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
if (ptr == MAP_FAILED) {
error_setg_errno(errp, errno, "Failed to mmap shared memory");
close(fd);
return;
}
memory_region_init_ram_ptr(&s->server_bar2, OBJECT(s),
- "ivshmem.bar2", s->ivshmem_size, ptr);
+ "ivshmem.bar2", size, ptr);
qemu_set_ram_fd(s->server_bar2.ram_addr, fd);
s->ivshmem_bar2 = &s->server_bar2;
}
@@ -701,7 +722,7 @@ static void ivshmem_vector_use(IVShmemState *s)
static void ivshmem_reset(DeviceState *d)
{
- IVShmemState *s = IVSHMEM(d);
+ IVShmemState *s = IVSHMEM_COMMON(d);
s->intrstatus = 0;
s->intrmask = 0;
@@ -777,7 +798,7 @@ static void ivshmem_disable_irqfd(IVShmemState *s)
static void ivshmem_write_config(PCIDevice *pdev, uint32_t address,
uint32_t val, int len)
{
- IVShmemState *s = IVSHMEM(pdev);
+ IVShmemState *s = IVSHMEM_COMMON(pdev);
int is_enabled, was_enabled = msix_enabled(pdev);
pci_default_write_config(pdev, address, val, len);
@@ -801,7 +822,7 @@ static void desugar_shm(IVShmemState *s)
path = g_strdup_printf("/dev/shm/%s", s->shmobj);
object_property_set_str(obj, path, "mem-path", &error_abort);
g_free(path);
- object_property_set_int(obj, s->ivshmem_size, "size", &error_abort);
+ object_property_set_int(obj, s->legacy_size, "size", &error_abort);
object_property_set_bool(obj, true, "share", &error_abort);
object_property_add_child(OBJECT(s), "internal-shm-backend", obj,
&error_abort);
@@ -809,42 +830,14 @@ static void desugar_shm(IVShmemState *s)
s->hostmem = MEMORY_BACKEND(obj);
}
-static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
+static void ivshmem_common_realize(PCIDevice *dev, Error **errp)
{
- IVShmemState *s = IVSHMEM(dev);
+ IVShmemState *s = IVSHMEM_COMMON(dev);
Error *err = NULL;
uint8_t *pci_conf;
uint8_t attr = PCI_BASE_ADDRESS_SPACE_MEMORY |
PCI_BASE_ADDRESS_MEM_PREFETCH;
- if (!!s->server_chr + !!s->shmobj + !!s->hostmem != 1) {
- error_setg(errp,
- "You must specify either 'shm', 'chardev' or 'x-memdev'");
- return;
- }
-
- if (s->hostmem) {
- MemoryRegion *mr;
-
- if (s->sizearg) {
- g_warning("size argument ignored with hostmem");
- }
-
- mr = host_memory_backend_get_memory(s->hostmem, &error_abort);
- s->ivshmem_size = memory_region_size(mr);
- } else if (s->sizearg == NULL) {
- s->ivshmem_size = 4 << 20; /* 4 MB default */
- } else {
- char *end;
- int64_t size = qemu_strtosz(s->sizearg, &end);
- if (size < 0 || (size_t)size != size || *end != '\0'
- || !is_power_of_2(size)) {
- error_setg(errp, "Invalid size %s", s->sizearg);
- return;
- }
- s->ivshmem_size = size;
- }
-
/* IRQFD requires MSI */
if (ivshmem_has_feature(s, IVSHMEM_IOEVENTFD) &&
!ivshmem_has_feature(s, IVSHMEM_MSI)) {
@@ -852,29 +845,9 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
return;
}
- /* check that role is reasonable */
- if (s->role) {
- if (strncmp(s->role, "peer", 5) == 0) {
- s->master = ON_OFF_AUTO_OFF;
- } else if (strncmp(s->role, "master", 7) == 0) {
- s->master = ON_OFF_AUTO_ON;
- } else {
- error_setg(errp, "'role' must be 'peer' or 'master'");
- return;
- }
- } else {
- s->master = ON_OFF_AUTO_AUTO;
- }
-
pci_conf = dev->config;
pci_conf[PCI_COMMAND] = PCI_COMMAND_IO | PCI_COMMAND_MEMORY;
- /*
- * Note: we don't use INTx with IVSHMEM_MSI at all, so this is a
- * bald-faced lie then. But it's a backwards compatible lie.
- */
- pci_config_set_interrupt_pin(pci_conf, 1);
-
memory_region_init_io(&s->ivshmem_mmio, OBJECT(s), &ivshmem_mmio_ops, s,
"ivshmem-mmio", IVSHMEM_REG_BAR_SIZE);
@@ -882,14 +855,10 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_MEMORY,
&s->ivshmem_mmio);
- if (s->ivshmem_64bit) {
+ if (!s->not_legacy_32bit) {
attr |= PCI_BASE_ADDRESS_MEM_TYPE_64;
}
- if (s->shmobj) {
- desugar_shm(s);
- }
-
if (s->hostmem != NULL) {
IVSHMEM_DPRINTF("using hostmem\n");
@@ -936,9 +905,68 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
}
}
-static void pci_ivshmem_exit(PCIDevice *dev)
+static void ivshmem_realize(PCIDevice *dev, Error **errp)
{
- IVShmemState *s = IVSHMEM(dev);
+ IVShmemState *s = IVSHMEM_COMMON(dev);
+
+ if (!qtest_enabled()) {
+ error_report("ivshmem is deprecated, please use ivshmem-plain"
+ " or ivshmem-doorbell instead");
+ }
+
+ if (!!s->server_chr + !!s->shmobj + !!s->hostmem != 1) {
+ error_setg(errp,
+ "You must specify either 'shm', 'chardev' or 'x-memdev'");
+ return;
+ }
+
+ if (s->hostmem) {
+ if (s->sizearg) {
+ g_warning("size argument ignored with hostmem");
+ }
+ } else if (s->sizearg == NULL) {
+ s->legacy_size = 4 << 20; /* 4 MB default */
+ } else {
+ char *end;
+ int64_t size = qemu_strtosz(s->sizearg, &end);
+ if (size < 0 || (size_t)size != size || *end != '\0'
+ || !is_power_of_2(size)) {
+ error_setg(errp, "Invalid size %s", s->sizearg);
+ return;
+ }
+ s->legacy_size = size;
+ }
+
+ /* check that role is reasonable */
+ if (s->role) {
+ if (strncmp(s->role, "peer", 5) == 0) {
+ s->master = ON_OFF_AUTO_OFF;
+ } else if (strncmp(s->role, "master", 7) == 0) {
+ s->master = ON_OFF_AUTO_ON;
+ } else {
+ error_setg(errp, "'role' must be 'peer' or 'master'");
+ return;
+ }
+ } else {
+ s->master = ON_OFF_AUTO_AUTO;
+ }
+
+ if (s->shmobj) {
+ desugar_shm(s);
+ }
+
+ /*
+ * Note: we don't use INTx with IVSHMEM_MSI at all, so this is a
+ * bald-faced lie then. But it's a backwards compatible lie.
+ */
+ pci_config_set_interrupt_pin(dev->config, 1);
+
+ ivshmem_common_realize(dev, errp);
+}
+
+static void ivshmem_exit(PCIDevice *dev)
+{
+ IVShmemState *s = IVSHMEM_COMMON(dev);
int i;
if (s->migration_blocker) {
@@ -950,7 +978,7 @@ static void pci_ivshmem_exit(PCIDevice *dev)
if (!s->hostmem) {
void *addr = memory_region_get_ram_ptr(s->ivshmem_bar2);
- if (munmap(addr, s->ivshmem_size) == -1) {
+ if (munmap(addr, memory_region_size(s->ivshmem_bar2) == -1)) {
error_report("Failed to munmap shared memory %s",
strerror(errno));
}
@@ -1065,28 +1093,39 @@ static Property ivshmem_properties[] = {
DEFINE_PROP_BIT("msi", IVShmemState, features, IVSHMEM_MSI, true),
DEFINE_PROP_STRING("shm", IVShmemState, shmobj),
DEFINE_PROP_STRING("role", IVShmemState, role),
- DEFINE_PROP_UINT32("use64", IVShmemState, ivshmem_64bit, 1),
+ DEFINE_PROP_UINT32("use64", IVShmemState, not_legacy_32bit, 1),
DEFINE_PROP_END_OF_LIST(),
};
-static void ivshmem_class_init(ObjectClass *klass, void *data)
+static void ivshmem_common_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
- k->realize = pci_ivshmem_realize;
- k->exit = pci_ivshmem_exit;
+ k->realize = ivshmem_common_realize;
+ k->exit = ivshmem_exit;
k->config_write = ivshmem_write_config;
k->vendor_id = PCI_VENDOR_ID_IVSHMEM;
k->device_id = PCI_DEVICE_ID_IVSHMEM;
k->class_id = PCI_CLASS_MEMORY_RAM;
+ k->revision = 1;
dc->reset = ivshmem_reset;
- dc->props = ivshmem_properties;
- dc->vmsd = &ivshmem_vmsd;
set_bit(DEVICE_CATEGORY_MISC, dc->categories);
dc->desc = "Inter-VM shared memory";
}
+static void ivshmem_class_init(ObjectClass *klass, void *data)
+{
+ DeviceClass *dc = DEVICE_CLASS(klass);
+ PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
+
+ k->realize = ivshmem_realize;
+ k->revision = 0;
+ dc->desc = "Inter-VM shared memory (legacy)";
+ dc->props = ivshmem_properties;
+ dc->vmsd = &ivshmem_vmsd;
+}
+
static void ivshmem_check_memdev_is_busy(Object *obj, const char *name,
Object *val, Error **errp)
{
@@ -1113,16 +1152,121 @@ static void ivshmem_init(Object *obj)
&error_abort);
}
+static const TypeInfo ivshmem_common_info = {
+ .name = TYPE_IVSHMEM_COMMON,
+ .parent = TYPE_PCI_DEVICE,
+ .instance_size = sizeof(IVShmemState),
+ .abstract = true,
+ .class_init = ivshmem_common_class_init,
+};
+
static const TypeInfo ivshmem_info = {
.name = TYPE_IVSHMEM,
- .parent = TYPE_PCI_DEVICE,
+ .parent = TYPE_IVSHMEM_COMMON,
.instance_size = sizeof(IVShmemState),
.instance_init = ivshmem_init,
.class_init = ivshmem_class_init,
};
+static const VMStateDescription ivshmem_plain_vmsd = {
+ .name = TYPE_IVSHMEM_PLAIN,
+ .version_id = 0,
+ .minimum_version_id = 0,
+ .pre_load = ivshmem_pre_load,
+ .post_load = ivshmem_post_load,
+ .fields = (VMStateField[]) {
+ VMSTATE_PCI_DEVICE(parent_obj, IVShmemState),
+ VMSTATE_UINT32(intrstatus, IVShmemState),
+ VMSTATE_UINT32(intrmask, IVShmemState),
+ VMSTATE_END_OF_LIST()
+ },
+};
+
+static Property ivshmem_plain_properties[] = {
+ DEFINE_PROP_ON_OFF_AUTO("master", IVShmemState, master, ON_OFF_AUTO_OFF),
+ DEFINE_PROP_END_OF_LIST(),
+};
+
+static void ivshmem_plain_init(Object *obj)
+{
+ IVShmemState *s = IVSHMEM_PLAIN(obj);
+
+ object_property_add_link(obj, "memdev", TYPE_MEMORY_BACKEND,
+ (Object **)&s->hostmem,
+ ivshmem_check_memdev_is_busy,
+ OBJ_PROP_LINK_UNREF_ON_RELEASE,
+ &error_abort);
+}
+
+static void ivshmem_plain_class_init(ObjectClass *klass, void *data)
+{
+ DeviceClass *dc = DEVICE_CLASS(klass);
+
+ dc->props = ivshmem_plain_properties;
+ dc->vmsd = &ivshmem_plain_vmsd;
+}
+
+static const TypeInfo ivshmem_plain_info = {
+ .name = TYPE_IVSHMEM_PLAIN,
+ .parent = TYPE_IVSHMEM_COMMON,
+ .instance_size = sizeof(IVShmemState),
+ .instance_init = ivshmem_plain_init,
+ .class_init = ivshmem_plain_class_init,
+};
+
+static const VMStateDescription ivshmem_doorbell_vmsd = {
+ .name = TYPE_IVSHMEM_DOORBELL,
+ .version_id = 0,
+ .minimum_version_id = 0,
+ .pre_load = ivshmem_pre_load,
+ .post_load = ivshmem_post_load,
+ .fields = (VMStateField[]) {
+ VMSTATE_PCI_DEVICE(parent_obj, IVShmemState),
+ VMSTATE_MSIX(parent_obj, IVShmemState),
+ VMSTATE_UINT32(intrstatus, IVShmemState),
+ VMSTATE_UINT32(intrmask, IVShmemState),
+ VMSTATE_END_OF_LIST()
+ },
+};
+
+static Property ivshmem_doorbell_properties[] = {
+ DEFINE_PROP_CHR("chardev", IVShmemState, server_chr),
+ DEFINE_PROP_UINT32("vectors", IVShmemState, vectors, 1),
+ DEFINE_PROP_BIT("ioeventfd", IVShmemState, features, IVSHMEM_IOEVENTFD,
+ true),
+ DEFINE_PROP_ON_OFF_AUTO("master", IVShmemState, master, ON_OFF_AUTO_OFF),
+ DEFINE_PROP_END_OF_LIST(),
+};
+
+static void ivshmem_doorbell_init(Object *obj)
+{
+ IVShmemState *s = IVSHMEM_DOORBELL(obj);
+
+ s->features |= (1 << IVSHMEM_MSI);
+ s->legacy_size = SIZE_MAX; /* whatever the server sends */
+}
+
+static void ivshmem_doorbell_class_init(ObjectClass *klass, void *data)
+{
+ DeviceClass *dc = DEVICE_CLASS(klass);
+
+ dc->props = ivshmem_doorbell_properties;
+ dc->vmsd = &ivshmem_doorbell_vmsd;
+}
+
+static const TypeInfo ivshmem_doorbell_info = {
+ .name = TYPE_IVSHMEM_DOORBELL,
+ .parent = TYPE_IVSHMEM_COMMON,
+ .instance_size = sizeof(IVShmemState),
+ .instance_init = ivshmem_doorbell_init,
+ .class_init = ivshmem_doorbell_class_init,
+};
+
static void ivshmem_register_types(void)
{
+ type_register_static(&ivshmem_common_info);
+ type_register_static(&ivshmem_plain_info);
+ type_register_static(&ivshmem_doorbell_info);
type_register_static(&ivshmem_info);
}
diff --git a/qemu-doc.texi b/qemu-doc.texi
index 8afbbcd..0dd01c7 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -1262,13 +1262,18 @@ basic example.
@subsection Inter-VM Shared Memory device
-With KVM enabled on a Linux host, a shared memory device is available. Guests
-map a POSIX shared memory region into the guest as a PCI device that enables
-zero-copy communication to the application level of the guests. The basic
-syntax is:
+On Linux hosts, a shared memory device is available. The basic syntax
+is:
@example
-qemu-system-i386 -device ivshmem,size=@var{size},shm=@var{shm-name}
+qemu-system-x86_64 -device ivshmem-plain,memdev=@var{hostmem}
+@end example
+
+where @var{hostmem} names a host memory backend. For a POSIX shared
+memory backend, use something like
+
+@example
+-object memory-backend-file,size=1M,share,mem-path=/dev/shm/ivshmem,id=@var{hostmem}
@end example
If desired, interrupts can be sent between guest VMs accessing the same shared
@@ -1282,8 +1287,7 @@ memory server is:
ivshmem-server -p @var{pidfile} -S @var{path} -m @var{shm-name} -l @var{shm-size} -n @var{vectors}
# Then start your qemu instances with matching arguments
-qemu-system-i386 -device ivshmem,size=@var{shm-size},vectors=@var{vectors},chardev=@var{id}
- [,msi=on][,ioeventfd=on][,role=peer|master]
+qemu-system-x86_64 -device ivshmem-doorbell,vectors=@var{vectors},chardev=@var{id}
-chardev socket,path=@var{path},id=@var{id}
@end example
@@ -1291,12 +1295,11 @@ When using the server, the guest will be assigned a VM ID (>=0) that allows gues
using the same server to communicate via interrupts. Guests can read their
VM ID from a device register (see ivshmem-spec.txt).
-The @option{role} argument can be set to either master or peer and will affect
-how the shared memory is migrated. With @option{role=master}, the guest will
-copy the shared memory on migration to the destination host. With
-@option{role=peer}, the guest will not be able to migrate with the device attached.
-With the @option{peer} case, the device should be detached and then reattached
-after migration using the PCI hotplug support.
+With device property @option{master=on}, the guest will copy the shared
+memory on migration to the destination host. With @option{master=off},
+the guest will not be able to migrate with the device attached. In the
+latter case, the device should be detached and then reattached after
+migration using the PCI hotplug support.
@subsubsection ivshmem and hugepages
@@ -1304,8 +1307,8 @@ Instead of specifying the <shm size> using POSIX shm, you may specify
a memory backend that has hugepage support:
@example
-qemu-system-i386 -object memory-backend-file,size=1G,mem-path=/dev/hugepages/my-shmem-file,share,id=mb1
- -device ivshmem,x-memdev=mb1
+qemu-system-x86_64 -object memory-backend-file,size=1G,mem-path=/dev/hugepages/my-shmem-file,share,id=mb1
+ -device ivshmem-plain,memdev=mb1
@end example
ivshmem-server also supports hugepages mount points with the
diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c
index c7f3758..c027ff1 100644
--- a/tests/ivshmem-test.c
+++ b/tests/ivshmem-test.c
@@ -127,7 +127,9 @@ static void setup_vm_cmd(IVState *s, const char *cmd, bool msix)
static void setup_vm(IVState *s)
{
- char *cmd = g_strdup_printf("-device ivshmem,shm=%s,size=1M", tmpshm);
+ char *cmd = g_strdup_printf("-object memory-backend-file"
+ ",id=mb1,size=1M,share,mem-path=/dev/shm%s"
+ " -device ivshmem-plain,memdev=mb1", tmpshm);
setup_vm_cmd(s, cmd, false);
@@ -284,8 +286,10 @@ static void *server_thread(void *data)
static void setup_vm_with_server(IVState *s, int nvectors, bool msi)
{
char *cmd = g_strdup_printf("-chardev socket,id=chr0,path=%s,nowait "
- "-device ivshmem,size=1M,chardev=chr0,vectors=%d,msi=%s",
- tmpserver, nvectors, msi ? "true" : "false");
+ "-device ivshmem%s,chardev=chr0,vectors=%d",
+ tmpserver,
+ msi ? "-doorbell" : ",size=1M,msi=off",
+ nvectors);
setup_vm_cmd(s, cmd, msi);
@@ -412,7 +416,7 @@ static void test_ivshmem_memdev(void)
/* just for the sake of checking memory-backend property */
setup_vm_cmd(&state, "-object memory-backend-ram,size=1M,id=mb1"
- " -device ivshmem,x-memdev=mb1", false);
+ " -device ivshmem-plain,memdev=mb1", false);
cleanup_vm(&state);
}
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 39/42] ivshmem: Clean up after the previous commit
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (37 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 38/42] ivshmem: Split ivshmem-plain, ivshmem-doorbell off ivshmem Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 40/42] ivshmem: Drop ivshmem property x-memdev Markus Armbruster
` (4 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Move code to more sensible places. Use the opportunity to reorder and
document IVShmemState members.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/misc/ivshmem.c | 400 +++++++++++++++++++++++++++---------------------------
1 file changed, 203 insertions(+), 197 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 1fd2ef6..a46386d 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -85,26 +85,31 @@ typedef struct IVShmemState {
PCIDevice parent_obj;
/*< public >*/
- HostMemoryBackend *hostmem;
+ uint32_t features;
+
+ /* exactly one of these two may be set */
+ HostMemoryBackend *hostmem; /* with interrupts */
+ CharDriverState *server_chr; /* without interrupts */
+
+ /* registers */
uint32_t intrmask;
uint32_t intrstatus;
+ int vm_id;
- CharDriverState *server_chr;
- MemoryRegion ivshmem_mmio;
-
+ /* BARs */
+ MemoryRegion ivshmem_mmio; /* BAR 0 (registers) */
MemoryRegion *ivshmem_bar2; /* BAR 2 (shared memory) */
MemoryRegion server_bar2; /* used with server_chr */
+ /* interrupt support */
Peer *peers;
int nb_peers; /* space in @peers[] */
-
- int vm_id;
uint32_t vectors;
- uint32_t features;
MSIVector *msi_vectors;
uint64_t msg_buf; /* buffer for receiving server messages */
int msg_buffered_bytes; /* #bytes in @msg_buf */
+ /* migration stuff */
OnOffAuto master;
Error *migration_blocker;
@@ -813,23 +818,6 @@ static void ivshmem_write_config(PCIDevice *pdev, uint32_t address,
}
}
-static void desugar_shm(IVShmemState *s)
-{
- Object *obj;
- char *path;
-
- obj = object_new("memory-backend-file");
- path = g_strdup_printf("/dev/shm/%s", s->shmobj);
- object_property_set_str(obj, path, "mem-path", &error_abort);
- g_free(path);
- object_property_set_int(obj, s->legacy_size, "size", &error_abort);
- object_property_set_bool(obj, true, "share", &error_abort);
- object_property_add_child(OBJECT(s), "internal-shm-backend", obj,
- &error_abort);
- user_creatable_complete(obj, &error_abort);
- s->hostmem = MEMORY_BACKEND(obj);
-}
-
static void ivshmem_common_realize(PCIDevice *dev, Error **errp)
{
IVShmemState *s = IVSHMEM_COMMON(dev);
@@ -905,65 +893,6 @@ static void ivshmem_common_realize(PCIDevice *dev, Error **errp)
}
}
-static void ivshmem_realize(PCIDevice *dev, Error **errp)
-{
- IVShmemState *s = IVSHMEM_COMMON(dev);
-
- if (!qtest_enabled()) {
- error_report("ivshmem is deprecated, please use ivshmem-plain"
- " or ivshmem-doorbell instead");
- }
-
- if (!!s->server_chr + !!s->shmobj + !!s->hostmem != 1) {
- error_setg(errp,
- "You must specify either 'shm', 'chardev' or 'x-memdev'");
- return;
- }
-
- if (s->hostmem) {
- if (s->sizearg) {
- g_warning("size argument ignored with hostmem");
- }
- } else if (s->sizearg == NULL) {
- s->legacy_size = 4 << 20; /* 4 MB default */
- } else {
- char *end;
- int64_t size = qemu_strtosz(s->sizearg, &end);
- if (size < 0 || (size_t)size != size || *end != '\0'
- || !is_power_of_2(size)) {
- error_setg(errp, "Invalid size %s", s->sizearg);
- return;
- }
- s->legacy_size = size;
- }
-
- /* check that role is reasonable */
- if (s->role) {
- if (strncmp(s->role, "peer", 5) == 0) {
- s->master = ON_OFF_AUTO_OFF;
- } else if (strncmp(s->role, "master", 7) == 0) {
- s->master = ON_OFF_AUTO_ON;
- } else {
- error_setg(errp, "'role' must be 'peer' or 'master'");
- return;
- }
- } else {
- s->master = ON_OFF_AUTO_AUTO;
- }
-
- if (s->shmobj) {
- desugar_shm(s);
- }
-
- /*
- * Note: we don't use INTx with IVSHMEM_MSI at all, so this is a
- * bald-faced lie then. But it's a backwards compatible lie.
- */
- pci_config_set_interrupt_pin(dev->config, 1);
-
- ivshmem_common_realize(dev, errp);
-}
-
static void ivshmem_exit(PCIDevice *dev)
{
IVShmemState *s = IVSHMEM_COMMON(dev);
@@ -1003,18 +932,6 @@ static void ivshmem_exit(PCIDevice *dev)
g_free(s->msi_vectors);
}
-static bool test_msix(void *opaque, int version_id)
-{
- IVShmemState *s = opaque;
-
- return ivshmem_has_feature(s, IVSHMEM_MSI);
-}
-
-static bool test_no_msix(void *opaque, int version_id)
-{
- return !test_msix(opaque, version_id);
-}
-
static int ivshmem_pre_load(void *opaque)
{
IVShmemState *s = opaque;
@@ -1033,70 +950,6 @@ static int ivshmem_post_load(void *opaque, int version_id)
return 0;
}
-static int ivshmem_load_old(QEMUFile *f, void *opaque, int version_id)
-{
- IVShmemState *s = opaque;
- PCIDevice *pdev = PCI_DEVICE(s);
- int ret;
-
- IVSHMEM_DPRINTF("ivshmem_load_old\n");
-
- if (version_id != 0) {
- return -EINVAL;
- }
-
- ret = ivshmem_pre_load(s);
- if (ret) {
- return ret;
- }
-
- ret = pci_device_load(pdev, f);
- if (ret) {
- return ret;
- }
-
- if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
- msix_load(pdev, f);
- } else {
- s->intrstatus = qemu_get_be32(f);
- s->intrmask = qemu_get_be32(f);
- }
- ivshmem_vector_use(s);
-
- return 0;
-}
-
-static const VMStateDescription ivshmem_vmsd = {
- .name = "ivshmem",
- .version_id = 1,
- .minimum_version_id = 1,
- .pre_load = ivshmem_pre_load,
- .post_load = ivshmem_post_load,
- .fields = (VMStateField[]) {
- VMSTATE_PCI_DEVICE(parent_obj, IVShmemState),
-
- VMSTATE_MSIX_TEST(parent_obj, IVShmemState, test_msix),
- VMSTATE_UINT32_TEST(intrstatus, IVShmemState, test_no_msix),
- VMSTATE_UINT32_TEST(intrmask, IVShmemState, test_no_msix),
-
- VMSTATE_END_OF_LIST()
- },
- .load_state_old = ivshmem_load_old,
- .minimum_version_id_old = 0
-};
-
-static Property ivshmem_properties[] = {
- DEFINE_PROP_CHR("chardev", IVShmemState, server_chr),
- DEFINE_PROP_STRING("size", IVShmemState, sizearg),
- DEFINE_PROP_UINT32("vectors", IVShmemState, vectors, 1),
- DEFINE_PROP_BIT("ioeventfd", IVShmemState, features, IVSHMEM_IOEVENTFD, false),
- DEFINE_PROP_BIT("msi", IVShmemState, features, IVSHMEM_MSI, true),
- DEFINE_PROP_STRING("shm", IVShmemState, shmobj),
- DEFINE_PROP_STRING("role", IVShmemState, role),
- DEFINE_PROP_UINT32("use64", IVShmemState, not_legacy_32bit, 1),
- DEFINE_PROP_END_OF_LIST(),
-};
-
static void ivshmem_common_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
@@ -1114,17 +967,13 @@ static void ivshmem_common_class_init(ObjectClass *klass, void *data)
dc->desc = "Inter-VM shared memory";
}
-static void ivshmem_class_init(ObjectClass *klass, void *data)
-{
- DeviceClass *dc = DEVICE_CLASS(klass);
- PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
-
- k->realize = ivshmem_realize;
- k->revision = 0;
- dc->desc = "Inter-VM shared memory (legacy)";
- dc->props = ivshmem_properties;
- dc->vmsd = &ivshmem_vmsd;
-}
+static const TypeInfo ivshmem_common_info = {
+ .name = TYPE_IVSHMEM_COMMON,
+ .parent = TYPE_PCI_DEVICE,
+ .instance_size = sizeof(IVShmemState),
+ .abstract = true,
+ .class_init = ivshmem_common_class_init,
+};
static void ivshmem_check_memdev_is_busy(Object *obj, const char *name,
Object *val, Error **errp)
@@ -1141,33 +990,6 @@ static void ivshmem_check_memdev_is_busy(Object *obj, const char *name,
}
}
-static void ivshmem_init(Object *obj)
-{
- IVShmemState *s = IVSHMEM(obj);
-
- object_property_add_link(obj, "x-memdev", TYPE_MEMORY_BACKEND,
- (Object **)&s->hostmem,
- ivshmem_check_memdev_is_busy,
- OBJ_PROP_LINK_UNREF_ON_RELEASE,
- &error_abort);
-}
-
-static const TypeInfo ivshmem_common_info = {
- .name = TYPE_IVSHMEM_COMMON,
- .parent = TYPE_PCI_DEVICE,
- .instance_size = sizeof(IVShmemState),
- .abstract = true,
- .class_init = ivshmem_common_class_init,
-};
-
-static const TypeInfo ivshmem_info = {
- .name = TYPE_IVSHMEM,
- .parent = TYPE_IVSHMEM_COMMON,
- .instance_size = sizeof(IVShmemState),
- .instance_init = ivshmem_init,
- .class_init = ivshmem_class_init,
-};
-
static const VMStateDescription ivshmem_plain_vmsd = {
.name = TYPE_IVSHMEM_PLAIN,
.version_id = 0,
@@ -1262,6 +1084,190 @@ static const TypeInfo ivshmem_doorbell_info = {
.class_init = ivshmem_doorbell_class_init,
};
+static int ivshmem_load_old(QEMUFile *f, void *opaque, int version_id)
+{
+ IVShmemState *s = opaque;
+ PCIDevice *pdev = PCI_DEVICE(s);
+ int ret;
+
+ IVSHMEM_DPRINTF("ivshmem_load_old\n");
+
+ if (version_id != 0) {
+ return -EINVAL;
+ }
+
+ ret = ivshmem_pre_load(s);
+ if (ret) {
+ return ret;
+ }
+
+ ret = pci_device_load(pdev, f);
+ if (ret) {
+ return ret;
+ }
+
+ if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
+ msix_load(pdev, f);
+ } else {
+ s->intrstatus = qemu_get_be32(f);
+ s->intrmask = qemu_get_be32(f);
+ }
+ ivshmem_vector_use(s);
+
+ return 0;
+}
+
+static bool test_msix(void *opaque, int version_id)
+{
+ IVShmemState *s = opaque;
+
+ return ivshmem_has_feature(s, IVSHMEM_MSI);
+}
+
+static bool test_no_msix(void *opaque, int version_id)
+{
+ return !test_msix(opaque, version_id);
+}
+
+static const VMStateDescription ivshmem_vmsd = {
+ .name = "ivshmem",
+ .version_id = 1,
+ .minimum_version_id = 1,
+ .pre_load = ivshmem_pre_load,
+ .post_load = ivshmem_post_load,
+ .fields = (VMStateField[]) {
+ VMSTATE_PCI_DEVICE(parent_obj, IVShmemState),
+
+ VMSTATE_MSIX_TEST(parent_obj, IVShmemState, test_msix),
+ VMSTATE_UINT32_TEST(intrstatus, IVShmemState, test_no_msix),
+ VMSTATE_UINT32_TEST(intrmask, IVShmemState, test_no_msix),
+
+ VMSTATE_END_OF_LIST()
+ },
+ .load_state_old = ivshmem_load_old,
+ .minimum_version_id_old = 0
+};
+
+static Property ivshmem_properties[] = {
+ DEFINE_PROP_CHR("chardev", IVShmemState, server_chr),
+ DEFINE_PROP_STRING("size", IVShmemState, sizearg),
+ DEFINE_PROP_UINT32("vectors", IVShmemState, vectors, 1),
+ DEFINE_PROP_BIT("ioeventfd", IVShmemState, features, IVSHMEM_IOEVENTFD,
+ false),
+ DEFINE_PROP_BIT("msi", IVShmemState, features, IVSHMEM_MSI, true),
+ DEFINE_PROP_STRING("shm", IVShmemState, shmobj),
+ DEFINE_PROP_STRING("role", IVShmemState, role),
+ DEFINE_PROP_UINT32("use64", IVShmemState, not_legacy_32bit, 1),
+ DEFINE_PROP_END_OF_LIST(),
+};
+
+static void desugar_shm(IVShmemState *s)
+{
+ Object *obj;
+ char *path;
+
+ obj = object_new("memory-backend-file");
+ path = g_strdup_printf("/dev/shm/%s", s->shmobj);
+ object_property_set_str(obj, path, "mem-path", &error_abort);
+ g_free(path);
+ object_property_set_int(obj, s->legacy_size, "size", &error_abort);
+ object_property_set_bool(obj, true, "share", &error_abort);
+ object_property_add_child(OBJECT(s), "internal-shm-backend", obj,
+ &error_abort);
+ user_creatable_complete(obj, &error_abort);
+ s->hostmem = MEMORY_BACKEND(obj);
+}
+
+static void ivshmem_realize(PCIDevice *dev, Error **errp)
+{
+ IVShmemState *s = IVSHMEM_COMMON(dev);
+
+ if (!qtest_enabled()) {
+ error_report("ivshmem is deprecated, please use ivshmem-plain"
+ " or ivshmem-doorbell instead");
+ }
+
+ if (!!s->server_chr + !!s->shmobj + !!s->hostmem != 1) {
+ error_setg(errp,
+ "You must specify either 'shm', 'chardev' or 'x-memdev'");
+ return;
+ }
+
+ if (s->hostmem) {
+ if (s->sizearg) {
+ g_warning("size argument ignored with hostmem");
+ }
+ } else if (s->sizearg == NULL) {
+ s->legacy_size = 4 << 20; /* 4 MB default */
+ } else {
+ char *end;
+ int64_t size = qemu_strtosz(s->sizearg, &end);
+ if (size < 0 || (size_t)size != size || *end != '\0'
+ || !is_power_of_2(size)) {
+ error_setg(errp, "Invalid size %s", s->sizearg);
+ return;
+ }
+ s->legacy_size = size;
+ }
+
+ /* check that role is reasonable */
+ if (s->role) {
+ if (strncmp(s->role, "peer", 5) == 0) {
+ s->master = ON_OFF_AUTO_OFF;
+ } else if (strncmp(s->role, "master", 7) == 0) {
+ s->master = ON_OFF_AUTO_ON;
+ } else {
+ error_setg(errp, "'role' must be 'peer' or 'master'");
+ return;
+ }
+ } else {
+ s->master = ON_OFF_AUTO_AUTO;
+ }
+
+ if (s->shmobj) {
+ desugar_shm(s);
+ }
+
+ /*
+ * Note: we don't use INTx with IVSHMEM_MSI at all, so this is a
+ * bald-faced lie then. But it's a backwards compatible lie.
+ */
+ pci_config_set_interrupt_pin(dev->config, 1);
+
+ ivshmem_common_realize(dev, errp);
+}
+
+static void ivshmem_init(Object *obj)
+{
+ IVShmemState *s = IVSHMEM(obj);
+
+ object_property_add_link(obj, "x-memdev", TYPE_MEMORY_BACKEND,
+ (Object **)&s->hostmem,
+ ivshmem_check_memdev_is_busy,
+ OBJ_PROP_LINK_UNREF_ON_RELEASE,
+ &error_abort);
+}
+
+static void ivshmem_class_init(ObjectClass *klass, void *data)
+{
+ DeviceClass *dc = DEVICE_CLASS(klass);
+ PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
+
+ k->realize = ivshmem_realize;
+ k->revision = 0;
+ dc->desc = "Inter-VM shared memory (legacy)";
+ dc->props = ivshmem_properties;
+ dc->vmsd = &ivshmem_vmsd;
+}
+
+static const TypeInfo ivshmem_info = {
+ .name = TYPE_IVSHMEM,
+ .parent = TYPE_IVSHMEM_COMMON,
+ .instance_size = sizeof(IVShmemState),
+ .instance_init = ivshmem_init,
+ .class_init = ivshmem_class_init,
+};
+
static void ivshmem_register_types(void)
{
type_register_static(&ivshmem_common_info);
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 40/42] ivshmem: Drop ivshmem property x-memdev
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (38 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 39/42] ivshmem: Clean up after the previous commit Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-09 12:47 ` Marc-André Lureau
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 41/42] ivshmem: Require master to have ID zero Markus Armbruster
` (3 subsequent siblings)
43 siblings, 1 reply; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Use ivshmem-plain instead.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/misc/ivshmem.c | 23 +++--------------------
1 file changed, 3 insertions(+), 20 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index a46386d..6fe41ad 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -1187,17 +1187,12 @@ static void ivshmem_realize(PCIDevice *dev, Error **errp)
" or ivshmem-doorbell instead");
}
- if (!!s->server_chr + !!s->shmobj + !!s->hostmem != 1) {
- error_setg(errp,
- "You must specify either 'shm', 'chardev' or 'x-memdev'");
+ if (!!s->server_chr + !!s->shmobj != 1) {
+ error_setg(errp, "You must specify either 'shm' or 'chardev'");
return;
}
- if (s->hostmem) {
- if (s->sizearg) {
- g_warning("size argument ignored with hostmem");
- }
- } else if (s->sizearg == NULL) {
+ if (s->sizearg == NULL) {
s->legacy_size = 4 << 20; /* 4 MB default */
} else {
char *end;
@@ -1237,17 +1232,6 @@ static void ivshmem_realize(PCIDevice *dev, Error **errp)
ivshmem_common_realize(dev, errp);
}
-static void ivshmem_init(Object *obj)
-{
- IVShmemState *s = IVSHMEM(obj);
-
- object_property_add_link(obj, "x-memdev", TYPE_MEMORY_BACKEND,
- (Object **)&s->hostmem,
- ivshmem_check_memdev_is_busy,
- OBJ_PROP_LINK_UNREF_ON_RELEASE,
- &error_abort);
-}
-
static void ivshmem_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
@@ -1264,7 +1248,6 @@ static const TypeInfo ivshmem_info = {
.name = TYPE_IVSHMEM,
.parent = TYPE_IVSHMEM_COMMON,
.instance_size = sizeof(IVShmemState),
- .instance_init = ivshmem_init,
.class_init = ivshmem_class_init,
};
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 41/42] ivshmem: Require master to have ID zero
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (39 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 40/42] ivshmem: Drop ivshmem property x-memdev Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 42/42] contrib/ivshmem-server: Print "not for production" warning Markus Armbruster
` (2 subsequent siblings)
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
Migration with ivshmem needs to be carefully orchestrated to work.
Exactly one peer (the "master") migrates to the destination, all other
peers need to unplug (and disconnect), migrate, plug back (and
reconnect). This is sort of documented in qemu-doc.
If peers connect on the destination before migration completes, the
shared memory can get messed up. This isn't documented anywhere. Fix
that in qemu-doc.
To avoid messing up register IVPosition on migration, the server must
assign the same ID on source and destination. ivshmem-spec.txt leaves
ID assignment unspecified, however.
Amend ivshmem-spec.txt to require the first client to receive ID zero.
The example ivshmem-server complies: it always assigns the first
unused ID.
For a bit of additional safety, enforce ID zero for the master. This
does nothing when we're not using a server, because the ID is zero for
all peers then.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
docs/specs/ivshmem-spec.txt | 2 ++
hw/misc/ivshmem.c | 6 ++++++
qemu-doc.texi | 5 +++++
3 files changed, 13 insertions(+)
diff --git a/docs/specs/ivshmem-spec.txt b/docs/specs/ivshmem-spec.txt
index f3912c0..a1f5499 100644
--- a/docs/specs/ivshmem-spec.txt
+++ b/docs/specs/ivshmem-spec.txt
@@ -164,6 +164,8 @@ For each new client that connects to the server, the server
- sends interrupt setup messages to the new client (these contain file
descriptors for receiving interrupts).
+The first client to connect to the server receives ID zero.
+
When a client disconnects from the server, the server sends disconnect
notifications to the other clients.
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 6fe41ad..7a248c4 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -870,6 +870,12 @@ static void ivshmem_common_realize(PCIDevice *dev, Error **errp)
return;
}
+ if (s->master == ON_OFF_AUTO_ON && s->vm_id != 0) {
+ error_setg(errp,
+ "master must connect to the server before any peers");
+ return;
+ }
+
qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive,
ivshmem_read, NULL, s);
diff --git a/qemu-doc.texi b/qemu-doc.texi
index 0dd01c7..79141d3 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -1295,12 +1295,17 @@ When using the server, the guest will be assigned a VM ID (>=0) that allows gues
using the same server to communicate via interrupts. Guests can read their
VM ID from a device register (see ivshmem-spec.txt).
+@subsubsection Migration with ivshmem
+
With device property @option{master=on}, the guest will copy the shared
memory on migration to the destination host. With @option{master=off},
the guest will not be able to migrate with the device attached. In the
latter case, the device should be detached and then reattached after
migration using the PCI hotplug support.
+At most one of the devices sharing the same memory can be master. The
+master must complete migration before you plug back the other devices.
+
@subsubsection ivshmem and hugepages
Instead of specifying the <shm size> using POSIX shm, you may specify
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* [Qemu-devel] [PATCH v2 42/42] contrib/ivshmem-server: Print "not for production" warning
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (40 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 41/42] ivshmem: Require master to have ID zero Markus Armbruster
@ 2016-03-07 19:25 ` Markus Armbruster
2016-03-08 14:05 ` [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Paolo Bonzini
2016-03-08 14:22 ` Paolo Bonzini
43 siblings, 0 replies; 74+ messages in thread
From: Markus Armbruster @ 2016-03-07 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: claudio.fontana, cam, mlureau, david.marchand, pbonzini
The code is okay for illustrating how things work and for testing, but
its error handling make it unfit for production use. Print a warning
to protect the innocent.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
contrib/ivshmem-server/main.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c
index 2795db5..bebc32b 100644
--- a/contrib/ivshmem-server/main.c
+++ b/contrib/ivshmem-server/main.c
@@ -214,6 +214,12 @@ main(int argc, char *argv[])
};
int ret = 1;
+ /*
+ * Do not remove this notice without adding proper error handling!
+ * Start with handling ivshmem_server_send_one_msg() failure.
+ */
+ printf("*** Example code, do not use in production ***\n");
+
/* parse arguments, will exit on error */
ivshmem_server_parse_args(&args, argc, argv);
--
2.4.3
^ permalink raw reply related [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (41 preceding siblings ...)
2016-03-07 19:25 ` [Qemu-devel] [PATCH v2 42/42] contrib/ivshmem-server: Print "not for production" warning Markus Armbruster
@ 2016-03-08 14:05 ` Paolo Bonzini
2016-03-08 14:22 ` Paolo Bonzini
43 siblings, 0 replies; 74+ messages in thread
From: Paolo Bonzini @ 2016-03-08 14:05 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel
Cc: claudio.fontana, cam, mlureau, david.marchand
On 07/03/2016 20:25, Markus Armbruster wrote:
> * PATCH 01: Rewritten [Paolo]
Queued this one.
> * PATCH 22: Commit message improved [Paolo]
> * PATCH 33: Rewritten [Paolo]
These two
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
^ permalink raw reply [flat|nested] 74+ messages in thread* Re: [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split
2016-03-07 19:25 [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Markus Armbruster
` (42 preceding siblings ...)
2016-03-08 14:05 ` [Qemu-devel] [PATCH v2 00/42] ivshmem: Fixes, cleanups, device model split Paolo Bonzini
@ 2016-03-08 14:22 ` Paolo Bonzini
43 siblings, 0 replies; 74+ messages in thread
From: Paolo Bonzini @ 2016-03-08 14:22 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel
Cc: mlureau, cam, claudio.fontana, david.marchand
On 07/03/2016 20:25, Markus Armbruster wrote:
> * PATCH 34: Commit message improved, memory leak plugged by avoiding
> dynamic allocation [Paolo]
Forgot about this one, also
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 74+ messages in thread