From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad5RL-0005F7-Hd for qemu-devel@nongnu.org; Mon, 07 Mar 2016 19:23:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ad5RK-0003mP-NS for qemu-devel@nongnu.org; Mon, 07 Mar 2016 19:23:55 -0500 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:56124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad5RK-0003lc-Gu for qemu-devel@nongnu.org; Mon, 07 Mar 2016 19:23:54 -0500 From: Peter Maydell Date: Tue, 8 Mar 2016 00:23:43 +0000 Message-Id: <1457396623-27738-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] loader: Fix incorrect parameter name in load_image_mr() macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , "Michael S. Tsirkin" , Jens Wiklander , patches@linaro.org From: Jens Wiklander Fix a typo in the load_image_mr() macro: 'mr' was written when the parameter name is '_mr'. (This had no visible effects since the single use of the macro used 'mr' as the argument.) Fixes 76151cacfe956248a25b38b5e8429465584f47bb "loader: Add load_image_mr() to load ROM image to a MemoryRegion" Signed-off-by: Jens Wiklander Reviewed-by: Peter Maydell [PMM: tweaked commit message] Signed-off-by: Peter Maydell --- Oops... include/hw/loader.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/loader.h b/include/hw/loader.h index 0ba7808..b3d1358 100644 --- a/include/hw/loader.h +++ b/include/hw/loader.h @@ -137,7 +137,7 @@ void hmp_info_roms(Monitor *mon, const QDict *qdict); #define rom_add_blob_fixed(_f, _b, _l, _a) \ rom_add_blob(_f, _b, _l, _l, _a, NULL, NULL, NULL) #define rom_add_file_mr(_f, _mr, _i) \ - rom_add_file(_f, NULL, 0, _i, false, mr) + rom_add_file(_f, NULL, 0, _i, false, _mr) #define PC_ROM_MIN_VGA 0xc0000 #define PC_ROM_MIN_OPTION 0xc8000 -- 1.9.1