qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Liang Li <liang.z.li@intel.com>
To: amit.shah@redhat.com, quintela@redhat.com
Cc: pbonzini@redhat.com, Liang Li <liang.z.li@intel.com>,
	dgilbert@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v6 0/2] add avx2 instruction optimization
Date: Tue,  8 Mar 2016 13:53:15 +0800	[thread overview]
Message-ID: <1457416397-26671-1-git-send-email-liang.z.li@intel.com> (raw)

buffer_find_nonzero_offset() is a hot function during live migration.
Now it use SSE2 instructions for optimization. For platform supports
AVX2 instructions, use the AVX2 instructions for optimization can help
to improve the performance of zero page checking about 30% comparing
to SSE2.
Live migration can be faster with this optimization, the test result
shows that for an 8GB RAM idle guest, this patch can help to shorten
the total live migration time about 6%.

This patch use the ifunc mechanism to select the proper function when
running, for platform supports AVX2, execute the AVX2 instructions,
else, execute the original instructions.

With this patch, the QEMU binary can run on both platforms support AVX2
or not.

Compiler which doesn't support the AVX2 and ifunc attribute can also build
the source code successfully.

v5 -> v6 changes:
  * Restrict the optimization to GCC 4.9+ to prevent compiling failure
    in some case (Paolo's suggestion)
v4 -> v5 changes:
  * Enhance the ifunc attribute detection (Paolo's suggestion)

v3 -> v4 changes:
  * Use the GCC #pragma to make things simple (Paolo's suggestion) 
  * Put avx2 related code in cutils.c (Richard's suggestion)
  * Change the configure, detect ifunc and avx2 attributes together

v2 -> v3 changes:
  * Detect the ifunc attribute support (Paolo's suggestion) 
  * Use the ifunc attribute instead of the inline asm (Richard's suggestion)
  * Change the configure (Juan's suggestion)
Liang Li (2):
  configure: detect ifunc and avx2 attribute
  cutils: add avx2 instruction optimization

 configure             |  21 +++++++++
 include/qemu-common.h |   8 +---
 util/cutils.c         | 124 ++++++++++++++++++++++++++++++++++++++++++++++++--
 3 files changed, 142 insertions(+), 11 deletions(-)

-- 
1.9.1

             reply	other threads:[~2016-03-08  5:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08  5:53 Liang Li [this message]
2016-03-08  5:53 ` [Qemu-devel] [PATCH v6 1/2] configure: detect ifunc and avx2 attribute Liang Li
2016-03-08  5:53 ` [Qemu-devel] [PATCH v6 2/2] cutils: add avx2 instruction optimization Liang Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457416397-26671-1-git-send-email-liang.z.li@intel.com \
    --to=liang.z.li@intel.com \
    --cc=amit.shah@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).