From: Jason Wang <jasowang@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org
Cc: Jiri Pirko <jiri@mellanox.com>, Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PULL V2 09/12] rocker: allow user to specify rocker world by property
Date: Tue, 8 Mar 2016 15:52:41 +0800 [thread overview]
Message-ID: <1457423564-9724-10-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1457423564-9724-1-git-send-email-jasowang@redhat.com>
From: Jiri Pirko <jiri@mellanox.com>
Add property to specify rocker world. All ports will be assigned to this
world.
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/net/rocker/rocker.c | 29 ++++++++++++++++++++++++++++-
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c
index 104c097..30f2ce4 100644
--- a/hw/net/rocker/rocker.c
+++ b/hw/net/rocker/rocker.c
@@ -43,6 +43,7 @@ struct rocker {
/* switch configuration */
char *name; /* switch name */
+ char *world_name; /* world name */
uint32_t fp_ports; /* front-panel port count */
NICPeers *fp_ports_peers;
MACAddr fp_start_macaddr; /* front-panel port 0 mac addr */
@@ -1286,6 +1287,18 @@ static void rocker_msix_uninit(Rocker *r)
rocker_msix_vectors_unuse(r, ROCKER_MSIX_VEC_COUNT(r->fp_ports));
}
+static World *rocker_world_type_by_name(Rocker *r, const char *name)
+{
+ int i;
+
+ for (i = 0; i < ROCKER_WORLD_TYPE_MAX; i++) {
+ if (strcmp(name, world_name(r->worlds[i])) == 0) {
+ return r->worlds[i];
+ }
+ }
+ return NULL;
+}
+
static int pci_rocker_init(PCIDevice *dev)
{
Rocker *r = to_rocker(dev);
@@ -1297,7 +1310,6 @@ static int pci_rocker_init(PCIDevice *dev)
/* allocate worlds */
r->worlds[ROCKER_WORLD_TYPE_OF_DPA] = of_dpa_world_alloc(r);
- r->world_dflt = r->worlds[ROCKER_WORLD_TYPE_OF_DPA];
for (i = 0; i < ROCKER_WORLD_TYPE_MAX; i++) {
if (!r->worlds[i]) {
@@ -1306,6 +1318,19 @@ static int pci_rocker_init(PCIDevice *dev)
}
}
+ if (!r->world_name) {
+ r->world_name = g_strdup(world_name(r->worlds[ROCKER_WORLD_TYPE_OF_DPA]));
+ }
+
+ r->world_dflt = rocker_world_type_by_name(r, r->world_name);
+ if (!r->world_dflt) {
+ fprintf(stderr,
+ "rocker: requested world \"%s\" does not exist\n",
+ r->world_name);
+ err = -EINVAL;
+ goto err_world_type_by_name;
+ }
+
/* set up memory-mapped region at BAR0 */
memory_region_init_io(&r->mmio, OBJECT(r), &rocker_mmio_ops, r,
@@ -1439,6 +1464,7 @@ err_duplicate:
err_msix_init:
object_unparent(OBJECT(&r->msix_bar));
object_unparent(OBJECT(&r->mmio));
+err_world_type_by_name:
err_world_alloc:
for (i = 0; i < ROCKER_WORLD_TYPE_MAX; i++) {
if (r->worlds[i]) {
@@ -1510,6 +1536,7 @@ static void rocker_reset(DeviceState *dev)
static Property rocker_properties[] = {
DEFINE_PROP_STRING("name", Rocker, name),
+ DEFINE_PROP_STRING("world", Rocker, world_name),
DEFINE_PROP_MACADDR("fp_start_macaddr", Rocker,
fp_start_macaddr),
DEFINE_PROP_UINT64("switch_id", Rocker,
--
2.5.0
next prev parent reply other threads:[~2016-03-08 7:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 7:52 [Qemu-devel] [PULL V2 00/12] Net patches Jason Wang
2016-03-08 7:52 ` [Qemu-devel] [PULL V2 01/12] net: ne2000: check ring buffer control registers Jason Wang
2016-03-08 7:52 ` [Qemu-devel] [PULL V2 02/12] net: filter: correctly remove filter from the list during finalization Jason Wang
2016-03-08 7:52 ` [Qemu-devel] [PULL V2 03/12] MAINTAINERS: Add entries for include/net/ files Jason Wang
2016-03-08 7:52 ` [Qemu-devel] [PULL V2 04/12] net: simplify net_init_tap_one logic Jason Wang
2016-03-08 7:52 ` [Qemu-devel] [PULL V2 05/12] net: netmap: probe netmap interface for virtio-net header Jason Wang
2016-03-08 7:52 ` [Qemu-devel] [PULL V2 06/12] rocker: forbid to change world type Jason Wang
2016-03-08 7:52 ` [Qemu-devel] [PULL V2 07/12] rocker: return -ENOMEM in case of some world alloc fails Jason Wang
2016-03-08 7:52 ` [Qemu-devel] [PULL V2 08/12] rocker: add name field into WorldOps ale let world specify its name Jason Wang
2016-03-08 7:52 ` Jason Wang [this message]
2016-03-08 7:52 ` [Qemu-devel] [PULL V2 10/12] filter: Add 'status' property for filter object Jason Wang
2016-03-08 7:52 ` [Qemu-devel] [PULL V2 11/12] filter-buffer: Add status_changed callback processing Jason Wang
2016-03-08 7:52 ` [Qemu-devel] [PULL V2 12/12] net: check packet payload length Jason Wang
2016-03-09 0:16 ` [Qemu-devel] [PULL V2 00/12] Net patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457423564-9724-10-git-send-email-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=jiri@mellanox.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).