qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org
Cc: Jiri Pirko <jiri@mellanox.com>, Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PULL V2 07/12] rocker: return -ENOMEM in case of some world alloc fails
Date: Tue,  8 Mar 2016 15:52:39 +0800	[thread overview]
Message-ID: <1457423564-9724-8-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1457423564-9724-1-git-send-email-jasowang@redhat.com>

From: Jiri Pirko <jiri@mellanox.com>

Until now, 0 is returned in this error case. Fix it ro return -ENOMEM.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 hw/net/rocker/rocker.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c
index a1d921d..104c097 100644
--- a/hw/net/rocker/rocker.c
+++ b/hw/net/rocker/rocker.c
@@ -1301,6 +1301,7 @@ static int pci_rocker_init(PCIDevice *dev)
 
     for (i = 0; i < ROCKER_WORLD_TYPE_MAX; i++) {
         if (!r->worlds[i]) {
+            err = -ENOMEM;
             goto err_world_alloc;
         }
     }
-- 
2.5.0

  parent reply	other threads:[~2016-03-08  7:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08  7:52 [Qemu-devel] [PULL V2 00/12] Net patches Jason Wang
2016-03-08  7:52 ` [Qemu-devel] [PULL V2 01/12] net: ne2000: check ring buffer control registers Jason Wang
2016-03-08  7:52 ` [Qemu-devel] [PULL V2 02/12] net: filter: correctly remove filter from the list during finalization Jason Wang
2016-03-08  7:52 ` [Qemu-devel] [PULL V2 03/12] MAINTAINERS: Add entries for include/net/ files Jason Wang
2016-03-08  7:52 ` [Qemu-devel] [PULL V2 04/12] net: simplify net_init_tap_one logic Jason Wang
2016-03-08  7:52 ` [Qemu-devel] [PULL V2 05/12] net: netmap: probe netmap interface for virtio-net header Jason Wang
2016-03-08  7:52 ` [Qemu-devel] [PULL V2 06/12] rocker: forbid to change world type Jason Wang
2016-03-08  7:52 ` Jason Wang [this message]
2016-03-08  7:52 ` [Qemu-devel] [PULL V2 08/12] rocker: add name field into WorldOps ale let world specify its name Jason Wang
2016-03-08  7:52 ` [Qemu-devel] [PULL V2 09/12] rocker: allow user to specify rocker world by property Jason Wang
2016-03-08  7:52 ` [Qemu-devel] [PULL V2 10/12] filter: Add 'status' property for filter object Jason Wang
2016-03-08  7:52 ` [Qemu-devel] [PULL V2 11/12] filter-buffer: Add status_changed callback processing Jason Wang
2016-03-08  7:52 ` [Qemu-devel] [PULL V2 12/12] net: check packet payload length Jason Wang
2016-03-09  0:16 ` [Qemu-devel] [PULL V2 00/12] Net patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457423564-9724-8-git-send-email-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=jiri@mellanox.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).