From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37075)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1adCjC-0005Pm-OI
	for qemu-devel@nongnu.org; Tue, 08 Mar 2016 03:10:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1adCj9-0004Tr-IR
	for qemu-devel@nongnu.org; Tue, 08 Mar 2016 03:10:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58570)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1adCj9-0004Tn-Dd
	for qemu-devel@nongnu.org; Tue, 08 Mar 2016 03:10:47 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id E91AD486D7
	for <qemu-devel@nongnu.org>; Tue,  8 Mar 2016 08:10:46 +0000 (UTC)
Message-ID: <1457424644.22567.27.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 08 Mar 2016 09:10:44 +0100
In-Reply-To: <1457420446-25276-7-git-send-email-peterx@redhat.com>
References: <1457420446-25276-1-git-send-email-peterx@redhat.com>
	<1457420446-25276-7-git-send-email-peterx@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 6/8] usb: fix unbounded stack for
	usb_mtp_add_str
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Xu <peterx@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org

>  static void usb_mtp_add_str(MTPData *data, const char *str)
>  {
> +#define __WSTR_LEN (256)
>      uint32_t len =3D strlen(str)+1;
> -    wchar_t wstr[len];
> +    wchar_t wstr[__WSTR_LEN];

I think we should g_malloc() here.

cheers,
  Gerd