From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Gabriel L. Somlo" <somlo@cmu.edu>,
"open list:ARM ACPI Subsystem" <qemu-arm@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Shannon Zhao <zhaoshenglong@huawei.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PULL 4/6] acpi: arm: add fw_cfg device node to dsdt
Date: Tue, 8 Mar 2016 12:18:59 +0100 [thread overview]
Message-ID: <1457435941-17578-5-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1457435941-17578-1-git-send-email-kraxel@redhat.com>
From: "Gabriel L. Somlo" <somlo@cmu.edu>
Add a fw_cfg device node to the ACPI DSDT. This is mostly
informational, as the authoritative fw_cfg MMIO region(s)
are listed in the Device Tree. However, since we are building
ACPI tables, we might as well be thorough while at it...
Signed-off-by: Gabriel Somlo <somlo@cmu.edu>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Tested-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Marc Marí <markmb@redhat.com>
Reviewed-by: Shannon Zhao <shannon.zhao@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-id: 1455906029-25565-5-git-send-email-somlo@cmu.edu
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/arm/virt-acpi-build.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index b8b3ece..6a86b2c 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -81,6 +81,20 @@ static void acpi_dsdt_add_uart(Aml *scope, const MemMapEntry *uart_memmap,
aml_append(scope, dev);
}
+static void acpi_dsdt_add_fw_cfg(Aml *scope, const MemMapEntry *fw_cfg_memmap)
+{
+ Aml *dev = aml_device("FWCF");
+ aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0002")));
+ /* device present, functioning, decoding, not shown in UI */
+ aml_append(dev, aml_name_decl("_STA", aml_int(0xB)));
+
+ Aml *crs = aml_resource_template();
+ aml_append(crs, aml_memory32_fixed(fw_cfg_memmap->base,
+ fw_cfg_memmap->size, AML_READ_WRITE));
+ aml_append(dev, aml_name_decl("_CRS", crs));
+ aml_append(scope, dev);
+}
+
static void acpi_dsdt_add_flash(Aml *scope, const MemMapEntry *flash_memmap)
{
Aml *dev, *crs;
@@ -549,6 +563,7 @@ build_dsdt(GArray *table_data, GArray *linker, VirtGuestInfo *guest_info)
acpi_dsdt_add_uart(scope, &memmap[VIRT_UART],
(irqmap[VIRT_UART] + ARM_SPI_BASE));
acpi_dsdt_add_flash(scope, &memmap[VIRT_FLASH]);
+ acpi_dsdt_add_fw_cfg(scope, &memmap[VIRT_FW_CFG]);
acpi_dsdt_add_virtio(scope, &memmap[VIRT_MMIO],
(irqmap[VIRT_MMIO] + ARM_SPI_BASE), NUM_VIRTIO_TRANSPORTS);
acpi_dsdt_add_pci(scope, memmap, (irqmap[VIRT_PCIE] + ARM_SPI_BASE),
--
1.8.3.1
next prev parent reply other threads:[~2016-03-08 11:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 11:18 [Qemu-devel] [PULL 0/6] acpi: add fw_cfg device node to dsdt Gerd Hoffmann
2016-03-08 11:18 ` [Qemu-devel] [PULL 1/6] fw_cfg: expose control register size in fw_cfg.h Gerd Hoffmann
2016-03-08 11:18 ` [Qemu-devel] [PULL 2/6] pc: fw_cfg: move ioport base constant to pc.h Gerd Hoffmann
2016-03-08 11:18 ` [Qemu-devel] [PULL 3/6] acpi: pc: add fw_cfg device node to dsdt Gerd Hoffmann
2016-03-08 11:18 ` Gerd Hoffmann [this message]
2016-03-08 11:19 ` [Qemu-devel] [PULL 5/6] fw_cfg: document ACPI device node information Gerd Hoffmann
2016-03-08 11:19 ` [Qemu-devel] [PULL 6/6] tests: update acpi test data Gerd Hoffmann
2016-03-09 1:06 ` [Qemu-devel] [PULL 0/6] acpi: add fw_cfg device node to dsdt Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457435941-17578-5-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=somlo@cmu.edu \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).