From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adX7Q-0002zV-0K for qemu-devel@nongnu.org; Wed, 09 Mar 2016 00:57:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adX7P-0002Qi-4J for qemu-devel@nongnu.org; Wed, 09 Mar 2016 00:57:11 -0500 From: Peter Xu Date: Wed, 9 Mar 2016 13:56:37 +0800 Message-Id: <1457502997-30904-3-git-send-email-peterx@redhat.com> In-Reply-To: <1457502997-30904-1-git-send-email-peterx@redhat.com> References: <1457502997-30904-1-git-send-email-peterx@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] block/qapi: fix unbounded stack for dump_qdict List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org, armbru@redhat.com, peterx@redhat.com, pbonzini@redhat.com Using heap instead of stack for better safety. Signed-off-by: Peter Xu --- block/qapi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qapi.c b/block/qapi.c index c4c2115..b798e35 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -636,9 +636,8 @@ static void dump_qdict(fprintf_function func_fprintf, void *f, int indentation, for (entry = qdict_first(dict); entry; entry = qdict_next(dict, entry)) { QType type = qobject_type(entry->value); bool composite = (type == QTYPE_QDICT || type == QTYPE_QLIST); - char key[strlen(entry->key) + 1]; + char *key = g_malloc(strlen(entry->key) + 1); int i; - /* replace dashes with spaces in key (variable) names */ for (i = 0; entry->key[i]; i++) { key[i] = entry->key[i] == '-' ? ' ' : entry->key[i]; @@ -650,6 +649,7 @@ static void dump_qdict(fprintf_function func_fprintf, void *f, int indentation, if (!composite) { func_fprintf(f, "\n"); } + g_free(key); } } -- 2.4.3