From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adXHZ-0008W4-NE for qemu-devel@nongnu.org; Wed, 09 Mar 2016 01:07:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adXHT-00058h-IO for qemu-devel@nongnu.org; Wed, 09 Mar 2016 01:07:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adXHT-00058d-D8 for qemu-devel@nongnu.org; Wed, 09 Mar 2016 01:07:35 -0500 From: Peter Xu Date: Wed, 9 Mar 2016 14:07:20 +0800 Message-Id: <1457503640-31473-1-git-send-email-peterx@redhat.com> Subject: [Qemu-devel] [PATCH] usb: fix unbound stack warning for inotify_watchfn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, kraxel@redhat.com, peterx@redhat.com, peter.maydell@linaro.org Signed-off-by: Peter Xu --- hw/usb/dev-mtp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 7391783..76ad64e 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -433,12 +433,11 @@ static void inotify_watchfn(void *arg) MTPState *s = arg; ssize_t bytes; /* From the man page: atleast one event can be read */ - int len = sizeof(struct inotify_event) + NAME_MAX + 1; int pos; - char buf[len]; + char buf[sizeof(struct inotify_event) + NAME_MAX + 1]; for (;;) { - bytes = read(s->inotifyfd, buf, len); + bytes = read(s->inotifyfd, buf, sizeof(buf)); pos = 0; if (bytes <= 0) { -- 2.4.3