From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adXKJ-00029U-Ll for qemu-devel@nongnu.org; Wed, 09 Mar 2016 01:10:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adXKJ-0006Mk-01 for qemu-devel@nongnu.org; Wed, 09 Mar 2016 01:10:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adXKI-0006Mg-Pf for qemu-devel@nongnu.org; Wed, 09 Mar 2016 01:10:30 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 876818F86C for ; Wed, 9 Mar 2016 06:10:30 +0000 (UTC) From: Peter Xu Date: Wed, 9 Mar 2016 14:10:13 +0800 Message-Id: <1457503813-31631-3-git-send-email-peterx@redhat.com> In-Reply-To: <1457503813-31631-1-git-send-email-peterx@redhat.com> References: <1457503813-31631-1-git-send-email-peterx@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] usb: trivial cleanup for usb_mtp_add_str List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, kraxel@redhat.com, peterx@redhat.com Remove useless var "ret". Signed-off-by: Peter Xu --- hw/usb/dev-mtp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index cf63fd0..38cc4fc 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -719,10 +719,8 @@ static void usb_mtp_add_str(MTPData *data, const char *str) { uint32_t len = strlen(str)+1; wchar_t *wstr = g_malloc(sizeof(wchar_t) * len); - size_t ret; - ret = mbstowcs(wstr, str, len); - if (ret == -1) { + if (mbstowcs(wstr, str, len) == -1) { usb_mtp_add_wstr(data, L"Oops"); } else { usb_mtp_add_wstr(data, wstr); -- 2.4.3