From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33618) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adXM8-0004zO-22 for qemu-devel@nongnu.org; Wed, 09 Mar 2016 01:12:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adXM3-0006vV-3O for qemu-devel@nongnu.org; Wed, 09 Mar 2016 01:12:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adXM2-0006vM-UL for qemu-devel@nongnu.org; Wed, 09 Mar 2016 01:12:19 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id A51E8C00DE16 for ; Wed, 9 Mar 2016 06:12:18 +0000 (UTC) From: Peter Xu Date: Wed, 9 Mar 2016 14:12:12 +0800 Message-Id: <1457503932-31763-1-git-send-email-peterx@redhat.com> Subject: [Qemu-devel] [PATCH] migration: fix warning for source_return_path_thread List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: amit.shah@redhat.com, pbonzini@redhat.com, peterx@redhat.com, quintela@redhat.com max_len is not necessary, while it brings a warning during compilation when specify "-Wstack-usage=1000000". Replacing using sizeof(). Signed-off-by: Peter Xu --- migration/migration.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 0129d9f..6680d95 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1268,8 +1268,7 @@ static void *source_return_path_thread(void *opaque) MigrationState *ms = opaque; QEMUFile *rp = ms->rp_state.from_dst_file; uint16_t header_len, header_type; - const int max_len = 512; - uint8_t buf[max_len]; + uint8_t buf[512]; uint32_t tmp32, sibling_error; ram_addr_t start = 0; /* =0 to silence warning */ size_t len = 0, expected_len; @@ -1292,7 +1291,7 @@ static void *source_return_path_thread(void *opaque) if ((rp_cmd_args[header_type].len != -1 && header_len != rp_cmd_args[header_type].len) || - header_len > max_len) { + header_len > sizeof(buf)) { error_report("RP: Received '%s' message (0x%04x) with" "incorrect length %d expecting %zu", rp_cmd_args[header_type].name, header_type, header_len, -- 2.4.3