From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48205)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1adfir-0000eD-Lk
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 10:08:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1adfim-0004Tc-4G
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 10:08:25 -0500
Received: from mx1.redhat.com ([209.132.183.28]:40446)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1adfil-0004TR-V0
	for qemu-devel@nongnu.org; Wed, 09 Mar 2016 10:08:20 -0500
Message-ID: <1457536096.676.57.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 09 Mar 2016 16:08:16 +0100
In-Reply-To: <1457447247-4865-3-git-send-email-kraxel@redhat.com>
References: <1457447247-4865-1-git-send-email-kraxel@redhat.com>
	<1457447247-4865-3-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v4 2/8] pc: move igd support code to igd.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: kevin.tian@intel.com
Cc: igvt-g@ml01.01.org, xen-devel@lists.xensource.com, "Michael S. Tsirkin" <mst@redhat.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, "open list:All
	patches CC here" <qemu-devel@nongnu.org>, Alex Williamson <alex.williamson@redhat.com>

  Hi,

> +/* Here we just expose minimal host bridge offset subset. */
> +static const IGDHostInfo igd_host_bridge_infos[] =3D {
> +    {0x08, 2},  /* revision id */
> +    {0x2c, 2},  /* sybsystem vendor id */
> +    {0x2e, 2},  /* sybsystem id */

Can anyone clarify where this comes from?

Setting the subsystem id without also setting the pci id looks wrong,
given that each pci id has its own subsystem id namespace.

Testing (with alex vfio patches) shows that dropping this seems to have
no bad effects.  Things are still working fine of we only set these ...

> +    {0x50, 2},  /* SNB: processor graphics control register */
> +    {0x52, 2},  /* processor graphics control register */
> +    {0xa4, 4},  /* SNB: graphics base of stolen memory */
> +    {0xa8, 4},  /* SNB: base of GTT stolen memory */

... gfx registers in host bridge pci config space.

thanks,
  Gerd