From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adk7i-0000Ic-L1 for qemu-devel@nongnu.org; Wed, 09 Mar 2016 14:50:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adk7g-0006wD-92 for qemu-devel@nongnu.org; Wed, 09 Mar 2016 14:50:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adk7g-0006w5-3c for qemu-devel@nongnu.org; Wed, 09 Mar 2016 14:50:20 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 9FA946315B for ; Wed, 9 Mar 2016 19:50:19 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" Date: Wed, 9 Mar 2016 19:50:15 +0000 Message-Id: <1457553016-1869-2-git-send-email-dgilbert@redhat.com> In-Reply-To: <1457553016-1869-1-git-send-email-dgilbert@redhat.com> References: <1457553016-1869-1-git-send-email-dgilbert@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] postcopy: listen thread is never joined List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, amit.shah@redhat.com, quintela@redhat.com, jdenemar@redhat.com From: "Dr. David Alan Gilbert" We don't join the listen thread, it does it's own cleanup. Mark as detached not joinable. Signed-off-by: Dr. David Alan Gilbert Reported-by: Paolo Bonzini --- migration/savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/savevm.c b/migration/savevm.c index 384e872..0a33c22 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -1494,7 +1494,7 @@ static int loadvm_postcopy_handle_listen(MigrationIncomingState *mis) qemu_sem_init(&mis->listen_thread_sem, 0); qemu_thread_create(&mis->listen_thread, "postcopy/listen", postcopy_ram_listen_thread, mis->from_src_file, - QEMU_THREAD_JOINABLE); + QEMU_THREAD_DETACHED); qemu_sem_wait(&mis->listen_thread_sem); qemu_sem_destroy(&mis->listen_thread_sem); -- 2.5.0