From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adqS1-00004z-7Q for qemu-devel@nongnu.org; Wed, 09 Mar 2016 21:35:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adqS0-0005hl-BV for qemu-devel@nongnu.org; Wed, 09 Mar 2016 21:35:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adqS0-0005hh-6D for qemu-devel@nongnu.org; Wed, 09 Mar 2016 21:35:44 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id D35A380518 for ; Thu, 10 Mar 2016 02:35:43 +0000 (UTC) From: Peter Xu Date: Thu, 10 Mar 2016 10:35:24 +0800 Message-Id: <1457577325-21606-2-git-send-email-peterx@redhat.com> In-Reply-To: <1457577325-21606-1-git-send-email-peterx@redhat.com> References: <1457577325-21606-1-git-send-email-peterx@redhat.com> Subject: [Qemu-devel] [PATCH v2 1/2] usb: fix unbound stack usage for usb_mtp_add_str List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, famz@redhat.com, kraxel@redhat.com, peterx@redhat.com Use heap instead of stack. Signed-off-by: Peter Xu --- hw/usb/dev-mtp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 7391783..62fb7cd 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -718,7 +718,7 @@ static void usb_mtp_add_wstr(MTPData *data, const wchar_t *str) static void usb_mtp_add_str(MTPData *data, const char *str) { uint32_t len = strlen(str)+1; - wchar_t wstr[len]; + wchar_t *wstr = g_new(wchar_t, len); size_t ret; ret = mbstowcs(wstr, str, len); @@ -727,6 +727,8 @@ static void usb_mtp_add_str(MTPData *data, const char *str) } else { usb_mtp_add_wstr(data, wstr); } + + g_free(wstr); } static void usb_mtp_add_time(MTPData *data, time_t time) -- 2.4.3