From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] usb: fix unbounded stack warning for xhci_dma_write_u32s
Date: Thu, 10 Mar 2016 08:34:13 +0100 [thread overview]
Message-ID: <1457595253.6405.3.camel@redhat.com> (raw)
In-Reply-To: <1457575914-15581-1-git-send-email-peterx@redhat.com>
On Do, 2016-03-10 at 10:11 +0800, Peter Xu wrote:
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> hw/usb/hcd-xhci.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
> index 44b6f8c..d15918f 100644
> --- a/hw/usb/hcd-xhci.c
> +++ b/hw/usb/hcd-xhci.c
> @@ -698,11 +698,13 @@ static inline void xhci_dma_write_u32s(XHCIState *xhci, dma_addr_t addr,
> uint32_t *buf, size_t len)
> {
> int i;
> - uint32_t tmp[len / sizeof(uint32_t)];
> + uint32_t tmp[12];
Where does the 12 come from?
cheers,
Gerd
next prev parent reply other threads:[~2016-03-10 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 2:11 [Qemu-devel] [PATCH] usb: fix unbounded stack warning for xhci_dma_write_u32s Peter Xu
2016-03-10 7:34 ` Gerd Hoffmann [this message]
2016-03-10 7:56 ` Peter Xu
2016-03-10 9:21 ` Gerd Hoffmann
2016-03-11 1:44 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457595253.6405.3.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).