From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adv6x-0002tc-Lg for qemu-devel@nongnu.org; Thu, 10 Mar 2016 02:34:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adv6u-000368-HH for qemu-devel@nongnu.org; Thu, 10 Mar 2016 02:34:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adv6u-000361-C3 for qemu-devel@nongnu.org; Thu, 10 Mar 2016 02:34:16 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 93BB780514 for ; Thu, 10 Mar 2016 07:34:15 +0000 (UTC) Message-ID: <1457595253.6405.3.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 10 Mar 2016 08:34:13 +0100 In-Reply-To: <1457575914-15581-1-git-send-email-peterx@redhat.com> References: <1457575914-15581-1-git-send-email-peterx@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] usb: fix unbounded stack warning for xhci_dma_write_u32s List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: pbonzini@redhat.com, qemu-devel@nongnu.org On Do, 2016-03-10 at 10:11 +0800, Peter Xu wrote: > Signed-off-by: Peter Xu > --- > hw/usb/hcd-xhci.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c > index 44b6f8c..d15918f 100644 > --- a/hw/usb/hcd-xhci.c > +++ b/hw/usb/hcd-xhci.c > @@ -698,11 +698,13 @@ static inline void xhci_dma_write_u32s(XHCIState *x= hci, dma_addr_t addr, > uint32_t *buf, size_t len) > { > int i; > - uint32_t tmp[len / sizeof(uint32_t)]; > + uint32_t tmp[12]; Where does the 12 come from? cheers, Gerd