From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae4N4-0002Qu-1K for qemu-devel@nongnu.org; Thu, 10 Mar 2016 12:27:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ae4N3-0001lp-9V for qemu-devel@nongnu.org; Thu, 10 Mar 2016 12:27:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae4N3-0001li-4m for qemu-devel@nongnu.org; Thu, 10 Mar 2016 12:27:33 -0500 From: "Daniel P. Berrange" Date: Thu, 10 Mar 2016 17:26:58 +0000 Message-Id: <1457630825-26638-12-git-send-email-berrange@redhat.com> In-Reply-To: <1457630825-26638-1-git-send-email-berrange@redhat.com> References: <1457630825-26638-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PATCH v2 11/18] io: use qemu_accept to ensure SOCK_CLOEXEC is set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Andrew Baumann , Stefan Weil The QIOChannelSocket code mistakenly uses the bare accept() function which does not set SOCK_CLOEXEC. Signed-off-by: Daniel P. Berrange --- io/channel-socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/io/channel-socket.c b/io/channel-socket.c index 775bb9f..9b5f2d8 100644 --- a/io/channel-socket.c +++ b/io/channel-socket.c @@ -343,8 +343,8 @@ qio_channel_socket_accept(QIOChannelSocket *ioc, retry: trace_qio_channel_socket_accept(ioc); - cioc->fd = accept(ioc->fd, (struct sockaddr *)&cioc->remoteAddr, - &cioc->remoteAddrLen); + cioc->fd = qemu_accept(ioc->fd, (struct sockaddr *)&cioc->remoteAddr, + &cioc->remoteAddrLen); if (cioc->fd < 0) { trace_qio_channel_socket_accept_fail(ioc); if (socket_error() == EINTR) { -- 2.5.0