From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae4Mu-0002AM-8A for qemu-devel@nongnu.org; Thu, 10 Mar 2016 12:27:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ae4Mt-0001eH-CJ for qemu-devel@nongnu.org; Thu, 10 Mar 2016 12:27:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae4Mt-0001eC-6c for qemu-devel@nongnu.org; Thu, 10 Mar 2016 12:27:23 -0500 From: "Daniel P. Berrange" Date: Thu, 10 Mar 2016 17:26:53 +0000 Message-Id: <1457630825-26638-7-git-send-email-berrange@redhat.com> In-Reply-To: <1457630825-26638-1-git-send-email-berrange@redhat.com> References: <1457630825-26638-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PATCH v2 06/18] io: set correct error object in background reader test thread List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Andrew Baumann , Stefan Weil The reader thread was accidentally setting the error pointer intended for the writer thread. If both threads set errors this would result in QEMU abort'ing due to the error already being set. Reviewed-by: Paolo Bonzini Signed-off-by: Daniel P. Berrange --- tests/io-channel-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/io-channel-helpers.c b/tests/io-channel-helpers.c index 8440669..d513792 100644 --- a/tests/io-channel-helpers.c +++ b/tests/io-channel-helpers.c @@ -132,7 +132,7 @@ static gpointer test_io_thread_reader(gpointer opaque) if (ret == QIO_CHANNEL_ERR_BLOCK) { if (data->blocking) { - error_setg(&data->writeerr, + error_setg(&data->readerr, "Unexpected I/O blocking"); break; } else { -- 2.5.0