From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeJvn-0003de-GN for qemu-devel@nongnu.org; Fri, 11 Mar 2016 05:04:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeJvm-0001fz-Ka for qemu-devel@nongnu.org; Fri, 11 Mar 2016 05:04:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeJvm-0001fp-Ex for qemu-devel@nongnu.org; Fri, 11 Mar 2016 05:04:26 -0500 From: "Daniel P. Berrange" Date: Fri, 11 Mar 2016 10:03:54 +0000 Message-Id: <1457690648-19267-5-git-send-email-berrange@redhat.com> In-Reply-To: <1457690648-19267-1-git-send-email-berrange@redhat.com> References: <1457690648-19267-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PULL v1 04/18] io: bind to socket before creating QIOChannelSocket List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell In the QIOChannelSocket test we create a socket file descriptor and then try to create a QIOChannelSocket. This works on Linux, but fails on Win32 because it is not valid to call getsockname() on an unbound socket. Reviewed-by: Paolo Bonzini Signed-off-by: Daniel P. Berrange --- tests/test-io-channel-socket.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tests/test-io-channel-socket.c b/tests/test-io-channel-socket.c index f226e47..4c16da1 100644 --- a/tests/test-io-channel-socket.c +++ b/tests/test-io-channel-socket.c @@ -470,10 +470,20 @@ static void test_io_channel_ipv4_fd(void) { QIOChannel *ioc; int fd = -1; + struct sockaddr_in sa = { + .sin_family = AF_INET, + .sin_addr = { + .s_addr = htonl(INADDR_LOOPBACK), + } + /* Leave port unset for auto-assign */ + }; + socklen_t salen = sizeof(sa); fd = socket(AF_INET, SOCK_STREAM, 0); g_assert_cmpint(fd, >, -1); + g_assert_cmpint(bind(fd, (struct sockaddr *)&sa, salen), ==, 0); + ioc = qio_channel_new_fd(fd, &error_abort); g_assert_cmpstr(object_get_typename(OBJECT(ioc)), -- 2.5.0