From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeJvq-0003eX-Q7 for qemu-devel@nongnu.org; Fri, 11 Mar 2016 05:04:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeJvp-0001hq-UW for qemu-devel@nongnu.org; Fri, 11 Mar 2016 05:04:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeJvp-0001hk-Pu for qemu-devel@nongnu.org; Fri, 11 Mar 2016 05:04:29 -0500 From: "Daniel P. Berrange" Date: Fri, 11 Mar 2016 10:03:57 +0000 Message-Id: <1457690648-19267-8-git-send-email-berrange@redhat.com> In-Reply-To: <1457690648-19267-1-git-send-email-berrange@redhat.com> References: <1457690648-19267-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PULL v1 07/18] io: assert errors before asserting content in I/O test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell When checking the results of an I/O operation test, assert that the error objects are NULL before asserting on the content. This is found to give more useful indication of the problem when diagnosing test failures. Reviewed-by: Paolo Bonzini Signed-off-by: Daniel P. Berrange --- tests/io-channel-helpers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/io-channel-helpers.c b/tests/io-channel-helpers.c index d513792..a4dedbe 100644 --- a/tests/io-channel-helpers.c +++ b/tests/io-channel-helpers.c @@ -233,11 +233,11 @@ void qio_channel_test_run_reader(QIOChannelTest *test, void qio_channel_test_validate(QIOChannelTest *test) { + g_assert(test->readerr == NULL); + g_assert(test->writeerr == NULL); g_assert_cmpint(memcmp(test->input, test->output, test->len), ==, 0); - g_assert(test->readerr == NULL); - g_assert(test->writeerr == NULL); g_free(test->inputv); g_free(test->outputv); -- 2.5.0