From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afSQt-0008BB-Hr for qemu-devel@nongnu.org; Mon, 14 Mar 2016 09:21:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afSQp-0006WI-LW for qemu-devel@nongnu.org; Mon, 14 Mar 2016 09:21:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afSQp-0006WB-Gb for qemu-devel@nongnu.org; Mon, 14 Mar 2016 09:21:11 -0400 From: Christophe Fergeau Date: Mon, 14 Mar 2016 12:41:12 +0100 Message-Id: <1457955672-28758-1-git-send-email-cfergeau@redhat.com> Subject: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Currently, virgl support has to go through a local unix socket, trying to connect to a VM using -spice gl through spice://localhost:5900 will only result in a black screen. This commit errors out when the user tries to start a VM with both GL support and a port/tls-port set. This would fit better in spice-server, but currently QEMU does not call into spice-server when parsing 'gl' on its command line, so we have to do this check in QEMU instead. Signed-off-by: Christophe Fergeau --- ui/spice-core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ui/spice-core.c b/ui/spice-core.c index 7987a4e..94f3236 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -844,6 +844,10 @@ void qemu_spice_init(void) #ifdef HAVE_SPICE_GL if (qemu_opt_get_bool(opts, "gl", 0)) { + if ((port != 0) || (tls_port != 0)) { + error_report("SPICE GL support is local-only for now and incompatible with -spice port/tls-port"); + exit(1); + } if (egl_rendernode_init() == 0) { display_opengl = 1; } -- 2.5.0