From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afUgC-0003Se-7Z for qemu-devel@nongnu.org; Mon, 14 Mar 2016 11:45:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afUgB-0002eV-Av for qemu-devel@nongnu.org; Mon, 14 Mar 2016 11:45:12 -0400 From: Kevin Wolf Date: Mon, 14 Mar 2016 16:44:50 +0100 Message-Id: <1457970292-12291-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1457970292-12291-1-git-send-email-kwolf@redhat.com> References: <1457970292-12291-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 3/5] block: Remove cache.writeback from blockdev-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, mreitz@redhat.com, jsnow@redhat.com The WCE bit is a frontend property and should not be part of the backend configuration. This is especially important because the same BDS can be used by different users with different WCE requirements. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 9bf1b22..e3617e2 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1614,7 +1614,6 @@ # # Includes cache-related options for block devices # -# @writeback: #optional enables writeback mode for any caches (default: true) # @direct: #optional enables use of O_DIRECT (bypass the host page cache; # default: false) # @no-flush: #optional ignore any flush requests for the device (default: @@ -1623,8 +1622,7 @@ # Since: 1.7 ## { 'struct': 'BlockdevCacheOptions', - 'data': { '*writeback': 'bool', - '*direct': 'bool', + 'data': { '*direct': 'bool', '*no-flush': 'bool' } } ## -- 1.8.3.1